Approve Ma Chao handpainted sprite v2
BIN
docs/handpaint-batch7-ma-chao-source-v1.png
Normal file
|
After Width: | Height: | Size: 2.3 MiB |
BIN
docs/handpaint-batch7-ma-chao-v2-animation.gif
Normal file
|
After Width: | Height: | Size: 238 KiB |
BIN
docs/handpaint-batch7-ma-chao-v2-battle-composite.png
Normal file
|
After Width: | Height: | Size: 887 KiB |
BIN
docs/handpaint-batch7-ma-chao-v2-before-after.png
Normal file
|
After Width: | Height: | Size: 58 KiB |
BIN
docs/handpaint-batch7-ma-chao-v2-contact.png
Normal file
|
After Width: | Height: | Size: 212 KiB |
BIN
docs/handpaint-batch7-ma-chao-v2-debug-preview-battle-check.png
Normal file
|
After Width: | Height: | Size: 686 KiB |
24
docs/handpaint-batch7-ma-chao-v2-report.md
Normal file
@@ -0,0 +1,24 @@
|
||||
# Ma Chao hand-painted v2 report
|
||||
|
||||
- source: `handpaint-batch7-ma-chao-source-v1.png`
|
||||
- base status: ok
|
||||
- action status: ok
|
||||
- base partial alpha: 0, opaque pixels: 2162408
|
||||
- action partial alpha: 0, opaque pixels: 4482935
|
||||
- base frame border hits: 0
|
||||
- action frame border hits: 0
|
||||
- base empty frames: 0
|
||||
- action empty frames: 0
|
||||
- base bbox width range: 166..263
|
||||
- base bbox height range: 288..296
|
||||
- base bottom range: 303..303
|
||||
- action bbox width range: 166..263
|
||||
- action bbox height range: 284..296
|
||||
- action bottom range: 303..303
|
||||
- contact: `handpaint-batch7-ma-chao-v2-contact.png`
|
||||
- animation: `handpaint-batch7-ma-chao-v2-animation.gif`
|
||||
- before/after: `handpaint-batch7-ma-chao-v2-before-after.png`
|
||||
- scale compare: `handpaint-batch7-ma-chao-v2-scale-compare.png`
|
||||
- battle composite: `handpaint-batch7-ma-chao-v2-battle-composite.png`
|
||||
- manual checks: run build and local browser verification after generation
|
||||
- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval
|
||||
BIN
docs/handpaint-batch7-ma-chao-v2-scale-compare.png
Normal file
|
After Width: | Height: | Size: 28 KiB |
@@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not
|
||||
|
||||
- Manifest: `docs/unit-sprite-rework-manifest.json`
|
||||
- Audit: `docs/unit-sprite-rework-audit.json`
|
||||
- Approved baseline units: 81
|
||||
- Approved baseline units: 82
|
||||
- Pending approval units: 0
|
||||
- Queued rework units: 10
|
||||
- Queued rework units: 9
|
||||
|
||||
## Checked Rules
|
||||
|
||||
|
||||
@@ -14,6 +14,7 @@
|
||||
"unit-liu-bei",
|
||||
"unit-lu-bu",
|
||||
"unit-lu-meng",
|
||||
"unit-ma-chao",
|
||||
"unit-meng-huo",
|
||||
"unit-nanman-infantry",
|
||||
"unit-nanman-infantry-jungle",
|
||||
@@ -88,8 +89,8 @@
|
||||
"pendingApproval": [],
|
||||
"nextAfterApproval": [],
|
||||
"stageCounts": {
|
||||
"approved-baseline": 81,
|
||||
"queued-rework": 10
|
||||
"approved-baseline": 82,
|
||||
"queued-rework": 9
|
||||
},
|
||||
"batches": [
|
||||
{
|
||||
@@ -1175,24 +1176,10 @@
|
||||
"label": "Batch 7 unique officers",
|
||||
"total": 19,
|
||||
"stageCounts": {
|
||||
"approved-baseline": 9,
|
||||
"queued-rework": 10
|
||||
"approved-baseline": 10,
|
||||
"queued-rework": 9
|
||||
},
|
||||
"units": [
|
||||
{
|
||||
"stem": "unit-ma-chao",
|
||||
"reviewStage": "queued-rework",
|
||||
"queueRole": "queued rework",
|
||||
"baseStatus": "border-hits=64",
|
||||
"actionStatus": "border-hits=144",
|
||||
"battleBasePx": [
|
||||
26.5,
|
||||
47.3,
|
||||
45.0,
|
||||
46.0
|
||||
],
|
||||
"spec": null
|
||||
},
|
||||
{
|
||||
"stem": "unit-ma-dai",
|
||||
"reviewStage": "queued-rework",
|
||||
@@ -1444,6 +1431,20 @@
|
||||
46.3
|
||||
],
|
||||
"spec": null
|
||||
},
|
||||
{
|
||||
"stem": "unit-ma-chao",
|
||||
"reviewStage": "approved-baseline",
|
||||
"queueRole": "approved reference",
|
||||
"baseStatus": "ok",
|
||||
"actionStatus": "ok",
|
||||
"battleBasePx": [
|
||||
26.5,
|
||||
42.0,
|
||||
46.0,
|
||||
47.3
|
||||
],
|
||||
"spec": null
|
||||
}
|
||||
]
|
||||
}
|
||||
|
||||
@@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i
|
||||
|
||||
## Current State
|
||||
|
||||
- Approved baseline units: 81
|
||||
- Approved baseline units: 82
|
||||
- Pending approval units: 0
|
||||
- Queued rework units: 10
|
||||
- Queued rework units: 9
|
||||
- Manifest: `docs/unit-sprite-rework-manifest.json`
|
||||
- Audit: `docs/unit-sprite-rework-audit.json`
|
||||
|
||||
@@ -157,11 +157,10 @@ No next unit is currently defined.
|
||||
|
||||
- Batch key: `batch7-unique-officer`
|
||||
- Total units: 19
|
||||
- Stage counts: approved-baseline 9, queued-rework 10
|
||||
- Stage counts: approved-baseline 10, queued-rework 9
|
||||
|
||||
| unit | role | stage | status | battle base px | spec |
|
||||
| --- | --- | --- | --- | --- | --- |
|
||||
| `unit-ma-chao` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 26.5..47.3 x 45.0..46.0 | |
|
||||
| `unit-ma-dai` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 25.6..46.5 x 45.0..46.2 | |
|
||||
| `unit-ma-liang` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | |
|
||||
| `unit-pang-tong` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | |
|
||||
@@ -180,3 +179,4 @@ No next unit is currently defined.
|
||||
| `unit-li-yan` | approved reference | approved-baseline | technical ok | 27.2..41.9 x 45.7..46.3 | |
|
||||
| `unit-lu-bu` | approved reference | approved-baseline | technical ok | 29.9..40.4 x 44.7..46.3 | |
|
||||
| `unit-lu-meng` | approved reference | approved-baseline | technical ok | 27.0..40.4 x 46.0..46.3 | |
|
||||
| `unit-ma-chao` | approved reference | approved-baseline | technical ok | 26.5..42.0 x 46.0..47.3 | |
|
||||
|
||||
|
Before Width: | Height: | Size: 629 KiB After Width: | Height: | Size: 652 KiB |
36
docs/unit-sprite-ma-chao-v2-approval-packet.md
Normal file
@@ -0,0 +1,36 @@
|
||||
# Ma Chao hand-painted sprite v2 approval packet
|
||||
|
||||
- Unit: `unit-ma-chao`
|
||||
- Candidate version: `v2`
|
||||
- Source sheet: `docs/handpaint-batch7-ma-chao-source-v1.png`
|
||||
- Contact sheet: `docs/handpaint-batch7-ma-chao-v2-contact.png`
|
||||
- Animation GIF: `docs/handpaint-batch7-ma-chao-v2-animation.gif`
|
||||
- Before/after: `docs/handpaint-batch7-ma-chao-v2-before-after.png`
|
||||
- Battle composite: `docs/handpaint-batch7-ma-chao-v2-battle-composite.png`
|
||||
- Scale compare: `docs/handpaint-batch7-ma-chao-v2-scale-compare.png`
|
||||
- Local browser check: `docs/handpaint-batch7-ma-chao-v2-debug-preview-battle-check.png`
|
||||
- Current approval board: `docs/unit-sprite-current-approval-board.png`
|
||||
|
||||
## Visual Decision
|
||||
|
||||
- Approved for continuous production run.
|
||||
- Direction: silver-white Xiliang cavalry commander on a pale horse, with long lance, gold accents, and blue/teal scarf details.
|
||||
- The 100% PC browser debug preview reads as a mounted lancer and not as a foot officer, generic cavalry, or Lu Bu-style boss.
|
||||
- The unit body is opaque and readable at battle scale without base rings, completion badges, or other external readability helpers.
|
||||
|
||||
## Technical Checks
|
||||
|
||||
- Local build: `pnpm build` passed.
|
||||
- Local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-ma-chao&v=ma-chao-v2`
|
||||
- Local browser console errors: `0`
|
||||
- Local browser 404s: `0`
|
||||
- Base partial alpha: `0`
|
||||
- Action partial alpha: `0`
|
||||
- Base frame border hits: `0`
|
||||
- Action frame border hits: `0`
|
||||
- Base battle size from audit: `26.5..42.0 x 46.0..47.3`
|
||||
|
||||
## Notes
|
||||
|
||||
- v1 established the mounted art direction but felt slightly too compressed in action frames.
|
||||
- v2 restores the cavalry/lance silhouette while keeping the horse, lance, and rider inside frame bounds.
|
||||
@@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`.
|
||||
|
||||
## Current Gate
|
||||
|
||||
- Approved baseline units: 81
|
||||
- Approved baseline units: 82
|
||||
- Pending approval units: 0
|
||||
- Queued rework units: 10
|
||||
- Queued rework units: 9
|
||||
- Manifest: `docs/unit-sprite-rework-manifest.json`
|
||||
- Audit: `docs/unit-sprite-rework-audit.json`
|
||||
- Current approval board: not generated until the next pending sample.
|
||||
|
||||
|
Before Width: | Height: | Size: 760 KiB After Width: | Height: | Size: 768 KiB |
|
Before Width: | Height: | Size: 162 KiB After Width: | Height: | Size: 161 KiB |
|
Before Width: | Height: | Size: 97 KiB After Width: | Height: | Size: 97 KiB |
@@ -11,8 +11,8 @@
|
||||
"batch7-unique-officer": 19
|
||||
},
|
||||
"stage_counts": {
|
||||
"approved-baseline": 81,
|
||||
"queued-rework": 10
|
||||
"approved-baseline": 82,
|
||||
"queued-rework": 9
|
||||
},
|
||||
"rows": [
|
||||
{
|
||||
@@ -644,7 +644,7 @@
|
||||
},
|
||||
{
|
||||
"batch": "batch7-unique-officer",
|
||||
"review_stage": "queued-rework",
|
||||
"review_stage": "approved-baseline",
|
||||
"stem": "unit-ma-chao",
|
||||
"base": {
|
||||
"key": "unit-ma-chao",
|
||||
@@ -654,23 +654,23 @@
|
||||
1252
|
||||
],
|
||||
"partial_alpha": 0,
|
||||
"opaque_pixels": 2540801,
|
||||
"border_hits": 64,
|
||||
"opaque_pixels": 2162408,
|
||||
"border_hits": 0,
|
||||
"min_width": 166,
|
||||
"max_width": 296,
|
||||
"min_height": 282,
|
||||
"max_height": 288,
|
||||
"min_bottom": 281,
|
||||
"max_bottom": 287,
|
||||
"max_width": 263,
|
||||
"min_height": 288,
|
||||
"max_height": 296,
|
||||
"min_bottom": 303,
|
||||
"max_bottom": 303,
|
||||
"empty_frames": 0,
|
||||
"width_swing": 130,
|
||||
"height_swing": 6,
|
||||
"bottom_swing": 6,
|
||||
"width_swing": 97,
|
||||
"height_swing": 8,
|
||||
"bottom_swing": 0,
|
||||
"battle_min_width_px": 26.5,
|
||||
"battle_max_width_px": 47.3,
|
||||
"battle_min_height_px": 45.0,
|
||||
"battle_max_height_px": 46.0,
|
||||
"status": "border-hits=64"
|
||||
"battle_max_width_px": 42.0,
|
||||
"battle_min_height_px": 46.0,
|
||||
"battle_max_height_px": 47.3,
|
||||
"status": "ok"
|
||||
},
|
||||
"actions": {
|
||||
"key": "unit-ma-chao-actions",
|
||||
@@ -680,23 +680,23 @@
|
||||
1252
|
||||
],
|
||||
"partial_alpha": 0,
|
||||
"opaque_pixels": 5689665,
|
||||
"border_hits": 144,
|
||||
"opaque_pixels": 4482935,
|
||||
"border_hits": 0,
|
||||
"min_width": 166,
|
||||
"max_width": 305,
|
||||
"min_height": 274,
|
||||
"max_height": 290,
|
||||
"min_bottom": 273,
|
||||
"max_bottom": 289,
|
||||
"max_width": 263,
|
||||
"min_height": 284,
|
||||
"max_height": 296,
|
||||
"min_bottom": 303,
|
||||
"max_bottom": 303,
|
||||
"empty_frames": 0,
|
||||
"width_swing": 139,
|
||||
"height_swing": 16,
|
||||
"bottom_swing": 16,
|
||||
"width_swing": 97,
|
||||
"height_swing": 12,
|
||||
"bottom_swing": 0,
|
||||
"battle_min_width_px": 26.5,
|
||||
"battle_max_width_px": 48.7,
|
||||
"battle_min_height_px": 43.8,
|
||||
"battle_max_height_px": 46.3,
|
||||
"status": "border-hits=144"
|
||||
"battle_max_width_px": 42.0,
|
||||
"battle_min_height_px": 45.4,
|
||||
"battle_max_height_px": 47.3,
|
||||
"status": "ok"
|
||||
}
|
||||
},
|
||||
{
|
||||
|
||||
@@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards.
|
||||
|
||||
## Review Stage Counts
|
||||
|
||||
- approved-baseline: 81
|
||||
- queued-rework: 10
|
||||
- approved-baseline: 82
|
||||
- queued-rework: 9
|
||||
|
||||
## Batch Plan
|
||||
|
||||
@@ -63,7 +63,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards.
|
||||
| batch1-approved-core | approved-baseline | `unit-liu-bei` | ok | ok | 138..258 x 278..289 | 148..300 x 252..284 | 22.0..41.2 x 44.4..46.2 | w120 h11 b12 |
|
||||
| batch7-unique-officer | approved-baseline | `unit-lu-bu` | ok | ok | 187..253 x 280..290 | 155..271 x 280..290 | 29.9..40.4 x 44.7..46.3 | w66 h10 b0 |
|
||||
| batch7-unique-officer | approved-baseline | `unit-lu-meng` | ok | ok | 169..253 x 288..290 | 153..238 x 286..290 | 27.0..40.4 x 46.0..46.3 | w84 h2 b0 |
|
||||
| batch7-unique-officer | queued-rework | `unit-ma-chao` | border-hits=64 | border-hits=144 | 166..296 x 282..288 | 166..305 x 274..290 | 26.5..47.3 x 45.0..46.0 | w130 h6 b6 |
|
||||
| batch7-unique-officer | approved-baseline | `unit-ma-chao` | ok | ok | 166..263 x 288..296 | 166..263 x 284..296 | 26.5..42.0 x 46.0..47.3 | w97 h8 b0 |
|
||||
| batch7-unique-officer | queued-rework | `unit-ma-dai` | border-hits=64 | border-hits=144 | 160..291 x 282..289 | 160..300 x 274..290 | 25.6..46.5 x 45.0..46.2 | w131 h7 b7 |
|
||||
| batch7-unique-officer | queued-rework | `unit-ma-liang` | border-hits=32 | border-hits=98 | 243..246 x 280..281 | 220..255 x 275..281 | 38.8..39.3 x 44.7..44.9 | w3 h1 b6 |
|
||||
| batch6-nanman-special | approved-baseline | `unit-meng-huo` | ok | ok | 174..221 x 286..288 | 149..248 x 275..289 | 27.8..35.3 x 45.7..46.0 | w47 h2 b0 |
|
||||
|
||||
@@ -22,6 +22,7 @@
|
||||
"unit-liu-bei",
|
||||
"unit-lu-bu",
|
||||
"unit-lu-meng",
|
||||
"unit-ma-chao",
|
||||
"unit-meng-huo",
|
||||
"unit-nanman-infantry",
|
||||
"unit-nanman-infantry-jungle",
|
||||
|
||||
|
Before Width: | Height: | Size: 1.6 MiB After Width: | Height: | Size: 3.0 MiB |
|
Before Width: | Height: | Size: 675 KiB After Width: | Height: | Size: 982 KiB |