diff --git a/docs/handpaint-batch7-ma-chao-source-v1.png b/docs/handpaint-batch7-ma-chao-source-v1.png new file mode 100644 index 0000000..ac76d11 Binary files /dev/null and b/docs/handpaint-batch7-ma-chao-source-v1.png differ diff --git a/docs/handpaint-batch7-ma-chao-v2-animation.gif b/docs/handpaint-batch7-ma-chao-v2-animation.gif new file mode 100644 index 0000000..7ea36ac Binary files /dev/null and b/docs/handpaint-batch7-ma-chao-v2-animation.gif differ diff --git a/docs/handpaint-batch7-ma-chao-v2-battle-composite.png b/docs/handpaint-batch7-ma-chao-v2-battle-composite.png new file mode 100644 index 0000000..0dffe9c Binary files /dev/null and b/docs/handpaint-batch7-ma-chao-v2-battle-composite.png differ diff --git a/docs/handpaint-batch7-ma-chao-v2-before-after.png b/docs/handpaint-batch7-ma-chao-v2-before-after.png new file mode 100644 index 0000000..656f1e8 Binary files /dev/null and b/docs/handpaint-batch7-ma-chao-v2-before-after.png differ diff --git a/docs/handpaint-batch7-ma-chao-v2-contact.png b/docs/handpaint-batch7-ma-chao-v2-contact.png new file mode 100644 index 0000000..223afd4 Binary files /dev/null and b/docs/handpaint-batch7-ma-chao-v2-contact.png differ diff --git a/docs/handpaint-batch7-ma-chao-v2-debug-preview-battle-check.png b/docs/handpaint-batch7-ma-chao-v2-debug-preview-battle-check.png new file mode 100644 index 0000000..ffca2bf Binary files /dev/null and b/docs/handpaint-batch7-ma-chao-v2-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch7-ma-chao-v2-report.md b/docs/handpaint-batch7-ma-chao-v2-report.md new file mode 100644 index 0000000..795d96e --- /dev/null +++ b/docs/handpaint-batch7-ma-chao-v2-report.md @@ -0,0 +1,24 @@ +# Ma Chao hand-painted v2 report + +- source: `handpaint-batch7-ma-chao-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 2162408 +- action partial alpha: 0, opaque pixels: 4482935 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 166..263 +- base bbox height range: 288..296 +- base bottom range: 303..303 +- action bbox width range: 166..263 +- action bbox height range: 284..296 +- action bottom range: 303..303 +- contact: `handpaint-batch7-ma-chao-v2-contact.png` +- animation: `handpaint-batch7-ma-chao-v2-animation.gif` +- before/after: `handpaint-batch7-ma-chao-v2-before-after.png` +- scale compare: `handpaint-batch7-ma-chao-v2-scale-compare.png` +- battle composite: `handpaint-batch7-ma-chao-v2-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch7-ma-chao-v2-scale-compare.png b/docs/handpaint-batch7-ma-chao-v2-scale-compare.png new file mode 100644 index 0000000..b7a3280 Binary files /dev/null and b/docs/handpaint-batch7-ma-chao-v2-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index d0709eb..d781bbd 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 81 +- Approved baseline units: 82 - Pending approval units: 0 -- Queued rework units: 10 +- Queued rework units: 9 ## Checked Rules diff --git a/docs/unit-sprite-batch-queue.json b/docs/unit-sprite-batch-queue.json index 9ff7f90..d5ed806 100644 --- a/docs/unit-sprite-batch-queue.json +++ b/docs/unit-sprite-batch-queue.json @@ -14,6 +14,7 @@ "unit-liu-bei", "unit-lu-bu", "unit-lu-meng", + "unit-ma-chao", "unit-meng-huo", "unit-nanman-infantry", "unit-nanman-infantry-jungle", @@ -88,8 +89,8 @@ "pendingApproval": [], "nextAfterApproval": [], "stageCounts": { - "approved-baseline": 81, - "queued-rework": 10 + "approved-baseline": 82, + "queued-rework": 9 }, "batches": [ { @@ -1175,24 +1176,10 @@ "label": "Batch 7 unique officers", "total": 19, "stageCounts": { - "approved-baseline": 9, - "queued-rework": 10 + "approved-baseline": 10, + "queued-rework": 9 }, "units": [ - { - "stem": "unit-ma-chao", - "reviewStage": "queued-rework", - "queueRole": "queued rework", - "baseStatus": "border-hits=64", - "actionStatus": "border-hits=144", - "battleBasePx": [ - 26.5, - 47.3, - 45.0, - 46.0 - ], - "spec": null - }, { "stem": "unit-ma-dai", "reviewStage": "queued-rework", @@ -1444,6 +1431,20 @@ 46.3 ], "spec": null + }, + { + "stem": "unit-ma-chao", + "reviewStage": "approved-baseline", + "queueRole": "approved reference", + "baseStatus": "ok", + "actionStatus": "ok", + "battleBasePx": [ + 26.5, + 42.0, + 46.0, + 47.3 + ], + "spec": null } ] } diff --git a/docs/unit-sprite-batch-queue.md b/docs/unit-sprite-batch-queue.md index e5e97bd..e5a20a9 100644 --- a/docs/unit-sprite-batch-queue.md +++ b/docs/unit-sprite-batch-queue.md @@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i ## Current State -- Approved baseline units: 81 +- Approved baseline units: 82 - Pending approval units: 0 -- Queued rework units: 10 +- Queued rework units: 9 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` @@ -157,11 +157,10 @@ No next unit is currently defined. - Batch key: `batch7-unique-officer` - Total units: 19 -- Stage counts: approved-baseline 9, queued-rework 10 +- Stage counts: approved-baseline 10, queued-rework 9 | unit | role | stage | status | battle base px | spec | | --- | --- | --- | --- | --- | --- | -| `unit-ma-chao` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 26.5..47.3 x 45.0..46.0 | | | `unit-ma-dai` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 25.6..46.5 x 45.0..46.2 | | | `unit-ma-liang` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | | `unit-pang-tong` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | @@ -180,3 +179,4 @@ No next unit is currently defined. | `unit-li-yan` | approved reference | approved-baseline | technical ok | 27.2..41.9 x 45.7..46.3 | | | `unit-lu-bu` | approved reference | approved-baseline | technical ok | 29.9..40.4 x 44.7..46.3 | | | `unit-lu-meng` | approved reference | approved-baseline | technical ok | 27.0..40.4 x 46.0..46.3 | | +| `unit-ma-chao` | approved reference | approved-baseline | technical ok | 26.5..42.0 x 46.0..47.3 | | diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index 57d1ebe..5ed3a4e 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-ma-chao-v2-approval-packet.md b/docs/unit-sprite-ma-chao-v2-approval-packet.md new file mode 100644 index 0000000..eb1a966 --- /dev/null +++ b/docs/unit-sprite-ma-chao-v2-approval-packet.md @@ -0,0 +1,36 @@ +# Ma Chao hand-painted sprite v2 approval packet + +- Unit: `unit-ma-chao` +- Candidate version: `v2` +- Source sheet: `docs/handpaint-batch7-ma-chao-source-v1.png` +- Contact sheet: `docs/handpaint-batch7-ma-chao-v2-contact.png` +- Animation GIF: `docs/handpaint-batch7-ma-chao-v2-animation.gif` +- Before/after: `docs/handpaint-batch7-ma-chao-v2-before-after.png` +- Battle composite: `docs/handpaint-batch7-ma-chao-v2-battle-composite.png` +- Scale compare: `docs/handpaint-batch7-ma-chao-v2-scale-compare.png` +- Local browser check: `docs/handpaint-batch7-ma-chao-v2-debug-preview-battle-check.png` +- Current approval board: `docs/unit-sprite-current-approval-board.png` + +## Visual Decision + +- Approved for continuous production run. +- Direction: silver-white Xiliang cavalry commander on a pale horse, with long lance, gold accents, and blue/teal scarf details. +- The 100% PC browser debug preview reads as a mounted lancer and not as a foot officer, generic cavalry, or Lu Bu-style boss. +- The unit body is opaque and readable at battle scale without base rings, completion badges, or other external readability helpers. + +## Technical Checks + +- Local build: `pnpm build` passed. +- Local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-ma-chao&v=ma-chao-v2` +- Local browser console errors: `0` +- Local browser 404s: `0` +- Base partial alpha: `0` +- Action partial alpha: `0` +- Base frame border hits: `0` +- Action frame border hits: `0` +- Base battle size from audit: `26.5..42.0 x 46.0..47.3` + +## Notes + +- v1 established the mounted art direction but felt slightly too compressed in action frames. +- v2 restores the cavalry/lance silhouette while keeping the horse, lance, and rider inside frame bounds. diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index bed4de8..ad80ee7 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 81 +- Approved baseline units: 82 - Pending approval units: 0 -- Queued rework units: 10 +- Queued rework units: 9 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index b1cf4b8..78e8449 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch7-unique-officer.png b/docs/unit-sprite-review-batch7-unique-officer.png index a377436..76516dc 100644 Binary files a/docs/unit-sprite-review-batch7-unique-officer.png and b/docs/unit-sprite-review-batch7-unique-officer.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index 2ba955e..4142f14 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index b38d590..bfe88e8 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 81, - "queued-rework": 10 + "approved-baseline": 82, + "queued-rework": 9 }, "rows": [ { @@ -644,7 +644,7 @@ }, { "batch": "batch7-unique-officer", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-ma-chao", "base": { "key": "unit-ma-chao", @@ -654,23 +654,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 2540801, - "border_hits": 64, + "opaque_pixels": 2162408, + "border_hits": 0, "min_width": 166, - "max_width": 296, - "min_height": 282, - "max_height": 288, - "min_bottom": 281, - "max_bottom": 287, + "max_width": 263, + "min_height": 288, + "max_height": 296, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 130, - "height_swing": 6, - "bottom_swing": 6, + "width_swing": 97, + "height_swing": 8, + "bottom_swing": 0, "battle_min_width_px": 26.5, - "battle_max_width_px": 47.3, - "battle_min_height_px": 45.0, - "battle_max_height_px": 46.0, - "status": "border-hits=64" + "battle_max_width_px": 42.0, + "battle_min_height_px": 46.0, + "battle_max_height_px": 47.3, + "status": "ok" }, "actions": { "key": "unit-ma-chao-actions", @@ -680,23 +680,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 5689665, - "border_hits": 144, + "opaque_pixels": 4482935, + "border_hits": 0, "min_width": 166, - "max_width": 305, - "min_height": 274, - "max_height": 290, - "min_bottom": 273, - "max_bottom": 289, + "max_width": 263, + "min_height": 284, + "max_height": 296, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 139, - "height_swing": 16, - "bottom_swing": 16, + "width_swing": 97, + "height_swing": 12, + "bottom_swing": 0, "battle_min_width_px": 26.5, - "battle_max_width_px": 48.7, - "battle_min_height_px": 43.8, - "battle_max_height_px": 46.3, - "status": "border-hits=144" + "battle_max_width_px": 42.0, + "battle_min_height_px": 45.4, + "battle_max_height_px": 47.3, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index c2a2f8f..4d370e4 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 81 -- queued-rework: 10 +- approved-baseline: 82 +- queued-rework: 9 ## Batch Plan @@ -63,7 +63,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch1-approved-core | approved-baseline | `unit-liu-bei` | ok | ok | 138..258 x 278..289 | 148..300 x 252..284 | 22.0..41.2 x 44.4..46.2 | w120 h11 b12 | | batch7-unique-officer | approved-baseline | `unit-lu-bu` | ok | ok | 187..253 x 280..290 | 155..271 x 280..290 | 29.9..40.4 x 44.7..46.3 | w66 h10 b0 | | batch7-unique-officer | approved-baseline | `unit-lu-meng` | ok | ok | 169..253 x 288..290 | 153..238 x 286..290 | 27.0..40.4 x 46.0..46.3 | w84 h2 b0 | -| batch7-unique-officer | queued-rework | `unit-ma-chao` | border-hits=64 | border-hits=144 | 166..296 x 282..288 | 166..305 x 274..290 | 26.5..47.3 x 45.0..46.0 | w130 h6 b6 | +| batch7-unique-officer | approved-baseline | `unit-ma-chao` | ok | ok | 166..263 x 288..296 | 166..263 x 284..296 | 26.5..42.0 x 46.0..47.3 | w97 h8 b0 | | batch7-unique-officer | queued-rework | `unit-ma-dai` | border-hits=64 | border-hits=144 | 160..291 x 282..289 | 160..300 x 274..290 | 25.6..46.5 x 45.0..46.2 | w131 h7 b7 | | batch7-unique-officer | queued-rework | `unit-ma-liang` | border-hits=32 | border-hits=98 | 243..246 x 280..281 | 220..255 x 275..281 | 38.8..39.3 x 44.7..44.9 | w3 h1 b6 | | batch6-nanman-special | approved-baseline | `unit-meng-huo` | ok | ok | 174..221 x 286..288 | 149..248 x 275..289 | 27.8..35.3 x 45.7..46.0 | w47 h2 b0 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index 3219b17..b655ba1 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -22,6 +22,7 @@ "unit-liu-bei", "unit-lu-bu", "unit-lu-meng", + "unit-ma-chao", "unit-meng-huo", "unit-nanman-infantry", "unit-nanman-infantry-jungle", diff --git a/src/assets/images/units/unit-ma-chao-actions.png b/src/assets/images/units/unit-ma-chao-actions.png index 0adc74f..bf568cd 100644 Binary files a/src/assets/images/units/unit-ma-chao-actions.png and b/src/assets/images/units/unit-ma-chao-actions.png differ diff --git a/src/assets/images/units/unit-ma-chao.png b/src/assets/images/units/unit-ma-chao.png index 037409e..394fec1 100644 Binary files a/src/assets/images/units/unit-ma-chao.png and b/src/assets/images/units/unit-ma-chao.png differ