Approve Zhao Yun handpainted sprite v3
BIN
docs/handpaint-batch7-zhao-yun-source-v1.png
Normal file
|
After Width: | Height: | Size: 2.1 MiB |
BIN
docs/handpaint-batch7-zhao-yun-v3-animation.gif
Normal file
|
After Width: | Height: | Size: 238 KiB |
BIN
docs/handpaint-batch7-zhao-yun-v3-battle-composite.png
Normal file
|
After Width: | Height: | Size: 886 KiB |
BIN
docs/handpaint-batch7-zhao-yun-v3-before-after.png
Normal file
|
After Width: | Height: | Size: 56 KiB |
BIN
docs/handpaint-batch7-zhao-yun-v3-contact.png
Normal file
|
After Width: | Height: | Size: 198 KiB |
BIN
docs/handpaint-batch7-zhao-yun-v3-debug-preview-battle-check.png
Normal file
|
After Width: | Height: | Size: 678 KiB |
24
docs/handpaint-batch7-zhao-yun-v3-report.md
Normal file
@@ -0,0 +1,24 @@
|
||||
# Zhao Yun hand-painted v3 report
|
||||
|
||||
- source: `handpaint-batch7-zhao-yun-source-v1.png`
|
||||
- base status: ok
|
||||
- action status: ok
|
||||
- base partial alpha: 0, opaque pixels: 1927986
|
||||
- action partial alpha: 0, opaque pixels: 3700516
|
||||
- base frame border hits: 0
|
||||
- action frame border hits: 0
|
||||
- base empty frames: 0
|
||||
- action empty frames: 0
|
||||
- base bbox width range: 141..266
|
||||
- base bbox height range: 282..290
|
||||
- base bottom range: 303..303
|
||||
- action bbox width range: 118..248
|
||||
- action bbox height range: 277..295
|
||||
- action bottom range: 303..303
|
||||
- contact: `handpaint-batch7-zhao-yun-v3-contact.png`
|
||||
- animation: `handpaint-batch7-zhao-yun-v3-animation.gif`
|
||||
- before/after: `handpaint-batch7-zhao-yun-v3-before-after.png`
|
||||
- scale compare: `handpaint-batch7-zhao-yun-v3-scale-compare.png`
|
||||
- battle composite: `handpaint-batch7-zhao-yun-v3-battle-composite.png`
|
||||
- manual checks: run build and local browser verification after generation
|
||||
- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval
|
||||
BIN
docs/handpaint-batch7-zhao-yun-v3-scale-compare.png
Normal file
|
After Width: | Height: | Size: 36 KiB |
@@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not
|
||||
|
||||
- Manifest: `docs/unit-sprite-rework-manifest.json`
|
||||
- Audit: `docs/unit-sprite-rework-audit.json`
|
||||
- Approved baseline units: 89
|
||||
- Approved baseline units: 90
|
||||
- Pending approval units: 0
|
||||
- Queued rework units: 2
|
||||
- Queued rework units: 1
|
||||
|
||||
## Checked Rules
|
||||
|
||||
|
||||
@@ -91,13 +91,14 @@
|
||||
"unit-wu-yi",
|
||||
"unit-yan-yan",
|
||||
"unit-yi-ji",
|
||||
"unit-zhang-fei"
|
||||
"unit-zhang-fei",
|
||||
"unit-zhao-yun"
|
||||
],
|
||||
"pendingApproval": [],
|
||||
"nextAfterApproval": [],
|
||||
"stageCounts": {
|
||||
"approved-baseline": 89,
|
||||
"queued-rework": 2
|
||||
"approved-baseline": 90,
|
||||
"queued-rework": 1
|
||||
},
|
||||
"batches": [
|
||||
{
|
||||
@@ -1183,24 +1184,10 @@
|
||||
"label": "Batch 7 unique officers",
|
||||
"total": 19,
|
||||
"stageCounts": {
|
||||
"approved-baseline": 17,
|
||||
"queued-rework": 2
|
||||
"approved-baseline": 18,
|
||||
"queued-rework": 1
|
||||
},
|
||||
"units": [
|
||||
{
|
||||
"stem": "unit-zhao-yun",
|
||||
"reviewStage": "queued-rework",
|
||||
"queueRole": "queued rework",
|
||||
"baseStatus": "border-hits=64",
|
||||
"actionStatus": "border-hits=144",
|
||||
"battleBasePx": [
|
||||
26.5,
|
||||
47.3,
|
||||
45.0,
|
||||
46.0
|
||||
],
|
||||
"spec": null
|
||||
},
|
||||
{
|
||||
"stem": "unit-zhuge-liang",
|
||||
"reviewStage": "queued-rework",
|
||||
@@ -1452,6 +1439,20 @@
|
||||
46.0
|
||||
],
|
||||
"spec": null
|
||||
},
|
||||
{
|
||||
"stem": "unit-zhao-yun",
|
||||
"reviewStage": "approved-baseline",
|
||||
"queueRole": "approved reference",
|
||||
"baseStatus": "ok",
|
||||
"actionStatus": "ok",
|
||||
"battleBasePx": [
|
||||
22.5,
|
||||
42.5,
|
||||
45.0,
|
||||
46.3
|
||||
],
|
||||
"spec": null
|
||||
}
|
||||
]
|
||||
}
|
||||
|
||||
@@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i
|
||||
|
||||
## Current State
|
||||
|
||||
- Approved baseline units: 89
|
||||
- Approved baseline units: 90
|
||||
- Pending approval units: 0
|
||||
- Queued rework units: 2
|
||||
- Queued rework units: 1
|
||||
- Manifest: `docs/unit-sprite-rework-manifest.json`
|
||||
- Audit: `docs/unit-sprite-rework-audit.json`
|
||||
|
||||
@@ -157,11 +157,10 @@ No next unit is currently defined.
|
||||
|
||||
- Batch key: `batch7-unique-officer`
|
||||
- Total units: 19
|
||||
- Stage counts: approved-baseline 17, queued-rework 2
|
||||
- Stage counts: approved-baseline 18, queued-rework 1
|
||||
|
||||
| unit | role | stage | status | battle base px | spec |
|
||||
| --- | --- | --- | --- | --- | --- |
|
||||
| `unit-zhao-yun` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 26.5..47.3 x 45.0..46.0 | |
|
||||
| `unit-zhuge-liang` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | |
|
||||
| `unit-cao-cao` | approved reference | approved-baseline | technical ok | 32.9..36.4 x 46.3..47.3 | |
|
||||
| `unit-fa-zheng` | approved reference | approved-baseline | technical ok | 29.1..35.3 x 46.3..46.3 | |
|
||||
@@ -180,3 +179,4 @@ No next unit is currently defined.
|
||||
| `unit-wang-ping` | approved reference | approved-baseline | technical ok | 28.0..33.7 x 45.7..46.0 | |
|
||||
| `unit-yan-yan` | approved reference | approved-baseline | technical ok | 30.4..37.5 x 45.7..46.0 | |
|
||||
| `unit-yi-ji` | approved reference | approved-baseline | technical ok | 27.8..33.9 x 45.7..46.0 | |
|
||||
| `unit-zhao-yun` | approved reference | approved-baseline | technical ok | 22.5..42.5 x 45.0..46.3 | |
|
||||
|
||||
|
Before Width: | Height: | Size: 666 KiB After Width: | Height: | Size: 640 KiB |
@@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`.
|
||||
|
||||
## Current Gate
|
||||
|
||||
- Approved baseline units: 89
|
||||
- Approved baseline units: 90
|
||||
- Pending approval units: 0
|
||||
- Queued rework units: 2
|
||||
- Queued rework units: 1
|
||||
- Manifest: `docs/unit-sprite-rework-manifest.json`
|
||||
- Audit: `docs/unit-sprite-rework-audit.json`
|
||||
- Current approval board: not generated until the next pending sample.
|
||||
|
||||
|
Before Width: | Height: | Size: 831 KiB After Width: | Height: | Size: 838 KiB |
|
Before Width: | Height: | Size: 178 KiB After Width: | Height: | Size: 177 KiB |
|
Before Width: | Height: | Size: 97 KiB After Width: | Height: | Size: 97 KiB |
@@ -11,8 +11,8 @@
|
||||
"batch7-unique-officer": 19
|
||||
},
|
||||
"stage_counts": {
|
||||
"approved-baseline": 89,
|
||||
"queued-rework": 2
|
||||
"approved-baseline": 90,
|
||||
"queued-rework": 1
|
||||
},
|
||||
"rows": [
|
||||
{
|
||||
@@ -5090,7 +5090,7 @@
|
||||
},
|
||||
{
|
||||
"batch": "batch7-unique-officer",
|
||||
"review_stage": "queued-rework",
|
||||
"review_stage": "approved-baseline",
|
||||
"stem": "unit-zhao-yun",
|
||||
"base": {
|
||||
"key": "unit-zhao-yun",
|
||||
@@ -5100,23 +5100,23 @@
|
||||
1252
|
||||
],
|
||||
"partial_alpha": 0,
|
||||
"opaque_pixels": 2540801,
|
||||
"border_hits": 64,
|
||||
"min_width": 166,
|
||||
"max_width": 296,
|
||||
"opaque_pixels": 1927986,
|
||||
"border_hits": 0,
|
||||
"min_width": 141,
|
||||
"max_width": 266,
|
||||
"min_height": 282,
|
||||
"max_height": 288,
|
||||
"min_bottom": 281,
|
||||
"max_bottom": 287,
|
||||
"max_height": 290,
|
||||
"min_bottom": 303,
|
||||
"max_bottom": 303,
|
||||
"empty_frames": 0,
|
||||
"width_swing": 130,
|
||||
"height_swing": 6,
|
||||
"bottom_swing": 6,
|
||||
"battle_min_width_px": 26.5,
|
||||
"battle_max_width_px": 47.3,
|
||||
"width_swing": 125,
|
||||
"height_swing": 8,
|
||||
"bottom_swing": 0,
|
||||
"battle_min_width_px": 22.5,
|
||||
"battle_max_width_px": 42.5,
|
||||
"battle_min_height_px": 45.0,
|
||||
"battle_max_height_px": 46.0,
|
||||
"status": "border-hits=64"
|
||||
"battle_max_height_px": 46.3,
|
||||
"status": "ok"
|
||||
},
|
||||
"actions": {
|
||||
"key": "unit-zhao-yun-actions",
|
||||
@@ -5126,23 +5126,23 @@
|
||||
1252
|
||||
],
|
||||
"partial_alpha": 0,
|
||||
"opaque_pixels": 5689665,
|
||||
"border_hits": 144,
|
||||
"min_width": 166,
|
||||
"max_width": 305,
|
||||
"min_height": 274,
|
||||
"max_height": 290,
|
||||
"min_bottom": 273,
|
||||
"max_bottom": 289,
|
||||
"opaque_pixels": 3700516,
|
||||
"border_hits": 0,
|
||||
"min_width": 118,
|
||||
"max_width": 248,
|
||||
"min_height": 277,
|
||||
"max_height": 295,
|
||||
"min_bottom": 303,
|
||||
"max_bottom": 303,
|
||||
"empty_frames": 0,
|
||||
"width_swing": 139,
|
||||
"height_swing": 16,
|
||||
"bottom_swing": 16,
|
||||
"battle_min_width_px": 26.5,
|
||||
"battle_max_width_px": 48.7,
|
||||
"battle_min_height_px": 43.8,
|
||||
"battle_max_height_px": 46.3,
|
||||
"status": "border-hits=144"
|
||||
"width_swing": 130,
|
||||
"height_swing": 18,
|
||||
"bottom_swing": 0,
|
||||
"battle_min_width_px": 18.8,
|
||||
"battle_max_width_px": 39.6,
|
||||
"battle_min_height_px": 44.2,
|
||||
"battle_max_height_px": 47.1,
|
||||
"status": "ok"
|
||||
}
|
||||
},
|
||||
{
|
||||
|
||||
@@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards.
|
||||
|
||||
## Review Stage Counts
|
||||
|
||||
- approved-baseline: 89
|
||||
- queued-rework: 2
|
||||
- approved-baseline: 90
|
||||
- queued-rework: 1
|
||||
|
||||
## Batch Plan
|
||||
|
||||
@@ -141,5 +141,5 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards.
|
||||
| batch7-unique-officer | approved-baseline | `unit-yan-yan` | ok | ok | 190..235 x 286..288 | 170..242 x 271..295 | 30.4..37.5 x 45.7..46.0 | w45 h2 b0 |
|
||||
| batch7-unique-officer | approved-baseline | `unit-yi-ji` | ok | ok | 174..212 x 286..288 | 167..273 x 286..295 | 27.8..33.9 x 45.7..46.0 | w38 h2 b0 |
|
||||
| batch1-approved-core | approved-baseline | `unit-zhang-fei` | ok | ok | 143..306 x 274..289 | 188..286 x 181..290 | 22.8..48.9 x 43.8..46.2 | w163 h15 b14 |
|
||||
| batch7-unique-officer | queued-rework | `unit-zhao-yun` | border-hits=64 | border-hits=144 | 166..296 x 282..288 | 166..305 x 274..290 | 26.5..47.3 x 45.0..46.0 | w130 h6 b6 |
|
||||
| batch7-unique-officer | approved-baseline | `unit-zhao-yun` | ok | ok | 141..266 x 282..290 | 118..248 x 277..295 | 22.5..42.5 x 45.0..46.3 | w125 h8 b0 |
|
||||
| batch7-unique-officer | queued-rework | `unit-zhuge-liang` | border-hits=32 | border-hits=98 | 243..246 x 280..281 | 220..255 x 275..281 | 38.8..39.3 x 44.7..44.9 | w3 h1 b6 |
|
||||
|
||||
@@ -99,7 +99,8 @@
|
||||
"unit-wu-yi",
|
||||
"unit-yan-yan",
|
||||
"unit-yi-ji",
|
||||
"unit-zhang-fei"
|
||||
"unit-zhang-fei",
|
||||
"unit-zhao-yun"
|
||||
],
|
||||
"pendingApproval": [],
|
||||
"currentApprovalCandidate": {},
|
||||
|
||||
35
docs/unit-sprite-zhao-yun-v3-approval-packet.md
Normal file
@@ -0,0 +1,35 @@
|
||||
# Zhao Yun hand-painted v3 approval packet
|
||||
|
||||
- unit: `unit-zhao-yun`
|
||||
- candidate: `handpaint-batch7-zhao-yun-v3`
|
||||
- source: `docs/handpaint-batch7-zhao-yun-source-v1.png`
|
||||
- contact sheet: `docs/handpaint-batch7-zhao-yun-v3-contact.png`
|
||||
- animation: `docs/handpaint-batch7-zhao-yun-v3-animation.gif`
|
||||
- before/after: `docs/handpaint-batch7-zhao-yun-v3-before-after.png`
|
||||
- battle composite: `docs/handpaint-batch7-zhao-yun-v3-battle-composite.png`
|
||||
- current approval board: `docs/unit-sprite-current-approval-board.png`
|
||||
- browser check: `docs/handpaint-batch7-zhao-yun-v3-debug-preview-battle-check.png`
|
||||
|
||||
## Result
|
||||
|
||||
- Local build: `pnpm build` passed.
|
||||
- Local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-zhao-yun&v=zhao-yun-v3`
|
||||
- Local browser console errors: `0`
|
||||
- Local browser 404s: `0`
|
||||
- Sample gate: passed.
|
||||
|
||||
## Sprite safety
|
||||
|
||||
- base partial alpha: 0
|
||||
- action partial alpha: 0
|
||||
- base frame border hits: 0
|
||||
- action frame border hits: 0
|
||||
- base battle size: 22.5..42.5 x 45.0..46.3
|
||||
- frame bbox width: 141..266 base, 118..248 action
|
||||
- frame bbox height: 282..290 base, 277..295 action
|
||||
|
||||
## Visual notes
|
||||
|
||||
- v1 had the right mounted-white-cavalry direction but missed the battle-scale width threshold and had slightly too much base-frame height swing.
|
||||
- v2 corrected vertical stability, and v3 widens the horse/rider silhouette enough for the art quality gate.
|
||||
- White horse, silver armor, blue scarf, and upright spear make Zhao Yun read as a distinct elite cavalry officer separate from Ma Chao and Ma Dai.
|
||||
|
Before Width: | Height: | Size: 2.0 MiB After Width: | Height: | Size: 2.8 MiB |
|
Before Width: | Height: | Size: 890 KiB After Width: | Height: | Size: 1.0 MiB |