diff --git a/docs/handpaint-batch7-zhao-yun-source-v1.png b/docs/handpaint-batch7-zhao-yun-source-v1.png new file mode 100644 index 0000000..7762328 Binary files /dev/null and b/docs/handpaint-batch7-zhao-yun-source-v1.png differ diff --git a/docs/handpaint-batch7-zhao-yun-v3-animation.gif b/docs/handpaint-batch7-zhao-yun-v3-animation.gif new file mode 100644 index 0000000..a51328e Binary files /dev/null and b/docs/handpaint-batch7-zhao-yun-v3-animation.gif differ diff --git a/docs/handpaint-batch7-zhao-yun-v3-battle-composite.png b/docs/handpaint-batch7-zhao-yun-v3-battle-composite.png new file mode 100644 index 0000000..7aeb03c Binary files /dev/null and b/docs/handpaint-batch7-zhao-yun-v3-battle-composite.png differ diff --git a/docs/handpaint-batch7-zhao-yun-v3-before-after.png b/docs/handpaint-batch7-zhao-yun-v3-before-after.png new file mode 100644 index 0000000..aafb6ac Binary files /dev/null and b/docs/handpaint-batch7-zhao-yun-v3-before-after.png differ diff --git a/docs/handpaint-batch7-zhao-yun-v3-contact.png b/docs/handpaint-batch7-zhao-yun-v3-contact.png new file mode 100644 index 0000000..e71ca0a Binary files /dev/null and b/docs/handpaint-batch7-zhao-yun-v3-contact.png differ diff --git a/docs/handpaint-batch7-zhao-yun-v3-debug-preview-battle-check.png b/docs/handpaint-batch7-zhao-yun-v3-debug-preview-battle-check.png new file mode 100644 index 0000000..14fd2ca Binary files /dev/null and b/docs/handpaint-batch7-zhao-yun-v3-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch7-zhao-yun-v3-report.md b/docs/handpaint-batch7-zhao-yun-v3-report.md new file mode 100644 index 0000000..012485c --- /dev/null +++ b/docs/handpaint-batch7-zhao-yun-v3-report.md @@ -0,0 +1,24 @@ +# Zhao Yun hand-painted v3 report + +- source: `handpaint-batch7-zhao-yun-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 1927986 +- action partial alpha: 0, opaque pixels: 3700516 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 141..266 +- base bbox height range: 282..290 +- base bottom range: 303..303 +- action bbox width range: 118..248 +- action bbox height range: 277..295 +- action bottom range: 303..303 +- contact: `handpaint-batch7-zhao-yun-v3-contact.png` +- animation: `handpaint-batch7-zhao-yun-v3-animation.gif` +- before/after: `handpaint-batch7-zhao-yun-v3-before-after.png` +- scale compare: `handpaint-batch7-zhao-yun-v3-scale-compare.png` +- battle composite: `handpaint-batch7-zhao-yun-v3-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch7-zhao-yun-v3-scale-compare.png b/docs/handpaint-batch7-zhao-yun-v3-scale-compare.png new file mode 100644 index 0000000..ab1cc89 Binary files /dev/null and b/docs/handpaint-batch7-zhao-yun-v3-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index f8205fe..b6f7543 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 89 +- Approved baseline units: 90 - Pending approval units: 0 -- Queued rework units: 2 +- Queued rework units: 1 ## Checked Rules diff --git a/docs/unit-sprite-batch-queue.json b/docs/unit-sprite-batch-queue.json index 1447018..9751cba 100644 --- a/docs/unit-sprite-batch-queue.json +++ b/docs/unit-sprite-batch-queue.json @@ -91,13 +91,14 @@ "unit-wu-yi", "unit-yan-yan", "unit-yi-ji", - "unit-zhang-fei" + "unit-zhang-fei", + "unit-zhao-yun" ], "pendingApproval": [], "nextAfterApproval": [], "stageCounts": { - "approved-baseline": 89, - "queued-rework": 2 + "approved-baseline": 90, + "queued-rework": 1 }, "batches": [ { @@ -1183,24 +1184,10 @@ "label": "Batch 7 unique officers", "total": 19, "stageCounts": { - "approved-baseline": 17, - "queued-rework": 2 + "approved-baseline": 18, + "queued-rework": 1 }, "units": [ - { - "stem": "unit-zhao-yun", - "reviewStage": "queued-rework", - "queueRole": "queued rework", - "baseStatus": "border-hits=64", - "actionStatus": "border-hits=144", - "battleBasePx": [ - 26.5, - 47.3, - 45.0, - 46.0 - ], - "spec": null - }, { "stem": "unit-zhuge-liang", "reviewStage": "queued-rework", @@ -1452,6 +1439,20 @@ 46.0 ], "spec": null + }, + { + "stem": "unit-zhao-yun", + "reviewStage": "approved-baseline", + "queueRole": "approved reference", + "baseStatus": "ok", + "actionStatus": "ok", + "battleBasePx": [ + 22.5, + 42.5, + 45.0, + 46.3 + ], + "spec": null } ] } diff --git a/docs/unit-sprite-batch-queue.md b/docs/unit-sprite-batch-queue.md index e10e6de..8b71df4 100644 --- a/docs/unit-sprite-batch-queue.md +++ b/docs/unit-sprite-batch-queue.md @@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i ## Current State -- Approved baseline units: 89 +- Approved baseline units: 90 - Pending approval units: 0 -- Queued rework units: 2 +- Queued rework units: 1 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` @@ -157,11 +157,10 @@ No next unit is currently defined. - Batch key: `batch7-unique-officer` - Total units: 19 -- Stage counts: approved-baseline 17, queued-rework 2 +- Stage counts: approved-baseline 18, queued-rework 1 | unit | role | stage | status | battle base px | spec | | --- | --- | --- | --- | --- | --- | -| `unit-zhao-yun` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 26.5..47.3 x 45.0..46.0 | | | `unit-zhuge-liang` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | | `unit-cao-cao` | approved reference | approved-baseline | technical ok | 32.9..36.4 x 46.3..47.3 | | | `unit-fa-zheng` | approved reference | approved-baseline | technical ok | 29.1..35.3 x 46.3..46.3 | | @@ -180,3 +179,4 @@ No next unit is currently defined. | `unit-wang-ping` | approved reference | approved-baseline | technical ok | 28.0..33.7 x 45.7..46.0 | | | `unit-yan-yan` | approved reference | approved-baseline | technical ok | 30.4..37.5 x 45.7..46.0 | | | `unit-yi-ji` | approved reference | approved-baseline | technical ok | 27.8..33.9 x 45.7..46.0 | | +| `unit-zhao-yun` | approved reference | approved-baseline | technical ok | 22.5..42.5 x 45.0..46.3 | | diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index 906f97b..066bf19 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index 4a67bd1..d6e0753 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 89 +- Approved baseline units: 90 - Pending approval units: 0 -- Queued rework units: 2 +- Queued rework units: 1 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index 25d89c8..6c4a83e 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch7-unique-officer.png b/docs/unit-sprite-review-batch7-unique-officer.png index e2a990d..f3ae261 100644 Binary files a/docs/unit-sprite-review-batch7-unique-officer.png and b/docs/unit-sprite-review-batch7-unique-officer.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index 651f262..b3a48e0 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index 3ce54cb..6d08691 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 89, - "queued-rework": 2 + "approved-baseline": 90, + "queued-rework": 1 }, "rows": [ { @@ -5090,7 +5090,7 @@ }, { "batch": "batch7-unique-officer", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-zhao-yun", "base": { "key": "unit-zhao-yun", @@ -5100,23 +5100,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 2540801, - "border_hits": 64, - "min_width": 166, - "max_width": 296, + "opaque_pixels": 1927986, + "border_hits": 0, + "min_width": 141, + "max_width": 266, "min_height": 282, - "max_height": 288, - "min_bottom": 281, - "max_bottom": 287, + "max_height": 290, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 130, - "height_swing": 6, - "bottom_swing": 6, - "battle_min_width_px": 26.5, - "battle_max_width_px": 47.3, + "width_swing": 125, + "height_swing": 8, + "bottom_swing": 0, + "battle_min_width_px": 22.5, + "battle_max_width_px": 42.5, "battle_min_height_px": 45.0, - "battle_max_height_px": 46.0, - "status": "border-hits=64" + "battle_max_height_px": 46.3, + "status": "ok" }, "actions": { "key": "unit-zhao-yun-actions", @@ -5126,23 +5126,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 5689665, - "border_hits": 144, - "min_width": 166, - "max_width": 305, - "min_height": 274, - "max_height": 290, - "min_bottom": 273, - "max_bottom": 289, + "opaque_pixels": 3700516, + "border_hits": 0, + "min_width": 118, + "max_width": 248, + "min_height": 277, + "max_height": 295, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 139, - "height_swing": 16, - "bottom_swing": 16, - "battle_min_width_px": 26.5, - "battle_max_width_px": 48.7, - "battle_min_height_px": 43.8, - "battle_max_height_px": 46.3, - "status": "border-hits=144" + "width_swing": 130, + "height_swing": 18, + "bottom_swing": 0, + "battle_min_width_px": 18.8, + "battle_max_width_px": 39.6, + "battle_min_height_px": 44.2, + "battle_max_height_px": 47.1, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index a6e487b..6a395b0 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 89 -- queued-rework: 2 +- approved-baseline: 90 +- queued-rework: 1 ## Batch Plan @@ -141,5 +141,5 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch7-unique-officer | approved-baseline | `unit-yan-yan` | ok | ok | 190..235 x 286..288 | 170..242 x 271..295 | 30.4..37.5 x 45.7..46.0 | w45 h2 b0 | | batch7-unique-officer | approved-baseline | `unit-yi-ji` | ok | ok | 174..212 x 286..288 | 167..273 x 286..295 | 27.8..33.9 x 45.7..46.0 | w38 h2 b0 | | batch1-approved-core | approved-baseline | `unit-zhang-fei` | ok | ok | 143..306 x 274..289 | 188..286 x 181..290 | 22.8..48.9 x 43.8..46.2 | w163 h15 b14 | -| batch7-unique-officer | queued-rework | `unit-zhao-yun` | border-hits=64 | border-hits=144 | 166..296 x 282..288 | 166..305 x 274..290 | 26.5..47.3 x 45.0..46.0 | w130 h6 b6 | +| batch7-unique-officer | approved-baseline | `unit-zhao-yun` | ok | ok | 141..266 x 282..290 | 118..248 x 277..295 | 22.5..42.5 x 45.0..46.3 | w125 h8 b0 | | batch7-unique-officer | queued-rework | `unit-zhuge-liang` | border-hits=32 | border-hits=98 | 243..246 x 280..281 | 220..255 x 275..281 | 38.8..39.3 x 44.7..44.9 | w3 h1 b6 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index 6e3a37d..9c04210 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -99,7 +99,8 @@ "unit-wu-yi", "unit-yan-yan", "unit-yi-ji", - "unit-zhang-fei" + "unit-zhang-fei", + "unit-zhao-yun" ], "pendingApproval": [], "currentApprovalCandidate": {}, diff --git a/docs/unit-sprite-zhao-yun-v3-approval-packet.md b/docs/unit-sprite-zhao-yun-v3-approval-packet.md new file mode 100644 index 0000000..25a2fa4 --- /dev/null +++ b/docs/unit-sprite-zhao-yun-v3-approval-packet.md @@ -0,0 +1,35 @@ +# Zhao Yun hand-painted v3 approval packet + +- unit: `unit-zhao-yun` +- candidate: `handpaint-batch7-zhao-yun-v3` +- source: `docs/handpaint-batch7-zhao-yun-source-v1.png` +- contact sheet: `docs/handpaint-batch7-zhao-yun-v3-contact.png` +- animation: `docs/handpaint-batch7-zhao-yun-v3-animation.gif` +- before/after: `docs/handpaint-batch7-zhao-yun-v3-before-after.png` +- battle composite: `docs/handpaint-batch7-zhao-yun-v3-battle-composite.png` +- current approval board: `docs/unit-sprite-current-approval-board.png` +- browser check: `docs/handpaint-batch7-zhao-yun-v3-debug-preview-battle-check.png` + +## Result + +- Local build: `pnpm build` passed. +- Local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-zhao-yun&v=zhao-yun-v3` +- Local browser console errors: `0` +- Local browser 404s: `0` +- Sample gate: passed. + +## Sprite safety + +- base partial alpha: 0 +- action partial alpha: 0 +- base frame border hits: 0 +- action frame border hits: 0 +- base battle size: 22.5..42.5 x 45.0..46.3 +- frame bbox width: 141..266 base, 118..248 action +- frame bbox height: 282..290 base, 277..295 action + +## Visual notes + +- v1 had the right mounted-white-cavalry direction but missed the battle-scale width threshold and had slightly too much base-frame height swing. +- v2 corrected vertical stability, and v3 widens the horse/rider silhouette enough for the art quality gate. +- White horse, silver armor, blue scarf, and upright spear make Zhao Yun read as a distinct elite cavalry officer separate from Ma Chao and Ma Dai. diff --git a/src/assets/images/units/unit-zhao-yun-actions.png b/src/assets/images/units/unit-zhao-yun-actions.png index 9885262..0ccb737 100644 Binary files a/src/assets/images/units/unit-zhao-yun-actions.png and b/src/assets/images/units/unit-zhao-yun-actions.png differ diff --git a/src/assets/images/units/unit-zhao-yun.png b/src/assets/images/units/unit-zhao-yun.png index 7662c7e..70fe6b0 100644 Binary files a/src/assets/images/units/unit-zhao-yun.png and b/src/assets/images/units/unit-zhao-yun.png differ