Approve Ma Liang handpainted sprite v2
BIN
docs/handpaint-batch7-ma-liang-source-v1.png
Normal file
|
After Width: | Height: | Size: 2.3 MiB |
BIN
docs/handpaint-batch7-ma-liang-v2-animation.gif
Normal file
|
After Width: | Height: | Size: 232 KiB |
BIN
docs/handpaint-batch7-ma-liang-v2-battle-composite.png
Normal file
|
After Width: | Height: | Size: 888 KiB |
BIN
docs/handpaint-batch7-ma-liang-v2-before-after.png
Normal file
|
After Width: | Height: | Size: 63 KiB |
BIN
docs/handpaint-batch7-ma-liang-v2-contact.png
Normal file
|
After Width: | Height: | Size: 221 KiB |
BIN
docs/handpaint-batch7-ma-liang-v2-debug-preview-battle-check.png
Normal file
|
After Width: | Height: | Size: 685 KiB |
24
docs/handpaint-batch7-ma-liang-v2-report.md
Normal file
@@ -0,0 +1,24 @@
|
||||
# Ma Liang hand-painted v2 report
|
||||
|
||||
- source: `handpaint-batch7-ma-liang-source-v1.png`
|
||||
- base status: ok
|
||||
- action status: ok
|
||||
- base partial alpha: 0, opaque pixels: 2452368
|
||||
- action partial alpha: 0, opaque pixels: 6122211
|
||||
- base frame border hits: 0
|
||||
- action frame border hits: 0
|
||||
- base empty frames: 0
|
||||
- action empty frames: 0
|
||||
- base bbox width range: 160..243
|
||||
- base bbox height range: 290..290
|
||||
- base bottom range: 303..303
|
||||
- action bbox width range: 160..264
|
||||
- action bbox height range: 286..290
|
||||
- action bottom range: 303..303
|
||||
- contact: `handpaint-batch7-ma-liang-v2-contact.png`
|
||||
- animation: `handpaint-batch7-ma-liang-v2-animation.gif`
|
||||
- before/after: `handpaint-batch7-ma-liang-v2-before-after.png`
|
||||
- scale compare: `handpaint-batch7-ma-liang-v2-scale-compare.png`
|
||||
- battle composite: `handpaint-batch7-ma-liang-v2-battle-composite.png`
|
||||
- manual checks: run build and local browser verification after generation
|
||||
- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval
|
||||
BIN
docs/handpaint-batch7-ma-liang-v2-scale-compare.png
Normal file
|
After Width: | Height: | Size: 29 KiB |
@@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not
|
||||
|
||||
- Manifest: `docs/unit-sprite-rework-manifest.json`
|
||||
- Audit: `docs/unit-sprite-rework-audit.json`
|
||||
- Approved baseline units: 83
|
||||
- Approved baseline units: 84
|
||||
- Pending approval units: 0
|
||||
- Queued rework units: 8
|
||||
- Queued rework units: 7
|
||||
|
||||
## Checked Rules
|
||||
|
||||
|
||||
@@ -16,6 +16,7 @@
|
||||
"unit-lu-meng",
|
||||
"unit-ma-chao",
|
||||
"unit-ma-dai",
|
||||
"unit-ma-liang",
|
||||
"unit-meng-huo",
|
||||
"unit-nanman-infantry",
|
||||
"unit-nanman-infantry-jungle",
|
||||
@@ -90,8 +91,8 @@
|
||||
"pendingApproval": [],
|
||||
"nextAfterApproval": [],
|
||||
"stageCounts": {
|
||||
"approved-baseline": 83,
|
||||
"queued-rework": 8
|
||||
"approved-baseline": 84,
|
||||
"queued-rework": 7
|
||||
},
|
||||
"batches": [
|
||||
{
|
||||
@@ -1177,24 +1178,10 @@
|
||||
"label": "Batch 7 unique officers",
|
||||
"total": 19,
|
||||
"stageCounts": {
|
||||
"approved-baseline": 11,
|
||||
"queued-rework": 8
|
||||
"approved-baseline": 12,
|
||||
"queued-rework": 7
|
||||
},
|
||||
"units": [
|
||||
{
|
||||
"stem": "unit-ma-liang",
|
||||
"reviewStage": "queued-rework",
|
||||
"queueRole": "queued rework",
|
||||
"baseStatus": "border-hits=32",
|
||||
"actionStatus": "border-hits=98",
|
||||
"battleBasePx": [
|
||||
38.8,
|
||||
39.3,
|
||||
44.7,
|
||||
44.9
|
||||
],
|
||||
"spec": null
|
||||
},
|
||||
{
|
||||
"stem": "unit-pang-tong",
|
||||
"reviewStage": "queued-rework",
|
||||
@@ -1446,6 +1433,20 @@
|
||||
46.3
|
||||
],
|
||||
"spec": null
|
||||
},
|
||||
{
|
||||
"stem": "unit-ma-liang",
|
||||
"reviewStage": "approved-baseline",
|
||||
"queueRole": "approved reference",
|
||||
"baseStatus": "ok",
|
||||
"actionStatus": "ok",
|
||||
"battleBasePx": [
|
||||
25.6,
|
||||
38.8,
|
||||
46.3,
|
||||
46.3
|
||||
],
|
||||
"spec": null
|
||||
}
|
||||
]
|
||||
}
|
||||
|
||||
@@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i
|
||||
|
||||
## Current State
|
||||
|
||||
- Approved baseline units: 83
|
||||
- Approved baseline units: 84
|
||||
- Pending approval units: 0
|
||||
- Queued rework units: 8
|
||||
- Queued rework units: 7
|
||||
- Manifest: `docs/unit-sprite-rework-manifest.json`
|
||||
- Audit: `docs/unit-sprite-rework-audit.json`
|
||||
|
||||
@@ -157,11 +157,10 @@ No next unit is currently defined.
|
||||
|
||||
- Batch key: `batch7-unique-officer`
|
||||
- Total units: 19
|
||||
- Stage counts: approved-baseline 11, queued-rework 8
|
||||
- Stage counts: approved-baseline 12, queued-rework 7
|
||||
|
||||
| unit | role | stage | status | battle base px | spec |
|
||||
| --- | --- | --- | --- | --- | --- |
|
||||
| `unit-ma-liang` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | |
|
||||
| `unit-pang-tong` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | |
|
||||
| `unit-sima-yi` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | |
|
||||
| `unit-wang-ping` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 31.9..40.6 x 44.6..44.6 | |
|
||||
@@ -180,3 +179,4 @@ No next unit is currently defined.
|
||||
| `unit-lu-meng` | approved reference | approved-baseline | technical ok | 27.0..40.4 x 46.0..46.3 | |
|
||||
| `unit-ma-chao` | approved reference | approved-baseline | technical ok | 26.5..42.0 x 46.0..47.3 | |
|
||||
| `unit-ma-dai` | approved reference | approved-baseline | technical ok | 27.0..39.8 x 46.0..46.3 | |
|
||||
| `unit-ma-liang` | approved reference | approved-baseline | technical ok | 25.6..38.8 x 46.3..46.3 | |
|
||||
|
||||
|
Before Width: | Height: | Size: 628 KiB After Width: | Height: | Size: 662 KiB |
35
docs/unit-sprite-ma-liang-v2-approval-packet.md
Normal file
@@ -0,0 +1,35 @@
|
||||
# Ma Liang hand-painted v2 approval packet
|
||||
|
||||
- unit: `unit-ma-liang`
|
||||
- candidate: `handpaint-batch7-ma-liang-v2`
|
||||
- source: `docs/handpaint-batch7-ma-liang-source-v1.png`
|
||||
- contact sheet: `docs/handpaint-batch7-ma-liang-v2-contact.png`
|
||||
- animation: `docs/handpaint-batch7-ma-liang-v2-animation.gif`
|
||||
- before/after: `docs/handpaint-batch7-ma-liang-v2-before-after.png`
|
||||
- battle composite: `docs/handpaint-batch7-ma-liang-v2-battle-composite.png`
|
||||
- current approval board: `docs/unit-sprite-current-approval-board.png`
|
||||
- browser check: `docs/handpaint-batch7-ma-liang-v2-debug-preview-battle-check.png`
|
||||
|
||||
## Result
|
||||
|
||||
- Local build: `pnpm build` passed.
|
||||
- Local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-ma-liang&v=ma-liang-v2`
|
||||
- Local browser console errors: `0`
|
||||
- Local browser 404s: `0`
|
||||
- Sample gate: passed.
|
||||
|
||||
## Sprite safety
|
||||
|
||||
- base partial alpha: 0
|
||||
- action partial alpha: 0
|
||||
- base frame border hits: 0
|
||||
- action frame border hits: 0
|
||||
- base battle size: 25.6..38.8 x 46.3..46.3
|
||||
- frame bbox width: 160..243 base, 160..264 action
|
||||
- frame bbox height: 290 base, 286..290 action
|
||||
|
||||
## Visual notes
|
||||
|
||||
- v1 was readable but too narrow beside approved strategist/officer silhouettes.
|
||||
- v2 widens the robe and fan posture while keeping all frames inside the 313x313 frame boundary.
|
||||
- White robe, scroll/fan gesture, and purple trim make Ma Liang distinct from Lu Meng, Fa Zheng, and generic Shu strategists at 50px battle scale.
|
||||
@@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`.
|
||||
|
||||
## Current Gate
|
||||
|
||||
- Approved baseline units: 83
|
||||
- Approved baseline units: 84
|
||||
- Pending approval units: 0
|
||||
- Queued rework units: 8
|
||||
- Queued rework units: 7
|
||||
- Manifest: `docs/unit-sprite-rework-manifest.json`
|
||||
- Audit: `docs/unit-sprite-rework-audit.json`
|
||||
- Current approval board: not generated until the next pending sample.
|
||||
|
||||
|
Before Width: | Height: | Size: 776 KiB After Width: | Height: | Size: 784 KiB |
|
Before Width: | Height: | Size: 162 KiB After Width: | Height: | Size: 171 KiB |
|
Before Width: | Height: | Size: 97 KiB After Width: | Height: | Size: 97 KiB |
@@ -11,8 +11,8 @@
|
||||
"batch7-unique-officer": 19
|
||||
},
|
||||
"stage_counts": {
|
||||
"approved-baseline": 83,
|
||||
"queued-rework": 8
|
||||
"approved-baseline": 84,
|
||||
"queued-rework": 7
|
||||
},
|
||||
"rows": [
|
||||
{
|
||||
@@ -758,7 +758,7 @@
|
||||
},
|
||||
{
|
||||
"batch": "batch7-unique-officer",
|
||||
"review_stage": "queued-rework",
|
||||
"review_stage": "approved-baseline",
|
||||
"stem": "unit-ma-liang",
|
||||
"base": {
|
||||
"key": "unit-ma-liang",
|
||||
@@ -768,23 +768,23 @@
|
||||
1252
|
||||
],
|
||||
"partial_alpha": 0,
|
||||
"opaque_pixels": 1999925,
|
||||
"border_hits": 32,
|
||||
"min_width": 243,
|
||||
"max_width": 246,
|
||||
"min_height": 280,
|
||||
"max_height": 281,
|
||||
"min_bottom": 281,
|
||||
"max_bottom": 287,
|
||||
"opaque_pixels": 2452368,
|
||||
"border_hits": 0,
|
||||
"min_width": 160,
|
||||
"max_width": 243,
|
||||
"min_height": 290,
|
||||
"max_height": 290,
|
||||
"min_bottom": 303,
|
||||
"max_bottom": 303,
|
||||
"empty_frames": 0,
|
||||
"width_swing": 3,
|
||||
"height_swing": 1,
|
||||
"bottom_swing": 6,
|
||||
"battle_min_width_px": 38.8,
|
||||
"battle_max_width_px": 39.3,
|
||||
"battle_min_height_px": 44.7,
|
||||
"battle_max_height_px": 44.9,
|
||||
"status": "border-hits=32"
|
||||
"width_swing": 83,
|
||||
"height_swing": 0,
|
||||
"bottom_swing": 0,
|
||||
"battle_min_width_px": 25.6,
|
||||
"battle_max_width_px": 38.8,
|
||||
"battle_min_height_px": 46.3,
|
||||
"battle_max_height_px": 46.3,
|
||||
"status": "ok"
|
||||
},
|
||||
"actions": {
|
||||
"key": "unit-ma-liang-actions",
|
||||
@@ -794,23 +794,23 @@
|
||||
1252
|
||||
],
|
||||
"partial_alpha": 0,
|
||||
"opaque_pixels": 4453376,
|
||||
"border_hits": 98,
|
||||
"min_width": 220,
|
||||
"max_width": 255,
|
||||
"min_height": 275,
|
||||
"max_height": 281,
|
||||
"min_bottom": 274,
|
||||
"max_bottom": 289,
|
||||
"opaque_pixels": 6122211,
|
||||
"border_hits": 0,
|
||||
"min_width": 160,
|
||||
"max_width": 264,
|
||||
"min_height": 286,
|
||||
"max_height": 290,
|
||||
"min_bottom": 303,
|
||||
"max_bottom": 303,
|
||||
"empty_frames": 0,
|
||||
"width_swing": 35,
|
||||
"height_swing": 6,
|
||||
"bottom_swing": 15,
|
||||
"battle_min_width_px": 35.1,
|
||||
"battle_max_width_px": 40.7,
|
||||
"battle_min_height_px": 43.9,
|
||||
"battle_max_height_px": 44.9,
|
||||
"status": "border-hits=98"
|
||||
"width_swing": 104,
|
||||
"height_swing": 4,
|
||||
"bottom_swing": 0,
|
||||
"battle_min_width_px": 25.6,
|
||||
"battle_max_width_px": 42.2,
|
||||
"battle_min_height_px": 45.7,
|
||||
"battle_max_height_px": 46.3,
|
||||
"status": "ok"
|
||||
}
|
||||
},
|
||||
{
|
||||
|
||||
@@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards.
|
||||
|
||||
## Review Stage Counts
|
||||
|
||||
- approved-baseline: 83
|
||||
- queued-rework: 8
|
||||
- approved-baseline: 84
|
||||
- queued-rework: 7
|
||||
|
||||
## Batch Plan
|
||||
|
||||
@@ -65,7 +65,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards.
|
||||
| batch7-unique-officer | approved-baseline | `unit-lu-meng` | ok | ok | 169..253 x 288..290 | 153..238 x 286..290 | 27.0..40.4 x 46.0..46.3 | w84 h2 b0 |
|
||||
| batch7-unique-officer | approved-baseline | `unit-ma-chao` | ok | ok | 166..263 x 288..296 | 166..263 x 284..296 | 26.5..42.0 x 46.0..47.3 | w97 h8 b0 |
|
||||
| batch7-unique-officer | approved-baseline | `unit-ma-dai` | ok | ok | 169..249 x 288..290 | 162..239 x 284..290 | 27.0..39.8 x 46.0..46.3 | w80 h2 b0 |
|
||||
| batch7-unique-officer | queued-rework | `unit-ma-liang` | border-hits=32 | border-hits=98 | 243..246 x 280..281 | 220..255 x 275..281 | 38.8..39.3 x 44.7..44.9 | w3 h1 b6 |
|
||||
| batch7-unique-officer | approved-baseline | `unit-ma-liang` | ok | ok | 160..243 x 290..290 | 160..264 x 286..290 | 25.6..38.8 x 46.3..46.3 | w83 h0 b0 |
|
||||
| batch6-nanman-special | approved-baseline | `unit-meng-huo` | ok | ok | 174..221 x 286..288 | 149..248 x 275..289 | 27.8..35.3 x 45.7..46.0 | w47 h2 b0 |
|
||||
| batch6-nanman-special | approved-baseline | `unit-nanman-infantry` | ok | ok | 152..219 x 288..288 | 152..243 x 265..288 | 24.3..35.0 x 46.0..46.0 | w67 h0 b0 |
|
||||
| batch6-nanman-special | approved-baseline | `unit-nanman-infantry-jungle` | ok | ok | 172..209 x 286..288 | 158..247 x 282..288 | 27.5..33.4 x 45.7..46.0 | w37 h2 b0 |
|
||||
|
||||
@@ -24,6 +24,7 @@
|
||||
"unit-lu-meng",
|
||||
"unit-ma-chao",
|
||||
"unit-ma-dai",
|
||||
"unit-ma-liang",
|
||||
"unit-meng-huo",
|
||||
"unit-nanman-infantry",
|
||||
"unit-nanman-infantry-jungle",
|
||||
|
||||