diff --git a/docs/handpaint-batch7-ma-liang-source-v1.png b/docs/handpaint-batch7-ma-liang-source-v1.png new file mode 100644 index 0000000..be8951f Binary files /dev/null and b/docs/handpaint-batch7-ma-liang-source-v1.png differ diff --git a/docs/handpaint-batch7-ma-liang-v2-animation.gif b/docs/handpaint-batch7-ma-liang-v2-animation.gif new file mode 100644 index 0000000..83a85d1 Binary files /dev/null and b/docs/handpaint-batch7-ma-liang-v2-animation.gif differ diff --git a/docs/handpaint-batch7-ma-liang-v2-battle-composite.png b/docs/handpaint-batch7-ma-liang-v2-battle-composite.png new file mode 100644 index 0000000..41a3d3a Binary files /dev/null and b/docs/handpaint-batch7-ma-liang-v2-battle-composite.png differ diff --git a/docs/handpaint-batch7-ma-liang-v2-before-after.png b/docs/handpaint-batch7-ma-liang-v2-before-after.png new file mode 100644 index 0000000..1ebddd1 Binary files /dev/null and b/docs/handpaint-batch7-ma-liang-v2-before-after.png differ diff --git a/docs/handpaint-batch7-ma-liang-v2-contact.png b/docs/handpaint-batch7-ma-liang-v2-contact.png new file mode 100644 index 0000000..462c703 Binary files /dev/null and b/docs/handpaint-batch7-ma-liang-v2-contact.png differ diff --git a/docs/handpaint-batch7-ma-liang-v2-debug-preview-battle-check.png b/docs/handpaint-batch7-ma-liang-v2-debug-preview-battle-check.png new file mode 100644 index 0000000..8830538 Binary files /dev/null and b/docs/handpaint-batch7-ma-liang-v2-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch7-ma-liang-v2-report.md b/docs/handpaint-batch7-ma-liang-v2-report.md new file mode 100644 index 0000000..5c9ca64 --- /dev/null +++ b/docs/handpaint-batch7-ma-liang-v2-report.md @@ -0,0 +1,24 @@ +# Ma Liang hand-painted v2 report + +- source: `handpaint-batch7-ma-liang-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 2452368 +- action partial alpha: 0, opaque pixels: 6122211 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 160..243 +- base bbox height range: 290..290 +- base bottom range: 303..303 +- action bbox width range: 160..264 +- action bbox height range: 286..290 +- action bottom range: 303..303 +- contact: `handpaint-batch7-ma-liang-v2-contact.png` +- animation: `handpaint-batch7-ma-liang-v2-animation.gif` +- before/after: `handpaint-batch7-ma-liang-v2-before-after.png` +- scale compare: `handpaint-batch7-ma-liang-v2-scale-compare.png` +- battle composite: `handpaint-batch7-ma-liang-v2-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch7-ma-liang-v2-scale-compare.png b/docs/handpaint-batch7-ma-liang-v2-scale-compare.png new file mode 100644 index 0000000..679e592 Binary files /dev/null and b/docs/handpaint-batch7-ma-liang-v2-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index 9b10954..023b4de 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 83 +- Approved baseline units: 84 - Pending approval units: 0 -- Queued rework units: 8 +- Queued rework units: 7 ## Checked Rules diff --git a/docs/unit-sprite-batch-queue.json b/docs/unit-sprite-batch-queue.json index b400965..f4e7ec1 100644 --- a/docs/unit-sprite-batch-queue.json +++ b/docs/unit-sprite-batch-queue.json @@ -16,6 +16,7 @@ "unit-lu-meng", "unit-ma-chao", "unit-ma-dai", + "unit-ma-liang", "unit-meng-huo", "unit-nanman-infantry", "unit-nanman-infantry-jungle", @@ -90,8 +91,8 @@ "pendingApproval": [], "nextAfterApproval": [], "stageCounts": { - "approved-baseline": 83, - "queued-rework": 8 + "approved-baseline": 84, + "queued-rework": 7 }, "batches": [ { @@ -1177,24 +1178,10 @@ "label": "Batch 7 unique officers", "total": 19, "stageCounts": { - "approved-baseline": 11, - "queued-rework": 8 + "approved-baseline": 12, + "queued-rework": 7 }, "units": [ - { - "stem": "unit-ma-liang", - "reviewStage": "queued-rework", - "queueRole": "queued rework", - "baseStatus": "border-hits=32", - "actionStatus": "border-hits=98", - "battleBasePx": [ - 38.8, - 39.3, - 44.7, - 44.9 - ], - "spec": null - }, { "stem": "unit-pang-tong", "reviewStage": "queued-rework", @@ -1446,6 +1433,20 @@ 46.3 ], "spec": null + }, + { + "stem": "unit-ma-liang", + "reviewStage": "approved-baseline", + "queueRole": "approved reference", + "baseStatus": "ok", + "actionStatus": "ok", + "battleBasePx": [ + 25.6, + 38.8, + 46.3, + 46.3 + ], + "spec": null } ] } diff --git a/docs/unit-sprite-batch-queue.md b/docs/unit-sprite-batch-queue.md index 2288a0d..4c43467 100644 --- a/docs/unit-sprite-batch-queue.md +++ b/docs/unit-sprite-batch-queue.md @@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i ## Current State -- Approved baseline units: 83 +- Approved baseline units: 84 - Pending approval units: 0 -- Queued rework units: 8 +- Queued rework units: 7 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` @@ -157,11 +157,10 @@ No next unit is currently defined. - Batch key: `batch7-unique-officer` - Total units: 19 -- Stage counts: approved-baseline 11, queued-rework 8 +- Stage counts: approved-baseline 12, queued-rework 7 | unit | role | stage | status | battle base px | spec | | --- | --- | --- | --- | --- | --- | -| `unit-ma-liang` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | | `unit-pang-tong` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | | `unit-sima-yi` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | | `unit-wang-ping` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 31.9..40.6 x 44.6..44.6 | | @@ -180,3 +179,4 @@ No next unit is currently defined. | `unit-lu-meng` | approved reference | approved-baseline | technical ok | 27.0..40.4 x 46.0..46.3 | | | `unit-ma-chao` | approved reference | approved-baseline | technical ok | 26.5..42.0 x 46.0..47.3 | | | `unit-ma-dai` | approved reference | approved-baseline | technical ok | 27.0..39.8 x 46.0..46.3 | | +| `unit-ma-liang` | approved reference | approved-baseline | technical ok | 25.6..38.8 x 46.3..46.3 | | diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index 1fef104..cd84b18 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-ma-liang-v2-approval-packet.md b/docs/unit-sprite-ma-liang-v2-approval-packet.md new file mode 100644 index 0000000..9dbec84 --- /dev/null +++ b/docs/unit-sprite-ma-liang-v2-approval-packet.md @@ -0,0 +1,35 @@ +# Ma Liang hand-painted v2 approval packet + +- unit: `unit-ma-liang` +- candidate: `handpaint-batch7-ma-liang-v2` +- source: `docs/handpaint-batch7-ma-liang-source-v1.png` +- contact sheet: `docs/handpaint-batch7-ma-liang-v2-contact.png` +- animation: `docs/handpaint-batch7-ma-liang-v2-animation.gif` +- before/after: `docs/handpaint-batch7-ma-liang-v2-before-after.png` +- battle composite: `docs/handpaint-batch7-ma-liang-v2-battle-composite.png` +- current approval board: `docs/unit-sprite-current-approval-board.png` +- browser check: `docs/handpaint-batch7-ma-liang-v2-debug-preview-battle-check.png` + +## Result + +- Local build: `pnpm build` passed. +- Local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-ma-liang&v=ma-liang-v2` +- Local browser console errors: `0` +- Local browser 404s: `0` +- Sample gate: passed. + +## Sprite safety + +- base partial alpha: 0 +- action partial alpha: 0 +- base frame border hits: 0 +- action frame border hits: 0 +- base battle size: 25.6..38.8 x 46.3..46.3 +- frame bbox width: 160..243 base, 160..264 action +- frame bbox height: 290 base, 286..290 action + +## Visual notes + +- v1 was readable but too narrow beside approved strategist/officer silhouettes. +- v2 widens the robe and fan posture while keeping all frames inside the 313x313 frame boundary. +- White robe, scroll/fan gesture, and purple trim make Ma Liang distinct from Lu Meng, Fa Zheng, and generic Shu strategists at 50px battle scale. diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index 063eceb..adb5902 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 83 +- Approved baseline units: 84 - Pending approval units: 0 -- Queued rework units: 8 +- Queued rework units: 7 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index ab30698..4f10cdf 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch7-unique-officer.png b/docs/unit-sprite-review-batch7-unique-officer.png index f7951d6..724e3c4 100644 Binary files a/docs/unit-sprite-review-batch7-unique-officer.png and b/docs/unit-sprite-review-batch7-unique-officer.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index 2626026..ef403a2 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index 2ac0527..5ddb88b 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 83, - "queued-rework": 8 + "approved-baseline": 84, + "queued-rework": 7 }, "rows": [ { @@ -758,7 +758,7 @@ }, { "batch": "batch7-unique-officer", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-ma-liang", "base": { "key": "unit-ma-liang", @@ -768,23 +768,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 1999925, - "border_hits": 32, - "min_width": 243, - "max_width": 246, - "min_height": 280, - "max_height": 281, - "min_bottom": 281, - "max_bottom": 287, + "opaque_pixels": 2452368, + "border_hits": 0, + "min_width": 160, + "max_width": 243, + "min_height": 290, + "max_height": 290, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 3, - "height_swing": 1, - "bottom_swing": 6, - "battle_min_width_px": 38.8, - "battle_max_width_px": 39.3, - "battle_min_height_px": 44.7, - "battle_max_height_px": 44.9, - "status": "border-hits=32" + "width_swing": 83, + "height_swing": 0, + "bottom_swing": 0, + "battle_min_width_px": 25.6, + "battle_max_width_px": 38.8, + "battle_min_height_px": 46.3, + "battle_max_height_px": 46.3, + "status": "ok" }, "actions": { "key": "unit-ma-liang-actions", @@ -794,23 +794,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4453376, - "border_hits": 98, - "min_width": 220, - "max_width": 255, - "min_height": 275, - "max_height": 281, - "min_bottom": 274, - "max_bottom": 289, + "opaque_pixels": 6122211, + "border_hits": 0, + "min_width": 160, + "max_width": 264, + "min_height": 286, + "max_height": 290, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 35, - "height_swing": 6, - "bottom_swing": 15, - "battle_min_width_px": 35.1, - "battle_max_width_px": 40.7, - "battle_min_height_px": 43.9, - "battle_max_height_px": 44.9, - "status": "border-hits=98" + "width_swing": 104, + "height_swing": 4, + "bottom_swing": 0, + "battle_min_width_px": 25.6, + "battle_max_width_px": 42.2, + "battle_min_height_px": 45.7, + "battle_max_height_px": 46.3, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index 9391b54..11a69aa 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 83 -- queued-rework: 8 +- approved-baseline: 84 +- queued-rework: 7 ## Batch Plan @@ -65,7 +65,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch7-unique-officer | approved-baseline | `unit-lu-meng` | ok | ok | 169..253 x 288..290 | 153..238 x 286..290 | 27.0..40.4 x 46.0..46.3 | w84 h2 b0 | | batch7-unique-officer | approved-baseline | `unit-ma-chao` | ok | ok | 166..263 x 288..296 | 166..263 x 284..296 | 26.5..42.0 x 46.0..47.3 | w97 h8 b0 | | batch7-unique-officer | approved-baseline | `unit-ma-dai` | ok | ok | 169..249 x 288..290 | 162..239 x 284..290 | 27.0..39.8 x 46.0..46.3 | w80 h2 b0 | -| batch7-unique-officer | queued-rework | `unit-ma-liang` | border-hits=32 | border-hits=98 | 243..246 x 280..281 | 220..255 x 275..281 | 38.8..39.3 x 44.7..44.9 | w3 h1 b6 | +| batch7-unique-officer | approved-baseline | `unit-ma-liang` | ok | ok | 160..243 x 290..290 | 160..264 x 286..290 | 25.6..38.8 x 46.3..46.3 | w83 h0 b0 | | batch6-nanman-special | approved-baseline | `unit-meng-huo` | ok | ok | 174..221 x 286..288 | 149..248 x 275..289 | 27.8..35.3 x 45.7..46.0 | w47 h2 b0 | | batch6-nanman-special | approved-baseline | `unit-nanman-infantry` | ok | ok | 152..219 x 288..288 | 152..243 x 265..288 | 24.3..35.0 x 46.0..46.0 | w67 h0 b0 | | batch6-nanman-special | approved-baseline | `unit-nanman-infantry-jungle` | ok | ok | 172..209 x 286..288 | 158..247 x 282..288 | 27.5..33.4 x 45.7..46.0 | w37 h2 b0 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index 0e24fa1..b3d7203 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -24,6 +24,7 @@ "unit-lu-meng", "unit-ma-chao", "unit-ma-dai", + "unit-ma-liang", "unit-meng-huo", "unit-nanman-infantry", "unit-nanman-infantry-jungle", diff --git a/src/assets/images/units/unit-ma-liang-actions.png b/src/assets/images/units/unit-ma-liang-actions.png index f8787f9..9257170 100644 Binary files a/src/assets/images/units/unit-ma-liang-actions.png and b/src/assets/images/units/unit-ma-liang-actions.png differ diff --git a/src/assets/images/units/unit-ma-liang.png b/src/assets/images/units/unit-ma-liang.png index bbf57ed..3b3d74c 100644 Binary files a/src/assets/images/units/unit-ma-liang.png and b/src/assets/images/units/unit-ma-liang.png differ