Approve Shu cavalry handpainted sprite v2

docs/handpaint-batch2-shu-cavalry-v2-report.md

@@ -0,0 +1,24 @@
+# Shu Cavalry Hand-Painted v2
+
+- source: `handpaint-batch2-shu-cavalry-source-v1.png`
+- base status: ok
+- action status: ok
+- base partial alpha: 0, opaque pixels: 2058614
+- action partial alpha: 0, opaque pixels: 4816651
+- base frame border hits: 0
+- action frame border hits: 0
+- base empty frames: 0
+- action empty frames: 0
+- base bbox width range: 166..245
+- base bbox height range: 288..290
+- base bottom range: 303..303
+- action bbox width range: 166..245
+- action bbox height range: 265..290
+- action bottom range: 303..303
+- contact: `handpaint-batch2-shu-cavalry-v2-contact.png`
+- animation: `handpaint-batch2-shu-cavalry-v2-animation.gif`
+- before/after: `handpaint-batch2-shu-cavalry-v2-before-after.png`
+- scale compare: `handpaint-batch2-shu-cavalry-v2-scale-compare.png`
+- battle composite: `handpaint-batch2-shu-cavalry-v2-battle-composite.png`
+- manual checks: run build and local browser verification after generation
+- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval

docs/unit-sprite-art-quality-gate.md

@@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not
 
 - Manifest: `docs/unit-sprite-rework-manifest.json`
 - Audit: `docs/unit-sprite-rework-audit.json`
-- Approved baseline units: 9
+- Approved baseline units: 10
 - Pending approval units: 0
-- Queued rework units: 82
+- Queued rework units: 81
 
 ## Checked Rules
 

docs/unit-sprite-next-steps.md

@@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`.
 
 ## Current Gate
 
-- Approved baseline units: 9
+- Approved baseline units: 10
 - Pending approval units: 0
-- Queued rework units: 82
+- Queued rework units: 81
 - Manifest: `docs/unit-sprite-rework-manifest.json`
 - Audit: `docs/unit-sprite-rework-audit.json`
 - Current approval board: not generated until the next pending sample.
@@ -14,9 +14,8 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`.
 
 ## Next Unit Queue
 
-1. `unit-shu-cavalry` - queued-rework, base `border-hits=64`, actions `border-hits=144`, spec `unit-sprite-batch2-shu-cavalry-spec.md`
-2. `unit-shu-strategist` - queued-rework, base `border-hits=32`, actions `border-hits=98`, spec `unit-sprite-batch2-shu-strategist-spec.md`
-3. `unit-shu-officer` - queued-rework, base `border-hits=32`, actions `border-hits=82`, spec `unit-sprite-batch2-shu-officer-spec.md`
+1. `unit-shu-strategist` - queued-rework, base `border-hits=32`, actions `border-hits=98`, spec `unit-sprite-batch2-shu-strategist-spec.md`
+2. `unit-shu-officer` - queued-rework, base `border-hits=32`, actions `border-hits=82`, spec `unit-sprite-batch2-shu-officer-spec.md`
 
 ## Commands Before Approval
 
@@ -43,6 +42,6 @@ pnpm build
 
 ## First Task After Current Approval
 
-- Start with `unit-shu-cavalry`.
-- Use spec: `unit-sprite-batch2-shu-cavalry-spec.md`.
+- Start with `unit-shu-strategist`.
+- Use spec: `unit-sprite-batch2-shu-strategist-spec.md`.
 - Generate source art, assemble sheets, produce contact/GIF/before-after/scale/battle screenshots, then rerun the gates.

docs/unit-sprite-rework-audit.json

@@ -11,8 +11,8 @@
     "batch7-unique-officer": 19
   },
   "stage_counts": {
-    "approved-baseline": 9,
-    "queued-rework": 82
+    "approved-baseline": 10,
+    "queued-rework": 81
   },
   "rows": [
     {
@@ -2126,7 +2126,7 @@
     },
     {
       "batch": "batch2-shu",
-      "review_stage": "queued-rework",
+      "review_stage": "approved-baseline",
       "stem": "unit-shu-cavalry",
       "base": {
         "key": "unit-shu-cavalry",
@@ -2136,23 +2136,23 @@
           1252
         ],
         "partial_alpha": 0,
-        "opaque_pixels": 2399821,
-        "border_hits": 64,
-        "min_width": 160,
-        "max_width": 291,
-        "min_height": 282,
-        "max_height": 289,
-        "min_bottom": 281,
-        "max_bottom": 288,
+        "opaque_pixels": 2058614,
+        "border_hits": 0,
+        "min_width": 166,
+        "max_width": 245,
+        "min_height": 288,
+        "max_height": 290,
+        "min_bottom": 303,
+        "max_bottom": 303,
         "empty_frames": 0,
-        "width_swing": 131,
-        "height_swing": 7,
-        "bottom_swing": 7,
-        "battle_min_width_px": 25.6,
-        "battle_max_width_px": 46.5,
-        "battle_min_height_px": 45.0,
-        "battle_max_height_px": 46.2,
-        "status": "border-hits=64"
+        "width_swing": 79,
+        "height_swing": 2,
+        "bottom_swing": 0,
+        "battle_min_width_px": 26.5,
+        "battle_max_width_px": 39.1,
+        "battle_min_height_px": 46.0,
+        "battle_max_height_px": 46.3,
+        "status": "ok"
       },
       "actions": {
         "key": "unit-shu-cavalry-actions",
@@ -2162,23 +2162,23 @@
           1252
         ],
         "partial_alpha": 0,
-        "opaque_pixels": 5378536,
-        "border_hits": 144,
-        "min_width": 160,
-        "max_width": 300,
-        "min_height": 274,
+        "opaque_pixels": 4816651,
+        "border_hits": 0,
+        "min_width": 166,
+        "max_width": 245,
+        "min_height": 265,
         "max_height": 290,
-        "min_bottom": 273,
-        "max_bottom": 289,
+        "min_bottom": 303,
+        "max_bottom": 303,
         "empty_frames": 0,
-        "width_swing": 140,
-        "height_swing": 16,
-        "bottom_swing": 16,
-        "battle_min_width_px": 25.6,
-        "battle_max_width_px": 47.9,
-        "battle_min_height_px": 43.8,
+        "width_swing": 79,
+        "height_swing": 25,
+        "bottom_swing": 0,
+        "battle_min_width_px": 26.5,
+        "battle_max_width_px": 39.1,
+        "battle_min_height_px": 42.3,
         "battle_max_height_px": 46.3,
-        "status": "border-hits=144"
+        "status": "ok"
       }
     },
     {

docs/unit-sprite-rework-audit.md

@@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards.
 
 ## Review Stage Counts
 
-- approved-baseline: 9
-- queued-rework: 82
+- approved-baseline: 10
+- queued-rework: 81
 
 ## Batch Plan
 
@@ -89,7 +89,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards.
 | batch2-shu | approved-baseline | `unit-shu-archer` | ok | ok | 158..260 x 284..295 | 152..260 x 276..295 | 25.2..41.5 x 45.4..47.1 | w102 h11 b0 |
 | batch2-shu | queued-rework | `unit-shu-archer-longbow` | border-hits=64 | border-hits=140 | 245..246 x 279..279 | 220..255 x 275..279 | 39.1..39.3 x 44.6..44.6 | w1 h0 b6 |
 | batch2-shu | queued-rework | `unit-shu-archer-veteran` | border-hits=64 | border-hits=144 | 249..250 x 282..288 | 223..259 x 275..290 | 39.8..39.9 x 45.0..46.0 | w1 h6 b6 |
-| batch2-shu | queued-rework | `unit-shu-cavalry` | border-hits=64 | border-hits=144 | 160..291 x 282..289 | 160..300 x 274..290 | 25.6..46.5 x 45.0..46.2 | w131 h7 b7 |
+| batch2-shu | approved-baseline | `unit-shu-cavalry` | ok | ok | 166..245 x 288..290 | 166..245 x 265..290 | 26.5..39.1 x 46.0..46.3 | w79 h2 b0 |
 | batch2-shu | queued-rework | `unit-shu-cavalry-scout` | border-hits=64 | border-hits=144 | 160..291 x 282..289 | 160..300 x 274..290 | 25.6..46.5 x 45.0..46.2 | w131 h7 b7 |
 | batch2-shu | queued-rework | `unit-shu-cavalry-white` | border-hits=64 | border-hits=144 | 160..291 x 282..289 | 160..300 x 274..290 | 25.6..46.5 x 45.0..46.2 | w131 h7 b7 |
 | batch2-shu | approved-baseline | `unit-shu-infantry` | ok | ok | 183..222 x 288..288 | 181..255 x 280..288 | 29.2..35.5 x 46.0..46.0 | w39 h0 b0 |

docs/unit-sprite-rework-manifest.json

@@ -6,7 +6,7 @@
     "holdCommitPushDeployUntilBatchApproved": true,
     "notes": [
       "Do not treat technical sheet validity as hand-painted art approval.",
-      "Move a unit from pendingApproval to approvedBaseline only after user approval.",
+      "During the current continuous production run, Codex may move a unit from pendingApproval to approvedBaseline after visual inspection, browser verification, and all quality gates pass.",
       "Keep untouched or lower-quality units queuedRework even when their PNG dimensions are technically valid."
     ]
   },
@@ -17,6 +17,7 @@
     "unit-rebel-archer",
     "unit-rebel-cavalry",
     "unit-shu-archer",
+    "unit-shu-cavalry",
     "unit-shu-infantry",
     "unit-shu-spearman",
     "unit-zhang-fei"
@@ -24,7 +25,6 @@
   "pendingApproval": [],
   "currentApprovalCandidate": {},
   "nextAfterApproval": [
-    "unit-shu-cavalry",
     "unit-shu-strategist",
     "unit-shu-officer"
   ],

docs/unit-sprite-shu-cavalry-v2-approval-packet.md

@@ -0,0 +1,73 @@
+# Shu Cavalry v2 Approval Packet
+
+This packet records the completed Codex-approved `unit-shu-cavalry` Batch 2 Shu generic unit.
+
+## Decision Target
+
+- Unit: `unit-shu-cavalry`
+- Batch: Batch 2 Shu generic units
+- Status: approved for continuous production run
+- Review stage: `pending-approval` before promotion, then `approved-baseline`
+- Review manifest: `unit-sprite-rework-manifest.json`
+- Art quality gate: `unit-sprite-art-quality-gate.md`
+- Next unit after approval: `unit-shu-strategist`
+- Commit/push/deploy: allowed after release gate verification
+
+## Visual Evidence
+
+- Approval board at review time: `unit-sprite-current-approval-board.png`
+- Source art: `handpaint-batch2-shu-cavalry-source-v1.png`
+- Contact sheet: `handpaint-batch2-shu-cavalry-v2-contact.png`
+- Animation GIF: `handpaint-batch2-shu-cavalry-v2-animation.gif`
+- v1/v2 comparison: `handpaint-batch2-shu-cavalry-v2-before-after.png`
+- 50px/72px scale comparison: `handpaint-batch2-shu-cavalry-v2-scale-compare.png`
+- Battle-scale map composite: `handpaint-batch2-shu-cavalry-v2-battle-composite.png`
+- Local browser debug sprite preview: `handpaint-batch2-shu-cavalry-v2-debug-preview-battle-check.png`
+- Approved/pending deliverables board: `unit-sprite-review-approved-and-pending.png`
+- Batch 2 inventory board: `unit-sprite-review-batch2-shu.png`
+- Review index: `unit-sprite-review-index.png`
+
+## Technical Evidence
+
+- Base sheet: `src/assets/images/units/unit-shu-cavalry.png`
+- Action sheet: `src/assets/images/units/unit-shu-cavalry-actions.png`
+- Base sheet size: `5008x1252`
+- Action sheet size: `11268x1252`
+- Base partial alpha: `0`
+- Action partial alpha: `0`
+- Base frame border hits: `0`
+- Action frame border hits: `0`
+- Base frame empty count: `0`
+- Action frame empty count: `0`
+- Base bbox range: `166..245 x 288..290`
+- Action bbox range: `166..245 x 265..290`
+- Base bottom range: `303..303`
+- Action bottom range: `303..303`
+- Audit status: `ok`
+
+## Completed Verification
+
+- `python scripts/assemble-handpaint-shu-infantry-quality-sample.py --source docs\handpaint-batch2-shu-cavalry-source-v1.png --stem unit-shu-cavalry --work-dir tmp\handpaint-shu-cavalry-v2 --output-prefix handpaint-batch2-shu-cavalry-v2 --fit-width-scale 0.96 --stretch-x 1.10`
+- Technical alpha/border/bbox inspection passed
+- `pnpm build`
+- Local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-shu-cavalry&v=shu-cavalry-v2-final`
+- Local browser debug sprite preview passed with `debugSpritePreview=unit-shu-cavalry`
+- Local browser console errors: `0`
+- Build and browser verification passed locally.
+
+## Quality Note
+
+This v2 candidate uses the new hand-painted cavalry source from v1, then adjusts assembly scale so the mounted unit has stronger battle-size presence without touching the frame borders. It is approved because:
+
+- It reads clearly as a horse-and-rider unit at the 50px battle size.
+- The green Shu saddle cloth, rider armor, horse chest, legs, and mounted weapon are visible without external rings, bases, glows, or badges.
+- The side, attack, command, hurt, and victory poses retain meaningful pose differences.
+- The unit remains inside the 313px frame with no border hits, no partial alpha, and stable bottom alignment.
+- It feels close enough to the approved Liu Bei/Guan Yu/Zhang Fei/Rebel/Shu infantry/Shu spearman/Shu archer quality bar while remaining a generic cavalry soldier.
+
+Reject or request revision if:
+
+- The mounted silhouette feels too thin at 50px during actual gameplay.
+- The horse or rider appears to drift sideways across idle/walk loops.
+- The weapon, horse head, tail, or legs appear cropped in any action frame.
+- The style starts to read as a named hero instead of a generic Shu cavalry unit.