diff --git a/docs/handpaint-batch2-shu-spearman-veteran-source-v2.png b/docs/handpaint-batch2-shu-spearman-veteran-source-v2.png new file mode 100644 index 0000000..180aaa7 Binary files /dev/null and b/docs/handpaint-batch2-shu-spearman-veteran-source-v2.png differ diff --git a/docs/handpaint-batch2-shu-spearman-veteran-v2-animation.gif b/docs/handpaint-batch2-shu-spearman-veteran-v2-animation.gif new file mode 100644 index 0000000..6e26c73 Binary files /dev/null and b/docs/handpaint-batch2-shu-spearman-veteran-v2-animation.gif differ diff --git a/docs/handpaint-batch2-shu-spearman-veteran-v2-battle-composite.png b/docs/handpaint-batch2-shu-spearman-veteran-v2-battle-composite.png new file mode 100644 index 0000000..6601c3b Binary files /dev/null and b/docs/handpaint-batch2-shu-spearman-veteran-v2-battle-composite.png differ diff --git a/docs/handpaint-batch2-shu-spearman-veteran-v2-before-after.png b/docs/handpaint-batch2-shu-spearman-veteran-v2-before-after.png new file mode 100644 index 0000000..27ef566 Binary files /dev/null and b/docs/handpaint-batch2-shu-spearman-veteran-v2-before-after.png differ diff --git a/docs/handpaint-batch2-shu-spearman-veteran-v2-contact.png b/docs/handpaint-batch2-shu-spearman-veteran-v2-contact.png new file mode 100644 index 0000000..9a3ddfb Binary files /dev/null and b/docs/handpaint-batch2-shu-spearman-veteran-v2-contact.png differ diff --git a/docs/handpaint-batch2-shu-spearman-veteran-v2-debug-preview-battle-check.png b/docs/handpaint-batch2-shu-spearman-veteran-v2-debug-preview-battle-check.png new file mode 100644 index 0000000..324438a Binary files /dev/null and b/docs/handpaint-batch2-shu-spearman-veteran-v2-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch2-shu-spearman-veteran-v2-report.md b/docs/handpaint-batch2-shu-spearman-veteran-v2-report.md new file mode 100644 index 0000000..11834a6 --- /dev/null +++ b/docs/handpaint-batch2-shu-spearman-veteran-v2-report.md @@ -0,0 +1,24 @@ +# Shu Spearman Veteran Hand-Painted v2 + +- source: `handpaint-batch2-shu-spearman-veteran-source-v2.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 1526086 +- action partial alpha: 0, opaque pixels: 3609218 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 163..206 +- base bbox height range: 290..295 +- base bottom range: 303..303 +- action bbox width range: 143..276 +- action bbox height range: 221..295 +- action bottom range: 303..303 +- contact: `handpaint-batch2-shu-spearman-veteran-v2-contact.png` +- animation: `handpaint-batch2-shu-spearman-veteran-v2-animation.gif` +- before/after: `handpaint-batch2-shu-spearman-veteran-v2-before-after.png` +- scale compare: `handpaint-batch2-shu-spearman-veteran-v2-scale-compare.png` +- battle composite: `handpaint-batch2-shu-spearman-veteran-v2-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch2-shu-spearman-veteran-v2-scale-compare.png b/docs/handpaint-batch2-shu-spearman-veteran-v2-scale-compare.png new file mode 100644 index 0000000..1312a3d Binary files /dev/null and b/docs/handpaint-batch2-shu-spearman-veteran-v2-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index 5f78b19..7e0d6bd 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 47 +- Approved baseline units: 48 - Pending approval units: 0 -- Queued rework units: 44 +- Queued rework units: 43 ## Checked Rules diff --git a/docs/unit-sprite-batch-queue.json b/docs/unit-sprite-batch-queue.json index 6916dc0..e9390a8 100644 --- a/docs/unit-sprite-batch-queue.json +++ b/docs/unit-sprite-batch-queue.json @@ -38,6 +38,7 @@ "unit-shu-officer-vanguard", "unit-shu-spearman", "unit-shu-spearman-guard", + "unit-shu-spearman-veteran", "unit-shu-strategist", "unit-wei-archer", "unit-wei-cavalry", @@ -54,8 +55,8 @@ "pendingApproval": [], "nextAfterApproval": [], "stageCounts": { - "approved-baseline": 47, - "queued-rework": 44 + "approved-baseline": 48, + "queued-rework": 43 }, "batches": [ { @@ -167,24 +168,10 @@ "label": "Batch 2 Shu generic units", "total": 18, "stageCounts": { - "approved-baseline": 15, - "queued-rework": 3 + "approved-baseline": 16, + "queued-rework": 2 }, "units": [ - { - "stem": "unit-shu-spearman-veteran", - "reviewStage": "queued-rework", - "queueRole": "queued rework", - "baseStatus": "border-hits=64", - "actionStatus": "border-hits=144", - "battleBasePx": [ - 32.3, - 41.2, - 45.0, - 46.0 - ], - "spec": null - }, { "stem": "unit-shu-strategist-field", "reviewStage": "queued-rework", @@ -409,6 +396,20 @@ ], "spec": null }, + { + "stem": "unit-shu-spearman-veteran", + "reviewStage": "approved-baseline", + "queueRole": "approved reference", + "baseStatus": "ok", + "actionStatus": "ok", + "battleBasePx": [ + 26.0, + 32.9, + 46.3, + 47.1 + ], + "spec": null + }, { "stem": "unit-shu-strategist", "reviewStage": "approved-baseline", diff --git a/docs/unit-sprite-batch-queue.md b/docs/unit-sprite-batch-queue.md index 038ac1b..aa6d65f 100644 --- a/docs/unit-sprite-batch-queue.md +++ b/docs/unit-sprite-batch-queue.md @@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i ## Current State -- Approved baseline units: 47 +- Approved baseline units: 48 - Pending approval units: 0 -- Queued rework units: 44 +- Queued rework units: 43 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` @@ -46,11 +46,10 @@ No next unit is currently defined. - Batch key: `batch2-shu` - Total units: 18 -- Stage counts: approved-baseline 15, queued-rework 3 +- Stage counts: approved-baseline 16, queued-rework 2 | unit | role | stage | status | battle base px | spec | | --- | --- | --- | --- | --- | --- | -| `unit-shu-spearman-veteran` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 32.3..41.2 x 45.0..46.0 | | | `unit-shu-strategist-field` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | | `unit-shu-strategist-white` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | | `unit-shu-archer` | approved reference | approved-baseline | technical ok | 25.2..41.5 x 45.4..47.1 | `unit-sprite-batch2-shu-archer-spec.md` | @@ -67,6 +66,7 @@ No next unit is currently defined. | `unit-shu-officer-vanguard` | approved reference | approved-baseline | technical ok | 27.0..36.1 x 44.2..47.1 | | | `unit-shu-spearman` | approved reference | approved-baseline | technical ok | 23.3..42.0 x 43.8..46.3 | `unit-sprite-batch2-shu-spearman-spec.md` | | `unit-shu-spearman-guard` | approved reference | approved-baseline | technical ok | 29.4..32.7 x 44.2..47.1 | | +| `unit-shu-spearman-veteran` | approved reference | approved-baseline | technical ok | 26.0..32.9 x 46.3..47.1 | | | `unit-shu-strategist` | approved reference | approved-baseline | technical ok | 24.9..34.2 x 45.0..46.8 | `unit-sprite-batch2-shu-strategist-spec.md` | ### Batch 3 Wei generic units diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index 9d4a224..8ad9d02 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index 41cb4dd..3bbb4c8 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 47 +- Approved baseline units: 48 - Pending approval units: 0 -- Queued rework units: 44 +- Queued rework units: 43 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index c795734..d144b18 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch2-shu.png b/docs/unit-sprite-review-batch2-shu.png index 2662af4..f72cbd9 100644 Binary files a/docs/unit-sprite-review-batch2-shu.png and b/docs/unit-sprite-review-batch2-shu.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index 580edcd..0cc1e5a 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index 555a318..64a8e9a 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 47, - "queued-rework": 44 + "approved-baseline": 48, + "queued-rework": 43 }, "rows": [ { @@ -2753,7 +2753,7 @@ }, { "batch": "batch2-shu", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-shu-spearman-veteran", "base": { "key": "unit-shu-spearman-veteran", @@ -2763,23 +2763,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 2147373, - "border_hits": 64, - "min_width": 202, - "max_width": 258, - "min_height": 282, - "max_height": 288, - "min_bottom": 281, - "max_bottom": 287, + "opaque_pixels": 1526086, + "border_hits": 0, + "min_width": 163, + "max_width": 206, + "min_height": 290, + "max_height": 295, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 56, - "height_swing": 6, - "bottom_swing": 6, - "battle_min_width_px": 32.3, - "battle_max_width_px": 41.2, - "battle_min_height_px": 45.0, - "battle_max_height_px": 46.0, - "status": "border-hits=64" + "width_swing": 43, + "height_swing": 5, + "bottom_swing": 0, + "battle_min_width_px": 26.0, + "battle_max_width_px": 32.9, + "battle_min_height_px": 46.3, + "battle_max_height_px": 47.1, + "status": "ok" }, "actions": { "key": "unit-shu-spearman-veteran-actions", @@ -2789,23 +2789,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4793457, - "border_hits": 144, - "min_width": 202, - "max_width": 267, - "min_height": 275, - "max_height": 290, - "min_bottom": 274, - "max_bottom": 289, + "opaque_pixels": 3609218, + "border_hits": 0, + "min_width": 143, + "max_width": 276, + "min_height": 221, + "max_height": 295, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 65, - "height_swing": 15, - "bottom_swing": 15, - "battle_min_width_px": 32.3, - "battle_max_width_px": 42.7, - "battle_min_height_px": 43.9, - "battle_max_height_px": 46.3, - "status": "border-hits=144" + "width_swing": 133, + "height_swing": 74, + "bottom_swing": 0, + "battle_min_width_px": 22.8, + "battle_max_width_px": 44.1, + "battle_min_height_px": 35.3, + "battle_max_height_px": 47.1, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index 1c9837c..90d16fb 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 47 -- queued-rework: 44 +- approved-baseline: 48 +- queued-rework: 43 ## Batch Plan @@ -100,7 +100,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch2-shu | approved-baseline | `unit-shu-officer-vanguard` | ok | ok | 169..226 x 277..295 | 169..277 x 264..295 | 27.0..36.1 x 44.2..47.1 | w57 h18 b0 | | batch2-shu | approved-baseline | `unit-shu-spearman` | ok | ok | 146..263 x 274..290 | 146..276 x 280..295 | 23.3..42.0 x 43.8..46.3 | w117 h16 b0 | | batch2-shu | approved-baseline | `unit-shu-spearman-guard` | ok | ok | 184..205 x 277..295 | 176..276 x 232..295 | 29.4..32.7 x 44.2..47.1 | w21 h18 b0 | -| batch2-shu | queued-rework | `unit-shu-spearman-veteran` | border-hits=64 | border-hits=144 | 202..258 x 282..288 | 202..267 x 275..290 | 32.3..41.2 x 45.0..46.0 | w56 h6 b6 | +| batch2-shu | approved-baseline | `unit-shu-spearman-veteran` | ok | ok | 163..206 x 290..295 | 143..276 x 221..295 | 26.0..32.9 x 46.3..47.1 | w43 h5 b0 | | batch2-shu | approved-baseline | `unit-shu-strategist` | ok | ok | 156..214 x 282..293 | 155..243 x 282..293 | 24.9..34.2 x 45.0..46.8 | w58 h11 b0 | | batch2-shu | queued-rework | `unit-shu-strategist-field` | border-hits=32 | border-hits=98 | 243..246 x 280..281 | 220..255 x 275..281 | 38.8..39.3 x 44.7..44.9 | w3 h1 b6 | | batch2-shu | queued-rework | `unit-shu-strategist-white` | border-hits=32 | border-hits=98 | 243..246 x 280..281 | 220..255 x 275..281 | 38.8..39.3 x 44.7..44.9 | w3 h1 b6 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index 8124c7b..c11b0a1 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -46,6 +46,7 @@ "unit-shu-officer-vanguard", "unit-shu-spearman", "unit-shu-spearman-guard", + "unit-shu-spearman-veteran", "unit-shu-strategist", "unit-wei-archer", "unit-wei-cavalry", diff --git a/docs/unit-sprite-shu-spearman-veteran-v2-approval-packet.md b/docs/unit-sprite-shu-spearman-veteran-v2-approval-packet.md new file mode 100644 index 0000000..590ccba --- /dev/null +++ b/docs/unit-sprite-shu-spearman-veteran-v2-approval-packet.md @@ -0,0 +1,36 @@ +# Unit Sprite Approval Packet: unit-shu-spearman-veteran v2 + +- Status: approved during continuous production run +- Source art: `docs/handpaint-batch2-shu-spearman-veteran-source-v2.png` +- Contact sheet: `docs/handpaint-batch2-shu-spearman-veteran-v2-contact.png` +- Animation GIF: `docs/handpaint-batch2-shu-spearman-veteran-v2-animation.gif` +- Before/after: `docs/handpaint-batch2-shu-spearman-veteran-v2-before-after.png` +- Scale compare: `docs/handpaint-batch2-shu-spearman-veteran-v2-scale-compare.png` +- Browser check: `docs/handpaint-batch2-shu-spearman-veteran-v2-debug-preview-battle-check.png` +- Current approval board: `docs/unit-sprite-current-approval-board.png` +- Debug preview URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-shu-spearman-veteran&v=shu-spearman-veteran-v2-console-clean` + +## Visual Decision + +Shu spearman veteran v2 is accepted as an offensive veteran spear unit. The red spear tassel, no-shield stance, and darker armor distinguish it from the defensive spear guard while preserving the approved Shu palette. + +## Technical Checks + +- Base partial alpha: `0` +- Action partial alpha: `0` +- Base frame border hits: `0` +- Action frame border hits: `0` +- Base empty frames: `0` +- Action empty frames: `0` +- Base bbox width range: `163..206` +- Base bbox height range: `290..295` +- Base bottom range: `303..303` +- Action bbox width range: `143..276` +- Action bbox height range: `221..295` +- Action bottom range: `303..303` +- Local build: `passed` +- Local browser console errors: `0` + +## Notes + +v2 widens the silhouette just enough to satisfy the battle-scale width gate. The unit remains clearly spear-focused without a shield, stays contained in all action frames, and all body pixels are fully opaque. diff --git a/src/assets/images/units/unit-shu-spearman-veteran-actions.png b/src/assets/images/units/unit-shu-spearman-veteran-actions.png index b2f49ba..9c45a24 100644 Binary files a/src/assets/images/units/unit-shu-spearman-veteran-actions.png and b/src/assets/images/units/unit-shu-spearman-veteran-actions.png differ diff --git a/src/assets/images/units/unit-shu-spearman-veteran.png b/src/assets/images/units/unit-shu-spearman-veteran.png index 11fb08a..8155087 100644 Binary files a/src/assets/images/units/unit-shu-spearman-veteran.png and b/src/assets/images/units/unit-shu-spearman-veteran.png differ