Wickedness/heros_web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clamp battle save unit core stats

Browse Source
This commit is contained in:
Wickedness
2026-07-05 13:48:19 +09:00
parent deaec059ee
commit fe5a3edfd2
2 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
scripts/verify-battle-save-normalization.mjs
View File

@@ -59,6 +59,11 @@ try {
['invalid unit exp threshold', { units: patchUnit(0, { exp: 100 }) }], ['invalid unit exp threshold', { units: patchUnit(0, { exp: 100 }) }],
['invalid max-level unit exp threshold', { units: patchUnit(0, { level: 99, exp: 101 }) }], ['invalid max-level unit exp threshold', { units: patchUnit(0, { level: 99, exp: 101 }) }],
['invalid unit hp', { units: patchUnit(0, { hp: 99, maxHp: 30 }) }], ['invalid unit hp', { units: patchUnit(0, { hp: 99, maxHp: 30 }) }],
['invalid unit hp precision', { units: patchUnit(0, { hp: 12.5 }) }],
['too high unit max hp', { units: patchUnit(0, { hp: 30, maxHp: 10000 }) }],
['invalid unit attack', { units: patchUnit(0, { attack: -1 }) }],
['invalid unit move precision', { units: patchUnit(0, { move: 3.5 }) }],
['too high unit move', { units: patchUnit(0, { move: 100 }) }],
['duplicate live unit tile', { units: patchUnit(1, { x: validState.units[0].x, y: validState.units[0].y }) }], ['duplicate live unit tile', { units: patchUnit(1, { x: validState.units[0].x, y: validState.units[0].y }) }],
['invalid unit x', { units: patchUnit(0, { x: 12 }) }], ['invalid unit x', { units: patchUnit(0, { x: 12 }) }],
['invalid unit direction', { units: patchUnit(0, { direction: 'down' }) }], ['invalid unit direction', { units: patchUnit(0, { direction: 'down' }) }],

11
src/game/state/battleSaveState.ts
View File

@@ -92,6 +92,9 @@ const maxBattleEffectTurns = 9;
const maxBattleBuffBonus = 99; const maxBattleBuffBonus = 99;
const maxBattleStatusPower = 99; const maxBattleStatusPower = 99;
const maxBattleUnitStatValue = 999999; const maxBattleUnitStatValue = 999999;
const maxBattleUnitHp = 9999;
const maxBattleUnitAttack = 9999;
const maxBattleUnitMove = 99;
const maxStatusKindsPerUnit = 2; const maxStatusKindsPerUnit = 2;
const maxBattleItemStockById: Record<string, number> = { const maxBattleItemStockById: Record<string, number> = {
bean: 3, bean: 3,
@@ -273,11 +276,11 @@ function isSavedBattleUnitState(value: unknown, options: BattleSaveValidationOpt
if ( if (
!isValidCharacterProgress(value.level, value.exp) || !isValidCharacterProgress(value.level, value.exp) ||
!isNonNegativeFiniteNumber(value.hp) || !isIntegerInRange(value.hp, 0, maxBattleUnitHp) ||
!isPositiveInteger(value.maxHp) || !isIntegerInRange(value.maxHp, 1, maxBattleUnitHp) ||
Number(value.hp) > Number(value.maxHp) || Number(value.hp) > Number(value.maxHp) ||
!isFiniteNumber(value.attack) || !isIntegerInRange(value.attack, 0, maxBattleUnitAttack) ||
!isNonNegativeFiniteNumber(value.move) || !isIntegerInRange(value.move, 0, maxBattleUnitMove) ||
!Number.isInteger(value.x) || !Number.isInteger(value.x) ||
!Number.isInteger(value.y) !Number.isInteger(value.y)
) { ) {