diff --git a/docs/handpaint-batch3-wei-officer-iron-source-v1.png b/docs/handpaint-batch3-wei-officer-iron-source-v1.png new file mode 100644 index 0000000..b12f324 Binary files /dev/null and b/docs/handpaint-batch3-wei-officer-iron-source-v1.png differ diff --git a/docs/handpaint-batch3-wei-officer-iron-v2-animation.gif b/docs/handpaint-batch3-wei-officer-iron-v2-animation.gif new file mode 100644 index 0000000..a0acda7 Binary files /dev/null and b/docs/handpaint-batch3-wei-officer-iron-v2-animation.gif differ diff --git a/docs/handpaint-batch3-wei-officer-iron-v2-battle-composite.png b/docs/handpaint-batch3-wei-officer-iron-v2-battle-composite.png new file mode 100644 index 0000000..cdaa798 Binary files /dev/null and b/docs/handpaint-batch3-wei-officer-iron-v2-battle-composite.png differ diff --git a/docs/handpaint-batch3-wei-officer-iron-v2-before-after.png b/docs/handpaint-batch3-wei-officer-iron-v2-before-after.png new file mode 100644 index 0000000..61df916 Binary files /dev/null and b/docs/handpaint-batch3-wei-officer-iron-v2-before-after.png differ diff --git a/docs/handpaint-batch3-wei-officer-iron-v2-contact.png b/docs/handpaint-batch3-wei-officer-iron-v2-contact.png new file mode 100644 index 0000000..911c145 Binary files /dev/null and b/docs/handpaint-batch3-wei-officer-iron-v2-contact.png differ diff --git a/docs/handpaint-batch3-wei-officer-iron-v2-debug-preview-battle-check.png b/docs/handpaint-batch3-wei-officer-iron-v2-debug-preview-battle-check.png new file mode 100644 index 0000000..daf4414 Binary files /dev/null and b/docs/handpaint-batch3-wei-officer-iron-v2-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch3-wei-officer-iron-v2-report.md b/docs/handpaint-batch3-wei-officer-iron-v2-report.md new file mode 100644 index 0000000..825cf14 --- /dev/null +++ b/docs/handpaint-batch3-wei-officer-iron-v2-report.md @@ -0,0 +1,24 @@ +# Wei Iron Officer v2 sprite report + +- source: `handpaint-batch3-wei-officer-iron-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 2488266 +- action partial alpha: 0, opaque pixels: 4988712 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 214..229 +- base bbox height range: 277..288 +- base bottom range: 303..303 +- action bbox width range: 201..258 +- action bbox height range: 230..288 +- action bottom range: 303..303 +- contact: `handpaint-batch3-wei-officer-iron-v2-contact.png` +- animation: `handpaint-batch3-wei-officer-iron-v2-animation.gif` +- before/after: `handpaint-batch3-wei-officer-iron-v2-before-after.png` +- scale compare: `handpaint-batch3-wei-officer-iron-v2-scale-compare.png` +- battle composite: `handpaint-batch3-wei-officer-iron-v2-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch3-wei-officer-iron-v2-scale-compare.png b/docs/handpaint-batch3-wei-officer-iron-v2-scale-compare.png new file mode 100644 index 0000000..46a4675 Binary files /dev/null and b/docs/handpaint-batch3-wei-officer-iron-v2-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index 6327736..0593d86 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 57 +- Approved baseline units: 58 - Pending approval units: 0 -- Queued rework units: 34 +- Queued rework units: 33 ## Checked Rules diff --git a/docs/unit-sprite-batch-queue.json b/docs/unit-sprite-batch-queue.json index e963817..1725208 100644 --- a/docs/unit-sprite-batch-queue.json +++ b/docs/unit-sprite-batch-queue.json @@ -53,6 +53,7 @@ "unit-wei-infantry-veteran", "unit-wei-officer", "unit-wei-officer-gate", + "unit-wei-officer-iron", "unit-wei-strategist", "unit-wu-archer", "unit-wu-cavalry", @@ -64,8 +65,8 @@ "pendingApproval": [], "nextAfterApproval": [], "stageCounts": { - "approved-baseline": 57, - "queued-rework": 34 + "approved-baseline": 58, + "queued-rework": 33 }, "batches": [ { @@ -439,24 +440,10 @@ "label": "Batch 3 Wei generic units", "total": 16, "stageCounts": { - "approved-baseline": 12, - "queued-rework": 4 + "approved-baseline": 13, + "queued-rework": 3 }, "units": [ - { - "stem": "unit-wei-officer-iron", - "reviewStage": "queued-rework", - "queueRole": "queued rework", - "baseStatus": "border-hits=64", - "actionStatus": "border-hits=144", - "battleBasePx": [ - 33.2, - 41.2, - 45.0, - 46.0 - ], - "spec": null - }, { "stem": "unit-wei-strategist-black", "reviewStage": "queued-rework", @@ -653,6 +640,20 @@ ], "spec": null }, + { + "stem": "unit-wei-officer-iron", + "reviewStage": "approved-baseline", + "queueRole": "approved reference", + "baseStatus": "ok", + "actionStatus": "ok", + "battleBasePx": [ + 34.2, + 36.6, + 44.2, + 46.0 + ], + "spec": null + }, { "stem": "unit-wei-strategist", "reviewStage": "approved-baseline", diff --git a/docs/unit-sprite-batch-queue.md b/docs/unit-sprite-batch-queue.md index b132ab8..96bdc0d 100644 --- a/docs/unit-sprite-batch-queue.md +++ b/docs/unit-sprite-batch-queue.md @@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i ## Current State -- Approved baseline units: 57 +- Approved baseline units: 58 - Pending approval units: 0 -- Queued rework units: 34 +- Queued rework units: 33 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` @@ -73,11 +73,10 @@ No next unit is currently defined. - Batch key: `batch3-wei` - Total units: 16 -- Stage counts: approved-baseline 12, queued-rework 4 +- Stage counts: approved-baseline 13, queued-rework 3 | unit | role | stage | status | battle base px | spec | | --- | --- | --- | --- | --- | --- | -| `unit-wei-officer-iron` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 33.2..41.2 x 45.0..46.0 | | | `unit-wei-strategist-black` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | | `unit-wei-strategist-blue` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | | `unit-wei-yan` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 31.0..40.6 x 44.6..44.6 | | @@ -92,6 +91,7 @@ No next unit is currently defined. | `unit-wei-infantry-veteran` | approved reference | approved-baseline | technical ok | 30.7..39.9 x 44.2..46.0 | | | `unit-wei-officer` | approved reference | approved-baseline | technical ok | 25.4..33.1 x 46.0..47.1 | | | `unit-wei-officer-gate` | approved reference | approved-baseline | technical ok | 28.1..33.4 x 46.0..46.0 | | +| `unit-wei-officer-iron` | approved reference | approved-baseline | technical ok | 34.2..36.6 x 44.2..46.0 | | | `unit-wei-strategist` | approved reference | approved-baseline | technical ok | 25.6..37.2 x 46.3..46.3 | | ### Batch 4 Wu generic units diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index 484aef6..892b9f9 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index 7500260..e0dfc59 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 57 +- Approved baseline units: 58 - Pending approval units: 0 -- Queued rework units: 34 +- Queued rework units: 33 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index ed9f8a9..735f5f4 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch3-wei.png b/docs/unit-sprite-review-batch3-wei.png index 06f146e..d96dd05 100644 Binary files a/docs/unit-sprite-review-batch3-wei.png and b/docs/unit-sprite-review-batch3-wei.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index eef5314..a012dd1 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index 6e3c844..5d7d4c8 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 57, - "queued-rework": 34 + "approved-baseline": 58, + "queued-rework": 33 }, "rows": [ { @@ -3722,7 +3722,7 @@ }, { "batch": "batch3-wei", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-wei-officer-iron", "base": { "key": "unit-wei-officer-iron", @@ -3732,23 +3732,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 2138098, - "border_hits": 64, - "min_width": 208, - "max_width": 258, - "min_height": 282, + "opaque_pixels": 2488266, + "border_hits": 0, + "min_width": 214, + "max_width": 229, + "min_height": 277, "max_height": 288, - "min_bottom": 281, - "max_bottom": 287, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 50, - "height_swing": 6, - "bottom_swing": 6, - "battle_min_width_px": 33.2, - "battle_max_width_px": 41.2, - "battle_min_height_px": 45.0, + "width_swing": 15, + "height_swing": 11, + "bottom_swing": 0, + "battle_min_width_px": 34.2, + "battle_max_width_px": 36.6, + "battle_min_height_px": 44.2, "battle_max_height_px": 46.0, - "status": "border-hits=64" + "status": "ok" }, "actions": { "key": "unit-wei-officer-iron-actions", @@ -3758,23 +3758,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4783362, - "border_hits": 144, - "min_width": 208, - "max_width": 267, - "min_height": 275, - "max_height": 290, - "min_bottom": 274, - "max_bottom": 289, + "opaque_pixels": 4988712, + "border_hits": 0, + "min_width": 201, + "max_width": 258, + "min_height": 230, + "max_height": 288, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 59, - "height_swing": 15, - "bottom_swing": 15, - "battle_min_width_px": 33.2, - "battle_max_width_px": 42.7, - "battle_min_height_px": 43.9, - "battle_max_height_px": 46.3, - "status": "border-hits=144" + "width_swing": 57, + "height_swing": 58, + "bottom_swing": 0, + "battle_min_width_px": 32.1, + "battle_max_width_px": 41.2, + "battle_min_height_px": 36.7, + "battle_max_height_px": 46.0, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index b4ce64a..0290ad2 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 57 -- queued-rework: 34 +- approved-baseline: 58 +- queued-rework: 33 ## Batch Plan @@ -117,7 +117,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch3-wei | approved-baseline | `unit-wei-infantry-veteran` | ok | ok | 192..250 x 277..288 | 208..274 x 226..288 | 30.7..39.9 x 44.2..46.0 | w58 h11 b0 | | batch3-wei | approved-baseline | `unit-wei-officer` | ok | ok | 159..207 x 288..295 | 158..255 x 288..295 | 25.4..33.1 x 46.0..47.1 | w48 h7 b0 | | batch3-wei | approved-baseline | `unit-wei-officer-gate` | ok | ok | 176..209 x 288..288 | 176..257 x 262..288 | 28.1..33.4 x 46.0..46.0 | w33 h0 b0 | -| batch3-wei | queued-rework | `unit-wei-officer-iron` | border-hits=64 | border-hits=144 | 208..258 x 282..288 | 208..267 x 275..290 | 33.2..41.2 x 45.0..46.0 | w50 h6 b6 | +| batch3-wei | approved-baseline | `unit-wei-officer-iron` | ok | ok | 214..229 x 277..288 | 201..258 x 230..288 | 34.2..36.6 x 44.2..46.0 | w15 h11 b0 | | batch3-wei | approved-baseline | `unit-wei-strategist` | ok | ok | 160..233 x 290..290 | 160..243 x 288..290 | 25.6..37.2 x 46.3..46.3 | w73 h0 b0 | | batch3-wei | queued-rework | `unit-wei-strategist-black` | border-hits=32 | border-hits=98 | 243..246 x 280..281 | 220..255 x 275..281 | 38.8..39.3 x 44.7..44.9 | w3 h1 b6 | | batch3-wei | queued-rework | `unit-wei-strategist-blue` | border-hits=32 | border-hits=98 | 243..246 x 280..281 | 220..255 x 275..281 | 38.8..39.3 x 44.7..44.9 | w3 h1 b6 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index 8352097..359a0e8 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -61,6 +61,7 @@ "unit-wei-infantry-veteran", "unit-wei-officer", "unit-wei-officer-gate", + "unit-wei-officer-iron", "unit-wei-strategist", "unit-wu-archer", "unit-wu-cavalry", diff --git a/docs/unit-sprite-wei-officer-iron-v2-approval-packet.md b/docs/unit-sprite-wei-officer-iron-v2-approval-packet.md new file mode 100644 index 0000000..9525f88 --- /dev/null +++ b/docs/unit-sprite-wei-officer-iron-v2-approval-packet.md @@ -0,0 +1,36 @@ +# Wei Iron Officer v2 Approval Packet + +- status: approved during continuous production run +- unit: `unit-wei-officer-iron` +- source art: `handpaint-batch3-wei-officer-iron-source-v1.png` +- contact sheet: `handpaint-batch3-wei-officer-iron-v2-contact.png` +- animation GIF: `handpaint-batch3-wei-officer-iron-v2-animation.gif` +- before/after: `handpaint-batch3-wei-officer-iron-v2-before-after.png` +- scale compare: `handpaint-batch3-wei-officer-iron-v2-scale-compare.png` +- battle composite: `handpaint-batch3-wei-officer-iron-v2-battle-composite.png` +- browser check: `handpaint-batch3-wei-officer-iron-v2-debug-preview-battle-check.png` +- current board: `unit-sprite-current-approval-board.png` +- debug URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-wei-officer-iron&v=wei-officer-iron-v2` + +## Visual Decision + +Approved for the continuous batch run. v2 corrects the v1 scale gate issues by standing the unit taller and widening the action read. The sheet now reads as a heavy Wei iron officer with dense dark armor, broad shoulders, and a close heavy blade while staying contained in the 50px battle tile. + +## Technical Checks + +- base status: ok +- action status: ok +- base partial alpha: 0 +- action partial alpha: 0 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- battle scale from sample gate: 34.2..36.6 x 44.2..46.0 +- local build: passed +- Local browser console errors: `0` +- Local browser 404s: `0` + +## Notes + +v1 was rejected by the release art quality gate for low minimum height and insufficient action width. v2 is the accepted version. diff --git a/src/assets/images/units/unit-wei-officer-iron-actions.png b/src/assets/images/units/unit-wei-officer-iron-actions.png index c52c0e6..8ea7dc7 100644 Binary files a/src/assets/images/units/unit-wei-officer-iron-actions.png and b/src/assets/images/units/unit-wei-officer-iron-actions.png differ diff --git a/src/assets/images/units/unit-wei-officer-iron.png b/src/assets/images/units/unit-wei-officer-iron.png index 302ba38..42b8a7e 100644 Binary files a/src/assets/images/units/unit-wei-officer-iron.png and b/src/assets/images/units/unit-wei-officer-iron.png differ