Wickedness/heros_web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Guard battle bond save arrays

Browse Source
This commit is contained in:
Wickedness
2026-07-05 13:24:49 +09:00
parent 9985998a5b
commit e9dbe404ff
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
scripts/verify-battle-save-normalization.mjs
View File

@@ -71,6 +71,9 @@ try {
['unknown unit id', { units: patchUnit(0, { id: 'ghost-unit' }) }], ['unknown unit id', { units: patchUnit(0, { id: 'ghost-unit' }) }],
['duplicate unit id', { units: [validState.units[0], { ...validState.units[0], x: 2 }, validState.units[2]] }], ['duplicate unit id', { units: [validState.units[0], { ...validState.units[0], x: 2 }, validState.units[2]] }],
['invalid bonds', { bonds: [{ ...validState.bonds[0], unitIds: ['liu-bei'] }] }], ['invalid bonds', { bonds: [{ ...validState.bonds[0], unitIds: ['liu-bei'] }] }],
['empty bond id', { bonds: [{ ...validState.bonds[0], id: '' }] }],
['duplicate bond id', { bonds: [validState.bonds[0], { ...validState.bonds[0], unitIds: ['guan-yu', 'liu-bei'] }] }],
['too many bonds', { bonds: Array.from({ length: 129 }, (_, index) => ({ ...validState.bonds[0], id: `bond-${index}` })) }],
['unknown bond unit id', { bonds: [{ ...validState.bonds[0], unitIds: ['liu-bei', 'ghost-unit'] }] }], ['unknown bond unit id', { bonds: [{ ...validState.bonds[0], unitIds: ['liu-bei', 'ghost-unit'] }] }],
['invalid bond level', { bonds: [{ ...validState.bonds[0], level: 0 }] }], ['invalid bond level', { bonds: [{ ...validState.bonds[0], level: 0 }] }],
['too high bond level', { bonds: [{ ...validState.bonds[0], level: 101 }] }], ['too high bond level', { bonds: [{ ...validState.bonds[0], level: 101 }] }],

4
src/game/state/battleSaveState.ts
View File

@@ -83,6 +83,7 @@ type BattleSaveValidationOptions = {
const unitDirections = new Set<UnitDirection>(['south', 'east', 'north', 'west']); const unitDirections = new Set<UnitDirection>(['south', 'east', 'north', 'west']);
const maxBattleLogEntries = 10; const maxBattleLogEntries = 10;
const maxBattleLogEntryLength = 96; const maxBattleLogEntryLength = 96;
const maxBattleBondEntries = 128;
const maxTriggeredBattleEventLength = 96; const maxTriggeredBattleEventLength = 96;
const defaultBattleSaveArrayLimit = 128; const defaultBattleSaveArrayLimit = 128;
const maxStatusKindsPerUnit = 2; const maxStatusKindsPerUnit = 2;
@@ -310,10 +311,13 @@ function isValidEquipmentProgress(level: unknown, exp: unknown) {
function isBondArray(value: unknown, options: BattleSaveValidationOptions) { function isBondArray(value: unknown, options: BattleSaveValidationOptions) {
return ( return (
Array.isArray(value) && Array.isArray(value) &&
value.length <= maxBattleBondEntries &&
hasUniqueRecordStrings(value, 'id') &&
value.every( value.every(
(bond) => (bond) =>
isRecord(bond) && isRecord(bond) &&
typeof bond.id === 'string' && typeof bond.id === 'string' &&
bond.id.length > 0 &&
Array.isArray(bond.unitIds) && Array.isArray(bond.unitIds) &&
bond.unitIds.length === 2 && bond.unitIds.length === 2 &&
bond.unitIds.every((unitId) => typeof unitId === 'string' && isKnownUnitId(unitId, options)) && bond.unitIds.every((unitId) => typeof unitId === 'string' && isKnownUnitId(unitId, options)) &&