diff --git a/docs/handpaint-batch6-nanman-infantry-spear-source-v1.png b/docs/handpaint-batch6-nanman-infantry-spear-source-v1.png new file mode 100644 index 0000000..51c7efc Binary files /dev/null and b/docs/handpaint-batch6-nanman-infantry-spear-source-v1.png differ diff --git a/docs/handpaint-batch6-nanman-infantry-spear-v1-animation.gif b/docs/handpaint-batch6-nanman-infantry-spear-v1-animation.gif new file mode 100644 index 0000000..4885205 Binary files /dev/null and b/docs/handpaint-batch6-nanman-infantry-spear-v1-animation.gif differ diff --git a/docs/handpaint-batch6-nanman-infantry-spear-v1-battle-composite.png b/docs/handpaint-batch6-nanman-infantry-spear-v1-battle-composite.png new file mode 100644 index 0000000..da7cf2f Binary files /dev/null and b/docs/handpaint-batch6-nanman-infantry-spear-v1-battle-composite.png differ diff --git a/docs/handpaint-batch6-nanman-infantry-spear-v1-before-after.png b/docs/handpaint-batch6-nanman-infantry-spear-v1-before-after.png new file mode 100644 index 0000000..4cb48e6 Binary files /dev/null and b/docs/handpaint-batch6-nanman-infantry-spear-v1-before-after.png differ diff --git a/docs/handpaint-batch6-nanman-infantry-spear-v1-contact.png b/docs/handpaint-batch6-nanman-infantry-spear-v1-contact.png new file mode 100644 index 0000000..2fcf067 Binary files /dev/null and b/docs/handpaint-batch6-nanman-infantry-spear-v1-contact.png differ diff --git a/docs/handpaint-batch6-nanman-infantry-spear-v1-debug-preview-battle-check.png b/docs/handpaint-batch6-nanman-infantry-spear-v1-debug-preview-battle-check.png new file mode 100644 index 0000000..153d385 Binary files /dev/null and b/docs/handpaint-batch6-nanman-infantry-spear-v1-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch6-nanman-infantry-spear-v1-report.md b/docs/handpaint-batch6-nanman-infantry-spear-v1-report.md new file mode 100644 index 0000000..5aa341e --- /dev/null +++ b/docs/handpaint-batch6-nanman-infantry-spear-v1-report.md @@ -0,0 +1,24 @@ +# Nanman Spear Infantry Hand-Painted v1 + +- source: `handpaint-batch6-nanman-infantry-spear-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 1833424 +- action partial alpha: 0, opaque pixels: 4549291 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 138..219 +- base bbox height range: 286..288 +- base bottom range: 303..303 +- action bbox width range: 137..263 +- action bbox height range: 277..289 +- action bottom range: 303..303 +- contact: `handpaint-batch6-nanman-infantry-spear-v1-contact.png` +- animation: `handpaint-batch6-nanman-infantry-spear-v1-animation.gif` +- before/after: `handpaint-batch6-nanman-infantry-spear-v1-before-after.png` +- scale compare: `handpaint-batch6-nanman-infantry-spear-v1-scale-compare.png` +- battle composite: `handpaint-batch6-nanman-infantry-spear-v1-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch6-nanman-infantry-spear-v1-scale-compare.png b/docs/handpaint-batch6-nanman-infantry-spear-v1-scale-compare.png new file mode 100644 index 0000000..be58d09 Binary files /dev/null and b/docs/handpaint-batch6-nanman-infantry-spear-v1-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index ecff98f..068131a 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 31 +- Approved baseline units: 32 - Pending approval units: 0 -- Queued rework units: 60 +- Queued rework units: 59 ## Checked Rules diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index 1eec810..6a79a81 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-nanman-infantry-spear-v1-approval-packet.md b/docs/unit-sprite-nanman-infantry-spear-v1-approval-packet.md new file mode 100644 index 0000000..372538a --- /dev/null +++ b/docs/unit-sprite-nanman-infantry-spear-v1-approval-packet.md @@ -0,0 +1,44 @@ +# Nanman Spear Infantry v1 Approval Packet + +- unit: `unit-nanman-infantry-spear` +- version: `v1` +- source: `docs/handpaint-batch6-nanman-infantry-spear-source-v1.png` +- contact sheet: `docs/handpaint-batch6-nanman-infantry-spear-v1-contact.png` +- animation: `docs/handpaint-batch6-nanman-infantry-spear-v1-animation.gif` +- battle preview: `docs/handpaint-batch6-nanman-infantry-spear-v1-debug-preview-battle-check.png` +- before/after: `docs/handpaint-batch6-nanman-infantry-spear-v1-before-after.png` +- scale compare: `docs/handpaint-batch6-nanman-infantry-spear-v1-scale-compare.png` +- current approval board: `docs/unit-sprite-current-approval-board.png` + +## Visual Decision + +Approved for the continuous production run. + +- 50px battle readability: pass +- Nanman spear infantry identity: pass +- compact spear/shield silhouette: pass +- spear stays tile-safe: pass +- opaque unit body: pass +- frame boundary safety: pass +- idle/action scale stability: pass + +## Technical Checks + +- local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-nanman-infantry-spear&v=nanman-spear-v1-final` +- Local browser console errors: `0` +- base partial alpha: `0` +- action partial alpha: `0` +- base frame border hits: `0` +- action frame border hits: `0` +- base empty frames: `0` +- action empty frames: `0` +- base bbox width range: `138..219` +- base bbox height range: `286..288` +- base bottom range: `303..303` +- action bbox width range: `137..263` +- action bbox height range: `277..289` +- action bottom range: `303..303` + +## Notes + +The v1 sheet differentiates the spear infantry from the regular and jungle Nanman infantry through a clear upright spear read while keeping attack and idle poses compact enough for the tactical tile. diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index 060dd91..c40a46a 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 31 +- Approved baseline units: 32 - Pending approval units: 0 -- Queued rework units: 60 +- Queued rework units: 59 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. @@ -14,13 +14,12 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Next Unit Queue -1. `unit-nanman-infantry-spear` - queued-rework, base `border-hits=32`, actions `border-hits=82` -2. `unit-nanman-officer` - queued-rework, base `border-hits=32`, actions `border-hits=82` -3. `unit-nanman-officer-bronze` - queued-rework, base `border-hits=64`, actions `border-hits=144` -4. `unit-nanman-officer-warlord` - queued-rework, base `border-hits=64`, actions `border-hits=144` -5. `unit-nanman-shaman` - queued-rework, base `border-hits=32`, actions `border-hits=98` -6. `unit-nanman-shaman-ember` - queued-rework, base `border-hits=32`, actions `border-hits=98` -7. `unit-nanman-shaman-storm` - queued-rework, base `border-hits=32`, actions `border-hits=98` +1. `unit-nanman-officer` - queued-rework, base `border-hits=32`, actions `border-hits=82` +2. `unit-nanman-officer-bronze` - queued-rework, base `border-hits=64`, actions `border-hits=144` +3. `unit-nanman-officer-warlord` - queued-rework, base `border-hits=64`, actions `border-hits=144` +4. `unit-nanman-shaman` - queued-rework, base `border-hits=32`, actions `border-hits=98` +5. `unit-nanman-shaman-ember` - queued-rework, base `border-hits=32`, actions `border-hits=98` +6. `unit-nanman-shaman-storm` - queued-rework, base `border-hits=32`, actions `border-hits=98` ## Commands Before Approval @@ -47,5 +46,5 @@ pnpm build ## First Task After Current Approval -- Start with `unit-nanman-infantry-spear`. +- Start with `unit-nanman-officer`. - Generate source art, assemble sheets, produce contact/GIF/before-after/scale/battle screenshots, then rerun the gates. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index ab1da78..19497e8 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch6-nanman-special.png b/docs/unit-sprite-review-batch6-nanman-special.png index 1f5384d..08fb2d1 100644 Binary files a/docs/unit-sprite-review-batch6-nanman-special.png and b/docs/unit-sprite-review-batch6-nanman-special.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index d688646..3b58bfb 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index 45e2e23..a8cb604 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 31, - "queued-rework": 60 + "approved-baseline": 32, + "queued-rework": 59 }, "rows": [ { @@ -986,7 +986,7 @@ }, { "batch": "batch6-nanman-special", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-nanman-infantry-spear", "base": { "key": "unit-nanman-infantry-spear", @@ -996,23 +996,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 2055128, - "border_hits": 32, - "min_width": 192, - "max_width": 277, - "min_height": 279, - "max_height": 279, - "min_bottom": 281, - "max_bottom": 287, + "opaque_pixels": 1833424, + "border_hits": 0, + "min_width": 138, + "max_width": 219, + "min_height": 286, + "max_height": 288, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 85, - "height_swing": 0, - "bottom_swing": 6, - "battle_min_width_px": 30.7, - "battle_max_width_px": 44.2, - "battle_min_height_px": 44.6, - "battle_max_height_px": 44.6, - "status": "border-hits=32" + "width_swing": 81, + "height_swing": 2, + "bottom_swing": 0, + "battle_min_width_px": 22.0, + "battle_max_width_px": 35.0, + "battle_min_height_px": 45.7, + "battle_max_height_px": 46.0, + "status": "ok" }, "actions": { "key": "unit-nanman-infantry-spear-actions", @@ -1022,23 +1022,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4610202, - "border_hits": 82, - "min_width": 192, - "max_width": 286, - "min_height": 275, - "max_height": 279, - "min_bottom": 274, - "max_bottom": 289, + "opaque_pixels": 4549291, + "border_hits": 0, + "min_width": 137, + "max_width": 263, + "min_height": 277, + "max_height": 289, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 94, - "height_swing": 4, - "bottom_swing": 15, - "battle_min_width_px": 30.7, - "battle_max_width_px": 45.7, - "battle_min_height_px": 43.9, - "battle_max_height_px": 44.6, - "status": "border-hits=82" + "width_swing": 126, + "height_swing": 12, + "bottom_swing": 0, + "battle_min_width_px": 21.9, + "battle_max_width_px": 42.0, + "battle_min_height_px": 44.2, + "battle_max_height_px": 46.2, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index bd2b445..686fecb 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 31 -- queued-rework: 60 +- approved-baseline: 32 +- queued-rework: 59 ## Batch Plan @@ -69,7 +69,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch6-nanman-special | approved-baseline | `unit-meng-huo` | ok | ok | 174..221 x 286..288 | 149..248 x 275..289 | 27.8..35.3 x 45.7..46.0 | w47 h2 b0 | | batch6-nanman-special | approved-baseline | `unit-nanman-infantry` | ok | ok | 152..219 x 288..288 | 152..243 x 265..288 | 24.3..35.0 x 46.0..46.0 | w67 h0 b0 | | batch6-nanman-special | approved-baseline | `unit-nanman-infantry-jungle` | ok | ok | 172..209 x 286..288 | 158..247 x 282..288 | 27.5..33.4 x 45.7..46.0 | w37 h2 b0 | -| batch6-nanman-special | queued-rework | `unit-nanman-infantry-spear` | border-hits=32 | border-hits=82 | 192..277 x 279..279 | 192..286 x 275..279 | 30.7..44.2 x 44.6..44.6 | w85 h0 b6 | +| batch6-nanman-special | approved-baseline | `unit-nanman-infantry-spear` | ok | ok | 138..219 x 286..288 | 137..263 x 277..289 | 22.0..35.0 x 45.7..46.0 | w81 h2 b0 | | batch6-nanman-special | queued-rework | `unit-nanman-officer` | border-hits=32 | border-hits=82 | 200..254 x 279..279 | 200..263 x 275..279 | 31.9..40.6 x 44.6..44.6 | w54 h0 b6 | | batch6-nanman-special | queued-rework | `unit-nanman-officer-bronze` | border-hits=64 | border-hits=144 | 208..258 x 282..288 | 208..267 x 275..290 | 33.2..41.2 x 45.0..46.0 | w50 h6 b6 | | batch6-nanman-special | queued-rework | `unit-nanman-officer-warlord` | border-hits=64 | border-hits=144 | 224..266 x 282..288 | 224..275 x 275..290 | 35.8..42.5 x 45.0..46.0 | w42 h6 b6 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index f4a0710..353086d 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -16,6 +16,7 @@ "unit-meng-huo", "unit-nanman-infantry", "unit-nanman-infantry-jungle", + "unit-nanman-infantry-spear", "unit-rebel", "unit-rebel-archer", "unit-rebel-archer-fire", @@ -46,7 +47,6 @@ "pendingApproval": [], "currentApprovalCandidate": {}, "nextAfterApproval": [ - "unit-nanman-infantry-spear", "unit-nanman-officer", "unit-nanman-officer-bronze", "unit-nanman-officer-warlord", diff --git a/src/assets/images/units/unit-nanman-infantry-spear-actions.png b/src/assets/images/units/unit-nanman-infantry-spear-actions.png index 4d56bf7..99c5eee 100644 Binary files a/src/assets/images/units/unit-nanman-infantry-spear-actions.png and b/src/assets/images/units/unit-nanman-infantry-spear-actions.png differ diff --git a/src/assets/images/units/unit-nanman-infantry-spear.png b/src/assets/images/units/unit-nanman-infantry-spear.png index 4c753db..94e88ff 100644 Binary files a/src/assets/images/units/unit-nanman-infantry-spear.png and b/src/assets/images/units/unit-nanman-infantry-spear.png differ