diff --git a/docs/propfix-wei-strategist-black-v2-animation.gif b/docs/propfix-wei-strategist-black-v2-animation.gif new file mode 100644 index 0000000..313841c Binary files /dev/null and b/docs/propfix-wei-strategist-black-v2-animation.gif differ diff --git a/docs/propfix-wei-strategist-black-v2-battle-composite.png b/docs/propfix-wei-strategist-black-v2-battle-composite.png new file mode 100644 index 0000000..4cde829 Binary files /dev/null and b/docs/propfix-wei-strategist-black-v2-battle-composite.png differ diff --git a/docs/propfix-wei-strategist-black-v2-before-after.png b/docs/propfix-wei-strategist-black-v2-before-after.png new file mode 100644 index 0000000..b1dbd55 Binary files /dev/null and b/docs/propfix-wei-strategist-black-v2-before-after.png differ diff --git a/docs/propfix-wei-strategist-black-v2-browser-check.png b/docs/propfix-wei-strategist-black-v2-browser-check.png new file mode 100644 index 0000000..967289c Binary files /dev/null and b/docs/propfix-wei-strategist-black-v2-browser-check.png differ diff --git a/docs/propfix-wei-strategist-black-v2-contact.png b/docs/propfix-wei-strategist-black-v2-contact.png new file mode 100644 index 0000000..913d5c4 Binary files /dev/null and b/docs/propfix-wei-strategist-black-v2-contact.png differ diff --git a/docs/propfix-wei-strategist-black-v2-report.md b/docs/propfix-wei-strategist-black-v2-report.md new file mode 100644 index 0000000..aa68709 --- /dev/null +++ b/docs/propfix-wei-strategist-black-v2-report.md @@ -0,0 +1,28 @@ +# Wei Covert Black Strategist v2 report + +- source: `propfix-wei-strategist-black-v2-source.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 2139336 +- action partial alpha: 0, opaque pixels: 4495357 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 162..205 +- base bbox height range: 282..295 +- base bottom range: 303..303 +- action bbox width range: 143..230 +- action bbox height range: 282..292 +- action bottom range: 303..303 +- contact: `propfix-wei-strategist-black-v2-contact.png` +- animation: `propfix-wei-strategist-black-v2-animation.gif` +- before/after: `propfix-wei-strategist-black-v2-before-after.png` +- scale compare: `propfix-wei-strategist-black-v2-scale-compare.png` +- battle composite: `propfix-wei-strategist-black-v2-battle-composite.png` +- browser check: `propfix-wei-strategist-black-v2-browser-check.png` +- identity note: replaced the white-fan black strategist read with a generic Wei covert adviser centered on black command tablet, sealed military order, iron tally baton, lacquer document case, and compact war ledger. +- local build: passed +- local browser console errors: 0 +- local browser battle check: passed at `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-wei-strategist-black&v=wei-black-v2-local` +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/propfix-wei-strategist-black-v2-scale-compare.png b/docs/propfix-wei-strategist-black-v2-scale-compare.png new file mode 100644 index 0000000..cb029d5 Binary files /dev/null and b/docs/propfix-wei-strategist-black-v2-scale-compare.png differ diff --git a/docs/propfix-wei-strategist-black-v2-source.png b/docs/propfix-wei-strategist-black-v2-source.png new file mode 100644 index 0000000..415c769 Binary files /dev/null and b/docs/propfix-wei-strategist-black-v2-source.png differ diff --git a/docs/strategist-character-direction.md b/docs/strategist-character-direction.md index 5317311..406a5b3 100644 --- a/docs/strategist-character-direction.md +++ b/docs/strategist-character-direction.md @@ -32,9 +32,9 @@ Zhuge Liang owns the large white feather fan and white-robed sage read. Other st ## Next Representative Fixes -1. `unit-wei-strategist-black`: verify the covert adviser keeps dark props instead of a pale fan read. -2. `unit-wei-strategist-blue`: verify the records officer stays map/registry focused instead of fan-focused. -3. `unit-sima-yi`: confirm the named Wei conspirator remains darker and more distinctive than generic Wei strategists. +1. `unit-wei-strategist-blue`: verify the records officer stays map/registry focused instead of fan-focused. +2. `unit-sima-yi`: confirm the named Wei conspirator remains darker and more distinctive than generic Wei strategists. +3. `unit-huang-quan`: verify the quartermaster official stays records/map focused without a fan read. Completed representative pass: @@ -44,5 +44,6 @@ Completed representative pass: - `unit-wu-strategist-fire`: changed from white-fan fire strategist to ember-red fire tactician with bronze tally, oil-map board, red command tablet, and talisman strips. - `unit-wu-strategist-river`: changed from white-fan river strategist to blue-green river-route tactician with water-route map board, scroll tube, oar-shaped baton, and navigation slips. - `unit-shu-strategist-field`: changed from white-fan sage-like field strategist to rugged Shu frontline staff officer with folded field map, short baton, bamboo slips, leather scroll case, and order pouch. +- `unit-wei-strategist-black`: changed from white-fan black strategist to generic Wei covert adviser with black command tablet, sealed military order, iron tally baton, lacquer case, and compact war ledger. Every representative fix should include contact sheet, animation GIF, battle preview, before/after, alpha audit, build, and browser check. diff --git a/docs/strategist-prop-audit.md b/docs/strategist-prop-audit.md index 9a1e7a2..343a6c8 100644 --- a/docs/strategist-prop-audit.md +++ b/docs/strategist-prop-audit.md @@ -27,7 +27,7 @@ Detailed per-unit visual direction lives in `strategist-character-direction.md`. | `unit-shu-strategist-field` | folded field map, short baton, bamboo slips, leather scroll case, order pouch | white fan and sage-white read removed; frontline staff officer identity restored | fixed in representative pass | | `unit-shu-strategist-white` | muted jade civil aide, document bundle, brush case, bamboo-slip ledger | white robe/fan pairing removed; Shu administrative aide identity restored | fixed in representative pass | | `unit-wei-strategist` | bronze command tablet, war ledger, compact map board | white feather fan removed; Wei court analyst identity restored | fixed in representative pass | -| `unit-wei-strategist-black` | dark strategist prop variant | acceptable if fan stays dark and compact | later identity pass | +| `unit-wei-strategist-black` | black command tablet, sealed military order, iron tally baton, lacquer case, compact war ledger | white fan removed; Wei covert adviser identity restored | fixed in representative pass | | `unit-wei-strategist-blue` | blue records officer variant | acceptable if props are records/maps | later identity pass | | `unit-wu-strategist` | naval chart, lacquer red baton, river map board | white feather fan removed; Wu river adviser identity restored | fixed in representative pass | | `unit-wu-strategist-fire` | bronze fire tally, oil-map board, red command tablet, talisman strips | white fan read removed; fire-plan tactician identity restored | fixed in representative pass | @@ -48,8 +48,8 @@ The first correction batch changes: Next representative cleanup order: -1. `unit-wei-strategist-black` -2. `unit-wei-strategist-blue` -3. `unit-sima-yi` +1. `unit-wei-strategist-blue` +2. `unit-sima-yi` +3. `unit-huang-quan` Later cleanup should remove white-feather-fan reads from remaining generic strategist variants after the representative fixes are verified. diff --git a/docs/unit-sprite-batch-queue.json b/docs/unit-sprite-batch-queue.json index 643105f..cfcaad4 100644 --- a/docs/unit-sprite-batch-queue.json +++ b/docs/unit-sprite-batch-queue.json @@ -664,10 +664,10 @@ "baseStatus": "ok", "actionStatus": "ok", "battleBasePx": [ - 23.3, - 34.0, - 43.1, - 46.0 + 25.9, + 32.7, + 45.0, + 47.1 ], "spec": null }, diff --git a/docs/unit-sprite-batch-queue.md b/docs/unit-sprite-batch-queue.md index ea5a58b..64900c6 100644 --- a/docs/unit-sprite-batch-queue.md +++ b/docs/unit-sprite-batch-queue.md @@ -90,7 +90,7 @@ No next unit is currently defined. | `unit-wei-officer-gate` | approved reference | approved-baseline | technical ok | 28.1..33.4 x 46.0..46.0 | | | `unit-wei-officer-iron` | approved reference | approved-baseline | technical ok | 34.2..36.6 x 44.2..46.0 | | | `unit-wei-strategist` | approved reference | approved-baseline | technical ok | 25.9..33.2 x 45.0..46.3 | | -| `unit-wei-strategist-black` | approved reference | approved-baseline | technical ok | 23.3..34.0 x 43.1..46.0 | | +| `unit-wei-strategist-black` | approved reference | approved-baseline | technical ok | 25.9..32.7 x 45.0..47.1 | | | `unit-wei-strategist-blue` | approved reference | approved-baseline | technical ok | 26.4..33.5 x 46.0..46.0 | | | `unit-wei-yan` | approved reference | approved-baseline | technical ok | 27.6..35.0 x 44.2..46.3 | | diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index e6e9c0c..596a03a 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch3-wei.png b/docs/unit-sprite-review-batch3-wei.png index 340d5a3..73064dd 100644 Binary files a/docs/unit-sprite-review-batch3-wei.png and b/docs/unit-sprite-review-batch3-wei.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index ce4857c..2748ba6 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index dad700d..8714407 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -3845,22 +3845,22 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 1942946, + "opaque_pixels": 2139336, "border_hits": 0, - "min_width": 146, - "max_width": 213, - "min_height": 270, - "max_height": 288, + "min_width": 162, + "max_width": 205, + "min_height": 282, + "max_height": 295, "min_bottom": 303, "max_bottom": 303, "empty_frames": 0, - "width_swing": 67, - "height_swing": 18, + "width_swing": 43, + "height_swing": 13, "bottom_swing": 0, - "battle_min_width_px": 23.3, - "battle_max_width_px": 34.0, - "battle_min_height_px": 43.1, - "battle_max_height_px": 46.0, + "battle_min_width_px": 25.9, + "battle_max_width_px": 32.7, + "battle_min_height_px": 45.0, + "battle_max_height_px": 47.1, "status": "ok" }, "actions": { @@ -3871,22 +3871,22 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4463257, + "opaque_pixels": 4495357, "border_hits": 0, - "min_width": 146, - "max_width": 240, - "min_height": 249, - "max_height": 288, + "min_width": 143, + "max_width": 230, + "min_height": 282, + "max_height": 292, "min_bottom": 303, "max_bottom": 303, "empty_frames": 0, - "width_swing": 94, - "height_swing": 39, + "width_swing": 87, + "height_swing": 10, "bottom_swing": 0, - "battle_min_width_px": 23.3, - "battle_max_width_px": 38.3, - "battle_min_height_px": 39.8, - "battle_max_height_px": 46.0, + "battle_min_width_px": 22.8, + "battle_max_width_px": 36.7, + "battle_min_height_px": 45.0, + "battle_max_height_px": 46.6, "status": "ok" } }, diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index c51bdc6..dc7958f 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -118,7 +118,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch3-wei | approved-baseline | `unit-wei-officer-gate` | ok | ok | 176..209 x 288..288 | 176..257 x 262..288 | 28.1..33.4 x 46.0..46.0 | w33 h0 b0 | | batch3-wei | approved-baseline | `unit-wei-officer-iron` | ok | ok | 214..229 x 277..288 | 201..258 x 230..288 | 34.2..36.6 x 44.2..46.0 | w15 h11 b0 | | batch3-wei | approved-baseline | `unit-wei-strategist` | ok | ok | 162..208 x 282..290 | 136..212 x 282..295 | 25.9..33.2 x 45.0..46.3 | w46 h8 b0 | -| batch3-wei | approved-baseline | `unit-wei-strategist-black` | ok | ok | 146..213 x 270..288 | 146..240 x 249..288 | 23.3..34.0 x 43.1..46.0 | w67 h18 b0 | +| batch3-wei | approved-baseline | `unit-wei-strategist-black` | ok | ok | 162..205 x 282..295 | 143..230 x 282..292 | 25.9..32.7 x 45.0..47.1 | w43 h13 b0 | | batch3-wei | approved-baseline | `unit-wei-strategist-blue` | ok | ok | 165..210 x 288..288 | 165..246 x 264..288 | 26.4..33.5 x 46.0..46.0 | w45 h0 b0 | | batch3-wei | approved-baseline | `unit-wei-yan` | ok | ok | 173..219 x 277..290 | 173..264 x 232..290 | 27.6..35.0 x 44.2..46.3 | w46 h13 b0 | | batch4-wu | approved-baseline | `unit-wu-archer` | ok | ok | 177..215 x 288..288 | 178..242 x 288..288 | 28.3..34.3 x 46.0..46.0 | w38 h0 b0 | diff --git a/src/assets/images/units/unit-wei-strategist-black-actions.png b/src/assets/images/units/unit-wei-strategist-black-actions.png index 513222c..f18ed96 100644 Binary files a/src/assets/images/units/unit-wei-strategist-black-actions.png and b/src/assets/images/units/unit-wei-strategist-black-actions.png differ diff --git a/src/assets/images/units/unit-wei-strategist-black.png b/src/assets/images/units/unit-wei-strategist-black.png index b9b3b06..709700f 100644 Binary files a/src/assets/images/units/unit-wei-strategist-black.png and b/src/assets/images/units/unit-wei-strategist-black.png differ