diff --git a/docs/handpaint-batch7-lu-meng-source-v1.png b/docs/handpaint-batch7-lu-meng-source-v1.png new file mode 100644 index 0000000..d27758b Binary files /dev/null and b/docs/handpaint-batch7-lu-meng-source-v1.png differ diff --git a/docs/handpaint-batch7-lu-meng-v1-animation.gif b/docs/handpaint-batch7-lu-meng-v1-animation.gif new file mode 100644 index 0000000..fe0f698 Binary files /dev/null and b/docs/handpaint-batch7-lu-meng-v1-animation.gif differ diff --git a/docs/handpaint-batch7-lu-meng-v1-battle-composite.png b/docs/handpaint-batch7-lu-meng-v1-battle-composite.png new file mode 100644 index 0000000..0bd006e Binary files /dev/null and b/docs/handpaint-batch7-lu-meng-v1-battle-composite.png differ diff --git a/docs/handpaint-batch7-lu-meng-v1-before-after.png b/docs/handpaint-batch7-lu-meng-v1-before-after.png new file mode 100644 index 0000000..978ee0c Binary files /dev/null and b/docs/handpaint-batch7-lu-meng-v1-before-after.png differ diff --git a/docs/handpaint-batch7-lu-meng-v1-contact.png b/docs/handpaint-batch7-lu-meng-v1-contact.png new file mode 100644 index 0000000..b15fadc Binary files /dev/null and b/docs/handpaint-batch7-lu-meng-v1-contact.png differ diff --git a/docs/handpaint-batch7-lu-meng-v1-debug-preview-battle-check.png b/docs/handpaint-batch7-lu-meng-v1-debug-preview-battle-check.png new file mode 100644 index 0000000..c4029cb Binary files /dev/null and b/docs/handpaint-batch7-lu-meng-v1-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch7-lu-meng-v1-report.md b/docs/handpaint-batch7-lu-meng-v1-report.md new file mode 100644 index 0000000..c54e873 --- /dev/null +++ b/docs/handpaint-batch7-lu-meng-v1-report.md @@ -0,0 +1,24 @@ +# Lu Meng hand-painted v1 report + +- source: `handpaint-batch7-lu-meng-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 2238724 +- action partial alpha: 0, opaque pixels: 4477687 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 169..253 +- base bbox height range: 288..290 +- base bottom range: 303..303 +- action bbox width range: 153..238 +- action bbox height range: 286..290 +- action bottom range: 303..303 +- contact: `handpaint-batch7-lu-meng-v1-contact.png` +- animation: `handpaint-batch7-lu-meng-v1-animation.gif` +- before/after: `handpaint-batch7-lu-meng-v1-before-after.png` +- scale compare: `handpaint-batch7-lu-meng-v1-scale-compare.png` +- battle composite: `handpaint-batch7-lu-meng-v1-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch7-lu-meng-v1-scale-compare.png b/docs/handpaint-batch7-lu-meng-v1-scale-compare.png new file mode 100644 index 0000000..19e97ee Binary files /dev/null and b/docs/handpaint-batch7-lu-meng-v1-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index 3316c24..d0709eb 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 80 +- Approved baseline units: 81 - Pending approval units: 0 -- Queued rework units: 11 +- Queued rework units: 10 ## Checked Rules diff --git a/docs/unit-sprite-batch-queue.json b/docs/unit-sprite-batch-queue.json index 7619d8b..9ff7f90 100644 --- a/docs/unit-sprite-batch-queue.json +++ b/docs/unit-sprite-batch-queue.json @@ -13,6 +13,7 @@ "unit-li-yan", "unit-liu-bei", "unit-lu-bu", + "unit-lu-meng", "unit-meng-huo", "unit-nanman-infantry", "unit-nanman-infantry-jungle", @@ -87,8 +88,8 @@ "pendingApproval": [], "nextAfterApproval": [], "stageCounts": { - "approved-baseline": 80, - "queued-rework": 11 + "approved-baseline": 81, + "queued-rework": 10 }, "batches": [ { @@ -1174,24 +1175,10 @@ "label": "Batch 7 unique officers", "total": 19, "stageCounts": { - "approved-baseline": 8, - "queued-rework": 11 + "approved-baseline": 9, + "queued-rework": 10 }, "units": [ - { - "stem": "unit-lu-meng", - "reviewStage": "queued-rework", - "queueRole": "queued rework", - "baseStatus": "border-hits=32", - "actionStatus": "border-hits=82", - "battleBasePx": [ - 30.7, - 44.2, - 44.6, - 44.6 - ], - "spec": null - }, { "stem": "unit-ma-chao", "reviewStage": "queued-rework", @@ -1443,6 +1430,20 @@ 46.3 ], "spec": null + }, + { + "stem": "unit-lu-meng", + "reviewStage": "approved-baseline", + "queueRole": "approved reference", + "baseStatus": "ok", + "actionStatus": "ok", + "battleBasePx": [ + 27.0, + 40.4, + 46.0, + 46.3 + ], + "spec": null } ] } diff --git a/docs/unit-sprite-batch-queue.md b/docs/unit-sprite-batch-queue.md index 42cbd4d..e5e97bd 100644 --- a/docs/unit-sprite-batch-queue.md +++ b/docs/unit-sprite-batch-queue.md @@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i ## Current State -- Approved baseline units: 80 +- Approved baseline units: 81 - Pending approval units: 0 -- Queued rework units: 11 +- Queued rework units: 10 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` @@ -157,11 +157,10 @@ No next unit is currently defined. - Batch key: `batch7-unique-officer` - Total units: 19 -- Stage counts: approved-baseline 8, queued-rework 11 +- Stage counts: approved-baseline 9, queued-rework 10 | unit | role | stage | status | battle base px | spec | | --- | --- | --- | --- | --- | --- | -| `unit-lu-meng` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 30.7..44.2 x 44.6..44.6 | | | `unit-ma-chao` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 26.5..47.3 x 45.0..46.0 | | | `unit-ma-dai` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 25.6..46.5 x 45.0..46.2 | | | `unit-ma-liang` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | @@ -180,3 +179,4 @@ No next unit is currently defined. | `unit-jiang-wei` | approved reference | approved-baseline | technical ok | 23.2..42.5 x 45.4..46.5 | | | `unit-li-yan` | approved reference | approved-baseline | technical ok | 27.2..41.9 x 45.7..46.3 | | | `unit-lu-bu` | approved reference | approved-baseline | technical ok | 29.9..40.4 x 44.7..46.3 | | +| `unit-lu-meng` | approved reference | approved-baseline | technical ok | 27.0..40.4 x 46.0..46.3 | | diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index aa37961..57d1ebe 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-lu-meng-v1-approval-packet.md b/docs/unit-sprite-lu-meng-v1-approval-packet.md new file mode 100644 index 0000000..50ecf46 --- /dev/null +++ b/docs/unit-sprite-lu-meng-v1-approval-packet.md @@ -0,0 +1,36 @@ +# Lu Meng hand-painted sprite v1 approval packet + +- Unit: `unit-lu-meng` +- Candidate version: `v1` +- Source sheet: `docs/handpaint-batch7-lu-meng-source-v1.png` +- Contact sheet: `docs/handpaint-batch7-lu-meng-v1-contact.png` +- Animation GIF: `docs/handpaint-batch7-lu-meng-v1-animation.gif` +- Before/after: `docs/handpaint-batch7-lu-meng-v1-before-after.png` +- Battle composite: `docs/handpaint-batch7-lu-meng-v1-battle-composite.png` +- Scale compare: `docs/handpaint-batch7-lu-meng-v1-scale-compare.png` +- Local browser check: `docs/handpaint-batch7-lu-meng-v1-debug-preview-battle-check.png` +- Current approval board: `docs/unit-sprite-current-approval-board.png` + +## Visual Decision + +- Approved for continuous production run. +- Direction: Wu river/naval commander with teal/navy armor, white crossing-river cloak, compact officer headgear, sword, and command-scroll details. +- The 100% PC browser debug preview reads as a distinct Wu commander, separate from Lu Bu's red boss silhouette and the older generic soldier. +- The unit body is opaque and readable at battle scale without base rings, completion badges, or other external readability helpers. + +## Technical Checks + +- Local build: `pnpm build` passed. +- Local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-lu-meng&v=lu-meng-v1` +- Local browser console errors: `0` +- Local browser 404s: `0` +- Base partial alpha: `0` +- Action partial alpha: `0` +- Base frame border hits: `0` +- Action frame border hits: `0` +- Base battle size from audit: `27.0..40.4 x 46.0..46.3` + +## Notes + +- v1 passes the visual and technical checks without further scaling iteration. +- The white cloak improves 50px readability while staying clear of UI ornamentation or external status markers. diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index a739c7e..bed4de8 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 80 +- Approved baseline units: 81 - Pending approval units: 0 -- Queued rework units: 11 +- Queued rework units: 10 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index 7f84fad..b1cf4b8 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch7-unique-officer.png b/docs/unit-sprite-review-batch7-unique-officer.png index a98358f..a377436 100644 Binary files a/docs/unit-sprite-review-batch7-unique-officer.png and b/docs/unit-sprite-review-batch7-unique-officer.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index ebe05a4..2ba955e 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index 3d953d1..b38d590 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 80, - "queued-rework": 11 + "approved-baseline": 81, + "queued-rework": 10 }, "rows": [ { @@ -587,7 +587,7 @@ }, { "batch": "batch7-unique-officer", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-lu-meng", "base": { "key": "unit-lu-meng", @@ -597,23 +597,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 2055128, - "border_hits": 32, - "min_width": 192, - "max_width": 277, - "min_height": 279, - "max_height": 279, - "min_bottom": 281, - "max_bottom": 287, + "opaque_pixels": 2238724, + "border_hits": 0, + "min_width": 169, + "max_width": 253, + "min_height": 288, + "max_height": 290, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 85, - "height_swing": 0, - "bottom_swing": 6, - "battle_min_width_px": 30.7, - "battle_max_width_px": 44.2, - "battle_min_height_px": 44.6, - "battle_max_height_px": 44.6, - "status": "border-hits=32" + "width_swing": 84, + "height_swing": 2, + "bottom_swing": 0, + "battle_min_width_px": 27.0, + "battle_max_width_px": 40.4, + "battle_min_height_px": 46.0, + "battle_max_height_px": 46.3, + "status": "ok" }, "actions": { "key": "unit-lu-meng-actions", @@ -623,23 +623,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4610202, - "border_hits": 82, - "min_width": 192, - "max_width": 286, - "min_height": 275, - "max_height": 279, - "min_bottom": 274, - "max_bottom": 289, + "opaque_pixels": 4477687, + "border_hits": 0, + "min_width": 153, + "max_width": 238, + "min_height": 286, + "max_height": 290, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 94, + "width_swing": 85, "height_swing": 4, - "bottom_swing": 15, - "battle_min_width_px": 30.7, - "battle_max_width_px": 45.7, - "battle_min_height_px": 43.9, - "battle_max_height_px": 44.6, - "status": "border-hits=82" + "bottom_swing": 0, + "battle_min_width_px": 24.4, + "battle_max_width_px": 38.0, + "battle_min_height_px": 45.7, + "battle_max_height_px": 46.3, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index 06b2475..c2a2f8f 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 80 -- queued-rework: 11 +- approved-baseline: 81 +- queued-rework: 10 ## Batch Plan @@ -62,7 +62,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch7-unique-officer | approved-baseline | `unit-li-yan` | ok | ok | 170..262 x 286..290 | 190..259 x 286..290 | 27.2..41.9 x 45.7..46.3 | w92 h4 b0 | | batch1-approved-core | approved-baseline | `unit-liu-bei` | ok | ok | 138..258 x 278..289 | 148..300 x 252..284 | 22.0..41.2 x 44.4..46.2 | w120 h11 b12 | | batch7-unique-officer | approved-baseline | `unit-lu-bu` | ok | ok | 187..253 x 280..290 | 155..271 x 280..290 | 29.9..40.4 x 44.7..46.3 | w66 h10 b0 | -| batch7-unique-officer | queued-rework | `unit-lu-meng` | border-hits=32 | border-hits=82 | 192..277 x 279..279 | 192..286 x 275..279 | 30.7..44.2 x 44.6..44.6 | w85 h0 b6 | +| batch7-unique-officer | approved-baseline | `unit-lu-meng` | ok | ok | 169..253 x 288..290 | 153..238 x 286..290 | 27.0..40.4 x 46.0..46.3 | w84 h2 b0 | | batch7-unique-officer | queued-rework | `unit-ma-chao` | border-hits=64 | border-hits=144 | 166..296 x 282..288 | 166..305 x 274..290 | 26.5..47.3 x 45.0..46.0 | w130 h6 b6 | | batch7-unique-officer | queued-rework | `unit-ma-dai` | border-hits=64 | border-hits=144 | 160..291 x 282..289 | 160..300 x 274..290 | 25.6..46.5 x 45.0..46.2 | w131 h7 b7 | | batch7-unique-officer | queued-rework | `unit-ma-liang` | border-hits=32 | border-hits=98 | 243..246 x 280..281 | 220..255 x 275..281 | 38.8..39.3 x 44.7..44.9 | w3 h1 b6 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index a9cff15..3219b17 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -21,6 +21,7 @@ "unit-li-yan", "unit-liu-bei", "unit-lu-bu", + "unit-lu-meng", "unit-meng-huo", "unit-nanman-infantry", "unit-nanman-infantry-jungle", diff --git a/src/assets/images/units/unit-lu-meng-actions.png b/src/assets/images/units/unit-lu-meng-actions.png index dff5754..90fc231 100644 Binary files a/src/assets/images/units/unit-lu-meng-actions.png and b/src/assets/images/units/unit-lu-meng-actions.png differ diff --git a/src/assets/images/units/unit-lu-meng.png b/src/assets/images/units/unit-lu-meng.png index 91af016..9d38d3a 100644 Binary files a/src/assets/images/units/unit-lu-meng.png and b/src/assets/images/units/unit-lu-meng.png differ