diff --git a/docs/handpaint-batch7-fa-zheng-source-v1.png b/docs/handpaint-batch7-fa-zheng-source-v1.png new file mode 100644 index 0000000..c7d184e Binary files /dev/null and b/docs/handpaint-batch7-fa-zheng-source-v1.png differ diff --git a/docs/handpaint-batch7-fa-zheng-v2-animation.gif b/docs/handpaint-batch7-fa-zheng-v2-animation.gif new file mode 100644 index 0000000..bc2e943 Binary files /dev/null and b/docs/handpaint-batch7-fa-zheng-v2-animation.gif differ diff --git a/docs/handpaint-batch7-fa-zheng-v2-battle-composite.png b/docs/handpaint-batch7-fa-zheng-v2-battle-composite.png new file mode 100644 index 0000000..b381639 Binary files /dev/null and b/docs/handpaint-batch7-fa-zheng-v2-battle-composite.png differ diff --git a/docs/handpaint-batch7-fa-zheng-v2-before-after.png b/docs/handpaint-batch7-fa-zheng-v2-before-after.png new file mode 100644 index 0000000..9a79bf6 Binary files /dev/null and b/docs/handpaint-batch7-fa-zheng-v2-before-after.png differ diff --git a/docs/handpaint-batch7-fa-zheng-v2-contact.png b/docs/handpaint-batch7-fa-zheng-v2-contact.png new file mode 100644 index 0000000..930a3e4 Binary files /dev/null and b/docs/handpaint-batch7-fa-zheng-v2-contact.png differ diff --git a/docs/handpaint-batch7-fa-zheng-v2-debug-preview-battle-check.png b/docs/handpaint-batch7-fa-zheng-v2-debug-preview-battle-check.png new file mode 100644 index 0000000..814d58f Binary files /dev/null and b/docs/handpaint-batch7-fa-zheng-v2-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch7-fa-zheng-v2-report.md b/docs/handpaint-batch7-fa-zheng-v2-report.md new file mode 100644 index 0000000..9d1e628 --- /dev/null +++ b/docs/handpaint-batch7-fa-zheng-v2-report.md @@ -0,0 +1,24 @@ +# Fa Zheng Handpainted Sprite v2 + +- source: `handpaint-batch7-fa-zheng-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 2296062 +- action partial alpha: 0, opaque pixels: 5507911 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 182..221 +- base bbox height range: 290..290 +- base bottom range: 303..303 +- action bbox width range: 183..244 +- action bbox height range: 270..290 +- action bottom range: 303..303 +- contact: `handpaint-batch7-fa-zheng-v2-contact.png` +- animation: `handpaint-batch7-fa-zheng-v2-animation.gif` +- before/after: `handpaint-batch7-fa-zheng-v2-before-after.png` +- scale compare: `handpaint-batch7-fa-zheng-v2-scale-compare.png` +- battle composite: `handpaint-batch7-fa-zheng-v2-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch7-fa-zheng-v2-scale-compare.png b/docs/handpaint-batch7-fa-zheng-v2-scale-compare.png new file mode 100644 index 0000000..e88f691 Binary files /dev/null and b/docs/handpaint-batch7-fa-zheng-v2-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index a99b419..bfa306a 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 73 +- Approved baseline units: 74 - Pending approval units: 0 -- Queued rework units: 18 +- Queued rework units: 17 ## Checked Rules diff --git a/docs/unit-sprite-batch-queue.json b/docs/unit-sprite-batch-queue.json index fb3daf5..9a03aa4 100644 --- a/docs/unit-sprite-batch-queue.json +++ b/docs/unit-sprite-batch-queue.json @@ -4,6 +4,7 @@ "audit": "docs/unit-sprite-rework-audit.json", "approvedBaseline": [ "unit-cao-cao", + "unit-fa-zheng", "unit-guan-yu", "unit-liu-bei", "unit-meng-huo", @@ -80,8 +81,8 @@ "pendingApproval": [], "nextAfterApproval": [], "stageCounts": { - "approved-baseline": 73, - "queued-rework": 18 + "approved-baseline": 74, + "queued-rework": 17 }, "batches": [ { @@ -1167,24 +1168,10 @@ "label": "Batch 7 unique officers", "total": 19, "stageCounts": { - "approved-baseline": 1, - "queued-rework": 18 + "approved-baseline": 2, + "queued-rework": 17 }, "units": [ - { - "stem": "unit-fa-zheng", - "reviewStage": "queued-rework", - "queueRole": "queued rework", - "baseStatus": "border-hits=32", - "actionStatus": "border-hits=98", - "battleBasePx": [ - 38.8, - 39.3, - 44.7, - 44.9 - ], - "spec": null - }, { "stem": "unit-gong-zhi", "reviewStage": "queued-rework", @@ -1436,6 +1423,20 @@ 47.3 ], "spec": null + }, + { + "stem": "unit-fa-zheng", + "reviewStage": "approved-baseline", + "queueRole": "approved reference", + "baseStatus": "ok", + "actionStatus": "ok", + "battleBasePx": [ + 29.1, + 35.3, + 46.3, + 46.3 + ], + "spec": null } ] } diff --git a/docs/unit-sprite-batch-queue.md b/docs/unit-sprite-batch-queue.md index 7ffbcd3..864885d 100644 --- a/docs/unit-sprite-batch-queue.md +++ b/docs/unit-sprite-batch-queue.md @@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i ## Current State -- Approved baseline units: 73 +- Approved baseline units: 74 - Pending approval units: 0 -- Queued rework units: 18 +- Queued rework units: 17 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` @@ -157,11 +157,10 @@ No next unit is currently defined. - Batch key: `batch7-unique-officer` - Total units: 19 -- Stage counts: approved-baseline 1, queued-rework 18 +- Stage counts: approved-baseline 2, queued-rework 17 | unit | role | stage | status | battle base px | spec | | --- | --- | --- | --- | --- | --- | -| `unit-fa-zheng` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | | `unit-gong-zhi` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 31.9..40.6 x 44.6..44.6 | | | `unit-huang-quan` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 31.9..40.6 x 44.6..44.6 | | | `unit-huang-zhong` | queued rework | queued-rework | base border-hits=64; actions border-hits=140 | 39.1..39.3 x 44.6..44.6 | | @@ -180,3 +179,4 @@ No next unit is currently defined. | `unit-zhao-yun` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 26.5..47.3 x 45.0..46.0 | | | `unit-zhuge-liang` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | | `unit-cao-cao` | approved reference | approved-baseline | technical ok | 32.9..36.4 x 46.3..47.3 | | +| `unit-fa-zheng` | approved reference | approved-baseline | technical ok | 29.1..35.3 x 46.3..46.3 | | diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index 1cbd934..f88343c 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-fa-zheng-v2-approval-packet.md b/docs/unit-sprite-fa-zheng-v2-approval-packet.md new file mode 100644 index 0000000..02976f7 --- /dev/null +++ b/docs/unit-sprite-fa-zheng-v2-approval-packet.md @@ -0,0 +1,37 @@ +# Fa Zheng v2 Approval Packet + +- status: approved during continuous production run +- unit: `unit-fa-zheng` +- source art: `handpaint-batch7-fa-zheng-source-v1.png` +- contact sheet: `handpaint-batch7-fa-zheng-v2-contact.png` +- animation GIF: `handpaint-batch7-fa-zheng-v2-animation.gif` +- before/after: `handpaint-batch7-fa-zheng-v2-before-after.png` +- scale compare: `handpaint-batch7-fa-zheng-v2-scale-compare.png` +- battle composite: `handpaint-batch7-fa-zheng-v2-battle-composite.png` +- browser check: `handpaint-batch7-fa-zheng-v2-debug-preview-battle-check.png` +- current board: `unit-sprite-current-approval-board.png` +- debug URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-fa-zheng&v=fa-zheng-v2` + +## Visual Decision + +Approved for the continuous batch run. v2 reads as Fa Zheng through the dark teal Yizhou official robe, black scholar hat, war fan, and bamboo-slip command poses. The silhouette is practical and severe rather than elegant, keeping him distinct from Zhuge Liang while still clearly belonging to the strategist class. + +## Technical Checks + +- base status: ok +- action status: ok +- base partial alpha: 0 +- action partial alpha: 0 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- battle scale from sample gate: 29.1..35.3 x 46.3..46.3 +- action battle scale from audit: 29.2..39.0 x 43.1..46.3 +- local build: passed +- Local browser console errors: `0` +- Local browser 404s: `0` + +## Notes + +v1 was rejected because the idle body read too narrow at battle scale. v2 widens the robe and sleeve mass while keeping the strategist posture restrained, so the unit remains readable without becoming a front-line officer. diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index 551b511..b8f9f90 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 73 +- Approved baseline units: 74 - Pending approval units: 0 -- Queued rework units: 18 +- Queued rework units: 17 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index 9e504fe..e1b14dd 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch7-unique-officer.png b/docs/unit-sprite-review-batch7-unique-officer.png index 2c2d7d5..3e7eaf3 100644 Binary files a/docs/unit-sprite-review-batch7-unique-officer.png and b/docs/unit-sprite-review-batch7-unique-officer.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index b214d3f..556b408 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index 216daa6..007432c 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 73, - "queued-rework": 18 + "approved-baseline": 74, + "queued-rework": 17 }, "rows": [ { @@ -74,7 +74,7 @@ }, { "batch": "batch7-unique-officer", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-fa-zheng", "base": { "key": "unit-fa-zheng", @@ -84,23 +84,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 1999925, - "border_hits": 32, - "min_width": 243, - "max_width": 246, - "min_height": 280, - "max_height": 281, - "min_bottom": 281, - "max_bottom": 287, + "opaque_pixels": 2296062, + "border_hits": 0, + "min_width": 182, + "max_width": 221, + "min_height": 290, + "max_height": 290, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 3, - "height_swing": 1, - "bottom_swing": 6, - "battle_min_width_px": 38.8, - "battle_max_width_px": 39.3, - "battle_min_height_px": 44.7, - "battle_max_height_px": 44.9, - "status": "border-hits=32" + "width_swing": 39, + "height_swing": 0, + "bottom_swing": 0, + "battle_min_width_px": 29.1, + "battle_max_width_px": 35.3, + "battle_min_height_px": 46.3, + "battle_max_height_px": 46.3, + "status": "ok" }, "actions": { "key": "unit-fa-zheng-actions", @@ -110,23 +110,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4453376, - "border_hits": 98, - "min_width": 220, - "max_width": 255, - "min_height": 275, - "max_height": 281, - "min_bottom": 274, - "max_bottom": 289, + "opaque_pixels": 5507911, + "border_hits": 0, + "min_width": 183, + "max_width": 244, + "min_height": 270, + "max_height": 290, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 35, - "height_swing": 6, - "bottom_swing": 15, - "battle_min_width_px": 35.1, - "battle_max_width_px": 40.7, - "battle_min_height_px": 43.9, - "battle_max_height_px": 44.9, - "status": "border-hits=98" + "width_swing": 61, + "height_swing": 20, + "bottom_swing": 0, + "battle_min_width_px": 29.2, + "battle_max_width_px": 39.0, + "battle_min_height_px": 43.1, + "battle_max_height_px": 46.3, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index c482abd..f83e16c 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 73 -- queued-rework: 18 +- approved-baseline: 74 +- queued-rework: 17 ## Batch Plan @@ -53,7 +53,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch | stage | stem | base | actions | base bbox | action bbox | battle base px | motion swing | | --- | --- | --- | --- | --- | --- | --- | --- | --- | | batch7-unique-officer | approved-baseline | `unit-cao-cao` | ok | ok | 206..228 x 290..296 | 186..252 x 270..296 | 32.9..36.4 x 46.3..47.3 | w22 h6 b0 | -| batch7-unique-officer | queued-rework | `unit-fa-zheng` | border-hits=32 | border-hits=98 | 243..246 x 280..281 | 220..255 x 275..281 | 38.8..39.3 x 44.7..44.9 | w3 h1 b6 | +| batch7-unique-officer | approved-baseline | `unit-fa-zheng` | ok | ok | 182..221 x 290..290 | 183..244 x 270..290 | 29.1..35.3 x 46.3..46.3 | w39 h0 b0 | | batch7-unique-officer | queued-rework | `unit-gong-zhi` | border-hits=32 | border-hits=82 | 200..254 x 279..279 | 200..263 x 275..279 | 31.9..40.6 x 44.6..44.6 | w54 h0 b6 | | batch1-approved-core | approved-baseline | `unit-guan-yu` | ok | ok | 190..270 x 276..291 | 172..296 x 171..289 | 30.4..43.1 x 44.1..46.5 | w80 h15 b4 | | batch7-unique-officer | queued-rework | `unit-huang-quan` | border-hits=32 | border-hits=82 | 200..254 x 279..279 | 200..263 x 275..279 | 31.9..40.6 x 44.6..44.6 | w54 h0 b6 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index 280ff5d..ef9f6c7 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -12,6 +12,7 @@ }, "approvedBaseline": [ "unit-cao-cao", + "unit-fa-zheng", "unit-guan-yu", "unit-liu-bei", "unit-meng-huo", diff --git a/src/assets/images/units/unit-fa-zheng-actions.png b/src/assets/images/units/unit-fa-zheng-actions.png index f8787f9..044227c 100644 Binary files a/src/assets/images/units/unit-fa-zheng-actions.png and b/src/assets/images/units/unit-fa-zheng-actions.png differ diff --git a/src/assets/images/units/unit-fa-zheng.png b/src/assets/images/units/unit-fa-zheng.png index bbf57ed..7c8d936 100644 Binary files a/src/assets/images/units/unit-fa-zheng.png and b/src/assets/images/units/unit-fa-zheng.png differ