diff --git a/docs/handpaint-batch2-shu-officer-council-source-v2.png b/docs/handpaint-batch2-shu-officer-council-source-v2.png new file mode 100644 index 0000000..cb4d3b0 Binary files /dev/null and b/docs/handpaint-batch2-shu-officer-council-source-v2.png differ diff --git a/docs/handpaint-batch2-shu-officer-council-v2-animation.gif b/docs/handpaint-batch2-shu-officer-council-v2-animation.gif new file mode 100644 index 0000000..2b8cba8 Binary files /dev/null and b/docs/handpaint-batch2-shu-officer-council-v2-animation.gif differ diff --git a/docs/handpaint-batch2-shu-officer-council-v2-battle-composite.png b/docs/handpaint-batch2-shu-officer-council-v2-battle-composite.png new file mode 100644 index 0000000..fca7dc9 Binary files /dev/null and b/docs/handpaint-batch2-shu-officer-council-v2-battle-composite.png differ diff --git a/docs/handpaint-batch2-shu-officer-council-v2-before-after.png b/docs/handpaint-batch2-shu-officer-council-v2-before-after.png new file mode 100644 index 0000000..269f303 Binary files /dev/null and b/docs/handpaint-batch2-shu-officer-council-v2-before-after.png differ diff --git a/docs/handpaint-batch2-shu-officer-council-v2-contact.png b/docs/handpaint-batch2-shu-officer-council-v2-contact.png new file mode 100644 index 0000000..2597736 Binary files /dev/null and b/docs/handpaint-batch2-shu-officer-council-v2-contact.png differ diff --git a/docs/handpaint-batch2-shu-officer-council-v2-debug-preview-battle-check.png b/docs/handpaint-batch2-shu-officer-council-v2-debug-preview-battle-check.png new file mode 100644 index 0000000..2d6e98f Binary files /dev/null and b/docs/handpaint-batch2-shu-officer-council-v2-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch2-shu-officer-council-v2-report.md b/docs/handpaint-batch2-shu-officer-council-v2-report.md new file mode 100644 index 0000000..bb3726d --- /dev/null +++ b/docs/handpaint-batch2-shu-officer-council-v2-report.md @@ -0,0 +1,24 @@ +# Shu Officer Council Hand-Painted v2 + +- source: `handpaint-batch2-shu-officer-council-source-v2.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 1892776 +- action partial alpha: 0, opaque pixels: 4500233 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 147..205 +- base bbox height range: 288..295 +- base bottom range: 303..303 +- action bbox width range: 147..286 +- action bbox height range: 276..295 +- action bottom range: 303..303 +- contact: `handpaint-batch2-shu-officer-council-v2-contact.png` +- animation: `handpaint-batch2-shu-officer-council-v2-animation.gif` +- before/after: `handpaint-batch2-shu-officer-council-v2-before-after.png` +- scale compare: `handpaint-batch2-shu-officer-council-v2-scale-compare.png` +- battle composite: `handpaint-batch2-shu-officer-council-v2-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch2-shu-officer-council-v2-scale-compare.png b/docs/handpaint-batch2-shu-officer-council-v2-scale-compare.png new file mode 100644 index 0000000..02ef2e2 Binary files /dev/null and b/docs/handpaint-batch2-shu-officer-council-v2-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index 972ba51..d991866 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 44 +- Approved baseline units: 45 - Pending approval units: 0 -- Queued rework units: 47 +- Queued rework units: 46 ## Checked Rules diff --git a/docs/unit-sprite-batch-queue.json b/docs/unit-sprite-batch-queue.json index d8f36fb..392cb6b 100644 --- a/docs/unit-sprite-batch-queue.json +++ b/docs/unit-sprite-batch-queue.json @@ -34,6 +34,7 @@ "unit-shu-infantry-banner", "unit-shu-infantry-guard", "unit-shu-officer", + "unit-shu-officer-council", "unit-shu-spearman", "unit-shu-strategist", "unit-wei-archer", @@ -51,8 +52,8 @@ "pendingApproval": [], "nextAfterApproval": [], "stageCounts": { - "approved-baseline": 44, - "queued-rework": 47 + "approved-baseline": 45, + "queued-rework": 46 }, "batches": [ { @@ -164,24 +165,10 @@ "label": "Batch 2 Shu generic units", "total": 18, "stageCounts": { - "approved-baseline": 12, - "queued-rework": 6 + "approved-baseline": 13, + "queued-rework": 5 }, "units": [ - { - "stem": "unit-shu-officer-council", - "reviewStage": "queued-rework", - "queueRole": "queued rework", - "baseStatus": "border-hits=32", - "actionStatus": "border-hits=82", - "battleBasePx": [ - 31.9, - 40.6, - 44.6, - 44.6 - ], - "spec": null - }, { "stem": "unit-shu-officer-vanguard", "reviewStage": "queued-rework", @@ -392,6 +379,20 @@ ], "spec": "unit-sprite-batch2-shu-officer-spec.md" }, + { + "stem": "unit-shu-officer-council", + "reviewStage": "approved-baseline", + "queueRole": "approved reference", + "baseStatus": "ok", + "actionStatus": "ok", + "battleBasePx": [ + 23.5, + 32.7, + 46.0, + 47.1 + ], + "spec": null + }, { "stem": "unit-shu-spearman", "reviewStage": "approved-baseline", diff --git a/docs/unit-sprite-batch-queue.md b/docs/unit-sprite-batch-queue.md index 537713a..afabaa6 100644 --- a/docs/unit-sprite-batch-queue.md +++ b/docs/unit-sprite-batch-queue.md @@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i ## Current State -- Approved baseline units: 44 +- Approved baseline units: 45 - Pending approval units: 0 -- Queued rework units: 47 +- Queued rework units: 46 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` @@ -46,11 +46,10 @@ No next unit is currently defined. - Batch key: `batch2-shu` - Total units: 18 -- Stage counts: approved-baseline 12, queued-rework 6 +- Stage counts: approved-baseline 13, queued-rework 5 | unit | role | stage | status | battle base px | spec | | --- | --- | --- | --- | --- | --- | -| `unit-shu-officer-council` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 31.9..40.6 x 44.6..44.6 | | | `unit-shu-officer-vanguard` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 33.2..41.2 x 45.0..46.0 | | | `unit-shu-spearman-guard` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 32.3..41.2 x 45.0..46.0 | | | `unit-shu-spearman-veteran` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 32.3..41.2 x 45.0..46.0 | | @@ -66,6 +65,7 @@ No next unit is currently defined. | `unit-shu-infantry-banner` | approved reference | approved-baseline | technical ok | 28.8..32.9 x 44.2..47.1 | | | `unit-shu-infantry-guard` | approved reference | approved-baseline | technical ok | 27.3..32.1 x 46.0..47.1 | | | `unit-shu-officer` | approved reference | approved-baseline | technical ok | 25.7..32.9 x 46.0..47.1 | `unit-sprite-batch2-shu-officer-spec.md` | +| `unit-shu-officer-council` | approved reference | approved-baseline | technical ok | 23.5..32.7 x 46.0..47.1 | | | `unit-shu-spearman` | approved reference | approved-baseline | technical ok | 23.3..42.0 x 43.8..46.3 | `unit-sprite-batch2-shu-spearman-spec.md` | | `unit-shu-strategist` | approved reference | approved-baseline | technical ok | 24.9..34.2 x 45.0..46.8 | `unit-sprite-batch2-shu-strategist-spec.md` | diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index 6132799..9ab723b 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index b3f39e3..c0155f4 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 44 +- Approved baseline units: 45 - Pending approval units: 0 -- Queued rework units: 47 +- Queued rework units: 46 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index f128a2c..78f8520 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch2-shu.png b/docs/unit-sprite-review-batch2-shu.png index 4fe2fc9..94e5b2c 100644 Binary files a/docs/unit-sprite-review-batch2-shu.png and b/docs/unit-sprite-review-batch2-shu.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index 296d0a9..27e8115 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index b8be96b..92939f5 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 44, - "queued-rework": 47 + "approved-baseline": 45, + "queued-rework": 46 }, "rows": [ { @@ -2525,7 +2525,7 @@ }, { "batch": "batch2-shu", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-shu-officer-council", "base": { "key": "unit-shu-officer-council", @@ -2535,23 +2535,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 1985543, - "border_hits": 32, - "min_width": 200, - "max_width": 254, - "min_height": 279, - "max_height": 279, - "min_bottom": 281, - "max_bottom": 287, + "opaque_pixels": 1892776, + "border_hits": 0, + "min_width": 147, + "max_width": 205, + "min_height": 288, + "max_height": 295, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 54, - "height_swing": 0, - "bottom_swing": 6, - "battle_min_width_px": 31.9, - "battle_max_width_px": 40.6, - "battle_min_height_px": 44.6, - "battle_max_height_px": 44.6, - "status": "border-hits=32" + "width_swing": 58, + "height_swing": 7, + "bottom_swing": 0, + "battle_min_width_px": 23.5, + "battle_max_width_px": 32.7, + "battle_min_height_px": 46.0, + "battle_max_height_px": 47.1, + "status": "ok" }, "actions": { "key": "unit-shu-officer-council-actions", @@ -2561,23 +2561,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4453784, - "border_hits": 82, - "min_width": 200, - "max_width": 263, - "min_height": 275, - "max_height": 279, - "min_bottom": 274, - "max_bottom": 289, + "opaque_pixels": 4500233, + "border_hits": 0, + "min_width": 147, + "max_width": 286, + "min_height": 276, + "max_height": 295, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 63, - "height_swing": 4, - "bottom_swing": 15, - "battle_min_width_px": 31.9, - "battle_max_width_px": 42.0, - "battle_min_height_px": 43.9, - "battle_max_height_px": 44.6, - "status": "border-hits=82" + "width_swing": 139, + "height_swing": 19, + "bottom_swing": 0, + "battle_min_width_px": 23.5, + "battle_max_width_px": 45.7, + "battle_min_height_px": 44.1, + "battle_max_height_px": 47.1, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index c57158b..8e44746 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 44 -- queued-rework: 47 +- approved-baseline: 45 +- queued-rework: 46 ## Batch Plan @@ -96,7 +96,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch2-shu | approved-baseline | `unit-shu-infantry-banner` | ok | ok | 180..206 x 277..295 | 180..300 x 277..295 | 28.8..32.9 x 44.2..47.1 | w26 h18 b0 | | batch2-shu | approved-baseline | `unit-shu-infantry-guard` | ok | ok | 171..201 x 288..295 | 171..261 x 276..295 | 27.3..32.1 x 46.0..47.1 | w30 h7 b0 | | batch2-shu | approved-baseline | `unit-shu-officer` | ok | ok | 161..206 x 288..295 | 161..238 x 282..295 | 25.7..32.9 x 46.0..47.1 | w45 h7 b0 | -| batch2-shu | queued-rework | `unit-shu-officer-council` | border-hits=32 | border-hits=82 | 200..254 x 279..279 | 200..263 x 275..279 | 31.9..40.6 x 44.6..44.6 | w54 h0 b6 | +| batch2-shu | approved-baseline | `unit-shu-officer-council` | ok | ok | 147..205 x 288..295 | 147..286 x 276..295 | 23.5..32.7 x 46.0..47.1 | w58 h7 b0 | | batch2-shu | queued-rework | `unit-shu-officer-vanguard` | border-hits=64 | border-hits=144 | 208..258 x 282..288 | 208..267 x 275..290 | 33.2..41.2 x 45.0..46.0 | w50 h6 b6 | | batch2-shu | approved-baseline | `unit-shu-spearman` | ok | ok | 146..263 x 274..290 | 146..276 x 280..295 | 23.3..42.0 x 43.8..46.3 | w117 h16 b0 | | batch2-shu | queued-rework | `unit-shu-spearman-guard` | border-hits=64 | border-hits=144 | 202..258 x 282..288 | 202..267 x 275..290 | 32.3..41.2 x 45.0..46.0 | w56 h6 b6 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index 9b6b1c3..cf96b73 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -42,6 +42,7 @@ "unit-shu-infantry-banner", "unit-shu-infantry-guard", "unit-shu-officer", + "unit-shu-officer-council", "unit-shu-spearman", "unit-shu-strategist", "unit-wei-archer", diff --git a/docs/unit-sprite-shu-officer-council-v2-approval-packet.md b/docs/unit-sprite-shu-officer-council-v2-approval-packet.md new file mode 100644 index 0000000..961fa7a --- /dev/null +++ b/docs/unit-sprite-shu-officer-council-v2-approval-packet.md @@ -0,0 +1,36 @@ +# Unit Sprite Approval Packet: unit-shu-officer-council v2 + +- Status: approved during continuous production run +- Source art: `docs/handpaint-batch2-shu-officer-council-source-v2.png` +- Contact sheet: `docs/handpaint-batch2-shu-officer-council-v2-contact.png` +- Animation GIF: `docs/handpaint-batch2-shu-officer-council-v2-animation.gif` +- Before/after: `docs/handpaint-batch2-shu-officer-council-v2-before-after.png` +- Scale compare: `docs/handpaint-batch2-shu-officer-council-v2-scale-compare.png` +- Browser check: `docs/handpaint-batch2-shu-officer-council-v2-debug-preview-battle-check.png` +- Current approval board: `docs/unit-sprite-current-approval-board.png` +- Debug preview URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-shu-officer-council&v=shu-officer-council-v2-console-clean` + +## Visual Decision + +Shu officer council v2 is accepted as a battlefield council officer. The command tablet, refined armor, and green cloak distinguish it from the robed strategist while staying less heroic than named officers. + +## Technical Checks + +- Base partial alpha: `0` +- Action partial alpha: `0` +- Base frame border hits: `0` +- Action frame border hits: `0` +- Base empty frames: `0` +- Action empty frames: `0` +- Base bbox width range: `147..205` +- Base bbox height range: `288..295` +- Base bottom range: `303..303` +- Action bbox width range: `147..286` +- Action bbox height range: `276..295` +- Action bottom range: `303..303` +- Local build: `passed` +- Local browser console errors: `0` + +## Notes + +v2 widens the v1 silhouette just enough for the 50px tactical map. The unit remains compact, opaque, and visually distinct from both shield infantry and robe-based strategist units. diff --git a/src/assets/images/units/unit-shu-officer-council-actions.png b/src/assets/images/units/unit-shu-officer-council-actions.png index 74501a4..16a1c76 100644 Binary files a/src/assets/images/units/unit-shu-officer-council-actions.png and b/src/assets/images/units/unit-shu-officer-council-actions.png differ diff --git a/src/assets/images/units/unit-shu-officer-council.png b/src/assets/images/units/unit-shu-officer-council.png index 9d7af18..dc7c8b2 100644 Binary files a/src/assets/images/units/unit-shu-officer-council.png and b/src/assets/images/units/unit-shu-officer-council.png differ