diff --git a/docs/handpaint-batch7-pang-tong-source-v1.png b/docs/handpaint-batch7-pang-tong-source-v1.png new file mode 100644 index 0000000..21312c9 Binary files /dev/null and b/docs/handpaint-batch7-pang-tong-source-v1.png differ diff --git a/docs/handpaint-batch7-pang-tong-v2-animation.gif b/docs/handpaint-batch7-pang-tong-v2-animation.gif new file mode 100644 index 0000000..a584bd1 Binary files /dev/null and b/docs/handpaint-batch7-pang-tong-v2-animation.gif differ diff --git a/docs/handpaint-batch7-pang-tong-v2-battle-composite.png b/docs/handpaint-batch7-pang-tong-v2-battle-composite.png new file mode 100644 index 0000000..9df625e Binary files /dev/null and b/docs/handpaint-batch7-pang-tong-v2-battle-composite.png differ diff --git a/docs/handpaint-batch7-pang-tong-v2-before-after.png b/docs/handpaint-batch7-pang-tong-v2-before-after.png new file mode 100644 index 0000000..aeb5515 Binary files /dev/null and b/docs/handpaint-batch7-pang-tong-v2-before-after.png differ diff --git a/docs/handpaint-batch7-pang-tong-v2-contact.png b/docs/handpaint-batch7-pang-tong-v2-contact.png new file mode 100644 index 0000000..cdc3a2f Binary files /dev/null and b/docs/handpaint-batch7-pang-tong-v2-contact.png differ diff --git a/docs/handpaint-batch7-pang-tong-v2-debug-preview-battle-check.png b/docs/handpaint-batch7-pang-tong-v2-debug-preview-battle-check.png new file mode 100644 index 0000000..6941654 Binary files /dev/null and b/docs/handpaint-batch7-pang-tong-v2-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch7-pang-tong-v2-report.md b/docs/handpaint-batch7-pang-tong-v2-report.md new file mode 100644 index 0000000..d1a165c --- /dev/null +++ b/docs/handpaint-batch7-pang-tong-v2-report.md @@ -0,0 +1,24 @@ +# Pang Tong hand-painted v2 report + +- source: `handpaint-batch7-pang-tong-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 2067632 +- action partial alpha: 0, opaque pixels: 5101099 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 175..201 +- base bbox height range: 288..288 +- base bottom range: 303..303 +- action bbox width range: 164..273 +- action bbox height range: 286..290 +- action bottom range: 303..303 +- contact: `handpaint-batch7-pang-tong-v2-contact.png` +- animation: `handpaint-batch7-pang-tong-v2-animation.gif` +- before/after: `handpaint-batch7-pang-tong-v2-before-after.png` +- scale compare: `handpaint-batch7-pang-tong-v2-scale-compare.png` +- battle composite: `handpaint-batch7-pang-tong-v2-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch7-pang-tong-v2-scale-compare.png b/docs/handpaint-batch7-pang-tong-v2-scale-compare.png new file mode 100644 index 0000000..f297103 Binary files /dev/null and b/docs/handpaint-batch7-pang-tong-v2-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index 023b4de..f2053e4 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 84 +- Approved baseline units: 85 - Pending approval units: 0 -- Queued rework units: 7 +- Queued rework units: 6 ## Checked Rules diff --git a/docs/unit-sprite-batch-queue.json b/docs/unit-sprite-batch-queue.json index f4e7ec1..980501f 100644 --- a/docs/unit-sprite-batch-queue.json +++ b/docs/unit-sprite-batch-queue.json @@ -27,6 +27,7 @@ "unit-nanman-shaman", "unit-nanman-shaman-ember", "unit-nanman-shaman-storm", + "unit-pang-tong", "unit-rebel", "unit-rebel-archer", "unit-rebel-archer-fire", @@ -91,8 +92,8 @@ "pendingApproval": [], "nextAfterApproval": [], "stageCounts": { - "approved-baseline": 84, - "queued-rework": 7 + "approved-baseline": 85, + "queued-rework": 6 }, "batches": [ { @@ -1178,24 +1179,10 @@ "label": "Batch 7 unique officers", "total": 19, "stageCounts": { - "approved-baseline": 12, - "queued-rework": 7 + "approved-baseline": 13, + "queued-rework": 6 }, "units": [ - { - "stem": "unit-pang-tong", - "reviewStage": "queued-rework", - "queueRole": "queued rework", - "baseStatus": "border-hits=32", - "actionStatus": "border-hits=98", - "battleBasePx": [ - 38.8, - 39.3, - 44.7, - 44.9 - ], - "spec": null - }, { "stem": "unit-sima-yi", "reviewStage": "queued-rework", @@ -1447,6 +1434,20 @@ 46.3 ], "spec": null + }, + { + "stem": "unit-pang-tong", + "reviewStage": "approved-baseline", + "queueRole": "approved reference", + "baseStatus": "ok", + "actionStatus": "ok", + "battleBasePx": [ + 28.0, + 32.1, + 46.0, + 46.0 + ], + "spec": null } ] } diff --git a/docs/unit-sprite-batch-queue.md b/docs/unit-sprite-batch-queue.md index 4c43467..6f2a6d0 100644 --- a/docs/unit-sprite-batch-queue.md +++ b/docs/unit-sprite-batch-queue.md @@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i ## Current State -- Approved baseline units: 84 +- Approved baseline units: 85 - Pending approval units: 0 -- Queued rework units: 7 +- Queued rework units: 6 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` @@ -157,11 +157,10 @@ No next unit is currently defined. - Batch key: `batch7-unique-officer` - Total units: 19 -- Stage counts: approved-baseline 12, queued-rework 7 +- Stage counts: approved-baseline 13, queued-rework 6 | unit | role | stage | status | battle base px | spec | | --- | --- | --- | --- | --- | --- | -| `unit-pang-tong` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | | `unit-sima-yi` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | | `unit-wang-ping` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 31.9..40.6 x 44.6..44.6 | | | `unit-yan-yan` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 31.0..40.6 x 44.6..44.6 | | @@ -180,3 +179,4 @@ No next unit is currently defined. | `unit-ma-chao` | approved reference | approved-baseline | technical ok | 26.5..42.0 x 46.0..47.3 | | | `unit-ma-dai` | approved reference | approved-baseline | technical ok | 27.0..39.8 x 46.0..46.3 | | | `unit-ma-liang` | approved reference | approved-baseline | technical ok | 25.6..38.8 x 46.3..46.3 | | +| `unit-pang-tong` | approved reference | approved-baseline | technical ok | 28.0..32.1 x 46.0..46.0 | | diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index cd84b18..3bc67bc 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index adb5902..4982623 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 84 +- Approved baseline units: 85 - Pending approval units: 0 -- Queued rework units: 7 +- Queued rework units: 6 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. diff --git a/docs/unit-sprite-pang-tong-v2-approval-packet.md b/docs/unit-sprite-pang-tong-v2-approval-packet.md new file mode 100644 index 0000000..2cd902d --- /dev/null +++ b/docs/unit-sprite-pang-tong-v2-approval-packet.md @@ -0,0 +1,35 @@ +# Pang Tong hand-painted v2 approval packet + +- unit: `unit-pang-tong` +- candidate: `handpaint-batch7-pang-tong-v2` +- source: `docs/handpaint-batch7-pang-tong-source-v1.png` +- contact sheet: `docs/handpaint-batch7-pang-tong-v2-contact.png` +- animation: `docs/handpaint-batch7-pang-tong-v2-animation.gif` +- before/after: `docs/handpaint-batch7-pang-tong-v2-before-after.png` +- battle composite: `docs/handpaint-batch7-pang-tong-v2-battle-composite.png` +- current approval board: `docs/unit-sprite-current-approval-board.png` +- browser check: `docs/handpaint-batch7-pang-tong-v2-debug-preview-battle-check.png` + +## Result + +- Local build: `pnpm build` passed. +- Local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-pang-tong&v=pang-tong-v2` +- Local browser console errors: `0` +- Local browser 404s: `0` +- Sample gate: passed. + +## Sprite safety + +- base partial alpha: 0 +- action partial alpha: 0 +- base frame border hits: 0 +- action frame border hits: 0 +- base battle size: 28.0..32.1 x 46.0..46.0 +- frame bbox width: 175..201 base, 164..273 action +- frame bbox height: 288 base, 286..290 action + +## Visual notes + +- v1 art direction was strong but too narrow beside the approved batch 7 strategist silhouettes. +- v2 widens the robe silhouette so Pang Tong reads clearly at 50px battle scale without adding rings, bases, or external visibility aids. +- Dark charcoal robe, bronze trim, feather crest, fan, and scroll separate him from Ma Liang's white-robed strategist read. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index 4f10cdf..cf8410b 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch7-unique-officer.png b/docs/unit-sprite-review-batch7-unique-officer.png index 724e3c4..d894525 100644 Binary files a/docs/unit-sprite-review-batch7-unique-officer.png and b/docs/unit-sprite-review-batch7-unique-officer.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index ef403a2..472991a 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index 5ddb88b..07fcd1a 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 84, - "queued-rework": 7 + "approved-baseline": 85, + "queued-rework": 6 }, "rows": [ { @@ -1385,7 +1385,7 @@ }, { "batch": "batch7-unique-officer", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-pang-tong", "base": { "key": "unit-pang-tong", @@ -1395,23 +1395,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 1999925, - "border_hits": 32, - "min_width": 243, - "max_width": 246, - "min_height": 280, - "max_height": 281, - "min_bottom": 281, - "max_bottom": 287, + "opaque_pixels": 2067632, + "border_hits": 0, + "min_width": 175, + "max_width": 201, + "min_height": 288, + "max_height": 288, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 3, - "height_swing": 1, - "bottom_swing": 6, - "battle_min_width_px": 38.8, - "battle_max_width_px": 39.3, - "battle_min_height_px": 44.7, - "battle_max_height_px": 44.9, - "status": "border-hits=32" + "width_swing": 26, + "height_swing": 0, + "bottom_swing": 0, + "battle_min_width_px": 28.0, + "battle_max_width_px": 32.1, + "battle_min_height_px": 46.0, + "battle_max_height_px": 46.0, + "status": "ok" }, "actions": { "key": "unit-pang-tong-actions", @@ -1421,23 +1421,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4453376, - "border_hits": 98, - "min_width": 220, - "max_width": 255, - "min_height": 275, - "max_height": 281, - "min_bottom": 274, - "max_bottom": 289, + "opaque_pixels": 5101099, + "border_hits": 0, + "min_width": 164, + "max_width": 273, + "min_height": 286, + "max_height": 290, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 35, - "height_swing": 6, - "bottom_swing": 15, - "battle_min_width_px": 35.1, - "battle_max_width_px": 40.7, - "battle_min_height_px": 43.9, - "battle_max_height_px": 44.9, - "status": "border-hits=98" + "width_swing": 109, + "height_swing": 4, + "bottom_swing": 0, + "battle_min_width_px": 26.2, + "battle_max_width_px": 43.6, + "battle_min_height_px": 45.7, + "battle_max_height_px": 46.3, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index 11a69aa..eda080f 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 84 -- queued-rework: 7 +- approved-baseline: 85 +- queued-rework: 6 ## Batch Plan @@ -76,7 +76,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch6-nanman-special | approved-baseline | `unit-nanman-shaman` | ok | ok | 190..214 x 288..288 | 197..263 x 277..290 | 30.4..34.2 x 46.0..46.0 | w24 h0 b0 | | batch6-nanman-special | approved-baseline | `unit-nanman-shaman-ember` | ok | ok | 180..212 x 288..290 | 180..242 x 264..290 | 28.8..33.9 x 46.0..46.3 | w32 h2 b0 | | batch6-nanman-special | approved-baseline | `unit-nanman-shaman-storm` | ok | ok | 195..223 x 286..290 | 195..245 x 240..290 | 31.2..35.6 x 45.7..46.3 | w28 h4 b0 | -| batch7-unique-officer | queued-rework | `unit-pang-tong` | border-hits=32 | border-hits=98 | 243..246 x 280..281 | 220..255 x 275..281 | 38.8..39.3 x 44.7..44.9 | w3 h1 b6 | +| batch7-unique-officer | approved-baseline | `unit-pang-tong` | ok | ok | 175..201 x 288..288 | 164..273 x 286..290 | 28.0..32.1 x 46.0..46.0 | w26 h0 b0 | | batch1-approved-rebel | approved-baseline | `unit-rebel` | ok | ok | 195..284 x 271..281 | 180..286 x 178..289 | 31.2..45.4 x 43.3..44.9 | w89 h10 b8 | | batch1-approved-rebel | approved-baseline | `unit-rebel-archer` | ok | ok | 185..263 x 272..278 | 116..284 x 228..288 | 29.6..42.0 x 43.5..44.4 | w78 h6 b1 | | batch5-rebel-other | approved-baseline | `unit-rebel-archer-fire` | ok | ok | 161..249 x 288..295 | 161..252 x 285..295 | 25.7..39.8 x 46.0..47.1 | w88 h7 b0 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index b3d7203..e775f46 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -35,6 +35,7 @@ "unit-nanman-shaman", "unit-nanman-shaman-ember", "unit-nanman-shaman-storm", + "unit-pang-tong", "unit-rebel", "unit-rebel-archer", "unit-rebel-archer-fire", diff --git a/src/assets/images/units/unit-pang-tong-actions.png b/src/assets/images/units/unit-pang-tong-actions.png index f8787f9..5cae52d 100644 Binary files a/src/assets/images/units/unit-pang-tong-actions.png and b/src/assets/images/units/unit-pang-tong-actions.png differ diff --git a/src/assets/images/units/unit-pang-tong.png b/src/assets/images/units/unit-pang-tong.png index bbf57ed..57e8e5f 100644 Binary files a/src/assets/images/units/unit-pang-tong.png and b/src/assets/images/units/unit-pang-tong.png differ