diff --git a/docs/handpaint-batch3-wei-yan-source-v2.png b/docs/handpaint-batch3-wei-yan-source-v2.png new file mode 100644 index 0000000..615f038 Binary files /dev/null and b/docs/handpaint-batch3-wei-yan-source-v2.png differ diff --git a/docs/handpaint-batch3-wei-yan-v3-animation.gif b/docs/handpaint-batch3-wei-yan-v3-animation.gif new file mode 100644 index 0000000..3c4d9f5 Binary files /dev/null and b/docs/handpaint-batch3-wei-yan-v3-animation.gif differ diff --git a/docs/handpaint-batch3-wei-yan-v3-battle-composite.png b/docs/handpaint-batch3-wei-yan-v3-battle-composite.png new file mode 100644 index 0000000..2550a9c Binary files /dev/null and b/docs/handpaint-batch3-wei-yan-v3-battle-composite.png differ diff --git a/docs/handpaint-batch3-wei-yan-v3-before-after.png b/docs/handpaint-batch3-wei-yan-v3-before-after.png new file mode 100644 index 0000000..7068ffc Binary files /dev/null and b/docs/handpaint-batch3-wei-yan-v3-before-after.png differ diff --git a/docs/handpaint-batch3-wei-yan-v3-contact.png b/docs/handpaint-batch3-wei-yan-v3-contact.png new file mode 100644 index 0000000..a60886b Binary files /dev/null and b/docs/handpaint-batch3-wei-yan-v3-contact.png differ diff --git a/docs/handpaint-batch3-wei-yan-v3-debug-preview-battle-check.png b/docs/handpaint-batch3-wei-yan-v3-debug-preview-battle-check.png new file mode 100644 index 0000000..8c7eefa Binary files /dev/null and b/docs/handpaint-batch3-wei-yan-v3-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch3-wei-yan-v3-report.md b/docs/handpaint-batch3-wei-yan-v3-report.md new file mode 100644 index 0000000..00ca30c --- /dev/null +++ b/docs/handpaint-batch3-wei-yan-v3-report.md @@ -0,0 +1,24 @@ +# Wei Yan v3 sprite report + +- source: `handpaint-batch3-wei-yan-source-v2.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 1734060 +- action partial alpha: 0, opaque pixels: 4731457 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 173..219 +- base bbox height range: 277..290 +- base bottom range: 303..303 +- action bbox width range: 173..264 +- action bbox height range: 232..290 +- action bottom range: 303..303 +- contact: `handpaint-batch3-wei-yan-v3-contact.png` +- animation: `handpaint-batch3-wei-yan-v3-animation.gif` +- before/after: `handpaint-batch3-wei-yan-v3-before-after.png` +- scale compare: `handpaint-batch3-wei-yan-v3-scale-compare.png` +- battle composite: `handpaint-batch3-wei-yan-v3-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch3-wei-yan-v3-scale-compare.png b/docs/handpaint-batch3-wei-yan-v3-scale-compare.png new file mode 100644 index 0000000..66c045a Binary files /dev/null and b/docs/handpaint-batch3-wei-yan-v3-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index 39b8968..9699385 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 60 +- Approved baseline units: 61 - Pending approval units: 0 -- Queued rework units: 31 +- Queued rework units: 30 ## Checked Rules diff --git a/docs/unit-sprite-batch-queue.json b/docs/unit-sprite-batch-queue.json index ab31b15..8bbcab6 100644 --- a/docs/unit-sprite-batch-queue.json +++ b/docs/unit-sprite-batch-queue.json @@ -57,6 +57,7 @@ "unit-wei-strategist", "unit-wei-strategist-black", "unit-wei-strategist-blue", + "unit-wei-yan", "unit-wu-archer", "unit-wu-cavalry", "unit-wu-infantry", @@ -67,8 +68,8 @@ "pendingApproval": [], "nextAfterApproval": [], "stageCounts": { - "approved-baseline": 60, - "queued-rework": 31 + "approved-baseline": 61, + "queued-rework": 30 }, "batches": [ { @@ -442,24 +443,9 @@ "label": "Batch 3 Wei generic units", "total": 16, "stageCounts": { - "approved-baseline": 15, - "queued-rework": 1 + "approved-baseline": 16 }, "units": [ - { - "stem": "unit-wei-yan", - "reviewStage": "queued-rework", - "queueRole": "queued rework", - "baseStatus": "border-hits=32", - "actionStatus": "border-hits=82", - "battleBasePx": [ - 31.0, - 40.6, - 44.6, - 44.6 - ], - "spec": null - }, { "stem": "unit-wei-archer", "reviewStage": "approved-baseline", @@ -669,6 +655,20 @@ 46.0 ], "spec": null + }, + { + "stem": "unit-wei-yan", + "reviewStage": "approved-baseline", + "queueRole": "approved reference", + "baseStatus": "ok", + "actionStatus": "ok", + "battleBasePx": [ + 27.6, + 35.0, + 44.2, + 46.3 + ], + "spec": null } ] }, diff --git a/docs/unit-sprite-batch-queue.md b/docs/unit-sprite-batch-queue.md index a65d5da..7f71628 100644 --- a/docs/unit-sprite-batch-queue.md +++ b/docs/unit-sprite-batch-queue.md @@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i ## Current State -- Approved baseline units: 60 +- Approved baseline units: 61 - Pending approval units: 0 -- Queued rework units: 31 +- Queued rework units: 30 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` @@ -73,11 +73,10 @@ No next unit is currently defined. - Batch key: `batch3-wei` - Total units: 16 -- Stage counts: approved-baseline 15, queued-rework 1 +- Stage counts: approved-baseline 16 | unit | role | stage | status | battle base px | spec | | --- | --- | --- | --- | --- | --- | -| `unit-wei-yan` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 31.0..40.6 x 44.6..44.6 | | | `unit-wei-archer` | approved reference | approved-baseline | technical ok | 30.4..39.1 x 46.0..47.3 | | | `unit-wei-archer-crossbow` | approved reference | approved-baseline | technical ok | 29.7..36.7 x 46.0..46.3 | | | `unit-wei-archer-veteran` | approved reference | approved-baseline | technical ok | 28.1..36.6 x 44.2..47.1 | | @@ -93,6 +92,7 @@ No next unit is currently defined. | `unit-wei-strategist` | approved reference | approved-baseline | technical ok | 25.6..37.2 x 46.3..46.3 | | | `unit-wei-strategist-black` | approved reference | approved-baseline | technical ok | 23.3..34.0 x 43.1..46.0 | | | `unit-wei-strategist-blue` | approved reference | approved-baseline | technical ok | 26.4..33.5 x 46.0..46.0 | | +| `unit-wei-yan` | approved reference | approved-baseline | technical ok | 27.6..35.0 x 44.2..46.3 | | ### Batch 4 Wu generic units diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index 599ba68..0d47ac3 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index 5c9e9b2..2283b39 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 60 +- Approved baseline units: 61 - Pending approval units: 0 -- Queued rework units: 31 +- Queued rework units: 30 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index 7ca7b49..811f654 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch3-wei.png b/docs/unit-sprite-review-batch3-wei.png index 49bbbf9..81dbcdb 100644 Binary files a/docs/unit-sprite-review-batch3-wei.png and b/docs/unit-sprite-review-batch3-wei.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index 4d80a4e..9d2b494 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index 33885ee..1d9c940 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 60, - "queued-rework": 31 + "approved-baseline": 61, + "queued-rework": 30 }, "rows": [ { @@ -3950,7 +3950,7 @@ }, { "batch": "batch3-wei", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-wei-yan", "base": { "key": "unit-wei-yan", @@ -3960,23 +3960,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 2000768, - "border_hits": 32, - "min_width": 194, - "max_width": 254, - "min_height": 279, - "max_height": 279, - "min_bottom": 281, - "max_bottom": 287, + "opaque_pixels": 1734060, + "border_hits": 0, + "min_width": 173, + "max_width": 219, + "min_height": 277, + "max_height": 290, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 60, - "height_swing": 0, - "bottom_swing": 6, - "battle_min_width_px": 31.0, - "battle_max_width_px": 40.6, - "battle_min_height_px": 44.6, - "battle_max_height_px": 44.6, - "status": "border-hits=32" + "width_swing": 46, + "height_swing": 13, + "bottom_swing": 0, + "battle_min_width_px": 27.6, + "battle_max_width_px": 35.0, + "battle_min_height_px": 44.2, + "battle_max_height_px": 46.3, + "status": "ok" }, "actions": { "key": "unit-wei-yan-actions", @@ -3986,23 +3986,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4471927, - "border_hits": 82, - "min_width": 194, - "max_width": 263, - "min_height": 275, - "max_height": 279, - "min_bottom": 274, - "max_bottom": 289, + "opaque_pixels": 4731457, + "border_hits": 0, + "min_width": 173, + "max_width": 264, + "min_height": 232, + "max_height": 290, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 69, - "height_swing": 4, - "bottom_swing": 15, - "battle_min_width_px": 31.0, - "battle_max_width_px": 42.0, - "battle_min_height_px": 43.9, - "battle_max_height_px": 44.6, - "status": "border-hits=82" + "width_swing": 91, + "height_swing": 58, + "bottom_swing": 0, + "battle_min_width_px": 27.6, + "battle_max_width_px": 42.2, + "battle_min_height_px": 37.1, + "battle_max_height_px": 46.3, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index 178e384..0958d32 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 60 -- queued-rework: 31 +- approved-baseline: 61 +- queued-rework: 30 ## Batch Plan @@ -121,7 +121,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch3-wei | approved-baseline | `unit-wei-strategist` | ok | ok | 160..233 x 290..290 | 160..243 x 288..290 | 25.6..37.2 x 46.3..46.3 | w73 h0 b0 | | batch3-wei | approved-baseline | `unit-wei-strategist-black` | ok | ok | 146..213 x 270..288 | 146..240 x 249..288 | 23.3..34.0 x 43.1..46.0 | w67 h18 b0 | | batch3-wei | approved-baseline | `unit-wei-strategist-blue` | ok | ok | 165..210 x 288..288 | 165..246 x 264..288 | 26.4..33.5 x 46.0..46.0 | w45 h0 b0 | -| batch3-wei | queued-rework | `unit-wei-yan` | border-hits=32 | border-hits=82 | 194..254 x 279..279 | 194..263 x 275..279 | 31.0..40.6 x 44.6..44.6 | w60 h0 b6 | +| batch3-wei | approved-baseline | `unit-wei-yan` | ok | ok | 173..219 x 277..290 | 173..264 x 232..290 | 27.6..35.0 x 44.2..46.3 | w46 h13 b0 | | batch4-wu | approved-baseline | `unit-wu-archer` | ok | ok | 177..215 x 288..288 | 178..242 x 288..288 | 28.3..34.3 x 46.0..46.0 | w38 h0 b0 | | batch4-wu | queued-rework | `unit-wu-archer-naval` | border-hits=64 | border-hits=140 | 245..246 x 279..279 | 220..255 x 275..279 | 39.1..39.3 x 44.6..44.6 | w1 h0 b6 | | batch4-wu | queued-rework | `unit-wu-archer-river` | border-hits=64 | border-hits=140 | 245..246 x 279..279 | 220..255 x 275..279 | 39.1..39.3 x 44.6..44.6 | w1 h0 b6 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index c004c98..898575b 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -65,6 +65,7 @@ "unit-wei-strategist", "unit-wei-strategist-black", "unit-wei-strategist-blue", + "unit-wei-yan", "unit-wu-archer", "unit-wu-cavalry", "unit-wu-infantry", diff --git a/docs/unit-sprite-wei-yan-v3-approval-packet.md b/docs/unit-sprite-wei-yan-v3-approval-packet.md new file mode 100644 index 0000000..21dedd3 --- /dev/null +++ b/docs/unit-sprite-wei-yan-v3-approval-packet.md @@ -0,0 +1,36 @@ +# Wei Yan v3 Approval Packet + +- status: approved during continuous production run +- unit: `unit-wei-yan` +- source art: `handpaint-batch3-wei-yan-source-v2.png` +- contact sheet: `handpaint-batch3-wei-yan-v3-contact.png` +- animation GIF: `handpaint-batch3-wei-yan-v3-animation.gif` +- before/after: `handpaint-batch3-wei-yan-v3-before-after.png` +- scale compare: `handpaint-batch3-wei-yan-v3-scale-compare.png` +- battle composite: `handpaint-batch3-wei-yan-v3-battle-composite.png` +- browser check: `handpaint-batch3-wei-yan-v3-debug-preview-battle-check.png` +- current board: `unit-sprite-current-approval-board.png` +- debug URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-wei-yan&v=wei-yan-v3` + +## Visual Decision + +Approved for the continuous batch run. v3 reads as a distinct fierce vanguard officer: crimson-black armor, rugged cloak strips, and a heavy curved blade. It avoids the green long-weapon Guan Yu silhouette, the bulky Zhang Fei read, and the blue Wei officer family. + +## Technical Checks + +- base status: ok +- action status: ok +- base partial alpha: 0 +- action partial alpha: 0 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- battle scale from sample gate: 27.6..35.0 x 44.2..46.3 +- local build: passed +- Local browser console errors: `0` +- Local browser 404s: `0` + +## Notes + +v1 and v2 were discarded because their side/ready frames produced excessive height swing. v3 is the accepted version after raising the side-frame scale safely within the tile. diff --git a/src/assets/images/units/unit-wei-yan-actions.png b/src/assets/images/units/unit-wei-yan-actions.png index ff565c2..78c65d3 100644 Binary files a/src/assets/images/units/unit-wei-yan-actions.png and b/src/assets/images/units/unit-wei-yan-actions.png differ diff --git a/src/assets/images/units/unit-wei-yan.png b/src/assets/images/units/unit-wei-yan.png index da9cdf8..7b8420e 100644 Binary files a/src/assets/images/units/unit-wei-yan.png and b/src/assets/images/units/unit-wei-yan.png differ