Standardize browser QA at 1920x1080
This commit is contained in:
@@ -62,8 +62,8 @@ Review state manifest: `unit-sprite-rework-manifest.json`.
|
||||
- `python scripts/check-unit-sprite-workflow-consistency.py`
|
||||
- Review the relevant `docs/unit-sprite-review-<batch>.png` by eye.
|
||||
- `pnpm build`
|
||||
- Local PC browser check.
|
||||
- For pending samples, local PC browser check with `?debug&debugSpritePreview=<unit-key>`.
|
||||
- Local PC browser check at an explicit 1920x1080 CSS viewport, 100% browser zoom, and DPR 1, following `docs/desktop-browser-qa-standard.md`.
|
||||
- For pending samples, run the same 1920x1080 CSS viewport, 100% zoom, DPR 1 check with `?debug&debugSpritePreview=<unit-key>`.
|
||||
- Console errors: `0`.
|
||||
- Approval received for the batch before commit/push/deploy.
|
||||
|
||||
@@ -76,7 +76,7 @@ Do not commit, push, or deploy when:
|
||||
- Any newly edited unit is still marked `pending-approval`.
|
||||
- Any untouched unit is accidentally counted as approved because it is only technically `ok`.
|
||||
- The review board shows the new unit is not visibly better than the old placeholder.
|
||||
- The browser check has not been run.
|
||||
- The browser check has not been run at the required 1920x1080 CSS viewport, 100% browser zoom, and DPR 1.
|
||||
- Console errors are present.
|
||||
|
||||
After approval and successful verification:
|
||||
|
||||
Reference in New Issue
Block a user