diff --git a/docs/handpaint-batch5-rebel-leader-source-v1.png b/docs/handpaint-batch5-rebel-leader-source-v1.png new file mode 100644 index 0000000..f81ef0d Binary files /dev/null and b/docs/handpaint-batch5-rebel-leader-source-v1.png differ diff --git a/docs/handpaint-batch5-rebel-leader-v1-animation.gif b/docs/handpaint-batch5-rebel-leader-v1-animation.gif new file mode 100644 index 0000000..b2e3afd Binary files /dev/null and b/docs/handpaint-batch5-rebel-leader-v1-animation.gif differ diff --git a/docs/handpaint-batch5-rebel-leader-v1-battle-composite.png b/docs/handpaint-batch5-rebel-leader-v1-battle-composite.png new file mode 100644 index 0000000..390c404 Binary files /dev/null and b/docs/handpaint-batch5-rebel-leader-v1-battle-composite.png differ diff --git a/docs/handpaint-batch5-rebel-leader-v1-before-after.png b/docs/handpaint-batch5-rebel-leader-v1-before-after.png new file mode 100644 index 0000000..4f0cd71 Binary files /dev/null and b/docs/handpaint-batch5-rebel-leader-v1-before-after.png differ diff --git a/docs/handpaint-batch5-rebel-leader-v1-contact.png b/docs/handpaint-batch5-rebel-leader-v1-contact.png new file mode 100644 index 0000000..be7b476 Binary files /dev/null and b/docs/handpaint-batch5-rebel-leader-v1-contact.png differ diff --git a/docs/handpaint-batch5-rebel-leader-v1-debug-preview-battle-check.png b/docs/handpaint-batch5-rebel-leader-v1-debug-preview-battle-check.png new file mode 100644 index 0000000..e227cd3 Binary files /dev/null and b/docs/handpaint-batch5-rebel-leader-v1-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch5-rebel-leader-v1-report.md b/docs/handpaint-batch5-rebel-leader-v1-report.md new file mode 100644 index 0000000..11174f9 --- /dev/null +++ b/docs/handpaint-batch5-rebel-leader-v1-report.md @@ -0,0 +1,24 @@ +# Rebel Leader Hand-Painted v1 + +- source: `handpaint-batch5-rebel-leader-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 1742158 +- action partial alpha: 0, opaque pixels: 4815119 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 156..203 +- base bbox height range: 288..290 +- base bottom range: 303..303 +- action bbox width range: 150..247 +- action bbox height range: 255..290 +- action bottom range: 303..303 +- contact: `handpaint-batch5-rebel-leader-v1-contact.png` +- animation: `handpaint-batch5-rebel-leader-v1-animation.gif` +- before/after: `handpaint-batch5-rebel-leader-v1-before-after.png` +- scale compare: `handpaint-batch5-rebel-leader-v1-scale-compare.png` +- battle composite: `handpaint-batch5-rebel-leader-v1-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch5-rebel-leader-v1-scale-compare.png b/docs/handpaint-batch5-rebel-leader-v1-scale-compare.png new file mode 100644 index 0000000..3584395 Binary files /dev/null and b/docs/handpaint-batch5-rebel-leader-v1-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index 385fe26..b11984c 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 25 +- Approved baseline units: 26 - Pending approval units: 0 -- Queued rework units: 66 +- Queued rework units: 65 ## Checked Rules diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index f13863b..ce962a6 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index 16acdff..72bd29c 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 25 +- Approved baseline units: 26 - Pending approval units: 0 -- Queued rework units: 66 +- Queued rework units: 65 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. @@ -14,9 +14,8 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Next Unit Queue -1. `unit-rebel-leader` - queued-rework, base `border-hits=32`, actions `border-hits=72` -2. `unit-rebel-leader-warlord` - queued-rework, base `border-hits=32`, actions `border-hits=78` -3. `unit-rebel-ragged` - queued-rework, base `border-hits=32`, actions `border-hits=72` +1. `unit-rebel-leader-warlord` - queued-rework, base `border-hits=32`, actions `border-hits=78` +2. `unit-rebel-ragged` - queued-rework, base `border-hits=32`, actions `border-hits=72` ## Commands Before Approval @@ -43,5 +42,5 @@ pnpm build ## First Task After Current Approval -- Start with `unit-rebel-leader`. +- Start with `unit-rebel-leader-warlord`. - Generate source art, assemble sheets, produce contact/GIF/before-after/scale/battle screenshots, then rerun the gates. diff --git a/docs/unit-sprite-rebel-leader-v1-approval-packet.md b/docs/unit-sprite-rebel-leader-v1-approval-packet.md new file mode 100644 index 0000000..5c2faed --- /dev/null +++ b/docs/unit-sprite-rebel-leader-v1-approval-packet.md @@ -0,0 +1,44 @@ +# Rebel Leader v1 Approval Packet + +- unit: `unit-rebel-leader` +- version: `v1` +- source: `docs/handpaint-batch5-rebel-leader-source-v1.png` +- contact sheet: `docs/handpaint-batch5-rebel-leader-v1-contact.png` +- animation: `docs/handpaint-batch5-rebel-leader-v1-animation.gif` +- battle preview: `docs/handpaint-batch5-rebel-leader-v1-debug-preview-battle-check.png` +- before/after: `docs/handpaint-batch5-rebel-leader-v1-before-after.png` +- scale compare: `docs/handpaint-batch5-rebel-leader-v1-scale-compare.png` +- current approval board: `docs/unit-sprite-current-approval-board.png` + +## Visual Decision + +Approved for the continuous production run. + +- 50px battle readability: pass +- Yellow Turban foot leader identity: pass +- command/saber silhouette: pass +- avoids unique hero or warlord read: pass +- opaque unit body: pass +- frame boundary safety: pass +- idle/action scale stability: pass + +## Technical Checks + +- local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-rebel-leader&v=rebel-leader-v1-final` +- Local browser console errors: `0` +- base partial alpha: `0` +- action partial alpha: `0` +- base frame border hits: `0` +- action frame border hits: `0` +- base empty frames: `0` +- action empty frames: `0` +- base bbox width range: `156..203` +- base bbox height range: `288..290` +- base bottom range: `303..303` +- action bbox width range: `150..247` +- action bbox height range: `255..290` +- action bottom range: `303..303` + +## Notes + +The v1 sheet establishes a mid-tier Yellow Turban foot commander: heavier and more authoritative than a basic rebel, but deliberately less ornate than a unique officer or the upcoming warlord variant. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index d8ab57a..60111d0 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch5-rebel-other.png b/docs/unit-sprite-review-batch5-rebel-other.png index 2f73a0b..07da680 100644 Binary files a/docs/unit-sprite-review-batch5-rebel-other.png and b/docs/unit-sprite-review-batch5-rebel-other.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index 76b1aa5..3412e4f 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index 94a7eff..590288a 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 25, - "queued-rework": 66 + "approved-baseline": 26, + "queued-rework": 65 }, "rows": [ { @@ -1784,7 +1784,7 @@ }, { "batch": "batch5-rebel-other", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-rebel-leader", "base": { "key": "unit-rebel-leader", @@ -1794,23 +1794,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 1982634, - "border_hits": 32, - "min_width": 200, - "max_width": 254, - "min_height": 266, - "max_height": 266, - "min_bottom": 281, - "max_bottom": 287, + "opaque_pixels": 1742158, + "border_hits": 0, + "min_width": 156, + "max_width": 203, + "min_height": 288, + "max_height": 290, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 54, - "height_swing": 0, - "bottom_swing": 6, - "battle_min_width_px": 31.9, - "battle_max_width_px": 40.6, - "battle_min_height_px": 42.5, - "battle_max_height_px": 42.5, - "status": "border-hits=32" + "width_swing": 47, + "height_swing": 2, + "bottom_swing": 0, + "battle_min_width_px": 24.9, + "battle_max_width_px": 32.4, + "battle_min_height_px": 46.0, + "battle_max_height_px": 46.3, + "status": "ok" }, "actions": { "key": "unit-rebel-leader-actions", @@ -1820,23 +1820,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4448389, - "border_hits": 72, - "min_width": 200, - "max_width": 263, - "min_height": 265, - "max_height": 266, - "min_bottom": 274, - "max_bottom": 289, + "opaque_pixels": 4815119, + "border_hits": 0, + "min_width": 150, + "max_width": 247, + "min_height": 255, + "max_height": 290, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 63, - "height_swing": 1, - "bottom_swing": 15, - "battle_min_width_px": 31.9, - "battle_max_width_px": 42.0, - "battle_min_height_px": 42.3, - "battle_max_height_px": 42.5, - "status": "border-hits=72" + "width_swing": 97, + "height_swing": 35, + "bottom_swing": 0, + "battle_min_width_px": 24.0, + "battle_max_width_px": 39.5, + "battle_min_height_px": 40.7, + "battle_max_height_px": 46.3, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index 1c85af6..58846c7 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 25 -- queued-rework: 66 +- approved-baseline: 26 +- queued-rework: 65 ## Batch Plan @@ -83,7 +83,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch5-rebel-other | approved-baseline | `unit-rebel-archer-veteran` | ok | ok | 182..233 x 286..290 | 162..243 x 224..290 | 29.1..37.2 x 45.7..46.3 | w51 h4 b0 | | batch1-approved-rebel | approved-baseline | `unit-rebel-cavalry` | ok | ok | 139..289 x 266..281 | 167..286 x 186..282 | 22.2..46.2 x 42.5..44.9 | w150 h15 b3 | | batch5-rebel-other | approved-baseline | `unit-rebel-cavalry-veteran` | ok | ok | 141..250 x 270..288 | 141..267 x 270..288 | 22.5..39.9 x 43.1..46.0 | w109 h18 b0 | -| batch5-rebel-other | queued-rework | `unit-rebel-leader` | border-hits=32 | border-hits=72 | 200..254 x 266..266 | 200..263 x 265..266 | 31.9..40.6 x 42.5..42.5 | w54 h0 b6 | +| batch5-rebel-other | approved-baseline | `unit-rebel-leader` | ok | ok | 156..203 x 288..290 | 150..247 x 255..290 | 24.9..32.4 x 46.0..46.3 | w47 h2 b0 | | batch5-rebel-other | queued-rework | `unit-rebel-leader-warlord` | border-hits=32 | border-hits=78 | 224..266 x 276..277 | 224..275 x 275..277 | 35.8..42.5 x 44.1..44.2 | w42 h1 b6 | | batch5-rebel-other | queued-rework | `unit-rebel-ragged` | border-hits=32 | border-hits=72 | 192..277 x 266..266 | 192..286 x 265..266 | 30.7..44.2 x 42.5..42.5 | w85 h0 b6 | | batch2-shu | approved-baseline | `unit-shu-archer` | ok | ok | 158..260 x 284..295 | 152..260 x 276..295 | 25.2..41.5 x 45.4..47.1 | w102 h11 b0 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index 7850743..232c358 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -19,6 +19,7 @@ "unit-rebel-archer-veteran", "unit-rebel-cavalry", "unit-rebel-cavalry-veteran", + "unit-rebel-leader", "unit-shu-archer", "unit-shu-cavalry", "unit-shu-infantry", @@ -40,7 +41,6 @@ "pendingApproval": [], "currentApprovalCandidate": {}, "nextAfterApproval": [ - "unit-rebel-leader", "unit-rebel-leader-warlord", "unit-rebel-ragged" ], diff --git a/src/assets/images/units/unit-rebel-leader-actions.png b/src/assets/images/units/unit-rebel-leader-actions.png index 626e418..721bcd0 100644 Binary files a/src/assets/images/units/unit-rebel-leader-actions.png and b/src/assets/images/units/unit-rebel-leader-actions.png differ diff --git a/src/assets/images/units/unit-rebel-leader.png b/src/assets/images/units/unit-rebel-leader.png index 1ce072e..27fc081 100644 Binary files a/src/assets/images/units/unit-rebel-leader.png and b/src/assets/images/units/unit-rebel-leader.png differ