diff --git a/docs/handpaint-batch7-gong-zhi-source-v1.png b/docs/handpaint-batch7-gong-zhi-source-v1.png new file mode 100644 index 0000000..2168163 Binary files /dev/null and b/docs/handpaint-batch7-gong-zhi-source-v1.png differ diff --git a/docs/handpaint-batch7-gong-zhi-v2-animation.gif b/docs/handpaint-batch7-gong-zhi-v2-animation.gif new file mode 100644 index 0000000..13ae864 Binary files /dev/null and b/docs/handpaint-batch7-gong-zhi-v2-animation.gif differ diff --git a/docs/handpaint-batch7-gong-zhi-v2-battle-composite.png b/docs/handpaint-batch7-gong-zhi-v2-battle-composite.png new file mode 100644 index 0000000..051762f Binary files /dev/null and b/docs/handpaint-batch7-gong-zhi-v2-battle-composite.png differ diff --git a/docs/handpaint-batch7-gong-zhi-v2-before-after.png b/docs/handpaint-batch7-gong-zhi-v2-before-after.png new file mode 100644 index 0000000..a2224ca Binary files /dev/null and b/docs/handpaint-batch7-gong-zhi-v2-before-after.png differ diff --git a/docs/handpaint-batch7-gong-zhi-v2-contact.png b/docs/handpaint-batch7-gong-zhi-v2-contact.png new file mode 100644 index 0000000..03e76c4 Binary files /dev/null and b/docs/handpaint-batch7-gong-zhi-v2-contact.png differ diff --git a/docs/handpaint-batch7-gong-zhi-v2-debug-preview-battle-check.png b/docs/handpaint-batch7-gong-zhi-v2-debug-preview-battle-check.png new file mode 100644 index 0000000..baadd10 Binary files /dev/null and b/docs/handpaint-batch7-gong-zhi-v2-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch7-gong-zhi-v2-report.md b/docs/handpaint-batch7-gong-zhi-v2-report.md new file mode 100644 index 0000000..90fd205 --- /dev/null +++ b/docs/handpaint-batch7-gong-zhi-v2-report.md @@ -0,0 +1,24 @@ +# Gong Zhi Handpainted Sprite v2 + +- source: `handpaint-batch7-gong-zhi-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 2314898 +- action partial alpha: 0, opaque pixels: 5687163 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 208..222 +- base bbox height range: 290..290 +- base bottom range: 303..303 +- action bbox width range: 196..287 +- action bbox height range: 270..290 +- action bottom range: 303..303 +- contact: `handpaint-batch7-gong-zhi-v2-contact.png` +- animation: `handpaint-batch7-gong-zhi-v2-animation.gif` +- before/after: `handpaint-batch7-gong-zhi-v2-before-after.png` +- scale compare: `handpaint-batch7-gong-zhi-v2-scale-compare.png` +- battle composite: `handpaint-batch7-gong-zhi-v2-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch7-gong-zhi-v2-scale-compare.png b/docs/handpaint-batch7-gong-zhi-v2-scale-compare.png new file mode 100644 index 0000000..4f908e3 Binary files /dev/null and b/docs/handpaint-batch7-gong-zhi-v2-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index bfa306a..1d6a82f 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 74 +- Approved baseline units: 75 - Pending approval units: 0 -- Queued rework units: 17 +- Queued rework units: 16 ## Checked Rules diff --git a/docs/unit-sprite-batch-queue.json b/docs/unit-sprite-batch-queue.json index 9a03aa4..459793d 100644 --- a/docs/unit-sprite-batch-queue.json +++ b/docs/unit-sprite-batch-queue.json @@ -5,6 +5,7 @@ "approvedBaseline": [ "unit-cao-cao", "unit-fa-zheng", + "unit-gong-zhi", "unit-guan-yu", "unit-liu-bei", "unit-meng-huo", @@ -81,8 +82,8 @@ "pendingApproval": [], "nextAfterApproval": [], "stageCounts": { - "approved-baseline": 74, - "queued-rework": 17 + "approved-baseline": 75, + "queued-rework": 16 }, "batches": [ { @@ -1168,24 +1169,10 @@ "label": "Batch 7 unique officers", "total": 19, "stageCounts": { - "approved-baseline": 2, - "queued-rework": 17 + "approved-baseline": 3, + "queued-rework": 16 }, "units": [ - { - "stem": "unit-gong-zhi", - "reviewStage": "queued-rework", - "queueRole": "queued rework", - "baseStatus": "border-hits=32", - "actionStatus": "border-hits=82", - "battleBasePx": [ - 31.9, - 40.6, - 44.6, - 44.6 - ], - "spec": null - }, { "stem": "unit-huang-quan", "reviewStage": "queued-rework", @@ -1437,6 +1424,20 @@ 46.3 ], "spec": null + }, + { + "stem": "unit-gong-zhi", + "reviewStage": "approved-baseline", + "queueRole": "approved reference", + "baseStatus": "ok", + "actionStatus": "ok", + "battleBasePx": [ + 33.2, + 35.5, + 46.3, + 46.3 + ], + "spec": null } ] } diff --git a/docs/unit-sprite-batch-queue.md b/docs/unit-sprite-batch-queue.md index 864885d..1a9c958 100644 --- a/docs/unit-sprite-batch-queue.md +++ b/docs/unit-sprite-batch-queue.md @@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i ## Current State -- Approved baseline units: 74 +- Approved baseline units: 75 - Pending approval units: 0 -- Queued rework units: 17 +- Queued rework units: 16 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` @@ -157,11 +157,10 @@ No next unit is currently defined. - Batch key: `batch7-unique-officer` - Total units: 19 -- Stage counts: approved-baseline 2, queued-rework 17 +- Stage counts: approved-baseline 3, queued-rework 16 | unit | role | stage | status | battle base px | spec | | --- | --- | --- | --- | --- | --- | -| `unit-gong-zhi` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 31.9..40.6 x 44.6..44.6 | | | `unit-huang-quan` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 31.9..40.6 x 44.6..44.6 | | | `unit-huang-zhong` | queued rework | queued-rework | base border-hits=64; actions border-hits=140 | 39.1..39.3 x 44.6..44.6 | | | `unit-jiang-wei` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 31.0..40.6 x 44.6..44.6 | | @@ -180,3 +179,4 @@ No next unit is currently defined. | `unit-zhuge-liang` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | | `unit-cao-cao` | approved reference | approved-baseline | technical ok | 32.9..36.4 x 46.3..47.3 | | | `unit-fa-zheng` | approved reference | approved-baseline | technical ok | 29.1..35.3 x 46.3..46.3 | | +| `unit-gong-zhi` | approved reference | approved-baseline | technical ok | 33.2..35.5 x 46.3..46.3 | | diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index f88343c..991ebdf 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-gong-zhi-v2-approval-packet.md b/docs/unit-sprite-gong-zhi-v2-approval-packet.md new file mode 100644 index 0000000..098fbbc --- /dev/null +++ b/docs/unit-sprite-gong-zhi-v2-approval-packet.md @@ -0,0 +1,37 @@ +# Gong Zhi v2 Approval Packet + +- status: approved during continuous production run +- unit: `unit-gong-zhi` +- source art: `handpaint-batch7-gong-zhi-source-v1.png` +- contact sheet: `handpaint-batch7-gong-zhi-v2-contact.png` +- animation GIF: `handpaint-batch7-gong-zhi-v2-animation.gif` +- before/after: `handpaint-batch7-gong-zhi-v2-before-after.png` +- scale compare: `handpaint-batch7-gong-zhi-v2-scale-compare.png` +- battle composite: `handpaint-batch7-gong-zhi-v2-battle-composite.png` +- browser check: `handpaint-batch7-gong-zhi-v2-debug-preview-battle-check.png` +- current board: `unit-sprite-current-approval-board.png` +- debug URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-gong-zhi&v=gong-zhi-v2` + +## Visual Decision + +Approved for the continuous batch run. v2 reads as Gong Zhi through olive-brown light armor, a rugged mountain-guide cloak, a short dao, and map-command poses. It is more grounded and local than Wu Yi, less scholarly than Fa Zheng, and avoids the bright heroic silhouette used by the main officers. + +## Technical Checks + +- base status: ok +- action status: ok +- base partial alpha: 0 +- action partial alpha: 0 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- battle scale from sample gate: 33.2..35.5 x 46.3..46.3 +- action battle scale from audit: 31.3..45.8 x 43.1..46.3 +- local build: passed +- Local browser console errors: `0` +- Local browser 404s: `0` + +## Notes + +v1 was visually good but too narrow at battle scale. v2 widens the assembled body and cloak while preserving the modest Wuling route-guide identity. diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index b8f9f90..9491ec9 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 74 +- Approved baseline units: 75 - Pending approval units: 0 -- Queued rework units: 17 +- Queued rework units: 16 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index e1b14dd..f9bf401 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch7-unique-officer.png b/docs/unit-sprite-review-batch7-unique-officer.png index 3e7eaf3..6d2e1fe 100644 Binary files a/docs/unit-sprite-review-batch7-unique-officer.png and b/docs/unit-sprite-review-batch7-unique-officer.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index 556b408..31936bb 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index 007432c..df0eac3 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 74, - "queued-rework": 17 + "approved-baseline": 75, + "queued-rework": 16 }, "rows": [ { @@ -131,7 +131,7 @@ }, { "batch": "batch7-unique-officer", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-gong-zhi", "base": { "key": "unit-gong-zhi", @@ -141,23 +141,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 1985543, - "border_hits": 32, - "min_width": 200, - "max_width": 254, - "min_height": 279, - "max_height": 279, - "min_bottom": 281, - "max_bottom": 287, + "opaque_pixels": 2314898, + "border_hits": 0, + "min_width": 208, + "max_width": 222, + "min_height": 290, + "max_height": 290, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 54, + "width_swing": 14, "height_swing": 0, - "bottom_swing": 6, - "battle_min_width_px": 31.9, - "battle_max_width_px": 40.6, - "battle_min_height_px": 44.6, - "battle_max_height_px": 44.6, - "status": "border-hits=32" + "bottom_swing": 0, + "battle_min_width_px": 33.2, + "battle_max_width_px": 35.5, + "battle_min_height_px": 46.3, + "battle_max_height_px": 46.3, + "status": "ok" }, "actions": { "key": "unit-gong-zhi-actions", @@ -167,23 +167,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4453784, - "border_hits": 82, - "min_width": 200, - "max_width": 263, - "min_height": 275, - "max_height": 279, - "min_bottom": 274, - "max_bottom": 289, + "opaque_pixels": 5687163, + "border_hits": 0, + "min_width": 196, + "max_width": 287, + "min_height": 270, + "max_height": 290, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 63, - "height_swing": 4, - "bottom_swing": 15, - "battle_min_width_px": 31.9, - "battle_max_width_px": 42.0, - "battle_min_height_px": 43.9, - "battle_max_height_px": 44.6, - "status": "border-hits=82" + "width_swing": 91, + "height_swing": 20, + "bottom_swing": 0, + "battle_min_width_px": 31.3, + "battle_max_width_px": 45.8, + "battle_min_height_px": 43.1, + "battle_max_height_px": 46.3, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index f83e16c..210675a 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 74 -- queued-rework: 17 +- approved-baseline: 75 +- queued-rework: 16 ## Batch Plan @@ -54,7 +54,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | --- | --- | --- | --- | --- | --- | --- | --- | --- | | batch7-unique-officer | approved-baseline | `unit-cao-cao` | ok | ok | 206..228 x 290..296 | 186..252 x 270..296 | 32.9..36.4 x 46.3..47.3 | w22 h6 b0 | | batch7-unique-officer | approved-baseline | `unit-fa-zheng` | ok | ok | 182..221 x 290..290 | 183..244 x 270..290 | 29.1..35.3 x 46.3..46.3 | w39 h0 b0 | -| batch7-unique-officer | queued-rework | `unit-gong-zhi` | border-hits=32 | border-hits=82 | 200..254 x 279..279 | 200..263 x 275..279 | 31.9..40.6 x 44.6..44.6 | w54 h0 b6 | +| batch7-unique-officer | approved-baseline | `unit-gong-zhi` | ok | ok | 208..222 x 290..290 | 196..287 x 270..290 | 33.2..35.5 x 46.3..46.3 | w14 h0 b0 | | batch1-approved-core | approved-baseline | `unit-guan-yu` | ok | ok | 190..270 x 276..291 | 172..296 x 171..289 | 30.4..43.1 x 44.1..46.5 | w80 h15 b4 | | batch7-unique-officer | queued-rework | `unit-huang-quan` | border-hits=32 | border-hits=82 | 200..254 x 279..279 | 200..263 x 275..279 | 31.9..40.6 x 44.6..44.6 | w54 h0 b6 | | batch7-unique-officer | queued-rework | `unit-huang-zhong` | border-hits=64 | border-hits=140 | 245..246 x 279..279 | 220..255 x 275..279 | 39.1..39.3 x 44.6..44.6 | w1 h0 b6 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index ef9f6c7..a999122 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -13,6 +13,7 @@ "approvedBaseline": [ "unit-cao-cao", "unit-fa-zheng", + "unit-gong-zhi", "unit-guan-yu", "unit-liu-bei", "unit-meng-huo", diff --git a/src/assets/images/units/unit-gong-zhi-actions.png b/src/assets/images/units/unit-gong-zhi-actions.png index 74501a4..af9e587 100644 Binary files a/src/assets/images/units/unit-gong-zhi-actions.png and b/src/assets/images/units/unit-gong-zhi-actions.png differ diff --git a/src/assets/images/units/unit-gong-zhi.png b/src/assets/images/units/unit-gong-zhi.png index 9d7af18..b84b9ab 100644 Binary files a/src/assets/images/units/unit-gong-zhi.png and b/src/assets/images/units/unit-gong-zhi.png differ