diff --git a/docs/handpaint-batch7-jiang-wei-source-v1.png b/docs/handpaint-batch7-jiang-wei-source-v1.png new file mode 100644 index 0000000..4ef9689 Binary files /dev/null and b/docs/handpaint-batch7-jiang-wei-source-v1.png differ diff --git a/docs/handpaint-batch7-jiang-wei-v3-animation.gif b/docs/handpaint-batch7-jiang-wei-v3-animation.gif new file mode 100644 index 0000000..0817021 Binary files /dev/null and b/docs/handpaint-batch7-jiang-wei-v3-animation.gif differ diff --git a/docs/handpaint-batch7-jiang-wei-v3-battle-composite.png b/docs/handpaint-batch7-jiang-wei-v3-battle-composite.png new file mode 100644 index 0000000..5292540 Binary files /dev/null and b/docs/handpaint-batch7-jiang-wei-v3-battle-composite.png differ diff --git a/docs/handpaint-batch7-jiang-wei-v3-before-after.png b/docs/handpaint-batch7-jiang-wei-v3-before-after.png new file mode 100644 index 0000000..cfa1883 Binary files /dev/null and b/docs/handpaint-batch7-jiang-wei-v3-before-after.png differ diff --git a/docs/handpaint-batch7-jiang-wei-v3-contact.png b/docs/handpaint-batch7-jiang-wei-v3-contact.png new file mode 100644 index 0000000..c849ec0 Binary files /dev/null and b/docs/handpaint-batch7-jiang-wei-v3-contact.png differ diff --git a/docs/handpaint-batch7-jiang-wei-v3-debug-preview-battle-check.png b/docs/handpaint-batch7-jiang-wei-v3-debug-preview-battle-check.png new file mode 100644 index 0000000..a701e68 Binary files /dev/null and b/docs/handpaint-batch7-jiang-wei-v3-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch7-jiang-wei-v3-report.md b/docs/handpaint-batch7-jiang-wei-v3-report.md new file mode 100644 index 0000000..e893aa4 --- /dev/null +++ b/docs/handpaint-batch7-jiang-wei-v3-report.md @@ -0,0 +1,24 @@ +# Jiang Wei hand-painted v3 report + +- source: `handpaint-batch7-jiang-wei-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 1922998 +- action partial alpha: 0, opaque pixels: 4444480 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 145..266 +- base bbox height range: 284..291 +- base bottom range: 303..303 +- action bbox width range: 142..261 +- action bbox height range: 261..291 +- action bottom range: 303..303 +- contact: `handpaint-batch7-jiang-wei-v3-contact.png` +- animation: `handpaint-batch7-jiang-wei-v3-animation.gif` +- before/after: `handpaint-batch7-jiang-wei-v3-before-after.png` +- scale compare: `handpaint-batch7-jiang-wei-v3-scale-compare.png` +- battle composite: `handpaint-batch7-jiang-wei-v3-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch7-jiang-wei-v3-scale-compare.png b/docs/handpaint-batch7-jiang-wei-v3-scale-compare.png new file mode 100644 index 0000000..884c255 Binary files /dev/null and b/docs/handpaint-batch7-jiang-wei-v3-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index f17357a..3ae8e81 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 77 +- Approved baseline units: 78 - Pending approval units: 0 -- Queued rework units: 14 +- Queued rework units: 13 ## Checked Rules diff --git a/docs/unit-sprite-batch-queue.json b/docs/unit-sprite-batch-queue.json index e344e0e..616c452 100644 --- a/docs/unit-sprite-batch-queue.json +++ b/docs/unit-sprite-batch-queue.json @@ -9,6 +9,7 @@ "unit-guan-yu", "unit-huang-quan", "unit-huang-zhong", + "unit-jiang-wei", "unit-liu-bei", "unit-meng-huo", "unit-nanman-infantry", @@ -84,8 +85,8 @@ "pendingApproval": [], "nextAfterApproval": [], "stageCounts": { - "approved-baseline": 77, - "queued-rework": 14 + "approved-baseline": 78, + "queued-rework": 13 }, "batches": [ { @@ -1171,24 +1172,10 @@ "label": "Batch 7 unique officers", "total": 19, "stageCounts": { - "approved-baseline": 5, - "queued-rework": 14 + "approved-baseline": 6, + "queued-rework": 13 }, "units": [ - { - "stem": "unit-jiang-wei", - "reviewStage": "queued-rework", - "queueRole": "queued rework", - "baseStatus": "border-hits=32", - "actionStatus": "border-hits=82", - "battleBasePx": [ - 31.0, - 40.6, - 44.6, - 44.6 - ], - "spec": null - }, { "stem": "unit-li-yan", "reviewStage": "queued-rework", @@ -1440,6 +1427,20 @@ 47.3 ], "spec": null + }, + { + "stem": "unit-jiang-wei", + "reviewStage": "approved-baseline", + "queueRole": "approved reference", + "baseStatus": "ok", + "actionStatus": "ok", + "battleBasePx": [ + 23.2, + 42.5, + 45.4, + 46.5 + ], + "spec": null } ] } diff --git a/docs/unit-sprite-batch-queue.md b/docs/unit-sprite-batch-queue.md index b3541e0..e372e23 100644 --- a/docs/unit-sprite-batch-queue.md +++ b/docs/unit-sprite-batch-queue.md @@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i ## Current State -- Approved baseline units: 77 +- Approved baseline units: 78 - Pending approval units: 0 -- Queued rework units: 14 +- Queued rework units: 13 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` @@ -157,11 +157,10 @@ No next unit is currently defined. - Batch key: `batch7-unique-officer` - Total units: 19 -- Stage counts: approved-baseline 5, queued-rework 14 +- Stage counts: approved-baseline 6, queued-rework 13 | unit | role | stage | status | battle base px | spec | | --- | --- | --- | --- | --- | --- | -| `unit-jiang-wei` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 31.0..40.6 x 44.6..44.6 | | | `unit-li-yan` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 31.9..40.6 x 44.6..44.6 | | | `unit-lu-bu` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 28.8..47.3 x 45.0..46.0 | | | `unit-lu-meng` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 30.7..44.2 x 44.6..44.6 | | @@ -180,3 +179,4 @@ No next unit is currently defined. | `unit-gong-zhi` | approved reference | approved-baseline | technical ok | 33.2..35.5 x 46.3..46.3 | | | `unit-huang-quan` | approved reference | approved-baseline | technical ok | 28.9..34.8 x 46.3..46.3 | | | `unit-huang-zhong` | approved reference | approved-baseline | technical ok | 27.2..36.3 x 46.3..47.3 | | +| `unit-jiang-wei` | approved reference | approved-baseline | technical ok | 23.2..42.5 x 45.4..46.5 | | diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index a228ab6..79aeffb 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-jiang-wei-v3-approval-packet.md b/docs/unit-sprite-jiang-wei-v3-approval-packet.md new file mode 100644 index 0000000..7c52a5b --- /dev/null +++ b/docs/unit-sprite-jiang-wei-v3-approval-packet.md @@ -0,0 +1,36 @@ +# Jiang Wei hand-painted sprite v3 approval packet + +- Unit: `unit-jiang-wei` +- Candidate version: `v3` +- Source sheet: `docs/handpaint-batch7-jiang-wei-source-v1.png` +- Contact sheet: `docs/handpaint-batch7-jiang-wei-v3-contact.png` +- Animation GIF: `docs/handpaint-batch7-jiang-wei-v3-animation.gif` +- Before/after: `docs/handpaint-batch7-jiang-wei-v3-before-after.png` +- Battle composite: `docs/handpaint-batch7-jiang-wei-v3-battle-composite.png` +- Scale compare: `docs/handpaint-batch7-jiang-wei-v3-scale-compare.png` +- Local browser check: `docs/handpaint-batch7-jiang-wei-v3-debug-preview-battle-check.png` +- Current approval board: `docs/unit-sprite-current-approval-board.png` + +## Visual Decision + +- Approved for continuous production run. +- Direction: youthful Shu/Northern-front spear commander with silver-blue armor, dark navy cloth, and clear long-spear silhouette. +- The 100% PC browser debug preview reads as a distinct commander rather than a green-robed Guan Yu or cavalry-style Ma Chao/Zhao Yun variant. +- The unit body is opaque and visible at battle scale without relying on base rings, badges, shadows, or external readability helpers. + +## Technical Checks + +- Local build: `pnpm build` passed. +- Local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-jiang-wei&v=jiang-wei-v3` +- Local browser console errors: `0` +- Local browser 404s: `0` +- Base partial alpha: `0` +- Action partial alpha: `0` +- Base frame border hits: `0` +- Action frame border hits: `0` +- Base battle size from audit: `23.2..42.5 x 45.4..46.5` + +## Notes + +- v1/v2 proved the art direction, but action width was too narrow for the quality gate. +- v3 keeps the same hand-painted source and restores action silhouette width while preserving frame boundary safety. diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index e1accbf..d6b4f7e 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 77 +- Approved baseline units: 78 - Pending approval units: 0 -- Queued rework units: 14 +- Queued rework units: 13 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index be12a66..b15fc27 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch7-unique-officer.png b/docs/unit-sprite-review-batch7-unique-officer.png index 2c86b25..24207bb 100644 Binary files a/docs/unit-sprite-review-batch7-unique-officer.png and b/docs/unit-sprite-review-batch7-unique-officer.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index 10d0601..8332d55 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index 0655820..e49ddfd 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 77, - "queued-rework": 14 + "approved-baseline": 78, + "queued-rework": 13 }, "rows": [ { @@ -359,7 +359,7 @@ }, { "batch": "batch7-unique-officer", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-jiang-wei", "base": { "key": "unit-jiang-wei", @@ -369,23 +369,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 2000768, - "border_hits": 32, - "min_width": 194, - "max_width": 254, - "min_height": 279, - "max_height": 279, - "min_bottom": 281, - "max_bottom": 287, + "opaque_pixels": 1922998, + "border_hits": 0, + "min_width": 145, + "max_width": 266, + "min_height": 284, + "max_height": 291, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 60, - "height_swing": 0, - "bottom_swing": 6, - "battle_min_width_px": 31.0, - "battle_max_width_px": 40.6, - "battle_min_height_px": 44.6, - "battle_max_height_px": 44.6, - "status": "border-hits=32" + "width_swing": 121, + "height_swing": 7, + "bottom_swing": 0, + "battle_min_width_px": 23.2, + "battle_max_width_px": 42.5, + "battle_min_height_px": 45.4, + "battle_max_height_px": 46.5, + "status": "ok" }, "actions": { "key": "unit-jiang-wei-actions", @@ -395,23 +395,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4471927, - "border_hits": 82, - "min_width": 194, - "max_width": 263, - "min_height": 275, - "max_height": 279, - "min_bottom": 274, - "max_bottom": 289, + "opaque_pixels": 4444480, + "border_hits": 0, + "min_width": 142, + "max_width": 261, + "min_height": 261, + "max_height": 291, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 69, - "height_swing": 4, - "bottom_swing": 15, - "battle_min_width_px": 31.0, - "battle_max_width_px": 42.0, - "battle_min_height_px": 43.9, - "battle_max_height_px": 44.6, - "status": "border-hits=82" + "width_swing": 119, + "height_swing": 30, + "bottom_swing": 0, + "battle_min_width_px": 22.7, + "battle_max_width_px": 41.7, + "battle_min_height_px": 41.7, + "battle_max_height_px": 46.5, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index a33edcf..33e2a7e 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 77 -- queued-rework: 14 +- approved-baseline: 78 +- queued-rework: 13 ## Batch Plan @@ -58,7 +58,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch1-approved-core | approved-baseline | `unit-guan-yu` | ok | ok | 190..270 x 276..291 | 172..296 x 171..289 | 30.4..43.1 x 44.1..46.5 | w80 h15 b4 | | batch7-unique-officer | approved-baseline | `unit-huang-quan` | ok | ok | 181..218 x 290..290 | 176..251 x 284..290 | 28.9..34.8 x 46.3..46.3 | w37 h0 b0 | | batch7-unique-officer | approved-baseline | `unit-huang-zhong` | ok | ok | 170..227 x 290..296 | 170..246 x 270..296 | 27.2..36.3 x 46.3..47.3 | w57 h6 b0 | -| batch7-unique-officer | queued-rework | `unit-jiang-wei` | border-hits=32 | border-hits=82 | 194..254 x 279..279 | 194..263 x 275..279 | 31.0..40.6 x 44.6..44.6 | w60 h0 b6 | +| batch7-unique-officer | approved-baseline | `unit-jiang-wei` | ok | ok | 145..266 x 284..291 | 142..261 x 261..291 | 23.2..42.5 x 45.4..46.5 | w121 h7 b0 | | batch7-unique-officer | queued-rework | `unit-li-yan` | border-hits=32 | border-hits=82 | 200..254 x 279..279 | 200..263 x 275..279 | 31.9..40.6 x 44.6..44.6 | w54 h0 b6 | | batch1-approved-core | approved-baseline | `unit-liu-bei` | ok | ok | 138..258 x 278..289 | 148..300 x 252..284 | 22.0..41.2 x 44.4..46.2 | w120 h11 b12 | | batch7-unique-officer | queued-rework | `unit-lu-bu` | border-hits=64 | border-hits=144 | 180..296 x 282..288 | 180..305 x 274..290 | 28.8..47.3 x 45.0..46.0 | w116 h6 b6 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index 69892cd..37582be 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -17,6 +17,7 @@ "unit-guan-yu", "unit-huang-quan", "unit-huang-zhong", + "unit-jiang-wei", "unit-liu-bei", "unit-meng-huo", "unit-nanman-infantry", diff --git a/src/assets/images/units/unit-jiang-wei-actions.png b/src/assets/images/units/unit-jiang-wei-actions.png index b4ab915..8fe833a 100644 Binary files a/src/assets/images/units/unit-jiang-wei-actions.png and b/src/assets/images/units/unit-jiang-wei-actions.png differ diff --git a/src/assets/images/units/unit-jiang-wei.png b/src/assets/images/units/unit-jiang-wei.png index 049185d..3f1746d 100644 Binary files a/src/assets/images/units/unit-jiang-wei.png and b/src/assets/images/units/unit-jiang-wei.png differ