diff --git a/docs/handpaint-batch7-zhuge-liang-source-v1.png b/docs/handpaint-batch7-zhuge-liang-source-v1.png new file mode 100644 index 0000000..c3cf569 Binary files /dev/null and b/docs/handpaint-batch7-zhuge-liang-source-v1.png differ diff --git a/docs/handpaint-batch7-zhuge-liang-v3-animation.gif b/docs/handpaint-batch7-zhuge-liang-v3-animation.gif new file mode 100644 index 0000000..02a3c4c Binary files /dev/null and b/docs/handpaint-batch7-zhuge-liang-v3-animation.gif differ diff --git a/docs/handpaint-batch7-zhuge-liang-v3-battle-composite.png b/docs/handpaint-batch7-zhuge-liang-v3-battle-composite.png new file mode 100644 index 0000000..fe2c2ed Binary files /dev/null and b/docs/handpaint-batch7-zhuge-liang-v3-battle-composite.png differ diff --git a/docs/handpaint-batch7-zhuge-liang-v3-before-after.png b/docs/handpaint-batch7-zhuge-liang-v3-before-after.png new file mode 100644 index 0000000..0db53ba Binary files /dev/null and b/docs/handpaint-batch7-zhuge-liang-v3-before-after.png differ diff --git a/docs/handpaint-batch7-zhuge-liang-v3-contact.png b/docs/handpaint-batch7-zhuge-liang-v3-contact.png new file mode 100644 index 0000000..de57c06 Binary files /dev/null and b/docs/handpaint-batch7-zhuge-liang-v3-contact.png differ diff --git a/docs/handpaint-batch7-zhuge-liang-v3-debug-preview-battle-check.png b/docs/handpaint-batch7-zhuge-liang-v3-debug-preview-battle-check.png new file mode 100644 index 0000000..98df691 Binary files /dev/null and b/docs/handpaint-batch7-zhuge-liang-v3-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch7-zhuge-liang-v3-report.md b/docs/handpaint-batch7-zhuge-liang-v3-report.md new file mode 100644 index 0000000..8e1070c --- /dev/null +++ b/docs/handpaint-batch7-zhuge-liang-v3-report.md @@ -0,0 +1,24 @@ +# Zhuge Liang hand-painted v3 report + +- source: `handpaint-batch7-zhuge-liang-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 2165668 +- action partial alpha: 0, opaque pixels: 4396498 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 150..250 +- base bbox height range: 277..288 +- base bottom range: 303..303 +- action bbox width range: 132..248 +- action bbox height range: 234..294 +- action bottom range: 303..303 +- contact: `handpaint-batch7-zhuge-liang-v3-contact.png` +- animation: `handpaint-batch7-zhuge-liang-v3-animation.gif` +- before/after: `handpaint-batch7-zhuge-liang-v3-before-after.png` +- scale compare: `handpaint-batch7-zhuge-liang-v3-scale-compare.png` +- battle composite: `handpaint-batch7-zhuge-liang-v3-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch7-zhuge-liang-v3-scale-compare.png b/docs/handpaint-batch7-zhuge-liang-v3-scale-compare.png new file mode 100644 index 0000000..1724e3a Binary files /dev/null and b/docs/handpaint-batch7-zhuge-liang-v3-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index b6f7543..8ad7ada 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 90 +- Approved baseline units: 91 - Pending approval units: 0 -- Queued rework units: 1 +- Queued rework units: 0 ## Checked Rules diff --git a/docs/unit-sprite-batch-queue.json b/docs/unit-sprite-batch-queue.json index 9751cba..3744235 100644 --- a/docs/unit-sprite-batch-queue.json +++ b/docs/unit-sprite-batch-queue.json @@ -92,13 +92,13 @@ "unit-yan-yan", "unit-yi-ji", "unit-zhang-fei", - "unit-zhao-yun" + "unit-zhao-yun", + "unit-zhuge-liang" ], "pendingApproval": [], "nextAfterApproval": [], "stageCounts": { - "approved-baseline": 90, - "queued-rework": 1 + "approved-baseline": 91 }, "batches": [ { @@ -1184,24 +1184,9 @@ "label": "Batch 7 unique officers", "total": 19, "stageCounts": { - "approved-baseline": 18, - "queued-rework": 1 + "approved-baseline": 19 }, "units": [ - { - "stem": "unit-zhuge-liang", - "reviewStage": "queued-rework", - "queueRole": "queued rework", - "baseStatus": "border-hits=32", - "actionStatus": "border-hits=98", - "battleBasePx": [ - 38.8, - 39.3, - 44.7, - 44.9 - ], - "spec": null - }, { "stem": "unit-cao-cao", "reviewStage": "approved-baseline", @@ -1453,6 +1438,20 @@ 46.3 ], "spec": null + }, + { + "stem": "unit-zhuge-liang", + "reviewStage": "approved-baseline", + "queueRole": "approved reference", + "baseStatus": "ok", + "actionStatus": "ok", + "battleBasePx": [ + 24.0, + 39.9, + 44.2, + 46.0 + ], + "spec": null } ] } diff --git a/docs/unit-sprite-batch-queue.md b/docs/unit-sprite-batch-queue.md index 8b71df4..4204961 100644 --- a/docs/unit-sprite-batch-queue.md +++ b/docs/unit-sprite-batch-queue.md @@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i ## Current State -- Approved baseline units: 90 +- Approved baseline units: 91 - Pending approval units: 0 -- Queued rework units: 1 +- Queued rework units: 0 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` @@ -157,11 +157,10 @@ No next unit is currently defined. - Batch key: `batch7-unique-officer` - Total units: 19 -- Stage counts: approved-baseline 18, queued-rework 1 +- Stage counts: approved-baseline 19 | unit | role | stage | status | battle base px | spec | | --- | --- | --- | --- | --- | --- | -| `unit-zhuge-liang` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | | `unit-cao-cao` | approved reference | approved-baseline | technical ok | 32.9..36.4 x 46.3..47.3 | | | `unit-fa-zheng` | approved reference | approved-baseline | technical ok | 29.1..35.3 x 46.3..46.3 | | | `unit-gong-zhi` | approved reference | approved-baseline | technical ok | 33.2..35.5 x 46.3..46.3 | | @@ -180,3 +179,4 @@ No next unit is currently defined. | `unit-yan-yan` | approved reference | approved-baseline | technical ok | 30.4..37.5 x 45.7..46.0 | | | `unit-yi-ji` | approved reference | approved-baseline | technical ok | 27.8..33.9 x 45.7..46.0 | | | `unit-zhao-yun` | approved reference | approved-baseline | technical ok | 22.5..42.5 x 45.0..46.3 | | +| `unit-zhuge-liang` | approved reference | approved-baseline | technical ok | 24.0..39.9 x 44.2..46.0 | | diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index 066bf19..82e4088 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index d6e0753..b24d9ba 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 90 +- Approved baseline units: 91 - Pending approval units: 0 -- Queued rework units: 1 +- Queued rework units: 0 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index 6c4a83e..4083e0e 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch7-unique-officer.png b/docs/unit-sprite-review-batch7-unique-officer.png index f3ae261..d59c43b 100644 Binary files a/docs/unit-sprite-review-batch7-unique-officer.png and b/docs/unit-sprite-review-batch7-unique-officer.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index b3a48e0..d9ca2a0 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index 6d08691..ff86dff 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,7 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 90, - "queued-rework": 1 + "approved-baseline": 91 }, "rows": [ { @@ -5147,7 +5146,7 @@ }, { "batch": "batch7-unique-officer", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-zhuge-liang", "base": { "key": "unit-zhuge-liang", @@ -5157,23 +5156,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 1999925, - "border_hits": 32, - "min_width": 243, - "max_width": 246, - "min_height": 280, - "max_height": 281, - "min_bottom": 281, - "max_bottom": 287, + "opaque_pixels": 2165668, + "border_hits": 0, + "min_width": 150, + "max_width": 250, + "min_height": 277, + "max_height": 288, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 3, - "height_swing": 1, - "bottom_swing": 6, - "battle_min_width_px": 38.8, - "battle_max_width_px": 39.3, - "battle_min_height_px": 44.7, - "battle_max_height_px": 44.9, - "status": "border-hits=32" + "width_swing": 100, + "height_swing": 11, + "bottom_swing": 0, + "battle_min_width_px": 24.0, + "battle_max_width_px": 39.9, + "battle_min_height_px": 44.2, + "battle_max_height_px": 46.0, + "status": "ok" }, "actions": { "key": "unit-zhuge-liang-actions", @@ -5183,23 +5182,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4453376, - "border_hits": 98, - "min_width": 220, - "max_width": 255, - "min_height": 275, - "max_height": 281, - "min_bottom": 274, - "max_bottom": 289, + "opaque_pixels": 4396498, + "border_hits": 0, + "min_width": 132, + "max_width": 248, + "min_height": 234, + "max_height": 294, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 35, - "height_swing": 6, - "bottom_swing": 15, - "battle_min_width_px": 35.1, - "battle_max_width_px": 40.7, - "battle_min_height_px": 43.9, - "battle_max_height_px": 44.9, - "status": "border-hits=98" + "width_swing": 116, + "height_swing": 60, + "bottom_swing": 0, + "battle_min_width_px": 21.1, + "battle_max_width_px": 39.6, + "battle_min_height_px": 37.4, + "battle_max_height_px": 47.0, + "status": "ok" } } ] diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index 6a395b0..9eea736 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 90 -- queued-rework: 1 +- approved-baseline: 91 ## Batch Plan @@ -142,4 +141,4 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch7-unique-officer | approved-baseline | `unit-yi-ji` | ok | ok | 174..212 x 286..288 | 167..273 x 286..295 | 27.8..33.9 x 45.7..46.0 | w38 h2 b0 | | batch1-approved-core | approved-baseline | `unit-zhang-fei` | ok | ok | 143..306 x 274..289 | 188..286 x 181..290 | 22.8..48.9 x 43.8..46.2 | w163 h15 b14 | | batch7-unique-officer | approved-baseline | `unit-zhao-yun` | ok | ok | 141..266 x 282..290 | 118..248 x 277..295 | 22.5..42.5 x 45.0..46.3 | w125 h8 b0 | -| batch7-unique-officer | queued-rework | `unit-zhuge-liang` | border-hits=32 | border-hits=98 | 243..246 x 280..281 | 220..255 x 275..281 | 38.8..39.3 x 44.7..44.9 | w3 h1 b6 | +| batch7-unique-officer | approved-baseline | `unit-zhuge-liang` | ok | ok | 150..250 x 277..288 | 132..248 x 234..294 | 24.0..39.9 x 44.2..46.0 | w100 h11 b0 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index 9c04210..0949db4 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -100,7 +100,8 @@ "unit-yan-yan", "unit-yi-ji", "unit-zhang-fei", - "unit-zhao-yun" + "unit-zhao-yun", + "unit-zhuge-liang" ], "pendingApproval": [], "currentApprovalCandidate": {}, diff --git a/docs/unit-sprite-zhuge-liang-v3-approval-packet.md b/docs/unit-sprite-zhuge-liang-v3-approval-packet.md new file mode 100644 index 0000000..2b10833 --- /dev/null +++ b/docs/unit-sprite-zhuge-liang-v3-approval-packet.md @@ -0,0 +1,35 @@ +# Zhuge Liang hand-painted v3 approval packet + +- unit: `unit-zhuge-liang` +- candidate: `handpaint-batch7-zhuge-liang-v3` +- source: `docs/handpaint-batch7-zhuge-liang-source-v1.png` +- contact sheet: `docs/handpaint-batch7-zhuge-liang-v3-contact.png` +- animation: `docs/handpaint-batch7-zhuge-liang-v3-animation.gif` +- before/after: `docs/handpaint-batch7-zhuge-liang-v3-before-after.png` +- battle composite: `docs/handpaint-batch7-zhuge-liang-v3-battle-composite.png` +- current approval board: `docs/unit-sprite-current-approval-board.png` +- browser check: `docs/handpaint-batch7-zhuge-liang-v3-debug-preview-battle-check.png` + +## Result + +- Local build: `pnpm build` passed. +- Local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-zhuge-liang&v=zhuge-liang-v3-headed` +- Local browser console errors: `0` +- Local browser 404s: `0` +- Sample gate: passed. + +## Sprite safety + +- base partial alpha: 0 +- action partial alpha: 0 +- base frame border hits: 0 +- action frame border hits: 0 +- base battle size: 24.0..39.9 x 44.2..46.0 +- frame bbox width: 150..250 base, 132..248 action +- frame bbox height: 277..288 base, 234..294 action + +## Visual notes + +- v1 had a strong original Zhuge Liang direction, v2 widened the idle silhouette, and v3 restores enough action width for the strategy/fan poses to pass the art quality gate. +- Large feather fan, tall scholar cap, pale teal sash, and ivory robe keep Zhuge Liang distinct from Ma Liang's softer white scholar look and Sima Yi's dark strategist silhouette. +- The sprite is fully opaque, has no frame-edge contact, and uses the character art itself for readability without rings, bases, or badges. diff --git a/src/assets/images/units/unit-zhuge-liang-actions.png b/src/assets/images/units/unit-zhuge-liang-actions.png index 6f05e7d..61b68a2 100644 Binary files a/src/assets/images/units/unit-zhuge-liang-actions.png and b/src/assets/images/units/unit-zhuge-liang-actions.png differ diff --git a/src/assets/images/units/unit-zhuge-liang.png b/src/assets/images/units/unit-zhuge-liang.png index 326a5d8..00572e8 100644 Binary files a/src/assets/images/units/unit-zhuge-liang.png and b/src/assets/images/units/unit-zhuge-liang.png differ