diff --git a/docs/propfix-wei-strategist-blue-v4-animation.gif b/docs/propfix-wei-strategist-blue-v4-animation.gif new file mode 100644 index 0000000..458a812 Binary files /dev/null and b/docs/propfix-wei-strategist-blue-v4-animation.gif differ diff --git a/docs/propfix-wei-strategist-blue-v4-battle-composite.png b/docs/propfix-wei-strategist-blue-v4-battle-composite.png new file mode 100644 index 0000000..ccdbb3d Binary files /dev/null and b/docs/propfix-wei-strategist-blue-v4-battle-composite.png differ diff --git a/docs/propfix-wei-strategist-blue-v4-before-after.png b/docs/propfix-wei-strategist-blue-v4-before-after.png new file mode 100644 index 0000000..67065ce Binary files /dev/null and b/docs/propfix-wei-strategist-blue-v4-before-after.png differ diff --git a/docs/propfix-wei-strategist-blue-v4-browser-check.png b/docs/propfix-wei-strategist-blue-v4-browser-check.png new file mode 100644 index 0000000..c7db8bb Binary files /dev/null and b/docs/propfix-wei-strategist-blue-v4-browser-check.png differ diff --git a/docs/propfix-wei-strategist-blue-v4-contact.png b/docs/propfix-wei-strategist-blue-v4-contact.png new file mode 100644 index 0000000..a3497b8 Binary files /dev/null and b/docs/propfix-wei-strategist-blue-v4-contact.png differ diff --git a/docs/propfix-wei-strategist-blue-v4-prod-browser-check.png b/docs/propfix-wei-strategist-blue-v4-prod-browser-check.png new file mode 100644 index 0000000..6de62a5 Binary files /dev/null and b/docs/propfix-wei-strategist-blue-v4-prod-browser-check.png differ diff --git a/docs/propfix-wei-strategist-blue-v4-report.md b/docs/propfix-wei-strategist-blue-v4-report.md new file mode 100644 index 0000000..9e581c2 --- /dev/null +++ b/docs/propfix-wei-strategist-blue-v4-report.md @@ -0,0 +1,31 @@ +# Wei Records Officer v4 report + +- source: `propfix-wei-strategist-blue-v4-source.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 1903538 +- action partial alpha: 0, opaque pixels: 4175036 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 133..197 +- base bbox height range: 282..288 +- base bottom range: 303..303 +- action bbox width range: 117..213 +- action bbox height range: 282..290 +- action bottom range: 303..303 +- contact: `propfix-wei-strategist-blue-v4-contact.png` +- animation: `propfix-wei-strategist-blue-v4-animation.gif` +- before/after: `propfix-wei-strategist-blue-v4-before-after.png` +- scale compare: `propfix-wei-strategist-blue-v4-scale-compare.png` +- battle composite: `propfix-wei-strategist-blue-v4-battle-composite.png` +- local browser check: `propfix-wei-strategist-blue-v4-browser-check.png` +- identity check: no white feather fan or large fan; reads as a Wei records officer through map scroll, registry book, bamboo-slip ledger, bronze tablet, and document case. +- build: `pnpm build` passed using the bundled Node runtime path. +- local browser verification: passed at `http://127.0.0.1:4174/heros_web/?debug&debugSpritePreview=unit-wei-strategist-blue&v=wei-blue-v4-local` +- local console errors: 0 +- deployed browser check: `propfix-wei-strategist-blue-v4-prod-browser-check.png` +- deployed browser verification: passed at `https://comtropy.synology.me/heros_web/?debug&debugSpritePreview=unit-wei-strategist-blue&v=wei-blue-v4-prod` +- deployed console errors: 0 +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/propfix-wei-strategist-blue-v4-scale-compare.png b/docs/propfix-wei-strategist-blue-v4-scale-compare.png new file mode 100644 index 0000000..303eb48 Binary files /dev/null and b/docs/propfix-wei-strategist-blue-v4-scale-compare.png differ diff --git a/docs/propfix-wei-strategist-blue-v4-source.png b/docs/propfix-wei-strategist-blue-v4-source.png new file mode 100644 index 0000000..04f7c86 Binary files /dev/null and b/docs/propfix-wei-strategist-blue-v4-source.png differ diff --git a/docs/strategist-character-direction.md b/docs/strategist-character-direction.md index 406a5b3..4be89c9 100644 --- a/docs/strategist-character-direction.md +++ b/docs/strategist-character-direction.md @@ -32,9 +32,8 @@ Zhuge Liang owns the large white feather fan and white-robed sage read. Other st ## Next Representative Fixes -1. `unit-wei-strategist-blue`: verify the records officer stays map/registry focused instead of fan-focused. -2. `unit-sima-yi`: confirm the named Wei conspirator remains darker and more distinctive than generic Wei strategists. -3. `unit-huang-quan`: verify the quartermaster official stays records/map focused without a fan read. +1. `unit-sima-yi`: confirm the named Wei conspirator remains darker and more distinctive than generic Wei strategists. +2. `unit-huang-quan`: verify the quartermaster official stays records/map focused without a fan read. Completed representative pass: @@ -45,5 +44,6 @@ Completed representative pass: - `unit-wu-strategist-river`: changed from white-fan river strategist to blue-green river-route tactician with water-route map board, scroll tube, oar-shaped baton, and navigation slips. - `unit-shu-strategist-field`: changed from white-fan sage-like field strategist to rugged Shu frontline staff officer with folded field map, short baton, bamboo slips, leather scroll case, and order pouch. - `unit-wei-strategist-black`: changed from white-fan black strategist to generic Wei covert adviser with black command tablet, sealed military order, iron tally baton, lacquer case, and compact war ledger. +- `unit-wei-strategist-blue`: changed from white-fan blue strategist to Wei records officer with map scroll, registry book, bamboo-slip ledger, bronze command tablet, and document case. Every representative fix should include contact sheet, animation GIF, battle preview, before/after, alpha audit, build, and browser check. diff --git a/docs/strategist-prop-audit.md b/docs/strategist-prop-audit.md index 343a6c8..eb821d8 100644 --- a/docs/strategist-prop-audit.md +++ b/docs/strategist-prop-audit.md @@ -28,7 +28,7 @@ Detailed per-unit visual direction lives in `strategist-character-direction.md`. | `unit-shu-strategist-white` | muted jade civil aide, document bundle, brush case, bamboo-slip ledger | white robe/fan pairing removed; Shu administrative aide identity restored | fixed in representative pass | | `unit-wei-strategist` | bronze command tablet, war ledger, compact map board | white feather fan removed; Wei court analyst identity restored | fixed in representative pass | | `unit-wei-strategist-black` | black command tablet, sealed military order, iron tally baton, lacquer case, compact war ledger | white fan removed; Wei covert adviser identity restored | fixed in representative pass | -| `unit-wei-strategist-blue` | blue records officer variant | acceptable if props are records/maps | later identity pass | +| `unit-wei-strategist-blue` | map scroll, registry book, bamboo-slip ledger, bronze command tablet, document case | white fan removed; Wei records officer identity restored | fixed in representative pass | | `unit-wu-strategist` | naval chart, lacquer red baton, river map board | white feather fan removed; Wu river adviser identity restored | fixed in representative pass | | `unit-wu-strategist-fire` | bronze fire tally, oil-map board, red command tablet, talisman strips | white fan read removed; fire-plan tactician identity restored | fixed in representative pass | | `unit-wu-strategist-river` | water-route map board, scroll tube, oar-shaped baton, navigation slips | white fan read removed; river-route tactician identity restored | fixed in representative pass | @@ -48,8 +48,7 @@ The first correction batch changes: Next representative cleanup order: -1. `unit-wei-strategist-blue` -2. `unit-sima-yi` -3. `unit-huang-quan` +1. `unit-sima-yi` +2. `unit-huang-quan` Later cleanup should remove white-feather-fan reads from remaining generic strategist variants after the representative fixes are verified. diff --git a/docs/unit-sprite-batch-queue.json b/docs/unit-sprite-batch-queue.json index cfcaad4..c17813e 100644 --- a/docs/unit-sprite-batch-queue.json +++ b/docs/unit-sprite-batch-queue.json @@ -678,9 +678,9 @@ "baseStatus": "ok", "actionStatus": "ok", "battleBasePx": [ - 26.4, - 33.5, - 46.0, + 21.2, + 31.5, + 45.0, 46.0 ], "spec": null diff --git a/docs/unit-sprite-batch-queue.md b/docs/unit-sprite-batch-queue.md index 64900c6..641d397 100644 --- a/docs/unit-sprite-batch-queue.md +++ b/docs/unit-sprite-batch-queue.md @@ -91,7 +91,7 @@ No next unit is currently defined. | `unit-wei-officer-iron` | approved reference | approved-baseline | technical ok | 34.2..36.6 x 44.2..46.0 | | | `unit-wei-strategist` | approved reference | approved-baseline | technical ok | 25.9..33.2 x 45.0..46.3 | | | `unit-wei-strategist-black` | approved reference | approved-baseline | technical ok | 25.9..32.7 x 45.0..47.1 | | -| `unit-wei-strategist-blue` | approved reference | approved-baseline | technical ok | 26.4..33.5 x 46.0..46.0 | | +| `unit-wei-strategist-blue` | approved reference | approved-baseline | technical ok | 21.2..31.5 x 45.0..46.0 | | | `unit-wei-yan` | approved reference | approved-baseline | technical ok | 27.6..35.0 x 44.2..46.3 | | ### Batch 4 Wu generic units diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index 596a03a..6743f6c 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch3-wei.png b/docs/unit-sprite-review-batch3-wei.png index 73064dd..90e8e82 100644 Binary files a/docs/unit-sprite-review-batch3-wei.png and b/docs/unit-sprite-review-batch3-wei.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index 2748ba6..351f0bb 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index 8714407..71434f6 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -3902,21 +3902,21 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 2087788, + "opaque_pixels": 1903538, "border_hits": 0, - "min_width": 165, - "max_width": 210, - "min_height": 288, + "min_width": 133, + "max_width": 197, + "min_height": 282, "max_height": 288, "min_bottom": 303, "max_bottom": 303, "empty_frames": 0, - "width_swing": 45, - "height_swing": 0, + "width_swing": 64, + "height_swing": 6, "bottom_swing": 0, - "battle_min_width_px": 26.4, - "battle_max_width_px": 33.5, - "battle_min_height_px": 46.0, + "battle_min_width_px": 21.2, + "battle_max_width_px": 31.5, + "battle_min_height_px": 45.0, "battle_max_height_px": 46.0, "status": "ok" }, @@ -3928,22 +3928,22 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4986681, + "opaque_pixels": 4175036, "border_hits": 0, - "min_width": 165, - "max_width": 246, - "min_height": 264, - "max_height": 288, + "min_width": 117, + "max_width": 213, + "min_height": 282, + "max_height": 290, "min_bottom": 303, "max_bottom": 303, "empty_frames": 0, - "width_swing": 81, - "height_swing": 24, + "width_swing": 96, + "height_swing": 8, "bottom_swing": 0, - "battle_min_width_px": 26.4, - "battle_max_width_px": 39.3, - "battle_min_height_px": 42.2, - "battle_max_height_px": 46.0, + "battle_min_width_px": 18.7, + "battle_max_width_px": 34.0, + "battle_min_height_px": 45.0, + "battle_max_height_px": 46.3, "status": "ok" } }, diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index dc7958f..0ba4cc6 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -119,7 +119,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch3-wei | approved-baseline | `unit-wei-officer-iron` | ok | ok | 214..229 x 277..288 | 201..258 x 230..288 | 34.2..36.6 x 44.2..46.0 | w15 h11 b0 | | batch3-wei | approved-baseline | `unit-wei-strategist` | ok | ok | 162..208 x 282..290 | 136..212 x 282..295 | 25.9..33.2 x 45.0..46.3 | w46 h8 b0 | | batch3-wei | approved-baseline | `unit-wei-strategist-black` | ok | ok | 162..205 x 282..295 | 143..230 x 282..292 | 25.9..32.7 x 45.0..47.1 | w43 h13 b0 | -| batch3-wei | approved-baseline | `unit-wei-strategist-blue` | ok | ok | 165..210 x 288..288 | 165..246 x 264..288 | 26.4..33.5 x 46.0..46.0 | w45 h0 b0 | +| batch3-wei | approved-baseline | `unit-wei-strategist-blue` | ok | ok | 133..197 x 282..288 | 117..213 x 282..290 | 21.2..31.5 x 45.0..46.0 | w64 h6 b0 | | batch3-wei | approved-baseline | `unit-wei-yan` | ok | ok | 173..219 x 277..290 | 173..264 x 232..290 | 27.6..35.0 x 44.2..46.3 | w46 h13 b0 | | batch4-wu | approved-baseline | `unit-wu-archer` | ok | ok | 177..215 x 288..288 | 178..242 x 288..288 | 28.3..34.3 x 46.0..46.0 | w38 h0 b0 | | batch4-wu | approved-baseline | `unit-wu-archer-naval` | ok | ok | 212..229 x 277..288 | 191..256 x 277..288 | 33.9..36.6 x 44.2..46.0 | w17 h11 b0 | diff --git a/src/assets/images/units/unit-wei-strategist-blue-actions.png b/src/assets/images/units/unit-wei-strategist-blue-actions.png index cbcaeaa..97b1ebb 100644 Binary files a/src/assets/images/units/unit-wei-strategist-blue-actions.png and b/src/assets/images/units/unit-wei-strategist-blue-actions.png differ diff --git a/src/assets/images/units/unit-wei-strategist-blue.png b/src/assets/images/units/unit-wei-strategist-blue.png index 2cf6970..9030226 100644 Binary files a/src/assets/images/units/unit-wei-strategist-blue.png and b/src/assets/images/units/unit-wei-strategist-blue.png differ