diff --git a/docs/handpaint-batch5-rebel-cavalry-veteran-source-v1.png b/docs/handpaint-batch5-rebel-cavalry-veteran-source-v1.png new file mode 100644 index 0000000..17671c2 Binary files /dev/null and b/docs/handpaint-batch5-rebel-cavalry-veteran-source-v1.png differ diff --git a/docs/handpaint-batch5-rebel-cavalry-veteran-v3-animation.gif b/docs/handpaint-batch5-rebel-cavalry-veteran-v3-animation.gif new file mode 100644 index 0000000..9c2881c Binary files /dev/null and b/docs/handpaint-batch5-rebel-cavalry-veteran-v3-animation.gif differ diff --git a/docs/handpaint-batch5-rebel-cavalry-veteran-v3-battle-composite.png b/docs/handpaint-batch5-rebel-cavalry-veteran-v3-battle-composite.png new file mode 100644 index 0000000..436e3b3 Binary files /dev/null and b/docs/handpaint-batch5-rebel-cavalry-veteran-v3-battle-composite.png differ diff --git a/docs/handpaint-batch5-rebel-cavalry-veteran-v3-before-after.png b/docs/handpaint-batch5-rebel-cavalry-veteran-v3-before-after.png new file mode 100644 index 0000000..16c1bd2 Binary files /dev/null and b/docs/handpaint-batch5-rebel-cavalry-veteran-v3-before-after.png differ diff --git a/docs/handpaint-batch5-rebel-cavalry-veteran-v3-contact.png b/docs/handpaint-batch5-rebel-cavalry-veteran-v3-contact.png new file mode 100644 index 0000000..be522ef Binary files /dev/null and b/docs/handpaint-batch5-rebel-cavalry-veteran-v3-contact.png differ diff --git a/docs/handpaint-batch5-rebel-cavalry-veteran-v3-debug-preview-battle-check.png b/docs/handpaint-batch5-rebel-cavalry-veteran-v3-debug-preview-battle-check.png new file mode 100644 index 0000000..9e0dfeb Binary files /dev/null and b/docs/handpaint-batch5-rebel-cavalry-veteran-v3-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch5-rebel-cavalry-veteran-v3-report.md b/docs/handpaint-batch5-rebel-cavalry-veteran-v3-report.md new file mode 100644 index 0000000..b862cee --- /dev/null +++ b/docs/handpaint-batch5-rebel-cavalry-veteran-v3-report.md @@ -0,0 +1,24 @@ +# Rebel Veteran Cavalry Hand-Painted v3 + +- source: `handpaint-batch5-rebel-cavalry-veteran-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 1962656 +- action partial alpha: 0, opaque pixels: 5026307 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 141..250 +- base bbox height range: 270..288 +- base bottom range: 303..303 +- action bbox width range: 141..267 +- action bbox height range: 270..288 +- action bottom range: 303..303 +- contact: `handpaint-batch5-rebel-cavalry-veteran-v3-contact.png` +- animation: `handpaint-batch5-rebel-cavalry-veteran-v3-animation.gif` +- before/after: `handpaint-batch5-rebel-cavalry-veteran-v3-before-after.png` +- scale compare: `handpaint-batch5-rebel-cavalry-veteran-v3-scale-compare.png` +- battle composite: `handpaint-batch5-rebel-cavalry-veteran-v3-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch5-rebel-cavalry-veteran-v3-scale-compare.png b/docs/handpaint-batch5-rebel-cavalry-veteran-v3-scale-compare.png new file mode 100644 index 0000000..9461584 Binary files /dev/null and b/docs/handpaint-batch5-rebel-cavalry-veteran-v3-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index 3283980..385fe26 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 24 +- Approved baseline units: 25 - Pending approval units: 0 -- Queued rework units: 67 +- Queued rework units: 66 ## Checked Rules diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index a77bbc0..f13863b 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index c3c414f..16acdff 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 24 +- Approved baseline units: 25 - Pending approval units: 0 -- Queued rework units: 67 +- Queued rework units: 66 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. @@ -14,10 +14,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Next Unit Queue -1. `unit-rebel-cavalry-veteran` - queued-rework, base `border-hits=64`, actions `border-hits=144` -2. `unit-rebel-leader` - queued-rework, base `border-hits=32`, actions `border-hits=72` -3. `unit-rebel-leader-warlord` - queued-rework, base `border-hits=32`, actions `border-hits=78` -4. `unit-rebel-ragged` - queued-rework, base `border-hits=32`, actions `border-hits=72` +1. `unit-rebel-leader` - queued-rework, base `border-hits=32`, actions `border-hits=72` +2. `unit-rebel-leader-warlord` - queued-rework, base `border-hits=32`, actions `border-hits=78` +3. `unit-rebel-ragged` - queued-rework, base `border-hits=32`, actions `border-hits=72` ## Commands Before Approval @@ -44,5 +43,5 @@ pnpm build ## First Task After Current Approval -- Start with `unit-rebel-cavalry-veteran`. +- Start with `unit-rebel-leader`. - Generate source art, assemble sheets, produce contact/GIF/before-after/scale/battle screenshots, then rerun the gates. diff --git a/docs/unit-sprite-rebel-cavalry-veteran-v3-approval-packet.md b/docs/unit-sprite-rebel-cavalry-veteran-v3-approval-packet.md new file mode 100644 index 0000000..a266c64 --- /dev/null +++ b/docs/unit-sprite-rebel-cavalry-veteran-v3-approval-packet.md @@ -0,0 +1,44 @@ +# Rebel Veteran Cavalry v3 Approval Packet + +- unit: `unit-rebel-cavalry-veteran` +- version: `v3` +- source: `docs/handpaint-batch5-rebel-cavalry-veteran-source-v1.png` +- contact sheet: `docs/handpaint-batch5-rebel-cavalry-veteran-v3-contact.png` +- animation: `docs/handpaint-batch5-rebel-cavalry-veteran-v3-animation.gif` +- battle preview: `docs/handpaint-batch5-rebel-cavalry-veteran-v3-debug-preview-battle-check.png` +- before/after: `docs/handpaint-batch5-rebel-cavalry-veteran-v3-before-after.png` +- scale compare: `docs/handpaint-batch5-rebel-cavalry-veteran-v3-scale-compare.png` +- current approval board: `docs/unit-sprite-current-approval-board.png` + +## Visual Decision + +Approved for the continuous production run. + +- 50px battle readability: pass +- Yellow Turban veteran cavalry identity: pass +- horse and rider silhouette: pass +- compact weapon/tile-safe width: pass +- opaque unit body: pass +- frame boundary safety: pass +- idle/action scale stability: pass + +## Technical Checks + +- local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-rebel-cavalry-veteran&v=rebel-cavalry-veteran-v3-final` +- Local browser console errors: `0` +- base partial alpha: `0` +- action partial alpha: `0` +- base frame border hits: `0` +- action frame border hits: `0` +- base empty frames: `0` +- action empty frames: `0` +- base bbox width range: `141..250` +- base bbox height range: `270..288` +- base bottom range: `303..303` +- action bbox width range: `141..267` +- action bbox height range: `270..288` +- action bottom range: `303..303` + +## Notes + +The v3 sheet fixes the earlier cavalry height swing while keeping the mounted silhouette readable. It uses a compact short-weapon posture so the cavalry does not rely on tile-spilling equipment for identity. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index bfdd815..54703a2 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch5-rebel-other.png b/docs/unit-sprite-review-batch5-rebel-other.png index 9902a1a..b0fd848 100644 Binary files a/docs/unit-sprite-review-batch5-rebel-other.png and b/docs/unit-sprite-review-batch5-rebel-other.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index 35ddd9e..dd91632 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index a873b99..94a7eff 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 24, - "queued-rework": 67 + "approved-baseline": 25, + "queued-rework": 66 }, "rows": [ { @@ -1727,7 +1727,7 @@ }, { "batch": "batch5-rebel-other", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-rebel-cavalry-veteran", "base": { "key": "unit-rebel-cavalry-veteran", @@ -1737,23 +1737,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 2540801, - "border_hits": 64, - "min_width": 166, - "max_width": 296, - "min_height": 282, + "opaque_pixels": 1962656, + "border_hits": 0, + "min_width": 141, + "max_width": 250, + "min_height": 270, "max_height": 288, - "min_bottom": 281, - "max_bottom": 287, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 130, - "height_swing": 6, - "bottom_swing": 6, - "battle_min_width_px": 26.5, - "battle_max_width_px": 47.3, - "battle_min_height_px": 45.0, + "width_swing": 109, + "height_swing": 18, + "bottom_swing": 0, + "battle_min_width_px": 22.5, + "battle_max_width_px": 39.9, + "battle_min_height_px": 43.1, "battle_max_height_px": 46.0, - "status": "border-hits=64" + "status": "ok" }, "actions": { "key": "unit-rebel-cavalry-veteran-actions", @@ -1763,23 +1763,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 5689665, - "border_hits": 144, - "min_width": 166, - "max_width": 305, - "min_height": 274, - "max_height": 290, - "min_bottom": 273, - "max_bottom": 289, + "opaque_pixels": 5026307, + "border_hits": 0, + "min_width": 141, + "max_width": 267, + "min_height": 270, + "max_height": 288, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 139, - "height_swing": 16, - "bottom_swing": 16, - "battle_min_width_px": 26.5, - "battle_max_width_px": 48.7, - "battle_min_height_px": 43.8, - "battle_max_height_px": 46.3, - "status": "border-hits=144" + "width_swing": 126, + "height_swing": 18, + "bottom_swing": 0, + "battle_min_width_px": 22.5, + "battle_max_width_px": 42.7, + "battle_min_height_px": 43.1, + "battle_max_height_px": 46.0, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index 5de0e30..1c85af6 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 24 -- queued-rework: 67 +- approved-baseline: 25 +- queued-rework: 66 ## Batch Plan @@ -82,7 +82,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch5-rebel-other | approved-baseline | `unit-rebel-archer-fire` | ok | ok | 161..249 x 288..295 | 161..252 x 285..295 | 25.7..39.8 x 46.0..47.1 | w88 h7 b0 | | batch5-rebel-other | approved-baseline | `unit-rebel-archer-veteran` | ok | ok | 182..233 x 286..290 | 162..243 x 224..290 | 29.1..37.2 x 45.7..46.3 | w51 h4 b0 | | batch1-approved-rebel | approved-baseline | `unit-rebel-cavalry` | ok | ok | 139..289 x 266..281 | 167..286 x 186..282 | 22.2..46.2 x 42.5..44.9 | w150 h15 b3 | -| batch5-rebel-other | queued-rework | `unit-rebel-cavalry-veteran` | border-hits=64 | border-hits=144 | 166..296 x 282..288 | 166..305 x 274..290 | 26.5..47.3 x 45.0..46.0 | w130 h6 b6 | +| batch5-rebel-other | approved-baseline | `unit-rebel-cavalry-veteran` | ok | ok | 141..250 x 270..288 | 141..267 x 270..288 | 22.5..39.9 x 43.1..46.0 | w109 h18 b0 | | batch5-rebel-other | queued-rework | `unit-rebel-leader` | border-hits=32 | border-hits=72 | 200..254 x 266..266 | 200..263 x 265..266 | 31.9..40.6 x 42.5..42.5 | w54 h0 b6 | | batch5-rebel-other | queued-rework | `unit-rebel-leader-warlord` | border-hits=32 | border-hits=78 | 224..266 x 276..277 | 224..275 x 275..277 | 35.8..42.5 x 44.1..44.2 | w42 h1 b6 | | batch5-rebel-other | queued-rework | `unit-rebel-ragged` | border-hits=32 | border-hits=72 | 192..277 x 266..266 | 192..286 x 265..266 | 30.7..44.2 x 42.5..42.5 | w85 h0 b6 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index 3027ed2..7850743 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -18,6 +18,7 @@ "unit-rebel-archer-fire", "unit-rebel-archer-veteran", "unit-rebel-cavalry", + "unit-rebel-cavalry-veteran", "unit-shu-archer", "unit-shu-cavalry", "unit-shu-infantry", @@ -39,7 +40,6 @@ "pendingApproval": [], "currentApprovalCandidate": {}, "nextAfterApproval": [ - "unit-rebel-cavalry-veteran", "unit-rebel-leader", "unit-rebel-leader-warlord", "unit-rebel-ragged" diff --git a/src/assets/images/units/unit-rebel-cavalry-veteran-actions.png b/src/assets/images/units/unit-rebel-cavalry-veteran-actions.png index b684888..fecd76c 100644 Binary files a/src/assets/images/units/unit-rebel-cavalry-veteran-actions.png and b/src/assets/images/units/unit-rebel-cavalry-veteran-actions.png differ diff --git a/src/assets/images/units/unit-rebel-cavalry-veteran.png b/src/assets/images/units/unit-rebel-cavalry-veteran.png index 3dc61b5..53ae358 100644 Binary files a/src/assets/images/units/unit-rebel-cavalry-veteran.png and b/src/assets/images/units/unit-rebel-cavalry-veteran.png differ