diff --git a/docs/handpaint-batch7-ma-dai-source-v2.png b/docs/handpaint-batch7-ma-dai-source-v2.png new file mode 100644 index 0000000..42566ab Binary files /dev/null and b/docs/handpaint-batch7-ma-dai-source-v2.png differ diff --git a/docs/handpaint-batch7-ma-dai-v1-animation.gif b/docs/handpaint-batch7-ma-dai-v1-animation.gif new file mode 100644 index 0000000..d7779f4 Binary files /dev/null and b/docs/handpaint-batch7-ma-dai-v1-animation.gif differ diff --git a/docs/handpaint-batch7-ma-dai-v1-battle-composite.png b/docs/handpaint-batch7-ma-dai-v1-battle-composite.png new file mode 100644 index 0000000..ad73b1a Binary files /dev/null and b/docs/handpaint-batch7-ma-dai-v1-battle-composite.png differ diff --git a/docs/handpaint-batch7-ma-dai-v1-before-after.png b/docs/handpaint-batch7-ma-dai-v1-before-after.png new file mode 100644 index 0000000..0c7cbd6 Binary files /dev/null and b/docs/handpaint-batch7-ma-dai-v1-before-after.png differ diff --git a/docs/handpaint-batch7-ma-dai-v1-contact.png b/docs/handpaint-batch7-ma-dai-v1-contact.png new file mode 100644 index 0000000..7be843c Binary files /dev/null and b/docs/handpaint-batch7-ma-dai-v1-contact.png differ diff --git a/docs/handpaint-batch7-ma-dai-v1-debug-preview-battle-check.png b/docs/handpaint-batch7-ma-dai-v1-debug-preview-battle-check.png new file mode 100644 index 0000000..193bde3 Binary files /dev/null and b/docs/handpaint-batch7-ma-dai-v1-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch7-ma-dai-v1-report.md b/docs/handpaint-batch7-ma-dai-v1-report.md new file mode 100644 index 0000000..e152306 --- /dev/null +++ b/docs/handpaint-batch7-ma-dai-v1-report.md @@ -0,0 +1,24 @@ +# Ma Dai hand-painted v1 report + +- source: `handpaint-batch7-ma-dai-source-v2.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 1892954 +- action partial alpha: 0, opaque pixels: 4248233 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 169..249 +- base bbox height range: 288..290 +- base bottom range: 303..303 +- action bbox width range: 162..239 +- action bbox height range: 284..290 +- action bottom range: 303..303 +- contact: `handpaint-batch7-ma-dai-v1-contact.png` +- animation: `handpaint-batch7-ma-dai-v1-animation.gif` +- before/after: `handpaint-batch7-ma-dai-v1-before-after.png` +- scale compare: `handpaint-batch7-ma-dai-v1-scale-compare.png` +- battle composite: `handpaint-batch7-ma-dai-v1-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch7-ma-dai-v1-scale-compare.png b/docs/handpaint-batch7-ma-dai-v1-scale-compare.png new file mode 100644 index 0000000..0403ca9 Binary files /dev/null and b/docs/handpaint-batch7-ma-dai-v1-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index d781bbd..9b10954 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 82 +- Approved baseline units: 83 - Pending approval units: 0 -- Queued rework units: 9 +- Queued rework units: 8 ## Checked Rules diff --git a/docs/unit-sprite-batch-queue.json b/docs/unit-sprite-batch-queue.json index d5ed806..b400965 100644 --- a/docs/unit-sprite-batch-queue.json +++ b/docs/unit-sprite-batch-queue.json @@ -15,6 +15,7 @@ "unit-lu-bu", "unit-lu-meng", "unit-ma-chao", + "unit-ma-dai", "unit-meng-huo", "unit-nanman-infantry", "unit-nanman-infantry-jungle", @@ -89,8 +90,8 @@ "pendingApproval": [], "nextAfterApproval": [], "stageCounts": { - "approved-baseline": 82, - "queued-rework": 9 + "approved-baseline": 83, + "queued-rework": 8 }, "batches": [ { @@ -1176,24 +1177,10 @@ "label": "Batch 7 unique officers", "total": 19, "stageCounts": { - "approved-baseline": 10, - "queued-rework": 9 + "approved-baseline": 11, + "queued-rework": 8 }, "units": [ - { - "stem": "unit-ma-dai", - "reviewStage": "queued-rework", - "queueRole": "queued rework", - "baseStatus": "border-hits=64", - "actionStatus": "border-hits=144", - "battleBasePx": [ - 25.6, - 46.5, - 45.0, - 46.2 - ], - "spec": null - }, { "stem": "unit-ma-liang", "reviewStage": "queued-rework", @@ -1445,6 +1432,20 @@ 47.3 ], "spec": null + }, + { + "stem": "unit-ma-dai", + "reviewStage": "approved-baseline", + "queueRole": "approved reference", + "baseStatus": "ok", + "actionStatus": "ok", + "battleBasePx": [ + 27.0, + 39.8, + 46.0, + 46.3 + ], + "spec": null } ] } diff --git a/docs/unit-sprite-batch-queue.md b/docs/unit-sprite-batch-queue.md index e5a20a9..2288a0d 100644 --- a/docs/unit-sprite-batch-queue.md +++ b/docs/unit-sprite-batch-queue.md @@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i ## Current State -- Approved baseline units: 82 +- Approved baseline units: 83 - Pending approval units: 0 -- Queued rework units: 9 +- Queued rework units: 8 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` @@ -157,11 +157,10 @@ No next unit is currently defined. - Batch key: `batch7-unique-officer` - Total units: 19 -- Stage counts: approved-baseline 10, queued-rework 9 +- Stage counts: approved-baseline 11, queued-rework 8 | unit | role | stage | status | battle base px | spec | | --- | --- | --- | --- | --- | --- | -| `unit-ma-dai` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 25.6..46.5 x 45.0..46.2 | | | `unit-ma-liang` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | | `unit-pang-tong` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | | `unit-sima-yi` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | @@ -180,3 +179,4 @@ No next unit is currently defined. | `unit-lu-bu` | approved reference | approved-baseline | technical ok | 29.9..40.4 x 44.7..46.3 | | | `unit-lu-meng` | approved reference | approved-baseline | technical ok | 27.0..40.4 x 46.0..46.3 | | | `unit-ma-chao` | approved reference | approved-baseline | technical ok | 26.5..42.0 x 46.0..47.3 | | +| `unit-ma-dai` | approved reference | approved-baseline | technical ok | 27.0..39.8 x 46.0..46.3 | | diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index 5ed3a4e..1fef104 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-ma-dai-v1-approval-packet.md b/docs/unit-sprite-ma-dai-v1-approval-packet.md new file mode 100644 index 0000000..694fb0e --- /dev/null +++ b/docs/unit-sprite-ma-dai-v1-approval-packet.md @@ -0,0 +1,36 @@ +# Ma Dai hand-painted sprite v1 approval packet + +- Unit: `unit-ma-dai` +- Candidate version: `v1` +- Source sheet: `docs/handpaint-batch7-ma-dai-source-v2.png` +- Contact sheet: `docs/handpaint-batch7-ma-dai-v1-contact.png` +- Animation GIF: `docs/handpaint-batch7-ma-dai-v1-animation.gif` +- Before/after: `docs/handpaint-batch7-ma-dai-v1-before-after.png` +- Battle composite: `docs/handpaint-batch7-ma-dai-v1-battle-composite.png` +- Scale compare: `docs/handpaint-batch7-ma-dai-v1-scale-compare.png` +- Local browser check: `docs/handpaint-batch7-ma-dai-v1-debug-preview-battle-check.png` +- Current approval board: `docs/unit-sprite-current-approval-board.png` + +## Visual Decision + +- Approved for continuous production run. +- Direction: disciplined Xiliang follow-up cavalry officer on a dark horse, with olive/iron armor, compact helmet, and controlled spear/saber poses. +- The 100% PC browser debug preview reads as a mounted support cavalry commander, distinct from Ma Chao's white horse and brighter silver lead-lancer silhouette. +- The unit body is opaque and readable at battle scale without base rings, completion badges, slash effects, or other external readability helpers. + +## Technical Checks + +- Local build: `pnpm build` passed. +- Local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-ma-dai&v=ma-dai-v1` +- Local browser console errors: `0` +- Local browser 404s: `0` +- Base partial alpha: `0` +- Action partial alpha: `0` +- Base frame border hits: `0` +- Action frame border hits: `0` +- Base battle size from audit: `27.0..39.8 x 46.0..46.3` + +## Notes + +- An earlier generated source with white motion trails was discarded because it could read like extra UI/effect decoration. +- The accepted source keeps the mounted silhouette clean and effect-free. diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index ad80ee7..063eceb 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 82 +- Approved baseline units: 83 - Pending approval units: 0 -- Queued rework units: 9 +- Queued rework units: 8 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index 78e8449..ab30698 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch7-unique-officer.png b/docs/unit-sprite-review-batch7-unique-officer.png index 76516dc..f7951d6 100644 Binary files a/docs/unit-sprite-review-batch7-unique-officer.png and b/docs/unit-sprite-review-batch7-unique-officer.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index 4142f14..2626026 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index bfe88e8..2ac0527 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 82, - "queued-rework": 9 + "approved-baseline": 83, + "queued-rework": 8 }, "rows": [ { @@ -701,7 +701,7 @@ }, { "batch": "batch7-unique-officer", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-ma-dai", "base": { "key": "unit-ma-dai", @@ -711,23 +711,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 2399821, - "border_hits": 64, - "min_width": 160, - "max_width": 291, - "min_height": 282, - "max_height": 289, - "min_bottom": 281, - "max_bottom": 288, + "opaque_pixels": 1892954, + "border_hits": 0, + "min_width": 169, + "max_width": 249, + "min_height": 288, + "max_height": 290, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 131, - "height_swing": 7, - "bottom_swing": 7, - "battle_min_width_px": 25.6, - "battle_max_width_px": 46.5, - "battle_min_height_px": 45.0, - "battle_max_height_px": 46.2, - "status": "border-hits=64" + "width_swing": 80, + "height_swing": 2, + "bottom_swing": 0, + "battle_min_width_px": 27.0, + "battle_max_width_px": 39.8, + "battle_min_height_px": 46.0, + "battle_max_height_px": 46.3, + "status": "ok" }, "actions": { "key": "unit-ma-dai-actions", @@ -737,23 +737,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 5378536, - "border_hits": 144, - "min_width": 160, - "max_width": 300, - "min_height": 274, + "opaque_pixels": 4248233, + "border_hits": 0, + "min_width": 162, + "max_width": 239, + "min_height": 284, "max_height": 290, - "min_bottom": 273, - "max_bottom": 289, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 140, - "height_swing": 16, - "bottom_swing": 16, - "battle_min_width_px": 25.6, - "battle_max_width_px": 47.9, - "battle_min_height_px": 43.8, + "width_swing": 77, + "height_swing": 6, + "bottom_swing": 0, + "battle_min_width_px": 25.9, + "battle_max_width_px": 38.2, + "battle_min_height_px": 45.4, "battle_max_height_px": 46.3, - "status": "border-hits=144" + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index 4d370e4..9391b54 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 82 -- queued-rework: 9 +- approved-baseline: 83 +- queued-rework: 8 ## Batch Plan @@ -64,7 +64,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch7-unique-officer | approved-baseline | `unit-lu-bu` | ok | ok | 187..253 x 280..290 | 155..271 x 280..290 | 29.9..40.4 x 44.7..46.3 | w66 h10 b0 | | batch7-unique-officer | approved-baseline | `unit-lu-meng` | ok | ok | 169..253 x 288..290 | 153..238 x 286..290 | 27.0..40.4 x 46.0..46.3 | w84 h2 b0 | | batch7-unique-officer | approved-baseline | `unit-ma-chao` | ok | ok | 166..263 x 288..296 | 166..263 x 284..296 | 26.5..42.0 x 46.0..47.3 | w97 h8 b0 | -| batch7-unique-officer | queued-rework | `unit-ma-dai` | border-hits=64 | border-hits=144 | 160..291 x 282..289 | 160..300 x 274..290 | 25.6..46.5 x 45.0..46.2 | w131 h7 b7 | +| batch7-unique-officer | approved-baseline | `unit-ma-dai` | ok | ok | 169..249 x 288..290 | 162..239 x 284..290 | 27.0..39.8 x 46.0..46.3 | w80 h2 b0 | | batch7-unique-officer | queued-rework | `unit-ma-liang` | border-hits=32 | border-hits=98 | 243..246 x 280..281 | 220..255 x 275..281 | 38.8..39.3 x 44.7..44.9 | w3 h1 b6 | | batch6-nanman-special | approved-baseline | `unit-meng-huo` | ok | ok | 174..221 x 286..288 | 149..248 x 275..289 | 27.8..35.3 x 45.7..46.0 | w47 h2 b0 | | batch6-nanman-special | approved-baseline | `unit-nanman-infantry` | ok | ok | 152..219 x 288..288 | 152..243 x 265..288 | 24.3..35.0 x 46.0..46.0 | w67 h0 b0 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index b655ba1..0e24fa1 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -23,6 +23,7 @@ "unit-lu-bu", "unit-lu-meng", "unit-ma-chao", + "unit-ma-dai", "unit-meng-huo", "unit-nanman-infantry", "unit-nanman-infantry-jungle", diff --git a/src/assets/images/units/unit-ma-dai-actions.png b/src/assets/images/units/unit-ma-dai-actions.png index 4882d60..7d529c4 100644 Binary files a/src/assets/images/units/unit-ma-dai-actions.png and b/src/assets/images/units/unit-ma-dai-actions.png differ diff --git a/src/assets/images/units/unit-ma-dai.png b/src/assets/images/units/unit-ma-dai.png index d29f67b..8203fd3 100644 Binary files a/src/assets/images/units/unit-ma-dai.png and b/src/assets/images/units/unit-ma-dai.png differ