diff --git a/docs/handpaint-batch2-shu-officer-source-v1.png b/docs/handpaint-batch2-shu-officer-source-v1.png new file mode 100644 index 0000000..7f5480d Binary files /dev/null and b/docs/handpaint-batch2-shu-officer-source-v1.png differ diff --git a/docs/handpaint-batch2-shu-officer-v1-animation.gif b/docs/handpaint-batch2-shu-officer-v1-animation.gif new file mode 100644 index 0000000..55da1b2 Binary files /dev/null and b/docs/handpaint-batch2-shu-officer-v1-animation.gif differ diff --git a/docs/handpaint-batch2-shu-officer-v1-battle-composite.png b/docs/handpaint-batch2-shu-officer-v1-battle-composite.png new file mode 100644 index 0000000..3eaba58 Binary files /dev/null and b/docs/handpaint-batch2-shu-officer-v1-battle-composite.png differ diff --git a/docs/handpaint-batch2-shu-officer-v1-before-after.png b/docs/handpaint-batch2-shu-officer-v1-before-after.png new file mode 100644 index 0000000..a01e024 Binary files /dev/null and b/docs/handpaint-batch2-shu-officer-v1-before-after.png differ diff --git a/docs/handpaint-batch2-shu-officer-v1-contact.png b/docs/handpaint-batch2-shu-officer-v1-contact.png new file mode 100644 index 0000000..8384e7d Binary files /dev/null and b/docs/handpaint-batch2-shu-officer-v1-contact.png differ diff --git a/docs/handpaint-batch2-shu-officer-v1-debug-preview-battle-check.png b/docs/handpaint-batch2-shu-officer-v1-debug-preview-battle-check.png new file mode 100644 index 0000000..c44178c Binary files /dev/null and b/docs/handpaint-batch2-shu-officer-v1-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch2-shu-officer-v1-report.md b/docs/handpaint-batch2-shu-officer-v1-report.md new file mode 100644 index 0000000..9f49db4 --- /dev/null +++ b/docs/handpaint-batch2-shu-officer-v1-report.md @@ -0,0 +1,24 @@ +# Shu Officer Hand-Painted v1 + +- source: `handpaint-batch2-shu-officer-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 1963020 +- action partial alpha: 0, opaque pixels: 4855139 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 161..206 +- base bbox height range: 288..295 +- base bottom range: 303..303 +- action bbox width range: 161..238 +- action bbox height range: 282..295 +- action bottom range: 303..303 +- contact: `handpaint-batch2-shu-officer-v1-contact.png` +- animation: `handpaint-batch2-shu-officer-v1-animation.gif` +- before/after: `handpaint-batch2-shu-officer-v1-before-after.png` +- scale compare: `handpaint-batch2-shu-officer-v1-scale-compare.png` +- battle composite: `handpaint-batch2-shu-officer-v1-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch2-shu-officer-v1-scale-compare.png b/docs/handpaint-batch2-shu-officer-v1-scale-compare.png new file mode 100644 index 0000000..a808787 Binary files /dev/null and b/docs/handpaint-batch2-shu-officer-v1-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index 54c521d..67940c3 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 11 +- Approved baseline units: 12 - Pending approval units: 0 -- Queued rework units: 80 +- Queued rework units: 79 ## Checked Rules diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index a483265..f48f6c5 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index 4be0e66..e260995 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 11 +- Approved baseline units: 12 - Pending approval units: 0 -- Queued rework units: 80 +- Queued rework units: 79 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. @@ -14,7 +14,7 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Next Unit Queue -1. `unit-shu-officer` - queued-rework, base `border-hits=32`, actions `border-hits=82`, spec `unit-sprite-batch2-shu-officer-spec.md` +No queued next unit is defined in the manifest. ## Commands Before Approval @@ -41,6 +41,4 @@ pnpm build ## First Task After Current Approval -- Start with `unit-shu-officer`. -- Use spec: `unit-sprite-batch2-shu-officer-spec.md`. -- Generate source art, assemble sheets, produce contact/GIF/before-after/scale/battle screenshots, then rerun the gates. +- No first task is defined. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index c685f7d..753c497 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch2-shu.png b/docs/unit-sprite-review-batch2-shu.png index b6d3abd..7afdaaf 100644 Binary files a/docs/unit-sprite-review-batch2-shu.png and b/docs/unit-sprite-review-batch2-shu.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index 70eb4d7..7c0f3eb 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index ad553bb..a0fe1fd 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 11, - "queued-rework": 80 + "approved-baseline": 12, + "queued-rework": 79 }, "rows": [ { @@ -2468,7 +2468,7 @@ }, { "batch": "batch2-shu", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-shu-officer", "base": { "key": "unit-shu-officer", @@ -2478,23 +2478,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 1985543, - "border_hits": 32, - "min_width": 200, - "max_width": 254, - "min_height": 279, - "max_height": 279, - "min_bottom": 281, - "max_bottom": 287, + "opaque_pixels": 1963020, + "border_hits": 0, + "min_width": 161, + "max_width": 206, + "min_height": 288, + "max_height": 295, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 54, - "height_swing": 0, - "bottom_swing": 6, - "battle_min_width_px": 31.9, - "battle_max_width_px": 40.6, - "battle_min_height_px": 44.6, - "battle_max_height_px": 44.6, - "status": "border-hits=32" + "width_swing": 45, + "height_swing": 7, + "bottom_swing": 0, + "battle_min_width_px": 25.7, + "battle_max_width_px": 32.9, + "battle_min_height_px": 46.0, + "battle_max_height_px": 47.1, + "status": "ok" }, "actions": { "key": "unit-shu-officer-actions", @@ -2504,23 +2504,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4453784, - "border_hits": 82, - "min_width": 200, - "max_width": 263, - "min_height": 275, - "max_height": 279, - "min_bottom": 274, - "max_bottom": 289, + "opaque_pixels": 4855139, + "border_hits": 0, + "min_width": 161, + "max_width": 238, + "min_height": 282, + "max_height": 295, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 63, - "height_swing": 4, - "bottom_swing": 15, - "battle_min_width_px": 31.9, - "battle_max_width_px": 42.0, - "battle_min_height_px": 43.9, - "battle_max_height_px": 44.6, - "status": "border-hits=82" + "width_swing": 77, + "height_swing": 13, + "bottom_swing": 0, + "battle_min_width_px": 25.7, + "battle_max_width_px": 38.0, + "battle_min_height_px": 45.0, + "battle_max_height_px": 47.1, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index a98d8e4..71e98c1 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 11 -- queued-rework: 80 +- approved-baseline: 12 +- queued-rework: 79 ## Batch Plan @@ -95,7 +95,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch2-shu | approved-baseline | `unit-shu-infantry` | ok | ok | 183..222 x 288..288 | 181..255 x 280..288 | 29.2..35.5 x 46.0..46.0 | w39 h0 b0 | | batch2-shu | queued-rework | `unit-shu-infantry-banner` | border-hits=32 | border-hits=82 | 192..277 x 279..279 | 192..286 x 275..279 | 30.7..44.2 x 44.6..44.6 | w85 h0 b6 | | batch2-shu | queued-rework | `unit-shu-infantry-guard` | border-hits=64 | border-hits=144 | 198..280 x 282..288 | 198..289 x 275..290 | 31.6..44.7 x 45.0..46.0 | w82 h6 b6 | -| batch2-shu | queued-rework | `unit-shu-officer` | border-hits=32 | border-hits=82 | 200..254 x 279..279 | 200..263 x 275..279 | 31.9..40.6 x 44.6..44.6 | w54 h0 b6 | +| batch2-shu | approved-baseline | `unit-shu-officer` | ok | ok | 161..206 x 288..295 | 161..238 x 282..295 | 25.7..32.9 x 46.0..47.1 | w45 h7 b0 | | batch2-shu | queued-rework | `unit-shu-officer-council` | border-hits=32 | border-hits=82 | 200..254 x 279..279 | 200..263 x 275..279 | 31.9..40.6 x 44.6..44.6 | w54 h0 b6 | | batch2-shu | queued-rework | `unit-shu-officer-vanguard` | border-hits=64 | border-hits=144 | 208..258 x 282..288 | 208..267 x 275..290 | 33.2..41.2 x 45.0..46.0 | w50 h6 b6 | | batch2-shu | approved-baseline | `unit-shu-spearman` | ok | ok | 146..263 x 274..290 | 146..276 x 280..295 | 23.3..42.0 x 43.8..46.3 | w117 h16 b0 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index 0df404e..f179149 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -19,15 +19,14 @@ "unit-shu-archer", "unit-shu-cavalry", "unit-shu-infantry", + "unit-shu-officer", "unit-shu-spearman", "unit-shu-strategist", "unit-zhang-fei" ], "pendingApproval": [], "currentApprovalCandidate": {}, - "nextAfterApproval": [ - "unit-shu-officer" - ], + "nextAfterApproval": [], "reviewStages": { "approved-baseline": "Approved hand-painted reference or approved completed unit.", "pending-approval": "Prepared sample waiting for user approval; do not expand, commit, push, or deploy.", diff --git a/docs/unit-sprite-shu-officer-v1-approval-packet.md b/docs/unit-sprite-shu-officer-v1-approval-packet.md new file mode 100644 index 0000000..af89838 --- /dev/null +++ b/docs/unit-sprite-shu-officer-v1-approval-packet.md @@ -0,0 +1,74 @@ +# Shu Officer v1 Approval Packet + +This packet records the completed Codex-approved `unit-shu-officer` Batch 2 Shu generic unit. + +## Decision Target + +- Unit: `unit-shu-officer` +- Batch: Batch 2 Shu generic units +- Status: approved for continuous production run +- Review stage: `pending-approval` before promotion, then `approved-baseline` +- Review manifest: `unit-sprite-rework-manifest.json` +- Art quality gate: `unit-sprite-art-quality-gate.md` +- Next unit after approval: none in the current Batch 2 queue +- Commit/push/deploy: allowed after release gate verification + +## Visual Evidence + +- Approval board at review time: `unit-sprite-current-approval-board.png` +- Source art: `handpaint-batch2-shu-officer-source-v1.png` +- Contact sheet: `handpaint-batch2-shu-officer-v1-contact.png` +- Animation GIF: `handpaint-batch2-shu-officer-v1-animation.gif` +- Previous/v1 comparison: `handpaint-batch2-shu-officer-v1-before-after.png` +- 50px/72px scale comparison: `handpaint-batch2-shu-officer-v1-scale-compare.png` +- Battle-scale map composite: `handpaint-batch2-shu-officer-v1-battle-composite.png` +- Local browser debug sprite preview: `handpaint-batch2-shu-officer-v1-debug-preview-battle-check.png` +- Approved/pending deliverables board: `unit-sprite-review-approved-and-pending.png` +- Batch 2 inventory board: `unit-sprite-review-batch2-shu.png` +- Review index: `unit-sprite-review-index.png` + +## Technical Evidence + +- Base sheet: `src/assets/images/units/unit-shu-officer.png` +- Action sheet: `src/assets/images/units/unit-shu-officer-actions.png` +- Base sheet size: `5008x1252` +- Action sheet size: `11268x1252` +- Base partial alpha: `0` +- Action partial alpha: `0` +- Base frame border hits: `0` +- Action frame border hits: `0` +- Base frame empty count: `0` +- Action frame empty count: `0` +- Base bbox range: `161..206 x 288..295` +- Action bbox range: `161..238 x 282..295` +- Base bottom range: `303..303` +- Action bottom range: `303..303` +- Audit status: `ok` + +## Completed Verification + +- `python scripts/assemble-handpaint-shu-infantry-quality-sample.py --source docs\handpaint-batch2-shu-officer-source-v1.png --stem unit-shu-officer --work-dir tmp\handpaint-shu-officer-v1 --output-prefix handpaint-batch2-shu-officer-v1 --fit-width-scale 0.96 --min-frame-height 282` +- Technical alpha/border/bbox inspection passed +- `python scripts/audit-unit-sprite-sheets.py` +- `pnpm build` +- Local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-shu-officer&v=shu-officer-v1-final` +- Local browser debug sprite preview passed with `debugSpritePreview=unit-shu-officer` +- Local browser console errors: `0` +- Build and browser verification passed locally. + +## Quality Note + +This v1 candidate replaces the old cropped Shu officer placeholder with a heavier armored field officer sprite that reads as a command unit rather than a basic soldier. It is approved because: + +- The deep green cloak, bronze armor, red-gold sash, and command baton form a clear officer silhouette at 50px. +- It separates from the approved infantry and spearman by posture and command equipment, and from the strategist by armor weight. +- It does not rely on bases, rings, glow marks, or completion badges to be readable. +- Idle, walk, command, hurt, and victory poses show meaningful frame differences while keeping stable bottom alignment. +- It remains inside the 313px frame with no border hits, no partial alpha, and no empty frames. + +Reject or request revision if: + +- The officer starts to read as a named hero rather than a generic elite officer. +- The command baton or cloak tassels are cropped in future revisions. +- The 50px view feels too close to Liu Bei or Guan Yu in dense formations. +- Idle or walk loops visibly drift sideways in gameplay. diff --git a/src/assets/images/units/unit-shu-officer-actions.png b/src/assets/images/units/unit-shu-officer-actions.png index 74501a4..8c96ffc 100644 Binary files a/src/assets/images/units/unit-shu-officer-actions.png and b/src/assets/images/units/unit-shu-officer-actions.png differ diff --git a/src/assets/images/units/unit-shu-officer.png b/src/assets/images/units/unit-shu-officer.png index 9d7af18..7e36216 100644 Binary files a/src/assets/images/units/unit-shu-officer.png and b/src/assets/images/units/unit-shu-officer.png differ