diff --git a/docs/handpaint-batch7-sima-yi-source-v1.png b/docs/handpaint-batch7-sima-yi-source-v1.png new file mode 100644 index 0000000..dea660d Binary files /dev/null and b/docs/handpaint-batch7-sima-yi-source-v1.png differ diff --git a/docs/handpaint-batch7-sima-yi-v2-animation.gif b/docs/handpaint-batch7-sima-yi-v2-animation.gif new file mode 100644 index 0000000..4cf98e1 Binary files /dev/null and b/docs/handpaint-batch7-sima-yi-v2-animation.gif differ diff --git a/docs/handpaint-batch7-sima-yi-v2-battle-composite.png b/docs/handpaint-batch7-sima-yi-v2-battle-composite.png new file mode 100644 index 0000000..4e0dbd1 Binary files /dev/null and b/docs/handpaint-batch7-sima-yi-v2-battle-composite.png differ diff --git a/docs/handpaint-batch7-sima-yi-v2-before-after.png b/docs/handpaint-batch7-sima-yi-v2-before-after.png new file mode 100644 index 0000000..650d7d2 Binary files /dev/null and b/docs/handpaint-batch7-sima-yi-v2-before-after.png differ diff --git a/docs/handpaint-batch7-sima-yi-v2-contact.png b/docs/handpaint-batch7-sima-yi-v2-contact.png new file mode 100644 index 0000000..f24a2d1 Binary files /dev/null and b/docs/handpaint-batch7-sima-yi-v2-contact.png differ diff --git a/docs/handpaint-batch7-sima-yi-v2-debug-preview-battle-check.png b/docs/handpaint-batch7-sima-yi-v2-debug-preview-battle-check.png new file mode 100644 index 0000000..3c6973e Binary files /dev/null and b/docs/handpaint-batch7-sima-yi-v2-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch7-sima-yi-v2-report.md b/docs/handpaint-batch7-sima-yi-v2-report.md new file mode 100644 index 0000000..4c6efe9 --- /dev/null +++ b/docs/handpaint-batch7-sima-yi-v2-report.md @@ -0,0 +1,24 @@ +# Sima Yi hand-painted v2 report + +- source: `handpaint-batch7-sima-yi-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 2302994 +- action partial alpha: 0, opaque pixels: 5483833 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 196..210 +- base bbox height range: 288..288 +- base bottom range: 303..303 +- action bbox width range: 180..267 +- action bbox height range: 286..290 +- action bottom range: 303..303 +- contact: `handpaint-batch7-sima-yi-v2-contact.png` +- animation: `handpaint-batch7-sima-yi-v2-animation.gif` +- before/after: `handpaint-batch7-sima-yi-v2-before-after.png` +- scale compare: `handpaint-batch7-sima-yi-v2-scale-compare.png` +- battle composite: `handpaint-batch7-sima-yi-v2-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch7-sima-yi-v2-scale-compare.png b/docs/handpaint-batch7-sima-yi-v2-scale-compare.png new file mode 100644 index 0000000..46d30ea Binary files /dev/null and b/docs/handpaint-batch7-sima-yi-v2-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index f2053e4..561a9e1 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 85 +- Approved baseline units: 86 - Pending approval units: 0 -- Queued rework units: 6 +- Queued rework units: 5 ## Checked Rules diff --git a/docs/unit-sprite-batch-queue.json b/docs/unit-sprite-batch-queue.json index 980501f..a885ea0 100644 --- a/docs/unit-sprite-batch-queue.json +++ b/docs/unit-sprite-batch-queue.json @@ -55,6 +55,7 @@ "unit-shu-strategist", "unit-shu-strategist-field", "unit-shu-strategist-white", + "unit-sima-yi", "unit-wei-archer", "unit-wei-archer-crossbow", "unit-wei-archer-veteran", @@ -92,8 +93,8 @@ "pendingApproval": [], "nextAfterApproval": [], "stageCounts": { - "approved-baseline": 85, - "queued-rework": 6 + "approved-baseline": 86, + "queued-rework": 5 }, "batches": [ { @@ -1179,24 +1180,10 @@ "label": "Batch 7 unique officers", "total": 19, "stageCounts": { - "approved-baseline": 13, - "queued-rework": 6 + "approved-baseline": 14, + "queued-rework": 5 }, "units": [ - { - "stem": "unit-sima-yi", - "reviewStage": "queued-rework", - "queueRole": "queued rework", - "baseStatus": "border-hits=32", - "actionStatus": "border-hits=98", - "battleBasePx": [ - 38.8, - 39.3, - 44.7, - 44.9 - ], - "spec": null - }, { "stem": "unit-wang-ping", "reviewStage": "queued-rework", @@ -1448,6 +1435,20 @@ 46.0 ], "spec": null + }, + { + "stem": "unit-sima-yi", + "reviewStage": "approved-baseline", + "queueRole": "approved reference", + "baseStatus": "ok", + "actionStatus": "ok", + "battleBasePx": [ + 31.3, + 33.5, + 46.0, + 46.0 + ], + "spec": null } ] } diff --git a/docs/unit-sprite-batch-queue.md b/docs/unit-sprite-batch-queue.md index 6f2a6d0..ae5569c 100644 --- a/docs/unit-sprite-batch-queue.md +++ b/docs/unit-sprite-batch-queue.md @@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i ## Current State -- Approved baseline units: 85 +- Approved baseline units: 86 - Pending approval units: 0 -- Queued rework units: 6 +- Queued rework units: 5 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` @@ -157,11 +157,10 @@ No next unit is currently defined. - Batch key: `batch7-unique-officer` - Total units: 19 -- Stage counts: approved-baseline 13, queued-rework 6 +- Stage counts: approved-baseline 14, queued-rework 5 | unit | role | stage | status | battle base px | spec | | --- | --- | --- | --- | --- | --- | -| `unit-sima-yi` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | | `unit-wang-ping` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 31.9..40.6 x 44.6..44.6 | | | `unit-yan-yan` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 31.0..40.6 x 44.6..44.6 | | | `unit-yi-ji` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | @@ -180,3 +179,4 @@ No next unit is currently defined. | `unit-ma-dai` | approved reference | approved-baseline | technical ok | 27.0..39.8 x 46.0..46.3 | | | `unit-ma-liang` | approved reference | approved-baseline | technical ok | 25.6..38.8 x 46.3..46.3 | | | `unit-pang-tong` | approved reference | approved-baseline | technical ok | 28.0..32.1 x 46.0..46.0 | | +| `unit-sima-yi` | approved reference | approved-baseline | technical ok | 31.3..33.5 x 46.0..46.0 | | diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index 3bc67bc..2eb562a 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index 4982623..78ec2b5 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 85 +- Approved baseline units: 86 - Pending approval units: 0 -- Queued rework units: 6 +- Queued rework units: 5 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index cf8410b..e169ee1 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch7-unique-officer.png b/docs/unit-sprite-review-batch7-unique-officer.png index d894525..3e0f6ab 100644 Binary files a/docs/unit-sprite-review-batch7-unique-officer.png and b/docs/unit-sprite-review-batch7-unique-officer.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index 472991a..2d513cc 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index 07fcd1a..a0c507b 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 85, - "queued-rework": 6 + "approved-baseline": 86, + "queued-rework": 5 }, "rows": [ { @@ -2981,7 +2981,7 @@ }, { "batch": "batch7-unique-officer", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-sima-yi", "base": { "key": "unit-sima-yi", @@ -2991,23 +2991,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 1999925, - "border_hits": 32, - "min_width": 243, - "max_width": 246, - "min_height": 280, - "max_height": 281, - "min_bottom": 281, - "max_bottom": 287, + "opaque_pixels": 2302994, + "border_hits": 0, + "min_width": 196, + "max_width": 210, + "min_height": 288, + "max_height": 288, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 3, - "height_swing": 1, - "bottom_swing": 6, - "battle_min_width_px": 38.8, - "battle_max_width_px": 39.3, - "battle_min_height_px": 44.7, - "battle_max_height_px": 44.9, - "status": "border-hits=32" + "width_swing": 14, + "height_swing": 0, + "bottom_swing": 0, + "battle_min_width_px": 31.3, + "battle_max_width_px": 33.5, + "battle_min_height_px": 46.0, + "battle_max_height_px": 46.0, + "status": "ok" }, "actions": { "key": "unit-sima-yi-actions", @@ -3017,23 +3017,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4453376, - "border_hits": 98, - "min_width": 220, - "max_width": 255, - "min_height": 275, - "max_height": 281, - "min_bottom": 274, - "max_bottom": 289, + "opaque_pixels": 5483833, + "border_hits": 0, + "min_width": 180, + "max_width": 267, + "min_height": 286, + "max_height": 290, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 35, - "height_swing": 6, - "bottom_swing": 15, - "battle_min_width_px": 35.1, - "battle_max_width_px": 40.7, - "battle_min_height_px": 43.9, - "battle_max_height_px": 44.9, - "status": "border-hits=98" + "width_swing": 87, + "height_swing": 4, + "bottom_swing": 0, + "battle_min_width_px": 28.8, + "battle_max_width_px": 42.7, + "battle_min_height_px": 45.7, + "battle_max_height_px": 46.3, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index eda080f..0011333 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 85 -- queued-rework: 6 +- approved-baseline: 86 +- queued-rework: 5 ## Batch Plan @@ -104,7 +104,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch2-shu | approved-baseline | `unit-shu-strategist` | ok | ok | 156..214 x 282..293 | 155..243 x 282..293 | 24.9..34.2 x 45.0..46.8 | w58 h11 b0 | | batch2-shu | approved-baseline | `unit-shu-strategist-field` | ok | ok | 166..206 x 277..295 | 166..269 x 277..295 | 26.5..32.9 x 44.2..47.1 | w40 h18 b0 | | batch2-shu | approved-baseline | `unit-shu-strategist-white` | ok | ok | 156..205 x 277..295 | 156..269 x 276..295 | 24.9..32.7 x 44.2..47.1 | w49 h18 b0 | -| batch7-unique-officer | queued-rework | `unit-sima-yi` | border-hits=32 | border-hits=98 | 243..246 x 280..281 | 220..255 x 275..281 | 38.8..39.3 x 44.7..44.9 | w3 h1 b6 | +| batch7-unique-officer | approved-baseline | `unit-sima-yi` | ok | ok | 196..210 x 288..288 | 180..267 x 286..290 | 31.3..33.5 x 46.0..46.0 | w14 h0 b0 | | batch7-unique-officer | queued-rework | `unit-wang-ping` | border-hits=32 | border-hits=82 | 200..254 x 279..279 | 200..263 x 275..279 | 31.9..40.6 x 44.6..44.6 | w54 h0 b6 | | batch3-wei | approved-baseline | `unit-wei-archer` | ok | ok | 190..245 x 288..296 | 190..245 x 282..296 | 30.4..39.1 x 46.0..47.3 | w55 h8 b0 | | batch3-wei | approved-baseline | `unit-wei-archer-crossbow` | ok | ok | 186..230 x 288..290 | 169..276 x 249..290 | 29.7..36.7 x 46.0..46.3 | w44 h2 b0 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index e775f46..1d8cd43 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -63,6 +63,7 @@ "unit-shu-strategist", "unit-shu-strategist-field", "unit-shu-strategist-white", + "unit-sima-yi", "unit-wei-archer", "unit-wei-archer-crossbow", "unit-wei-archer-veteran", diff --git a/docs/unit-sprite-sima-yi-v2-approval-packet.md b/docs/unit-sprite-sima-yi-v2-approval-packet.md new file mode 100644 index 0000000..a6913fc --- /dev/null +++ b/docs/unit-sprite-sima-yi-v2-approval-packet.md @@ -0,0 +1,35 @@ +# Sima Yi hand-painted v2 approval packet + +- unit: `unit-sima-yi` +- candidate: `handpaint-batch7-sima-yi-v2` +- source: `docs/handpaint-batch7-sima-yi-source-v1.png` +- contact sheet: `docs/handpaint-batch7-sima-yi-v2-contact.png` +- animation: `docs/handpaint-batch7-sima-yi-v2-animation.gif` +- before/after: `docs/handpaint-batch7-sima-yi-v2-before-after.png` +- battle composite: `docs/handpaint-batch7-sima-yi-v2-battle-composite.png` +- current approval board: `docs/unit-sprite-current-approval-board.png` +- browser check: `docs/handpaint-batch7-sima-yi-v2-debug-preview-battle-check.png` + +## Result + +- Local build: `pnpm build` passed. +- Local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-sima-yi&v=sima-yi-v2` +- Local browser console errors: `0` +- Local browser 404s: `0` +- Sample gate: passed. + +## Sprite safety + +- base partial alpha: 0 +- action partial alpha: 0 +- base frame border hits: 0 +- action frame border hits: 0 +- base battle size: 31.3..33.5 x 46.0..46.0 +- frame bbox width: 196..210 base, 180..267 action +- frame bbox height: 288 base, 286..290 action + +## Visual notes + +- v1 had solid art direction but failed the art gate because its battle-scale width stayed below 32px. +- v2 widens the robe silhouette while preserving the cold Wei strategist read and frame safety. +- Midnight-blue robe, silver trim, official cap, and iron fan/document distinguish Sima Yi from Pang Tong and Ma Liang at 50px scale. diff --git a/src/assets/images/units/unit-sima-yi-actions.png b/src/assets/images/units/unit-sima-yi-actions.png index 71c6937..47bd21b 100644 Binary files a/src/assets/images/units/unit-sima-yi-actions.png and b/src/assets/images/units/unit-sima-yi-actions.png differ diff --git a/src/assets/images/units/unit-sima-yi.png b/src/assets/images/units/unit-sima-yi.png index d87603e..ec04fa1 100644 Binary files a/src/assets/images/units/unit-sima-yi.png and b/src/assets/images/units/unit-sima-yi.png differ