Strengthen Sima Yi court strategist identity
BIN
docs/propfix-sima-yi-v2-animation.gif
Normal file
|
After Width: | Height: | Size: 172 KiB |
BIN
docs/propfix-sima-yi-v2-battle-composite.png
Normal file
|
After Width: | Height: | Size: 884 KiB |
BIN
docs/propfix-sima-yi-v2-before-after.png
Normal file
|
After Width: | Height: | Size: 57 KiB |
BIN
docs/propfix-sima-yi-v2-browser-check.png
Normal file
|
After Width: | Height: | Size: 138 KiB |
BIN
docs/propfix-sima-yi-v2-contact.png
Normal file
|
After Width: | Height: | Size: 162 KiB |
BIN
docs/propfix-sima-yi-v2-prod-browser-check.png
Normal file
|
After Width: | Height: | Size: 138 KiB |
31
docs/propfix-sima-yi-v2-report.md
Normal file
@@ -0,0 +1,31 @@
|
||||
# Sima Yi Court Conspirator v2 report
|
||||
|
||||
- source: `propfix-sima-yi-v2-source.png`
|
||||
- base status: ok
|
||||
- action status: ok
|
||||
- base partial alpha: 0, opaque pixels: 1836114
|
||||
- action partial alpha: 0, opaque pixels: 3816484
|
||||
- base frame border hits: 0
|
||||
- action frame border hits: 0
|
||||
- base empty frames: 0
|
||||
- action empty frames: 0
|
||||
- base bbox width range: 136..186
|
||||
- base bbox height range: 282..290
|
||||
- base bottom range: 303..303
|
||||
- action bbox width range: 112..184
|
||||
- action bbox height range: 282..295
|
||||
- action bottom range: 303..303
|
||||
- contact: `propfix-sima-yi-v2-contact.png`
|
||||
- animation: `propfix-sima-yi-v2-animation.gif`
|
||||
- before/after: `propfix-sima-yi-v2-before-after.png`
|
||||
- scale compare: `propfix-sima-yi-v2-scale-compare.png`
|
||||
- battle composite: `propfix-sima-yi-v2-battle-composite.png`
|
||||
- local browser check: `propfix-sima-yi-v2-browser-check.png`
|
||||
- identity check: no white feather fan, no large fan, and no records-officer map read; Sima Yi reads as a named Wei court conspirator through the tall black court crown, black command tablet, sealed military order, dark decree scroll, bronze tally baton, and narrow command rod.
|
||||
- build: `pnpm build` passed using the bundled Node runtime path.
|
||||
- local browser verification: passed at `http://127.0.0.1:4175/heros_web/?debug&debugSpritePreview=unit-sima-yi&v=sima-yi-v2-local`
|
||||
- local console errors: 0
|
||||
- deployed browser check: `propfix-sima-yi-v2-prod-browser-check.png`
|
||||
- deployed browser verification: passed at `https://comtropy.synology.me/heros_web/?debug&debugSpritePreview=unit-sima-yi&v=sima-yi-v2-prod`
|
||||
- deployed console errors: 0
|
||||
- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval
|
||||
BIN
docs/propfix-sima-yi-v2-scale-compare.png
Normal file
|
After Width: | Height: | Size: 41 KiB |
BIN
docs/propfix-sima-yi-v2-source.png
Normal file
|
After Width: | Height: | Size: 2.0 MiB |
@@ -32,8 +32,7 @@ Zhuge Liang owns the large white feather fan and white-robed sage read. Other st
|
||||
|
||||
## Next Representative Fixes
|
||||
|
||||
1. `unit-sima-yi`: confirm the named Wei conspirator remains darker and more distinctive than generic Wei strategists.
|
||||
2. `unit-huang-quan`: verify the quartermaster official stays records/map focused without a fan read.
|
||||
1. `unit-huang-quan`: verify the quartermaster official stays records/map focused without a fan read.
|
||||
|
||||
Completed representative pass:
|
||||
|
||||
@@ -45,5 +44,6 @@ Completed representative pass:
|
||||
- `unit-shu-strategist-field`: changed from white-fan sage-like field strategist to rugged Shu frontline staff officer with folded field map, short baton, bamboo slips, leather scroll case, and order pouch.
|
||||
- `unit-wei-strategist-black`: changed from white-fan black strategist to generic Wei covert adviser with black command tablet, sealed military order, iron tally baton, lacquer case, and compact war ledger.
|
||||
- `unit-wei-strategist-blue`: changed from white-fan blue strategist to Wei records officer with map scroll, registry book, bamboo-slip ledger, bronze command tablet, and document case.
|
||||
- `unit-sima-yi`: strengthened from generic dark strategist to named Wei court conspirator with tall black court crown, black lacquer command tablet, sealed military order, dark decree scroll, bronze tally baton, and narrow command rod.
|
||||
|
||||
Every representative fix should include contact sheet, animation GIF, battle preview, before/after, alpha audit, build, and browser check.
|
||||
|
||||
@@ -19,7 +19,7 @@ Detailed per-unit visual direction lives in `strategist-character-direction.md`.
|
||||
| `unit-zhuge-liang` | large white feather fan | allowed signature prop | keep |
|
||||
| `unit-ma-liang` | white eyebrows, bamboo slips, bound book, scroll case | white robe/fan read removed while preserving Ma Liang's white-eyebrow identity | fixed in follow-up |
|
||||
| `unit-pang-tong` | dark wood slips, compact dark folded fan, scroll bundles | no white feather fan | fixed in batch 1 |
|
||||
| `unit-sima-yi` | black command tablet, sealed military order, tally baton | fan removed | fixed in batch 1 |
|
||||
| `unit-sima-yi` | black lacquer command tablet, sealed military order, dark decree scroll, bronze tally baton, narrow command rod | fan removed; named Wei court conspirator identity strengthened | fixed in representative pass |
|
||||
| `unit-fa-zheng` | campaign map board, command slips, tally baton | fan removed | fixed in batch 1 |
|
||||
| `unit-yi-ji` | letter, bamboo slips, scroll | distinct civil envoy | keep |
|
||||
| `unit-huang-quan` | bamboo slips, map board, baton | distinct quartermaster official | keep |
|
||||
@@ -48,7 +48,6 @@ The first correction batch changes:
|
||||
|
||||
Next representative cleanup order:
|
||||
|
||||
1. `unit-sima-yi`
|
||||
2. `unit-huang-quan`
|
||||
1. `unit-huang-quan`
|
||||
|
||||
Later cleanup should remove white-feather-fan reads from remaining generic strategist variants after the representative fixes are verified.
|
||||
|
||||
@@ -1376,10 +1376,10 @@
|
||||
"baseStatus": "ok",
|
||||
"actionStatus": "ok",
|
||||
"battleBasePx": [
|
||||
25.4,
|
||||
37.9,
|
||||
21.7,
|
||||
29.7,
|
||||
45.0,
|
||||
47.0
|
||||
46.3
|
||||
],
|
||||
"spec": null
|
||||
},
|
||||
|
||||
@@ -174,7 +174,7 @@ No next unit is currently defined.
|
||||
| `unit-ma-dai` | approved reference | approved-baseline | technical ok | 27.0..39.8 x 46.0..46.3 | |
|
||||
| `unit-ma-liang` | approved reference | approved-baseline | technical ok | 26.5..35.8 x 45.0..46.3 | |
|
||||
| `unit-pang-tong` | approved reference | approved-baseline | technical ok | 24.3..32.7 x 45.0..46.3 | |
|
||||
| `unit-sima-yi` | approved reference | approved-baseline | technical ok | 25.4..37.9 x 45.0..47.0 | |
|
||||
| `unit-sima-yi` | approved reference | approved-baseline | technical ok | 21.7..29.7 x 45.0..46.3 | |
|
||||
| `unit-wang-ping` | approved reference | approved-baseline | technical ok | 28.0..33.7 x 45.7..46.0 | |
|
||||
| `unit-yan-yan` | approved reference | approved-baseline | technical ok | 30.4..37.5 x 45.7..46.0 | |
|
||||
| `unit-yi-ji` | approved reference | approved-baseline | technical ok | 27.8..33.9 x 45.7..46.0 | |
|
||||
|
||||
|
Before Width: | Height: | Size: 839 KiB After Width: | Height: | Size: 838 KiB |
|
Before Width: | Height: | Size: 171 KiB After Width: | Height: | Size: 170 KiB |
|
Before Width: | Height: | Size: 96 KiB After Width: | Height: | Size: 96 KiB |
@@ -2990,22 +2990,22 @@
|
||||
1252
|
||||
],
|
||||
"partial_alpha": 0,
|
||||
"opaque_pixels": 2205012,
|
||||
"opaque_pixels": 1836114,
|
||||
"border_hits": 0,
|
||||
"min_width": 159,
|
||||
"max_width": 237,
|
||||
"min_width": 136,
|
||||
"max_width": 186,
|
||||
"min_height": 282,
|
||||
"max_height": 294,
|
||||
"max_height": 290,
|
||||
"min_bottom": 303,
|
||||
"max_bottom": 303,
|
||||
"empty_frames": 0,
|
||||
"width_swing": 78,
|
||||
"height_swing": 12,
|
||||
"width_swing": 50,
|
||||
"height_swing": 8,
|
||||
"bottom_swing": 0,
|
||||
"battle_min_width_px": 25.4,
|
||||
"battle_max_width_px": 37.9,
|
||||
"battle_min_width_px": 21.7,
|
||||
"battle_max_width_px": 29.7,
|
||||
"battle_min_height_px": 45.0,
|
||||
"battle_max_height_px": 47.0,
|
||||
"battle_max_height_px": 46.3,
|
||||
"status": "ok"
|
||||
},
|
||||
"actions": {
|
||||
@@ -3016,22 +3016,22 @@
|
||||
1252
|
||||
],
|
||||
"partial_alpha": 0,
|
||||
"opaque_pixels": 4503608,
|
||||
"opaque_pixels": 3816484,
|
||||
"border_hits": 0,
|
||||
"min_width": 137,
|
||||
"max_width": 224,
|
||||
"min_height": 276,
|
||||
"max_height": 294,
|
||||
"min_width": 112,
|
||||
"max_width": 184,
|
||||
"min_height": 282,
|
||||
"max_height": 295,
|
||||
"min_bottom": 303,
|
||||
"max_bottom": 303,
|
||||
"empty_frames": 0,
|
||||
"width_swing": 87,
|
||||
"height_swing": 18,
|
||||
"width_swing": 72,
|
||||
"height_swing": 13,
|
||||
"bottom_swing": 0,
|
||||
"battle_min_width_px": 21.9,
|
||||
"battle_max_width_px": 35.8,
|
||||
"battle_min_height_px": 44.1,
|
||||
"battle_max_height_px": 47.0,
|
||||
"battle_min_width_px": 17.9,
|
||||
"battle_max_width_px": 29.4,
|
||||
"battle_min_height_px": 45.0,
|
||||
"battle_max_height_px": 47.1,
|
||||
"status": "ok"
|
||||
}
|
||||
},
|
||||
|
||||
@@ -103,7 +103,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards.
|
||||
| batch2-shu | approved-baseline | `unit-shu-strategist` | ok | ok | 149..249 x 282..288 | 125..237 x 248..288 | 23.8..39.8 x 45.0..46.0 | w100 h6 b0 |
|
||||
| batch2-shu | approved-baseline | `unit-shu-strategist-field` | ok | ok | 144..202 x 287..295 | 130..230 x 282..295 | 23.0..32.3 x 45.8..47.1 | w58 h8 b0 |
|
||||
| batch2-shu | approved-baseline | `unit-shu-strategist-white` | ok | ok | 167..222 x 282..290 | 140..209 x 282..295 | 26.7..35.5 x 45.0..46.3 | w55 h8 b0 |
|
||||
| batch7-unique-officer | approved-baseline | `unit-sima-yi` | ok | ok | 159..237 x 282..294 | 137..224 x 276..294 | 25.4..37.9 x 45.0..47.0 | w78 h12 b0 |
|
||||
| batch7-unique-officer | approved-baseline | `unit-sima-yi` | ok | ok | 136..186 x 282..290 | 112..184 x 282..295 | 21.7..29.7 x 45.0..46.3 | w50 h8 b0 |
|
||||
| batch7-unique-officer | approved-baseline | `unit-wang-ping` | ok | ok | 175..211 x 286..288 | 158..256 x 286..295 | 28.0..33.7 x 45.7..46.0 | w36 h2 b0 |
|
||||
| batch3-wei | approved-baseline | `unit-wei-archer` | ok | ok | 190..245 x 288..296 | 190..245 x 282..296 | 30.4..39.1 x 46.0..47.3 | w55 h8 b0 |
|
||||
| batch3-wei | approved-baseline | `unit-wei-archer-crossbow` | ok | ok | 186..230 x 288..290 | 169..276 x 249..290 | 29.7..36.7 x 46.0..46.3 | w44 h2 b0 |
|
||||
|
||||