diff --git a/docs/handpaint-batch3-wei-officer-source-v1.png b/docs/handpaint-batch3-wei-officer-source-v1.png new file mode 100644 index 0000000..b0b29ef Binary files /dev/null and b/docs/handpaint-batch3-wei-officer-source-v1.png differ diff --git a/docs/handpaint-batch3-wei-officer-v2-animation.gif b/docs/handpaint-batch3-wei-officer-v2-animation.gif new file mode 100644 index 0000000..48f6874 Binary files /dev/null and b/docs/handpaint-batch3-wei-officer-v2-animation.gif differ diff --git a/docs/handpaint-batch3-wei-officer-v2-battle-composite.png b/docs/handpaint-batch3-wei-officer-v2-battle-composite.png new file mode 100644 index 0000000..728b027 Binary files /dev/null and b/docs/handpaint-batch3-wei-officer-v2-battle-composite.png differ diff --git a/docs/handpaint-batch3-wei-officer-v2-before-after.png b/docs/handpaint-batch3-wei-officer-v2-before-after.png new file mode 100644 index 0000000..014fcc3 Binary files /dev/null and b/docs/handpaint-batch3-wei-officer-v2-before-after.png differ diff --git a/docs/handpaint-batch3-wei-officer-v2-contact.png b/docs/handpaint-batch3-wei-officer-v2-contact.png new file mode 100644 index 0000000..6101cbe Binary files /dev/null and b/docs/handpaint-batch3-wei-officer-v2-contact.png differ diff --git a/docs/handpaint-batch3-wei-officer-v2-debug-preview-battle-check.png b/docs/handpaint-batch3-wei-officer-v2-debug-preview-battle-check.png new file mode 100644 index 0000000..984fa4c Binary files /dev/null and b/docs/handpaint-batch3-wei-officer-v2-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch3-wei-officer-v2-report.md b/docs/handpaint-batch3-wei-officer-v2-report.md new file mode 100644 index 0000000..1cd43aa --- /dev/null +++ b/docs/handpaint-batch3-wei-officer-v2-report.md @@ -0,0 +1,24 @@ +# Wei Officer Hand-Painted v2 + +- source: `handpaint-batch3-wei-officer-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 1894536 +- action partial alpha: 0, opaque pixels: 4588531 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 159..207 +- base bbox height range: 288..295 +- base bottom range: 303..303 +- action bbox width range: 158..255 +- action bbox height range: 288..295 +- action bottom range: 303..303 +- contact: `handpaint-batch3-wei-officer-v2-contact.png` +- animation: `handpaint-batch3-wei-officer-v2-animation.gif` +- before/after: `handpaint-batch3-wei-officer-v2-before-after.png` +- scale compare: `handpaint-batch3-wei-officer-v2-scale-compare.png` +- battle composite: `handpaint-batch3-wei-officer-v2-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch3-wei-officer-v2-scale-compare.png b/docs/handpaint-batch3-wei-officer-v2-scale-compare.png new file mode 100644 index 0000000..612b575 Binary files /dev/null and b/docs/handpaint-batch3-wei-officer-v2-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index cbd673b..36482d7 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 16 +- Approved baseline units: 17 - Pending approval units: 0 -- Queued rework units: 75 +- Queued rework units: 74 ## Checked Rules diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index c0a02a5..79f2468 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index d12b9ad..305319a 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 16 +- Approved baseline units: 17 - Pending approval units: 0 -- Queued rework units: 75 +- Queued rework units: 74 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. @@ -14,7 +14,7 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Next Unit Queue -1. `unit-wei-officer` - queued-rework, base `border-hits=32`, actions `border-hits=82` +No queued next unit is defined in the manifest. ## Commands Before Approval @@ -41,5 +41,4 @@ pnpm build ## First Task After Current Approval -- Start with `unit-wei-officer`. -- Generate source art, assemble sheets, produce contact/GIF/before-after/scale/battle screenshots, then rerun the gates. +- No first task is defined. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index 521de9f..dc06ff2 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch3-wei.png b/docs/unit-sprite-review-batch3-wei.png index fa6f8fc..f302000 100644 Binary files a/docs/unit-sprite-review-batch3-wei.png and b/docs/unit-sprite-review-batch3-wei.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index ec7ea0a..fb9ecb3 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index 8caf8e8..a0cafc9 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 16, - "queued-rework": 75 + "approved-baseline": 17, + "queued-rework": 74 }, "rows": [ { @@ -3608,7 +3608,7 @@ }, { "batch": "batch3-wei", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-wei-officer", "base": { "key": "unit-wei-officer", @@ -3618,23 +3618,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 1985543, - "border_hits": 32, - "min_width": 200, - "max_width": 254, - "min_height": 279, - "max_height": 279, - "min_bottom": 281, - "max_bottom": 287, + "opaque_pixels": 1894536, + "border_hits": 0, + "min_width": 159, + "max_width": 207, + "min_height": 288, + "max_height": 295, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 54, - "height_swing": 0, - "bottom_swing": 6, - "battle_min_width_px": 31.9, - "battle_max_width_px": 40.6, - "battle_min_height_px": 44.6, - "battle_max_height_px": 44.6, - "status": "border-hits=32" + "width_swing": 48, + "height_swing": 7, + "bottom_swing": 0, + "battle_min_width_px": 25.4, + "battle_max_width_px": 33.1, + "battle_min_height_px": 46.0, + "battle_max_height_px": 47.1, + "status": "ok" }, "actions": { "key": "unit-wei-officer-actions", @@ -3644,23 +3644,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4453784, - "border_hits": 82, - "min_width": 200, - "max_width": 263, - "min_height": 275, - "max_height": 279, - "min_bottom": 274, - "max_bottom": 289, + "opaque_pixels": 4588531, + "border_hits": 0, + "min_width": 158, + "max_width": 255, + "min_height": 288, + "max_height": 295, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 63, - "height_swing": 4, - "bottom_swing": 15, - "battle_min_width_px": 31.9, - "battle_max_width_px": 42.0, - "battle_min_height_px": 43.9, - "battle_max_height_px": 44.6, - "status": "border-hits=82" + "width_swing": 97, + "height_swing": 7, + "bottom_swing": 0, + "battle_min_width_px": 25.2, + "battle_max_width_px": 40.7, + "battle_min_height_px": 46.0, + "battle_max_height_px": 47.1, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index b7609cb..6198579 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 16 -- queued-rework: 75 +- approved-baseline: 17 +- queued-rework: 74 ## Batch Plan @@ -115,7 +115,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch3-wei | approved-baseline | `unit-wei-infantry` | ok | ok | 174..223 x 282..295 | 154..248 x 282..295 | 27.8..35.6 x 45.0..47.1 | w49 h13 b0 | | batch3-wei | queued-rework | `unit-wei-infantry-shield` | border-hits=32 | border-hits=82 | 192..277 x 279..279 | 192..286 x 275..279 | 30.7..44.2 x 44.6..44.6 | w85 h0 b6 | | batch3-wei | queued-rework | `unit-wei-infantry-veteran` | border-hits=64 | border-hits=144 | 198..280 x 282..288 | 198..289 x 275..290 | 31.6..44.7 x 45.0..46.0 | w82 h6 b6 | -| batch3-wei | queued-rework | `unit-wei-officer` | border-hits=32 | border-hits=82 | 200..254 x 279..279 | 200..263 x 275..279 | 31.9..40.6 x 44.6..44.6 | w54 h0 b6 | +| batch3-wei | approved-baseline | `unit-wei-officer` | ok | ok | 159..207 x 288..295 | 158..255 x 288..295 | 25.4..33.1 x 46.0..47.1 | w48 h7 b0 | | batch3-wei | queued-rework | `unit-wei-officer-gate` | border-hits=32 | border-hits=82 | 200..254 x 279..279 | 200..263 x 275..279 | 31.9..40.6 x 44.6..44.6 | w54 h0 b6 | | batch3-wei | queued-rework | `unit-wei-officer-iron` | border-hits=64 | border-hits=144 | 208..258 x 282..288 | 208..267 x 275..290 | 33.2..41.2 x 45.0..46.0 | w50 h6 b6 | | batch3-wei | approved-baseline | `unit-wei-strategist` | ok | ok | 160..233 x 290..290 | 160..243 x 288..290 | 25.6..37.2 x 46.3..46.3 | w73 h0 b0 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index cdff940..861e9f9 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -25,14 +25,13 @@ "unit-wei-archer", "unit-wei-cavalry", "unit-wei-infantry", + "unit-wei-officer", "unit-wei-strategist", "unit-zhang-fei" ], "pendingApproval": [], "currentApprovalCandidate": {}, - "nextAfterApproval": [ - "unit-wei-officer" - ], + "nextAfterApproval": [], "reviewStages": { "approved-baseline": "Approved hand-painted reference or approved completed unit.", "pending-approval": "Prepared sample waiting for user approval; do not expand, commit, push, or deploy.", diff --git a/docs/unit-sprite-wei-officer-v2-approval-packet.md b/docs/unit-sprite-wei-officer-v2-approval-packet.md new file mode 100644 index 0000000..e2163fa --- /dev/null +++ b/docs/unit-sprite-wei-officer-v2-approval-packet.md @@ -0,0 +1,44 @@ +# Wei Officer v2 Approval Packet + +- unit: `unit-wei-officer` +- version: `v2` +- source: `docs/handpaint-batch3-wei-officer-source-v1.png` +- contact sheet: `docs/handpaint-batch3-wei-officer-v2-contact.png` +- animation: `docs/handpaint-batch3-wei-officer-v2-animation.gif` +- battle preview: `docs/handpaint-batch3-wei-officer-v2-debug-preview-battle-check.png` +- before/after: `docs/handpaint-batch3-wei-officer-v2-before-after.png` +- scale compare: `docs/handpaint-batch3-wei-officer-v2-scale-compare.png` +- current approval board: `docs/unit-sprite-current-approval-board.png` + +## Visual Decision + +Approved for the continuous production run. + +- 50px battle readability: pass +- Wei faction officer identity: pass +- officer armor/cloak/command sword silhouette: pass +- avoids archer, cavalry, strategist, or long-polearm read: pass +- opaque unit body: pass +- frame boundary safety: pass +- idle/action scale stability: pass + +## Technical Checks + +- local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-wei-officer&v=wei-officer-v2-final` +- Local browser console errors: `0` +- base partial alpha: `0` +- action partial alpha: `0` +- base frame border hits: `0` +- action frame border hits: `0` +- base empty frames: `0` +- action empty frames: `0` +- base bbox width range: `159..207` +- base bbox height range: `288..295` +- base bottom range: `303..303` +- action bbox width range: `158..255` +- action bbox height range: `288..295` +- action bottom range: `303..303` + +## Notes + +The v2 sheet slightly widens the officer silhouette so the armor, cloak, and command sword remain readable at 50px while staying clearly below the unique-hero visual weight. diff --git a/src/assets/images/units/unit-wei-officer-actions.png b/src/assets/images/units/unit-wei-officer-actions.png index c08933e..545f462 100644 Binary files a/src/assets/images/units/unit-wei-officer-actions.png and b/src/assets/images/units/unit-wei-officer-actions.png differ diff --git a/src/assets/images/units/unit-wei-officer.png b/src/assets/images/units/unit-wei-officer.png index 77ec97a..60d46dd 100644 Binary files a/src/assets/images/units/unit-wei-officer.png and b/src/assets/images/units/unit-wei-officer.png differ