diff --git a/docs/handpaint-batch7-wang-ping-source-v1.png b/docs/handpaint-batch7-wang-ping-source-v1.png new file mode 100644 index 0000000..6862d9a Binary files /dev/null and b/docs/handpaint-batch7-wang-ping-source-v1.png differ diff --git a/docs/handpaint-batch7-wang-ping-v2-animation.gif b/docs/handpaint-batch7-wang-ping-v2-animation.gif new file mode 100644 index 0000000..2a7bcf1 Binary files /dev/null and b/docs/handpaint-batch7-wang-ping-v2-animation.gif differ diff --git a/docs/handpaint-batch7-wang-ping-v2-battle-composite.png b/docs/handpaint-batch7-wang-ping-v2-battle-composite.png new file mode 100644 index 0000000..d62c83a Binary files /dev/null and b/docs/handpaint-batch7-wang-ping-v2-battle-composite.png differ diff --git a/docs/handpaint-batch7-wang-ping-v2-before-after.png b/docs/handpaint-batch7-wang-ping-v2-before-after.png new file mode 100644 index 0000000..84f15ce Binary files /dev/null and b/docs/handpaint-batch7-wang-ping-v2-before-after.png differ diff --git a/docs/handpaint-batch7-wang-ping-v2-contact.png b/docs/handpaint-batch7-wang-ping-v2-contact.png new file mode 100644 index 0000000..b8cfac3 Binary files /dev/null and b/docs/handpaint-batch7-wang-ping-v2-contact.png differ diff --git a/docs/handpaint-batch7-wang-ping-v2-debug-preview-battle-check.png b/docs/handpaint-batch7-wang-ping-v2-debug-preview-battle-check.png new file mode 100644 index 0000000..cb52022 Binary files /dev/null and b/docs/handpaint-batch7-wang-ping-v2-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch7-wang-ping-v2-report.md b/docs/handpaint-batch7-wang-ping-v2-report.md new file mode 100644 index 0000000..31ac732 --- /dev/null +++ b/docs/handpaint-batch7-wang-ping-v2-report.md @@ -0,0 +1,24 @@ +# Wang Ping hand-painted v2 report + +- source: `handpaint-batch7-wang-ping-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 2167696 +- action partial alpha: 0, opaque pixels: 4212994 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 175..211 +- base bbox height range: 286..288 +- base bottom range: 303..303 +- action bbox width range: 158..256 +- action bbox height range: 286..295 +- action bottom range: 303..303 +- contact: `handpaint-batch7-wang-ping-v2-contact.png` +- animation: `handpaint-batch7-wang-ping-v2-animation.gif` +- before/after: `handpaint-batch7-wang-ping-v2-before-after.png` +- scale compare: `handpaint-batch7-wang-ping-v2-scale-compare.png` +- battle composite: `handpaint-batch7-wang-ping-v2-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch7-wang-ping-v2-scale-compare.png b/docs/handpaint-batch7-wang-ping-v2-scale-compare.png new file mode 100644 index 0000000..625535a Binary files /dev/null and b/docs/handpaint-batch7-wang-ping-v2-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index 561a9e1..17f7443 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 86 +- Approved baseline units: 87 - Pending approval units: 0 -- Queued rework units: 5 +- Queued rework units: 4 ## Checked Rules diff --git a/docs/unit-sprite-batch-queue.json b/docs/unit-sprite-batch-queue.json index a885ea0..f771240 100644 --- a/docs/unit-sprite-batch-queue.json +++ b/docs/unit-sprite-batch-queue.json @@ -56,6 +56,7 @@ "unit-shu-strategist-field", "unit-shu-strategist-white", "unit-sima-yi", + "unit-wang-ping", "unit-wei-archer", "unit-wei-archer-crossbow", "unit-wei-archer-veteran", @@ -93,8 +94,8 @@ "pendingApproval": [], "nextAfterApproval": [], "stageCounts": { - "approved-baseline": 86, - "queued-rework": 5 + "approved-baseline": 87, + "queued-rework": 4 }, "batches": [ { @@ -1180,24 +1181,10 @@ "label": "Batch 7 unique officers", "total": 19, "stageCounts": { - "approved-baseline": 14, - "queued-rework": 5 + "approved-baseline": 15, + "queued-rework": 4 }, "units": [ - { - "stem": "unit-wang-ping", - "reviewStage": "queued-rework", - "queueRole": "queued rework", - "baseStatus": "border-hits=32", - "actionStatus": "border-hits=82", - "battleBasePx": [ - 31.9, - 40.6, - 44.6, - 44.6 - ], - "spec": null - }, { "stem": "unit-yan-yan", "reviewStage": "queued-rework", @@ -1449,6 +1436,20 @@ 46.0 ], "spec": null + }, + { + "stem": "unit-wang-ping", + "reviewStage": "approved-baseline", + "queueRole": "approved reference", + "baseStatus": "ok", + "actionStatus": "ok", + "battleBasePx": [ + 28.0, + 33.7, + 45.7, + 46.0 + ], + "spec": null } ] } diff --git a/docs/unit-sprite-batch-queue.md b/docs/unit-sprite-batch-queue.md index ae5569c..34471f3 100644 --- a/docs/unit-sprite-batch-queue.md +++ b/docs/unit-sprite-batch-queue.md @@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i ## Current State -- Approved baseline units: 86 +- Approved baseline units: 87 - Pending approval units: 0 -- Queued rework units: 5 +- Queued rework units: 4 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` @@ -157,11 +157,10 @@ No next unit is currently defined. - Batch key: `batch7-unique-officer` - Total units: 19 -- Stage counts: approved-baseline 14, queued-rework 5 +- Stage counts: approved-baseline 15, queued-rework 4 | unit | role | stage | status | battle base px | spec | | --- | --- | --- | --- | --- | --- | -| `unit-wang-ping` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 31.9..40.6 x 44.6..44.6 | | | `unit-yan-yan` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 31.0..40.6 x 44.6..44.6 | | | `unit-yi-ji` | queued rework | queued-rework | base border-hits=32; actions border-hits=98 | 38.8..39.3 x 44.7..44.9 | | | `unit-zhao-yun` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 26.5..47.3 x 45.0..46.0 | | @@ -180,3 +179,4 @@ No next unit is currently defined. | `unit-ma-liang` | approved reference | approved-baseline | technical ok | 25.6..38.8 x 46.3..46.3 | | | `unit-pang-tong` | approved reference | approved-baseline | technical ok | 28.0..32.1 x 46.0..46.0 | | | `unit-sima-yi` | approved reference | approved-baseline | technical ok | 31.3..33.5 x 46.0..46.0 | | +| `unit-wang-ping` | approved reference | approved-baseline | technical ok | 28.0..33.7 x 45.7..46.0 | | diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index 2eb562a..2332b1b 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index 78ec2b5..5897f17 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 86 +- Approved baseline units: 87 - Pending approval units: 0 -- Queued rework units: 5 +- Queued rework units: 4 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index e169ee1..2e2bdfe 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch7-unique-officer.png b/docs/unit-sprite-review-batch7-unique-officer.png index 3e0f6ab..f50c5b4 100644 Binary files a/docs/unit-sprite-review-batch7-unique-officer.png and b/docs/unit-sprite-review-batch7-unique-officer.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index 2d513cc..330086b 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index a0c507b..f8a016f 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 86, - "queued-rework": 5 + "approved-baseline": 87, + "queued-rework": 4 }, "rows": [ { @@ -3038,7 +3038,7 @@ }, { "batch": "batch7-unique-officer", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-wang-ping", "base": { "key": "unit-wang-ping", @@ -3048,23 +3048,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 1985543, - "border_hits": 32, - "min_width": 200, - "max_width": 254, - "min_height": 279, - "max_height": 279, - "min_bottom": 281, - "max_bottom": 287, + "opaque_pixels": 2167696, + "border_hits": 0, + "min_width": 175, + "max_width": 211, + "min_height": 286, + "max_height": 288, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 54, - "height_swing": 0, - "bottom_swing": 6, - "battle_min_width_px": 31.9, - "battle_max_width_px": 40.6, - "battle_min_height_px": 44.6, - "battle_max_height_px": 44.6, - "status": "border-hits=32" + "width_swing": 36, + "height_swing": 2, + "bottom_swing": 0, + "battle_min_width_px": 28.0, + "battle_max_width_px": 33.7, + "battle_min_height_px": 45.7, + "battle_max_height_px": 46.0, + "status": "ok" }, "actions": { "key": "unit-wang-ping-actions", @@ -3074,23 +3074,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4453784, - "border_hits": 82, - "min_width": 200, - "max_width": 263, - "min_height": 275, - "max_height": 279, - "min_bottom": 274, - "max_bottom": 289, + "opaque_pixels": 4212994, + "border_hits": 0, + "min_width": 158, + "max_width": 256, + "min_height": 286, + "max_height": 295, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 63, - "height_swing": 4, - "bottom_swing": 15, - "battle_min_width_px": 31.9, - "battle_max_width_px": 42.0, - "battle_min_height_px": 43.9, - "battle_max_height_px": 44.6, - "status": "border-hits=82" + "width_swing": 98, + "height_swing": 9, + "bottom_swing": 0, + "battle_min_width_px": 25.2, + "battle_max_width_px": 40.9, + "battle_min_height_px": 45.7, + "battle_max_height_px": 47.1, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index 0011333..5bd65b6 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 86 -- queued-rework: 5 +- approved-baseline: 87 +- queued-rework: 4 ## Batch Plan @@ -105,7 +105,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch2-shu | approved-baseline | `unit-shu-strategist-field` | ok | ok | 166..206 x 277..295 | 166..269 x 277..295 | 26.5..32.9 x 44.2..47.1 | w40 h18 b0 | | batch2-shu | approved-baseline | `unit-shu-strategist-white` | ok | ok | 156..205 x 277..295 | 156..269 x 276..295 | 24.9..32.7 x 44.2..47.1 | w49 h18 b0 | | batch7-unique-officer | approved-baseline | `unit-sima-yi` | ok | ok | 196..210 x 288..288 | 180..267 x 286..290 | 31.3..33.5 x 46.0..46.0 | w14 h0 b0 | -| batch7-unique-officer | queued-rework | `unit-wang-ping` | border-hits=32 | border-hits=82 | 200..254 x 279..279 | 200..263 x 275..279 | 31.9..40.6 x 44.6..44.6 | w54 h0 b6 | +| batch7-unique-officer | approved-baseline | `unit-wang-ping` | ok | ok | 175..211 x 286..288 | 158..256 x 286..295 | 28.0..33.7 x 45.7..46.0 | w36 h2 b0 | | batch3-wei | approved-baseline | `unit-wei-archer` | ok | ok | 190..245 x 288..296 | 190..245 x 282..296 | 30.4..39.1 x 46.0..47.3 | w55 h8 b0 | | batch3-wei | approved-baseline | `unit-wei-archer-crossbow` | ok | ok | 186..230 x 288..290 | 169..276 x 249..290 | 29.7..36.7 x 46.0..46.3 | w44 h2 b0 | | batch3-wei | approved-baseline | `unit-wei-archer-veteran` | ok | ok | 176..229 x 277..295 | 176..250 x 277..295 | 28.1..36.6 x 44.2..47.1 | w53 h18 b0 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index 1d8cd43..d47272f 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -64,6 +64,7 @@ "unit-shu-strategist-field", "unit-shu-strategist-white", "unit-sima-yi", + "unit-wang-ping", "unit-wei-archer", "unit-wei-archer-crossbow", "unit-wei-archer-veteran", diff --git a/docs/unit-sprite-wang-ping-v2-approval-packet.md b/docs/unit-sprite-wang-ping-v2-approval-packet.md new file mode 100644 index 0000000..057de45 --- /dev/null +++ b/docs/unit-sprite-wang-ping-v2-approval-packet.md @@ -0,0 +1,35 @@ +# Wang Ping hand-painted v2 approval packet + +- unit: `unit-wang-ping` +- candidate: `handpaint-batch7-wang-ping-v2` +- source: `docs/handpaint-batch7-wang-ping-source-v1.png` +- contact sheet: `docs/handpaint-batch7-wang-ping-v2-contact.png` +- animation: `docs/handpaint-batch7-wang-ping-v2-animation.gif` +- before/after: `docs/handpaint-batch7-wang-ping-v2-before-after.png` +- battle composite: `docs/handpaint-batch7-wang-ping-v2-battle-composite.png` +- current approval board: `docs/unit-sprite-current-approval-board.png` +- browser check: `docs/handpaint-batch7-wang-ping-v2-debug-preview-battle-check.png` + +## Result + +- Local build: `pnpm build` passed. +- Local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-wang-ping&v=wang-ping-v2` +- Local browser console errors: `0` +- Local browser 404s: `0` +- Sample gate: passed. + +## Sprite safety + +- base partial alpha: 0 +- action partial alpha: 0 +- base frame border hits: 0 +- action frame border hits: 0 +- base battle size: 28.0..33.7 x 45.7..46.0 +- frame bbox width: 175..211 base, 158..256 action +- frame bbox height: 286..288 base, 286..295 action + +## Visual notes + +- v1 art direction was strong but too close to the width threshold, so v2 slightly widens the armor and shield mass. +- Shield, short dao, muted teal armor, and route-map/marker details make Wang Ping read as a defensive mountain-path officer. +- The sprite stays fully opaque and does not rely on rings, bases, or completion badges for visibility. diff --git a/src/assets/images/units/unit-wang-ping-actions.png b/src/assets/images/units/unit-wang-ping-actions.png index 74501a4..b47e814 100644 Binary files a/src/assets/images/units/unit-wang-ping-actions.png and b/src/assets/images/units/unit-wang-ping-actions.png differ diff --git a/src/assets/images/units/unit-wang-ping.png b/src/assets/images/units/unit-wang-ping.png index 9d7af18..9fce8c0 100644 Binary files a/src/assets/images/units/unit-wang-ping.png and b/src/assets/images/units/unit-wang-ping.png differ