diff --git a/docs/handpaint-batch6-nanman-officer-source-v1.png b/docs/handpaint-batch6-nanman-officer-source-v1.png new file mode 100644 index 0000000..793224a Binary files /dev/null and b/docs/handpaint-batch6-nanman-officer-source-v1.png differ diff --git a/docs/handpaint-batch6-nanman-officer-v1-animation.gif b/docs/handpaint-batch6-nanman-officer-v1-animation.gif new file mode 100644 index 0000000..8f8bbb6 Binary files /dev/null and b/docs/handpaint-batch6-nanman-officer-v1-animation.gif differ diff --git a/docs/handpaint-batch6-nanman-officer-v1-battle-composite.png b/docs/handpaint-batch6-nanman-officer-v1-battle-composite.png new file mode 100644 index 0000000..fc4a616 Binary files /dev/null and b/docs/handpaint-batch6-nanman-officer-v1-battle-composite.png differ diff --git a/docs/handpaint-batch6-nanman-officer-v1-before-after.png b/docs/handpaint-batch6-nanman-officer-v1-before-after.png new file mode 100644 index 0000000..e66d8df Binary files /dev/null and b/docs/handpaint-batch6-nanman-officer-v1-before-after.png differ diff --git a/docs/handpaint-batch6-nanman-officer-v1-contact.png b/docs/handpaint-batch6-nanman-officer-v1-contact.png new file mode 100644 index 0000000..f9fb90a Binary files /dev/null and b/docs/handpaint-batch6-nanman-officer-v1-contact.png differ diff --git a/docs/handpaint-batch6-nanman-officer-v1-debug-preview-battle-check.png b/docs/handpaint-batch6-nanman-officer-v1-debug-preview-battle-check.png new file mode 100644 index 0000000..0632758 Binary files /dev/null and b/docs/handpaint-batch6-nanman-officer-v1-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch6-nanman-officer-v1-report.md b/docs/handpaint-batch6-nanman-officer-v1-report.md new file mode 100644 index 0000000..9fa7785 --- /dev/null +++ b/docs/handpaint-batch6-nanman-officer-v1-report.md @@ -0,0 +1,24 @@ +# Nanman Officer Hand-Painted v1 + +- source: `handpaint-batch6-nanman-officer-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 1878466 +- action partial alpha: 0, opaque pixels: 4921985 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 163..215 +- base bbox height range: 288..288 +- base bottom range: 303..303 +- action bbox width range: 159..238 +- action bbox height range: 280..288 +- action bottom range: 303..303 +- contact: `handpaint-batch6-nanman-officer-v1-contact.png` +- animation: `handpaint-batch6-nanman-officer-v1-animation.gif` +- before/after: `handpaint-batch6-nanman-officer-v1-before-after.png` +- scale compare: `handpaint-batch6-nanman-officer-v1-scale-compare.png` +- battle composite: `handpaint-batch6-nanman-officer-v1-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch6-nanman-officer-v1-scale-compare.png b/docs/handpaint-batch6-nanman-officer-v1-scale-compare.png new file mode 100644 index 0000000..3515214 Binary files /dev/null and b/docs/handpaint-batch6-nanman-officer-v1-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index 068131a..8f853ad 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 32 +- Approved baseline units: 33 - Pending approval units: 0 -- Queued rework units: 59 +- Queued rework units: 58 ## Checked Rules diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index 6a79a81..5ed5954 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-nanman-officer-v1-approval-packet.md b/docs/unit-sprite-nanman-officer-v1-approval-packet.md new file mode 100644 index 0000000..f33baf5 --- /dev/null +++ b/docs/unit-sprite-nanman-officer-v1-approval-packet.md @@ -0,0 +1,36 @@ +# Unit Sprite Approval Packet: unit-nanman-officer v1 + +- Status: approved during continuous production run +- Source art: `docs/handpaint-batch6-nanman-officer-source-v1.png` +- Contact sheet: `docs/handpaint-batch6-nanman-officer-v1-contact.png` +- Animation GIF: `docs/handpaint-batch6-nanman-officer-v1-animation.gif` +- Before/after: `docs/handpaint-batch6-nanman-officer-v1-before-after.png` +- Scale compare: `docs/handpaint-batch6-nanman-officer-v1-scale-compare.png` +- Browser check: `docs/handpaint-batch6-nanman-officer-v1-debug-preview-battle-check.png` +- Current approval board: `docs/unit-sprite-current-approval-board.png` +- Debug preview URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-nanman-officer&v=nanman-officer-v1-final` + +## Visual Decision + +Nanman officer v1 is accepted as a mid-tier southern commander sprite. The shield, saber, feathers, and heavier leather/bronze silhouette distinguish it from Nanman infantry while staying less massive and ornate than Meng Huo. + +## Technical Checks + +- Base partial alpha: `0` +- Action partial alpha: `0` +- Base frame border hits: `0` +- Action frame border hits: `0` +- Base empty frames: `0` +- Action empty frames: `0` +- Base bbox width range: `163..215` +- Base bbox height range: `288..288` +- Base bottom range: `303..303` +- Action bbox width range: `159..238` +- Action bbox height range: `280..288` +- Action bottom range: `303..303` +- Local build: `passed` +- Local browser console errors: `0` + +## Notes + +The battle-scale preview reads clearly at desktop 100% zoom without relying on external rings, bases, or badges. The unit stays inside the intended frame margins and keeps a stable bottom anchor across idle, walk, and action states. diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index c40a46a..7a3325f 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 32 +- Approved baseline units: 33 - Pending approval units: 0 -- Queued rework units: 59 +- Queued rework units: 58 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. @@ -14,12 +14,11 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Next Unit Queue -1. `unit-nanman-officer` - queued-rework, base `border-hits=32`, actions `border-hits=82` -2. `unit-nanman-officer-bronze` - queued-rework, base `border-hits=64`, actions `border-hits=144` -3. `unit-nanman-officer-warlord` - queued-rework, base `border-hits=64`, actions `border-hits=144` -4. `unit-nanman-shaman` - queued-rework, base `border-hits=32`, actions `border-hits=98` -5. `unit-nanman-shaman-ember` - queued-rework, base `border-hits=32`, actions `border-hits=98` -6. `unit-nanman-shaman-storm` - queued-rework, base `border-hits=32`, actions `border-hits=98` +1. `unit-nanman-officer-bronze` - queued-rework, base `border-hits=64`, actions `border-hits=144` +2. `unit-nanman-officer-warlord` - queued-rework, base `border-hits=64`, actions `border-hits=144` +3. `unit-nanman-shaman` - queued-rework, base `border-hits=32`, actions `border-hits=98` +4. `unit-nanman-shaman-ember` - queued-rework, base `border-hits=32`, actions `border-hits=98` +5. `unit-nanman-shaman-storm` - queued-rework, base `border-hits=32`, actions `border-hits=98` ## Commands Before Approval @@ -46,5 +45,5 @@ pnpm build ## First Task After Current Approval -- Start with `unit-nanman-officer`. +- Start with `unit-nanman-officer-bronze`. - Generate source art, assemble sheets, produce contact/GIF/before-after/scale/battle screenshots, then rerun the gates. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index 19497e8..b23696e 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch6-nanman-special.png b/docs/unit-sprite-review-batch6-nanman-special.png index 08fb2d1..bfa3de7 100644 Binary files a/docs/unit-sprite-review-batch6-nanman-special.png and b/docs/unit-sprite-review-batch6-nanman-special.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index 3b58bfb..b892523 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index a8cb604..f8698c3 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 32, - "queued-rework": 59 + "approved-baseline": 33, + "queued-rework": 58 }, "rows": [ { @@ -1043,7 +1043,7 @@ }, { "batch": "batch6-nanman-special", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-nanman-officer", "base": { "key": "unit-nanman-officer", @@ -1053,23 +1053,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 1985543, - "border_hits": 32, - "min_width": 200, - "max_width": 254, - "min_height": 279, - "max_height": 279, - "min_bottom": 281, - "max_bottom": 287, + "opaque_pixels": 1878466, + "border_hits": 0, + "min_width": 163, + "max_width": 215, + "min_height": 288, + "max_height": 288, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 54, + "width_swing": 52, "height_swing": 0, - "bottom_swing": 6, - "battle_min_width_px": 31.9, - "battle_max_width_px": 40.6, - "battle_min_height_px": 44.6, - "battle_max_height_px": 44.6, - "status": "border-hits=32" + "bottom_swing": 0, + "battle_min_width_px": 26.0, + "battle_max_width_px": 34.3, + "battle_min_height_px": 46.0, + "battle_max_height_px": 46.0, + "status": "ok" }, "actions": { "key": "unit-nanman-officer-actions", @@ -1079,23 +1079,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 4453784, - "border_hits": 82, - "min_width": 200, - "max_width": 263, - "min_height": 275, - "max_height": 279, - "min_bottom": 274, - "max_bottom": 289, + "opaque_pixels": 4921985, + "border_hits": 0, + "min_width": 159, + "max_width": 238, + "min_height": 280, + "max_height": 288, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 63, - "height_swing": 4, - "bottom_swing": 15, - "battle_min_width_px": 31.9, - "battle_max_width_px": 42.0, - "battle_min_height_px": 43.9, - "battle_max_height_px": 44.6, - "status": "border-hits=82" + "width_swing": 79, + "height_swing": 8, + "bottom_swing": 0, + "battle_min_width_px": 25.4, + "battle_max_width_px": 38.0, + "battle_min_height_px": 44.7, + "battle_max_height_px": 46.0, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index 686fecb..f738608 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 32 -- queued-rework: 59 +- approved-baseline: 33 +- queued-rework: 58 ## Batch Plan @@ -70,7 +70,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch6-nanman-special | approved-baseline | `unit-nanman-infantry` | ok | ok | 152..219 x 288..288 | 152..243 x 265..288 | 24.3..35.0 x 46.0..46.0 | w67 h0 b0 | | batch6-nanman-special | approved-baseline | `unit-nanman-infantry-jungle` | ok | ok | 172..209 x 286..288 | 158..247 x 282..288 | 27.5..33.4 x 45.7..46.0 | w37 h2 b0 | | batch6-nanman-special | approved-baseline | `unit-nanman-infantry-spear` | ok | ok | 138..219 x 286..288 | 137..263 x 277..289 | 22.0..35.0 x 45.7..46.0 | w81 h2 b0 | -| batch6-nanman-special | queued-rework | `unit-nanman-officer` | border-hits=32 | border-hits=82 | 200..254 x 279..279 | 200..263 x 275..279 | 31.9..40.6 x 44.6..44.6 | w54 h0 b6 | +| batch6-nanman-special | approved-baseline | `unit-nanman-officer` | ok | ok | 163..215 x 288..288 | 159..238 x 280..288 | 26.0..34.3 x 46.0..46.0 | w52 h0 b0 | | batch6-nanman-special | queued-rework | `unit-nanman-officer-bronze` | border-hits=64 | border-hits=144 | 208..258 x 282..288 | 208..267 x 275..290 | 33.2..41.2 x 45.0..46.0 | w50 h6 b6 | | batch6-nanman-special | queued-rework | `unit-nanman-officer-warlord` | border-hits=64 | border-hits=144 | 224..266 x 282..288 | 224..275 x 275..290 | 35.8..42.5 x 45.0..46.0 | w42 h6 b6 | | batch6-nanman-special | queued-rework | `unit-nanman-shaman` | border-hits=32 | border-hits=98 | 243..246 x 280..281 | 220..255 x 275..281 | 38.8..39.3 x 44.7..44.9 | w3 h1 b6 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index 353086d..76bcc4a 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -17,6 +17,7 @@ "unit-nanman-infantry", "unit-nanman-infantry-jungle", "unit-nanman-infantry-spear", + "unit-nanman-officer", "unit-rebel", "unit-rebel-archer", "unit-rebel-archer-fire", @@ -47,7 +48,6 @@ "pendingApproval": [], "currentApprovalCandidate": {}, "nextAfterApproval": [ - "unit-nanman-officer", "unit-nanman-officer-bronze", "unit-nanman-officer-warlord", "unit-nanman-shaman", diff --git a/src/assets/images/units/unit-nanman-officer-actions.png b/src/assets/images/units/unit-nanman-officer-actions.png index 3577da8..36fe3d8 100644 Binary files a/src/assets/images/units/unit-nanman-officer-actions.png and b/src/assets/images/units/unit-nanman-officer-actions.png differ diff --git a/src/assets/images/units/unit-nanman-officer.png b/src/assets/images/units/unit-nanman-officer.png index 4e4b48d..f56f6cd 100644 Binary files a/src/assets/images/units/unit-nanman-officer.png and b/src/assets/images/units/unit-nanman-officer.png differ