diff --git a/docs/handpaint-batch3-wei-cavalry-source-v1.png b/docs/handpaint-batch3-wei-cavalry-source-v1.png new file mode 100644 index 0000000..cf13f0e Binary files /dev/null and b/docs/handpaint-batch3-wei-cavalry-source-v1.png differ diff --git a/docs/handpaint-batch3-wei-cavalry-v2-animation.gif b/docs/handpaint-batch3-wei-cavalry-v2-animation.gif new file mode 100644 index 0000000..9b37059 Binary files /dev/null and b/docs/handpaint-batch3-wei-cavalry-v2-animation.gif differ diff --git a/docs/handpaint-batch3-wei-cavalry-v2-battle-composite.png b/docs/handpaint-batch3-wei-cavalry-v2-battle-composite.png new file mode 100644 index 0000000..2d4fd6a Binary files /dev/null and b/docs/handpaint-batch3-wei-cavalry-v2-battle-composite.png differ diff --git a/docs/handpaint-batch3-wei-cavalry-v2-before-after.png b/docs/handpaint-batch3-wei-cavalry-v2-before-after.png new file mode 100644 index 0000000..5f4300e Binary files /dev/null and b/docs/handpaint-batch3-wei-cavalry-v2-before-after.png differ diff --git a/docs/handpaint-batch3-wei-cavalry-v2-contact.png b/docs/handpaint-batch3-wei-cavalry-v2-contact.png new file mode 100644 index 0000000..98c4b85 Binary files /dev/null and b/docs/handpaint-batch3-wei-cavalry-v2-contact.png differ diff --git a/docs/handpaint-batch3-wei-cavalry-v2-debug-preview-battle-check.png b/docs/handpaint-batch3-wei-cavalry-v2-debug-preview-battle-check.png new file mode 100644 index 0000000..e38d52f Binary files /dev/null and b/docs/handpaint-batch3-wei-cavalry-v2-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch3-wei-cavalry-v2-report.md b/docs/handpaint-batch3-wei-cavalry-v2-report.md new file mode 100644 index 0000000..10c47da --- /dev/null +++ b/docs/handpaint-batch3-wei-cavalry-v2-report.md @@ -0,0 +1,24 @@ +# Wei Cavalry Hand-Painted v2 + +- source: `handpaint-batch3-wei-cavalry-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 2008836 +- action partial alpha: 0, opaque pixels: 4957773 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 146..266 +- base bbox height range: 288..295 +- base bottom range: 303..303 +- action bbox width range: 146..292 +- action bbox height range: 260..295 +- action bottom range: 303..303 +- contact: `handpaint-batch3-wei-cavalry-v2-contact.png` +- animation: `handpaint-batch3-wei-cavalry-v2-animation.gif` +- before/after: `handpaint-batch3-wei-cavalry-v2-before-after.png` +- scale compare: `handpaint-batch3-wei-cavalry-v2-scale-compare.png` +- battle composite: `handpaint-batch3-wei-cavalry-v2-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch3-wei-cavalry-v2-scale-compare.png b/docs/handpaint-batch3-wei-cavalry-v2-scale-compare.png new file mode 100644 index 0000000..00f019a Binary files /dev/null and b/docs/handpaint-batch3-wei-cavalry-v2-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index 5e879b0..6a929e5 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 14 +- Approved baseline units: 15 - Pending approval units: 0 -- Queued rework units: 77 +- Queued rework units: 76 ## Checked Rules diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index 94fbdea..c7add6c 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index 10d1808..9e34742 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 14 +- Approved baseline units: 15 - Pending approval units: 0 -- Queued rework units: 77 +- Queued rework units: 76 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. @@ -14,9 +14,8 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Next Unit Queue -1. `unit-wei-cavalry` - queued-rework, base `border-hits=64`, actions `border-hits=144` -2. `unit-wei-strategist` - queued-rework, base `border-hits=32`, actions `border-hits=98` -3. `unit-wei-officer` - queued-rework, base `border-hits=32`, actions `border-hits=82` +1. `unit-wei-strategist` - queued-rework, base `border-hits=32`, actions `border-hits=98` +2. `unit-wei-officer` - queued-rework, base `border-hits=32`, actions `border-hits=82` ## Commands Before Approval @@ -43,5 +42,5 @@ pnpm build ## First Task After Current Approval -- Start with `unit-wei-cavalry`. +- Start with `unit-wei-strategist`. - Generate source art, assemble sheets, produce contact/GIF/before-after/scale/battle screenshots, then rerun the gates. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index e96733a..9a159a5 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch3-wei.png b/docs/unit-sprite-review-batch3-wei.png index 302587b..dd26559 100644 Binary files a/docs/unit-sprite-review-batch3-wei.png and b/docs/unit-sprite-review-batch3-wei.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index b95de96..00fdea9 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index 451d65c..2f0df01 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 14, - "queued-rework": 77 + "approved-baseline": 15, + "queued-rework": 76 }, "rows": [ { @@ -3266,7 +3266,7 @@ }, { "batch": "batch3-wei", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-wei-cavalry", "base": { "key": "unit-wei-cavalry", @@ -3276,23 +3276,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 2399821, - "border_hits": 64, - "min_width": 160, - "max_width": 291, - "min_height": 282, - "max_height": 289, - "min_bottom": 281, - "max_bottom": 288, + "opaque_pixels": 2008836, + "border_hits": 0, + "min_width": 146, + "max_width": 266, + "min_height": 288, + "max_height": 295, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 131, + "width_swing": 120, "height_swing": 7, - "bottom_swing": 7, - "battle_min_width_px": 25.6, - "battle_max_width_px": 46.5, - "battle_min_height_px": 45.0, - "battle_max_height_px": 46.2, - "status": "border-hits=64" + "bottom_swing": 0, + "battle_min_width_px": 23.3, + "battle_max_width_px": 42.5, + "battle_min_height_px": 46.0, + "battle_max_height_px": 47.1, + "status": "ok" }, "actions": { "key": "unit-wei-cavalry-actions", @@ -3302,23 +3302,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 5378536, - "border_hits": 144, - "min_width": 160, - "max_width": 300, - "min_height": 274, - "max_height": 290, - "min_bottom": 273, - "max_bottom": 289, + "opaque_pixels": 4957773, + "border_hits": 0, + "min_width": 146, + "max_width": 292, + "min_height": 260, + "max_height": 295, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 140, - "height_swing": 16, - "bottom_swing": 16, - "battle_min_width_px": 25.6, - "battle_max_width_px": 47.9, - "battle_min_height_px": 43.8, - "battle_max_height_px": 46.3, - "status": "border-hits=144" + "width_swing": 146, + "height_swing": 35, + "bottom_swing": 0, + "battle_min_width_px": 23.3, + "battle_max_width_px": 46.6, + "battle_min_height_px": 41.5, + "battle_max_height_px": 47.1, + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index c4952df..c9e26a4 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 14 -- queued-rework: 77 +- approved-baseline: 15 +- queued-rework: 76 ## Batch Plan @@ -109,7 +109,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch3-wei | approved-baseline | `unit-wei-archer` | ok | ok | 190..245 x 288..296 | 190..245 x 282..296 | 30.4..39.1 x 46.0..47.3 | w55 h8 b0 | | batch3-wei | queued-rework | `unit-wei-archer-crossbow` | border-hits=64 | border-hits=144 | 245..246 x 279..279 | 220..255 x 275..279 | 39.1..39.3 x 44.6..44.6 | w1 h0 b6 | | batch3-wei | queued-rework | `unit-wei-archer-veteran` | border-hits=64 | border-hits=144 | 249..250 x 282..288 | 223..259 x 275..290 | 39.8..39.9 x 45.0..46.0 | w1 h6 b6 | -| batch3-wei | queued-rework | `unit-wei-cavalry` | border-hits=64 | border-hits=144 | 160..291 x 282..289 | 160..300 x 274..290 | 25.6..46.5 x 45.0..46.2 | w131 h7 b7 | +| batch3-wei | approved-baseline | `unit-wei-cavalry` | ok | ok | 146..266 x 288..295 | 146..292 x 260..295 | 23.3..42.5 x 46.0..47.1 | w120 h7 b0 | | batch3-wei | queued-rework | `unit-wei-cavalry-elite` | border-hits=64 | border-hits=144 | 166..296 x 282..288 | 166..305 x 274..290 | 26.5..47.3 x 45.0..46.0 | w130 h6 b6 | | batch3-wei | queued-rework | `unit-wei-cavalry-iron` | border-hits=64 | border-hits=144 | 166..296 x 282..288 | 166..305 x 274..290 | 26.5..47.3 x 45.0..46.0 | w130 h6 b6 | | batch3-wei | approved-baseline | `unit-wei-infantry` | ok | ok | 174..223 x 282..295 | 154..248 x 282..295 | 27.8..35.6 x 45.0..47.1 | w49 h13 b0 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index e86125d..60ed820 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -23,13 +23,13 @@ "unit-shu-spearman", "unit-shu-strategist", "unit-wei-archer", + "unit-wei-cavalry", "unit-wei-infantry", "unit-zhang-fei" ], "pendingApproval": [], "currentApprovalCandidate": {}, "nextAfterApproval": [ - "unit-wei-cavalry", "unit-wei-strategist", "unit-wei-officer" ], diff --git a/docs/unit-sprite-wei-cavalry-v2-approval-packet.md b/docs/unit-sprite-wei-cavalry-v2-approval-packet.md new file mode 100644 index 0000000..c28cc00 --- /dev/null +++ b/docs/unit-sprite-wei-cavalry-v2-approval-packet.md @@ -0,0 +1,44 @@ +# Wei Cavalry v2 Approval Packet + +- unit: `unit-wei-cavalry` +- version: `v2` +- source: `docs/handpaint-batch3-wei-cavalry-source-v1.png` +- contact sheet: `docs/handpaint-batch3-wei-cavalry-v2-contact.png` +- animation: `docs/handpaint-batch3-wei-cavalry-v2-animation.gif` +- battle preview: `docs/handpaint-batch3-wei-cavalry-v2-debug-preview-battle-check.png` +- before/after: `docs/handpaint-batch3-wei-cavalry-v2-before-after.png` +- scale compare: `docs/handpaint-batch3-wei-cavalry-v2-scale-compare.png` +- current approval board: `docs/unit-sprite-current-approval-board.png` + +## Visual Decision + +Approved for the continuous production run. + +- 50px battle readability: pass +- Wei/Shu faction separation: pass +- horse/rider silhouette: pass +- mounted action silhouette: pass +- opaque unit body: pass +- frame boundary safety: pass +- idle/action scale stability: pass + +## Technical Checks + +- local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-wei-cavalry&v=wei-cavalry-v2-final` +- Local browser console errors: `0` +- base partial alpha: `0` +- action partial alpha: `0` +- base frame border hits: `0` +- action frame border hits: `0` +- base empty frames: `0` +- action empty frames: `0` +- base bbox width range: `146..266` +- base bbox height range: `288..295` +- base bottom range: `303..303` +- action bbox width range: `146..292` +- action bbox height range: `260..295` +- action bottom range: `303..303` + +## Notes + +The v2 sheet slightly widens the mounted silhouette so the horse remains readable at 50px while staying within the 313px frame boundaries. diff --git a/src/assets/images/units/unit-wei-cavalry-actions.png b/src/assets/images/units/unit-wei-cavalry-actions.png index d36f418..bf5e46a 100644 Binary files a/src/assets/images/units/unit-wei-cavalry-actions.png and b/src/assets/images/units/unit-wei-cavalry-actions.png differ diff --git a/src/assets/images/units/unit-wei-cavalry.png b/src/assets/images/units/unit-wei-cavalry.png index 5b05447..65b9f2a 100644 Binary files a/src/assets/images/units/unit-wei-cavalry.png and b/src/assets/images/units/unit-wei-cavalry.png differ