diff --git a/docs/handpaint-batch7-lu-bu-source-v1.png b/docs/handpaint-batch7-lu-bu-source-v1.png new file mode 100644 index 0000000..015427e Binary files /dev/null and b/docs/handpaint-batch7-lu-bu-source-v1.png differ diff --git a/docs/handpaint-batch7-lu-bu-v2-animation.gif b/docs/handpaint-batch7-lu-bu-v2-animation.gif new file mode 100644 index 0000000..ea0c90d Binary files /dev/null and b/docs/handpaint-batch7-lu-bu-v2-animation.gif differ diff --git a/docs/handpaint-batch7-lu-bu-v2-battle-composite.png b/docs/handpaint-batch7-lu-bu-v2-battle-composite.png new file mode 100644 index 0000000..70bd39b Binary files /dev/null and b/docs/handpaint-batch7-lu-bu-v2-battle-composite.png differ diff --git a/docs/handpaint-batch7-lu-bu-v2-before-after.png b/docs/handpaint-batch7-lu-bu-v2-before-after.png new file mode 100644 index 0000000..994753f Binary files /dev/null and b/docs/handpaint-batch7-lu-bu-v2-before-after.png differ diff --git a/docs/handpaint-batch7-lu-bu-v2-contact.png b/docs/handpaint-batch7-lu-bu-v2-contact.png new file mode 100644 index 0000000..3a2b477 Binary files /dev/null and b/docs/handpaint-batch7-lu-bu-v2-contact.png differ diff --git a/docs/handpaint-batch7-lu-bu-v2-debug-preview-battle-check.png b/docs/handpaint-batch7-lu-bu-v2-debug-preview-battle-check.png new file mode 100644 index 0000000..700f205 Binary files /dev/null and b/docs/handpaint-batch7-lu-bu-v2-debug-preview-battle-check.png differ diff --git a/docs/handpaint-batch7-lu-bu-v2-report.md b/docs/handpaint-batch7-lu-bu-v2-report.md new file mode 100644 index 0000000..82dc3c1 --- /dev/null +++ b/docs/handpaint-batch7-lu-bu-v2-report.md @@ -0,0 +1,24 @@ +# Lu Bu hand-painted v2 report + +- source: `handpaint-batch7-lu-bu-source-v1.png` +- base status: ok +- action status: ok +- base partial alpha: 0, opaque pixels: 2067188 +- action partial alpha: 0, opaque pixels: 4624951 +- base frame border hits: 0 +- action frame border hits: 0 +- base empty frames: 0 +- action empty frames: 0 +- base bbox width range: 187..253 +- base bbox height range: 280..290 +- base bottom range: 303..303 +- action bbox width range: 155..271 +- action bbox height range: 280..290 +- action bottom range: 303..303 +- contact: `handpaint-batch7-lu-bu-v2-contact.png` +- animation: `handpaint-batch7-lu-bu-v2-animation.gif` +- before/after: `handpaint-batch7-lu-bu-v2-before-after.png` +- scale compare: `handpaint-batch7-lu-bu-v2-scale-compare.png` +- battle composite: `handpaint-batch7-lu-bu-v2-battle-composite.png` +- manual checks: run build and local browser verification after generation +- note: battle composite is a scale review image; gameplay roster is unchanged during sample approval diff --git a/docs/handpaint-batch7-lu-bu-v2-scale-compare.png b/docs/handpaint-batch7-lu-bu-v2-scale-compare.png new file mode 100644 index 0000000..eb19535 Binary files /dev/null and b/docs/handpaint-batch7-lu-bu-v2-scale-compare.png differ diff --git a/docs/unit-sprite-art-quality-gate.md b/docs/unit-sprite-art-quality-gate.md index d56244f..3316c24 100644 --- a/docs/unit-sprite-art-quality-gate.md +++ b/docs/unit-sprite-art-quality-gate.md @@ -6,9 +6,9 @@ This gate catches obvious sprite-art failures before user approval. It does not - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` -- Approved baseline units: 79 +- Approved baseline units: 80 - Pending approval units: 0 -- Queued rework units: 12 +- Queued rework units: 11 ## Checked Rules diff --git a/docs/unit-sprite-batch-queue.json b/docs/unit-sprite-batch-queue.json index 310817a..7619d8b 100644 --- a/docs/unit-sprite-batch-queue.json +++ b/docs/unit-sprite-batch-queue.json @@ -12,6 +12,7 @@ "unit-jiang-wei", "unit-li-yan", "unit-liu-bei", + "unit-lu-bu", "unit-meng-huo", "unit-nanman-infantry", "unit-nanman-infantry-jungle", @@ -86,8 +87,8 @@ "pendingApproval": [], "nextAfterApproval": [], "stageCounts": { - "approved-baseline": 79, - "queued-rework": 12 + "approved-baseline": 80, + "queued-rework": 11 }, "batches": [ { @@ -1173,24 +1174,10 @@ "label": "Batch 7 unique officers", "total": 19, "stageCounts": { - "approved-baseline": 7, - "queued-rework": 12 + "approved-baseline": 8, + "queued-rework": 11 }, "units": [ - { - "stem": "unit-lu-bu", - "reviewStage": "queued-rework", - "queueRole": "queued rework", - "baseStatus": "border-hits=64", - "actionStatus": "border-hits=144", - "battleBasePx": [ - 28.8, - 47.3, - 45.0, - 46.0 - ], - "spec": null - }, { "stem": "unit-lu-meng", "reviewStage": "queued-rework", @@ -1442,6 +1429,20 @@ 46.3 ], "spec": null + }, + { + "stem": "unit-lu-bu", + "reviewStage": "approved-baseline", + "queueRole": "approved reference", + "baseStatus": "ok", + "actionStatus": "ok", + "battleBasePx": [ + 29.9, + 40.4, + 44.7, + 46.3 + ], + "spec": null } ] } diff --git a/docs/unit-sprite-batch-queue.md b/docs/unit-sprite-batch-queue.md index 487eeae..42cbd4d 100644 --- a/docs/unit-sprite-batch-queue.md +++ b/docs/unit-sprite-batch-queue.md @@ -6,9 +6,9 @@ Use this as the long-running queue for the full hand-painted sprite rework. It i ## Current State -- Approved baseline units: 79 +- Approved baseline units: 80 - Pending approval units: 0 -- Queued rework units: 12 +- Queued rework units: 11 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` @@ -157,11 +157,10 @@ No next unit is currently defined. - Batch key: `batch7-unique-officer` - Total units: 19 -- Stage counts: approved-baseline 7, queued-rework 12 +- Stage counts: approved-baseline 8, queued-rework 11 | unit | role | stage | status | battle base px | spec | | --- | --- | --- | --- | --- | --- | -| `unit-lu-bu` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 28.8..47.3 x 45.0..46.0 | | | `unit-lu-meng` | queued rework | queued-rework | base border-hits=32; actions border-hits=82 | 30.7..44.2 x 44.6..44.6 | | | `unit-ma-chao` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 26.5..47.3 x 45.0..46.0 | | | `unit-ma-dai` | queued rework | queued-rework | base border-hits=64; actions border-hits=144 | 25.6..46.5 x 45.0..46.2 | | @@ -180,3 +179,4 @@ No next unit is currently defined. | `unit-huang-zhong` | approved reference | approved-baseline | technical ok | 27.2..36.3 x 46.3..47.3 | | | `unit-jiang-wei` | approved reference | approved-baseline | technical ok | 23.2..42.5 x 45.4..46.5 | | | `unit-li-yan` | approved reference | approved-baseline | technical ok | 27.2..41.9 x 45.7..46.3 | | +| `unit-lu-bu` | approved reference | approved-baseline | technical ok | 29.9..40.4 x 44.7..46.3 | | diff --git a/docs/unit-sprite-current-approval-board.png b/docs/unit-sprite-current-approval-board.png index 6965de8..aa37961 100644 Binary files a/docs/unit-sprite-current-approval-board.png and b/docs/unit-sprite-current-approval-board.png differ diff --git a/docs/unit-sprite-lu-bu-v2-approval-packet.md b/docs/unit-sprite-lu-bu-v2-approval-packet.md new file mode 100644 index 0000000..da67be3 --- /dev/null +++ b/docs/unit-sprite-lu-bu-v2-approval-packet.md @@ -0,0 +1,36 @@ +# Lu Bu hand-painted sprite v2 approval packet + +- Unit: `unit-lu-bu` +- Candidate version: `v2` +- Source sheet: `docs/handpaint-batch7-lu-bu-source-v1.png` +- Contact sheet: `docs/handpaint-batch7-lu-bu-v2-contact.png` +- Animation GIF: `docs/handpaint-batch7-lu-bu-v2-animation.gif` +- Before/after: `docs/handpaint-batch7-lu-bu-v2-before-after.png` +- Battle composite: `docs/handpaint-batch7-lu-bu-v2-battle-composite.png` +- Scale compare: `docs/handpaint-batch7-lu-bu-v2-scale-compare.png` +- Local browser check: `docs/handpaint-batch7-lu-bu-v2-debug-preview-battle-check.png` +- Current approval board: `docs/unit-sprite-current-approval-board.png` + +## Visual Decision + +- Approved for continuous production run. +- Direction: imposing red-and-black warlord boss with heavy armor, long red plumes, dark cloak, and a large fangtian-style halberd. +- The 100% PC browser debug preview reads as a unique boss at battle scale, distinct from Guan Yu, Zhang Fei, Jiang Wei, and generic cavalry/infantry units. +- The unit body is opaque and visible without base rings, completion badges, or other external readability helpers. + +## Technical Checks + +- Local build: `pnpm build` passed. +- Local browser URL: `http://127.0.0.1:4173/heros_web/?debug&debugSpritePreview=unit-lu-bu&v=lu-bu-v2` +- Local browser console errors: `0` +- Local browser 404s: `0` +- Base partial alpha: `0` +- Action partial alpha: `0` +- Base frame border hits: `0` +- Action frame border hits: `0` +- Base battle size from audit: `29.9..40.4 x 44.7..46.3` + +## Notes + +- v1 had strong art quality but made some action frames too narrow. +- v2 keeps frame safety while restoring the halberd/action silhouette for better 50px readability. diff --git a/docs/unit-sprite-next-steps.md b/docs/unit-sprite-next-steps.md index 81e5039..a739c7e 100644 --- a/docs/unit-sprite-next-steps.md +++ b/docs/unit-sprite-next-steps.md @@ -4,9 +4,9 @@ This file is generated by `scripts/write-unit-sprite-next-steps.py`. ## Current Gate -- Approved baseline units: 79 +- Approved baseline units: 80 - Pending approval units: 0 -- Queued rework units: 12 +- Queued rework units: 11 - Manifest: `docs/unit-sprite-rework-manifest.json` - Audit: `docs/unit-sprite-rework-audit.json` - Current approval board: not generated until the next pending sample. diff --git a/docs/unit-sprite-review-approved-and-pending.png b/docs/unit-sprite-review-approved-and-pending.png index f9c0cdc..7f84fad 100644 Binary files a/docs/unit-sprite-review-approved-and-pending.png and b/docs/unit-sprite-review-approved-and-pending.png differ diff --git a/docs/unit-sprite-review-batch7-unique-officer.png b/docs/unit-sprite-review-batch7-unique-officer.png index 6356b27..a98358f 100644 Binary files a/docs/unit-sprite-review-batch7-unique-officer.png and b/docs/unit-sprite-review-batch7-unique-officer.png differ diff --git a/docs/unit-sprite-review-index.png b/docs/unit-sprite-review-index.png index ac86b6e..ebe05a4 100644 Binary files a/docs/unit-sprite-review-index.png and b/docs/unit-sprite-review-index.png differ diff --git a/docs/unit-sprite-rework-audit.json b/docs/unit-sprite-rework-audit.json index e9dfbdd..3d953d1 100644 --- a/docs/unit-sprite-rework-audit.json +++ b/docs/unit-sprite-rework-audit.json @@ -11,8 +11,8 @@ "batch7-unique-officer": 19 }, "stage_counts": { - "approved-baseline": 79, - "queued-rework": 12 + "approved-baseline": 80, + "queued-rework": 11 }, "rows": [ { @@ -530,7 +530,7 @@ }, { "batch": "batch7-unique-officer", - "review_stage": "queued-rework", + "review_stage": "approved-baseline", "stem": "unit-lu-bu", "base": { "key": "unit-lu-bu", @@ -540,23 +540,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 2631122, - "border_hits": 64, - "min_width": 180, - "max_width": 296, - "min_height": 282, - "max_height": 288, - "min_bottom": 281, - "max_bottom": 287, + "opaque_pixels": 2067188, + "border_hits": 0, + "min_width": 187, + "max_width": 253, + "min_height": 280, + "max_height": 290, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 116, - "height_swing": 6, - "bottom_swing": 6, - "battle_min_width_px": 28.8, - "battle_max_width_px": 47.3, - "battle_min_height_px": 45.0, - "battle_max_height_px": 46.0, - "status": "border-hits=64" + "width_swing": 66, + "height_swing": 10, + "bottom_swing": 0, + "battle_min_width_px": 29.9, + "battle_max_width_px": 40.4, + "battle_min_height_px": 44.7, + "battle_max_height_px": 46.3, + "status": "ok" }, "actions": { "key": "unit-lu-bu-actions", @@ -566,23 +566,23 @@ 1252 ], "partial_alpha": 0, - "opaque_pixels": 5889699, - "border_hits": 144, - "min_width": 180, - "max_width": 305, - "min_height": 274, + "opaque_pixels": 4624951, + "border_hits": 0, + "min_width": 155, + "max_width": 271, + "min_height": 280, "max_height": 290, - "min_bottom": 273, - "max_bottom": 289, + "min_bottom": 303, + "max_bottom": 303, "empty_frames": 0, - "width_swing": 125, - "height_swing": 16, - "bottom_swing": 16, - "battle_min_width_px": 28.8, - "battle_max_width_px": 48.7, - "battle_min_height_px": 43.8, + "width_swing": 116, + "height_swing": 10, + "bottom_swing": 0, + "battle_min_width_px": 24.8, + "battle_max_width_px": 43.3, + "battle_min_height_px": 44.7, "battle_max_height_px": 46.3, - "status": "border-hits=144" + "status": "ok" } }, { diff --git a/docs/unit-sprite-rework-audit.md b/docs/unit-sprite-rework-audit.md index fdbf458..06b2475 100644 --- a/docs/unit-sprite-rework-audit.md +++ b/docs/unit-sprite-rework-audit.md @@ -29,8 +29,8 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. ## Review Stage Counts -- approved-baseline: 79 -- queued-rework: 12 +- approved-baseline: 80 +- queued-rework: 11 ## Batch Plan @@ -61,7 +61,7 @@ Visual review boards are generated by `scripts/render-unit-sprite-review-boards. | batch7-unique-officer | approved-baseline | `unit-jiang-wei` | ok | ok | 145..266 x 284..291 | 142..261 x 261..291 | 23.2..42.5 x 45.4..46.5 | w121 h7 b0 | | batch7-unique-officer | approved-baseline | `unit-li-yan` | ok | ok | 170..262 x 286..290 | 190..259 x 286..290 | 27.2..41.9 x 45.7..46.3 | w92 h4 b0 | | batch1-approved-core | approved-baseline | `unit-liu-bei` | ok | ok | 138..258 x 278..289 | 148..300 x 252..284 | 22.0..41.2 x 44.4..46.2 | w120 h11 b12 | -| batch7-unique-officer | queued-rework | `unit-lu-bu` | border-hits=64 | border-hits=144 | 180..296 x 282..288 | 180..305 x 274..290 | 28.8..47.3 x 45.0..46.0 | w116 h6 b6 | +| batch7-unique-officer | approved-baseline | `unit-lu-bu` | ok | ok | 187..253 x 280..290 | 155..271 x 280..290 | 29.9..40.4 x 44.7..46.3 | w66 h10 b0 | | batch7-unique-officer | queued-rework | `unit-lu-meng` | border-hits=32 | border-hits=82 | 192..277 x 279..279 | 192..286 x 275..279 | 30.7..44.2 x 44.6..44.6 | w85 h0 b6 | | batch7-unique-officer | queued-rework | `unit-ma-chao` | border-hits=64 | border-hits=144 | 166..296 x 282..288 | 166..305 x 274..290 | 26.5..47.3 x 45.0..46.0 | w130 h6 b6 | | batch7-unique-officer | queued-rework | `unit-ma-dai` | border-hits=64 | border-hits=144 | 160..291 x 282..289 | 160..300 x 274..290 | 25.6..46.5 x 45.0..46.2 | w131 h7 b7 | diff --git a/docs/unit-sprite-rework-manifest.json b/docs/unit-sprite-rework-manifest.json index a27f762..a9cff15 100644 --- a/docs/unit-sprite-rework-manifest.json +++ b/docs/unit-sprite-rework-manifest.json @@ -20,6 +20,7 @@ "unit-jiang-wei", "unit-li-yan", "unit-liu-bei", + "unit-lu-bu", "unit-meng-huo", "unit-nanman-infantry", "unit-nanman-infantry-jungle", diff --git a/src/assets/images/units/unit-lu-bu-actions.png b/src/assets/images/units/unit-lu-bu-actions.png index d2f6187..81b1e82 100644 Binary files a/src/assets/images/units/unit-lu-bu-actions.png and b/src/assets/images/units/unit-lu-bu-actions.png differ diff --git a/src/assets/images/units/unit-lu-bu.png b/src/assets/images/units/unit-lu-bu.png index c18264d..34d1b54 100644 Binary files a/src/assets/images/units/unit-lu-bu.png and b/src/assets/images/units/unit-lu-bu.png differ