Wickedness/heros
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refine large map viewport controls

Browse Source
This commit is contained in:
Wickedness
2026-06-19 18:53:03 +09:00
parent feac924a1c
commit f13f20939f
5 changed files with 67 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
tools/smoke_post_move_action_flow.gd
View File

@@ -9,6 +9,7 @@ func _init() -> void:
_check_deferred_move_events(failures)
_check_scene_post_move_menu_flow(failures)
_check_scene_post_move_edge_positioning(failures)
_check_scene_post_move_scrolled_view_positioning(failures)
_check_scene_post_move_text_fit(failures)
_check_scene_post_move_tactic_picker_flow(failures)
_check_scene_post_move_item_picker_flow(failures)
@@ -170,6 +171,39 @@ func _check_scene_post_move_edge_positioning(failures: Array[String]) -> void:
scene.free()
func _check_scene_post_move_scrolled_view_positioning(failures: Array[String]) -> void:
var scene = BattleSceneScript.new()
scene._create_hud()
if not scene.state.load_battle("res://data/scenarios/001_yellow_turbans.json"):
failures.append("could not load opening battle for scrolled menu positioning")
scene.free()
return
scene.battle_started = true
scene.campaign_complete_screen = false
scene.briefing_panel.visible = false
scene.result_panel.visible = false
scene._clear_pending_move_state()
scene.board_scroll_offset = scene._clamped_board_scroll_offset(Vector2(-9999.0, -9999.0))
var edge_cell := Vector2i(scene.state.map_size.x - 1, scene.state.map_size.y - 1)
var cao_cao: Dictionary = scene.state.get_unit("cao_cao")
cao_cao["pos"] = edge_cell
cao_cao["moved"] = true
cao_cao["acted"] = false
scene.state.select_unit("cao_cao")
scene.pending_move_unit_id = "cao_cao"
scene.pending_move_from_cell = Vector2i(edge_cell.x - 1, edge_cell.y)
scene.pending_move_to_cell = edge_cell
scene._show_post_move_menu()
if scene.post_move_menu == null or not scene.post_move_menu.visible:
failures.append("scrolled post-move action menu should be visible")
else:
_check_local_panel_position(failures, scene, scene.post_move_menu, edge_cell, "scrolled post-move action menu")
scene.free()
func _check_scene_post_move_text_fit(failures: Array[String]) -> void:
var scene = BattleSceneScript.new()
scene._create_hud()
@@ -577,17 +611,18 @@ func _check_scene_post_move_item_picker_flow(failures: Array[String]) -> void:
func _check_local_panel_position(failures: Array[String], scene, panel: Control, cell: Vector2i, label: String) -> void:
var padding := BattleSceneScript.LOCAL_COMMAND_PANEL_BOARD_PADDING
var board_position := BattleSceneScript.BOARD_OFFSET + Vector2(padding, padding)
var board_size := Vector2(scene.state.map_size.x, scene.state.map_size.y) * BattleSceneScript.TILE_SIZE - Vector2(padding * 2.0, padding * 2.0)
var board_rect := Rect2(board_position, board_size)
var board_rect: Rect2 = scene._board_rect().intersection(scene._map_view_rect())
if board_rect.size.x <= 0.0 or board_rect.size.y <= 0.0:
board_rect = scene._board_rect()
board_rect = board_rect.grow(-padding)
var panel_rect := Rect2(panel.position, panel.size)
var cell_rect: Rect2 = scene._rect_for_cell(cell).grow(2.0)
if panel_rect.size.x <= 0.0 or panel_rect.size.y <= 0.0:
failures.append("%s should have a stable visible size" % label)
if panel_rect.position.x < board_rect.position.x or panel_rect.position.y < board_rect.position.y:
failures.append("%s should stay inside the board minimum: %s" % [label, str(panel_rect)])
failures.append("%s should stay inside the visible board minimum: %s" % [label, str(panel_rect)])
if panel_rect.end.x > board_rect.end.x or panel_rect.end.y > board_rect.end.y:
failures.append("%s should stay inside the board maximum: %s" % [label, str(panel_rect)])
failures.append("%s should stay inside the visible board maximum: %s" % [label, str(panel_rect)])
if panel_rect.intersects(cell_rect):
failures.append("%s should not cover the moved unit cell: %s over %s" % [label, str(panel_rect), str(cell_rect)])