Polish auto end turn prompt
This commit is contained in:
@@ -98,6 +98,10 @@ func _check_auto_end_turn_prompt_flow(failures: Array[String]) -> void:
|
||||
failures.append("auto end turn prompt should be created with the HUD")
|
||||
scene.free()
|
||||
return
|
||||
if scene.auto_end_turn_yes_button == null or scene.auto_end_turn_yes_button.text != "차례 넘김":
|
||||
failures.append("auto end turn confirm button should use contextual Korean text")
|
||||
if scene.auto_end_turn_no_button == null or scene.auto_end_turn_no_button.text != "머무름":
|
||||
failures.append("auto end turn decline button should use contextual Korean text")
|
||||
|
||||
for unit in scene.state.units:
|
||||
if str(unit.get("team", "")) == BattleStateScript.TEAM_PLAYER and bool(unit.get("controllable", true)):
|
||||
|
||||
@@ -3233,6 +3233,7 @@ func _check_ancient_ui_theme(failures: Array[String]) -> void:
|
||||
_check_panel_style_frame(failures, scene.briefing_camp_overview_panel, "briefing silk map panel", Color(0.12, 0.060, 0.026, 0.98), 7)
|
||||
_check_panel_style_fill(failures, scene.dialogue_panel, "dialogue panel", Color(0.055, 0.028, 0.016, 0.982))
|
||||
_check_panel_style_frame(failures, scene.dialogue_panel, "dialogue panel", Color(0.30, 0.18, 0.075, 1.0), 12)
|
||||
_check_panel_style_fill(failures, scene.auto_end_turn_prompt_panel, "auto end turn prompt panel", Color(0.055, 0.025, 0.014, 0.988))
|
||||
_check_panel_style_fill(failures, scene.dialogue_portrait_panel, "dialogue portrait panel", Color(0.035, 0.014, 0.008, 1.0))
|
||||
_check_panel_style_fill(failures, scene.dialogue_speaker_panel, "dialogue speaker seal panel", Color(0.36, 0.025, 0.016, 0.995))
|
||||
_check_panel_style_fill(failures, scene.dialogue_text_panel, "dialogue text scroll panel", Color(0.61, 0.47, 0.26, 0.996))
|
||||
@@ -3276,6 +3277,12 @@ func _check_ancient_ui_theme(failures: Array[String]) -> void:
|
||||
failures.append("dialogue continue button should use Korean text")
|
||||
if scene.dialogue_previous_button == null or scene.dialogue_previous_button.text != "이전":
|
||||
failures.append("dialogue previous button should use Korean text")
|
||||
if scene.auto_end_turn_prompt_label == null or not _collect_child_text(scene.auto_end_turn_prompt_panel).contains("군령 완료"):
|
||||
failures.append("auto end turn prompt should show an old command-complete caption")
|
||||
if scene.auto_end_turn_yes_button == null or scene.auto_end_turn_yes_button.text != "차례 넘김":
|
||||
failures.append("auto end turn confirm button should use command wording")
|
||||
if scene.auto_end_turn_no_button == null or scene.auto_end_turn_no_button.text != "머무름":
|
||||
failures.append("auto end turn decline button should use command wording")
|
||||
var localized_lines := scene._normalized_dialogue_lines([{"speaker": "Cao Cao", "display_speaker": "조조", "text": "군령을 전하라."}])
|
||||
if localized_lines.is_empty() or str((localized_lines[0] as Dictionary).get("speaker", "")) != "조조":
|
||||
failures.append("dialogue normalization should preserve display_speaker for localized names")
|
||||
|
||||
Reference in New Issue
Block a user