Wickedness/heros
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refine battle side log readability

Browse Source
This commit is contained in:
Wickedness
2026-06-20 19:53:30 +09:00
parent 60bd716d25
commit e5318e65ad
2 changed files with 57 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tools/smoke_visual_assets.gd
View File

@@ -3852,6 +3852,18 @@ func _check_ancient_ui_theme(failures: Array[String]) -> void:
scene._on_log_added("조조군이 동쪽 성채에 발을 들였다.")
if scene.objective_notice_label == null or not scene.objective_notice_label.text.contains("거점 변화") or not scene.objective_notice_label.text.contains("성채"):
failures.append("castle event log should become a battlefield notice: %s" % ("" if scene.objective_notice_label == null else scene.objective_notice_label.text))
if scene.log_box == null:
failures.append("battle log summary missing")
else:
var visible_log_text: String = scene.log_box.get_parsed_text()
if not visible_log_text.contains("북쪽 숲 보급고") or not visible_log_text.contains("동쪽 성채"):
failures.append("battle log should show the latest two readable entries: %s" % visible_log_text)
if visible_log_text.contains("적군 차례") or visible_log_text.contains("아군 차례"):
failures.append("battle log visible text should hide older turn churn: %s" % visible_log_text)
if not scene.log_box.tooltip_text.contains("적군 차례") or not scene.log_box.tooltip_text.contains("마을 앞 유인선"):
failures.append("battle log tooltip should preserve earlier history: %s" % scene.log_box.tooltip_text)
if scene.log_box.scroll_active:
failures.append("battle log should avoid a visible scrollbar in the compact side panel")
var localized_lines := scene._normalized_dialogue_lines([{"speaker": "Cao Cao", "display_speaker": "조조", "text": "군령을 전하라."}])
if localized_lines.is_empty() or str((localized_lines[0] as Dictionary).get("speaker", "")) != "조조":
failures.append("dialogue normalization should preserve display_speaker for localized names")