Wickedness/heros
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clarify audio settings controls

Browse Source
This commit is contained in:
Wickedness
2026-06-20 11:32:21 +09:00
parent 7d9eba56b5
commit db1261b76c
2 changed files with 43 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
tools/smoke_title_menu.gd
View File

@@ -153,6 +153,11 @@ func _check_title_menu_start_load_and_settings(failures: Array[String]) -> void:
failures.append("title settings should replace the main title commands while open")
if scene.title_bgm_toggle == null or scene.title_sfx_toggle == null or scene.title_edge_scroll_toggle == null:
failures.append("title settings should expose BGM, SFX, and edge-scroll toggles")
else:
if not scene.title_bgm_toggle.text.contains("군막의 새벽"):
failures.append("title BGM toggle should name the active menu theme")
if not scene.title_sfx_toggle.text.contains("클릭") or not scene.title_sfx_toggle.text.contains("전투"):
failures.append("title SFX toggle should clarify menu and battle effects")
if scene.title_bgm_volume_slider == null or scene.title_sfx_volume_slider == null:
failures.append("title settings should expose BGM and SFX volume sliders")
scene._on_title_bgm_toggled(false)
@@ -179,10 +184,13 @@ func _check_title_menu_start_load_and_settings(failures: Array[String]) -> void:
if persisted_scene.title_bgm_volume_percent != 45 or persisted_scene.title_sfx_volume_percent != 35:
failures.append("title settings volume values should persist into a new scene instance")
persisted_scene.free()
if scene.title_audio_reset_button == null or scene.title_audio_reset_button.text != "소리 켜기":
failures.append("title settings should expose a one-click audio recovery button")
if scene.title_audio_reset_button == null or scene.title_audio_reset_button.text != "소리 확인":
failures.append("title settings should expose a one-click audio preview button")
else:
_check_title_menu_button_art(failures, scene.title_audio_reset_button, "status", "title audio reset")
if not scene.title_audio_reset_button.tooltip_text.contains("확인음"):
failures.append("title audio preview should explain that it plays a confirmation sound")
scene.recent_sfx_keys.clear()
scene._on_title_audio_reset_pressed()
if not scene.title_bgm_enabled or not scene.title_sfx_enabled:
failures.append("title audio recovery should re-enable BGM and SFX")
@@ -190,6 +198,8 @@ func _check_title_menu_start_load_and_settings(failures: Array[String]) -> void:
failures.append("title audio recovery should restore audible volume defaults")
if scene.bgm_player == null or scene.bgm_player.stream == null or scene.current_bgm_key.is_empty():
failures.append("title audio recovery should leave a playable BGM stream selected")
if not scene.recent_sfx_keys.has("menu_confirm"):
failures.append("title audio preview should play an audible confirmation SFX")
scene._on_title_settings_back_pressed()
if scene.title_settings_panel != null and scene.title_settings_panel.visible:
failures.append("settings back should hide the title settings panel")
@@ -345,6 +355,11 @@ func _check_title_menu_start_load_and_settings(failures: Array[String]) -> void:
failures.append("top Settings icon should open the in-game settings panel")
if scene.settings_bgm_toggle == null or scene.settings_sfx_toggle == null or scene.settings_edge_scroll_toggle == null:
failures.append("in-game settings panel should expose BGM, SFX, and edge-scroll toggles")
else:
if not scene.settings_bgm_toggle.text.contains("군막") or not scene.settings_bgm_toggle.text.contains("전투"):
failures.append("in-game BGM toggle should clarify menu and battle music")
if not scene.settings_sfx_toggle.text.contains("선택") or not scene.settings_sfx_toggle.text.contains("전투"):
failures.append("in-game SFX toggle should clarify menu and battle effects")
if scene.settings_bgm_volume_slider == null or scene.settings_sfx_volume_slider == null:
failures.append("in-game settings panel should expose BGM and SFX volume sliders")
scene._on_settings_bgm_toggled(true)
@@ -356,17 +371,22 @@ func _check_title_menu_start_load_and_settings(failures: Array[String]) -> void:
failures.append("in-game settings toggles should update the shared settings state")
if scene.title_bgm_volume_percent != 70 or scene.title_sfx_volume_percent != 60:
failures.append("in-game settings sliders should update the shared volume state")
if scene.settings_audio_reset_button == null or scene.settings_audio_reset_button.text != "소리 켜기":
failures.append("in-game settings should expose a one-click audio recovery button")
if scene.settings_audio_reset_button == null or scene.settings_audio_reset_button.text != "소리 확인":
failures.append("in-game settings should expose a one-click audio preview button")
elif not scene.settings_audio_reset_button.tooltip_text.contains("현재 음악"):
failures.append("in-game audio preview should explain that it plays the current music")
scene._on_settings_bgm_toggled(false)
scene._on_settings_sfx_toggled(false)
scene._on_settings_bgm_volume_changed(20.0)
scene._on_settings_sfx_volume_changed(15.0)
scene.recent_sfx_keys.clear()
scene._on_settings_audio_reset_pressed()
if not scene.title_bgm_enabled or not scene.title_sfx_enabled:
failures.append("in-game audio recovery should re-enable BGM and SFX")
if scene.title_bgm_volume_percent != BattleSceneScript.DEFAULT_AUDIO_VOLUME_PERCENT or scene.title_sfx_volume_percent != BattleSceneScript.DEFAULT_AUDIO_VOLUME_PERCENT:
failures.append("in-game audio recovery should restore audible volume defaults")
if not scene.recent_sfx_keys.has("menu_confirm"):
failures.append("in-game audio preview should play an audible confirmation SFX")
scene._hide_settings_panel()
scene._on_new_campaign_pressed()
if not scene._is_opening_prologue_visible():