Wickedness/heros
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add objective update notice

Browse Source
This commit is contained in:
Wickedness
2026-06-18 13:46:11 +09:00
parent c42d4dd4a7
commit 9d691cb75f
8 changed files with 135 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

71
tools/smoke_objective_progress.gd
View File

@@ -1,6 +1,7 @@
extends SceneTree
const BattleStateScript := preload("res://scripts/core/battle_state.gd")
const BattleSceneScript := preload("res://scripts/scenes/battle_scene.gd")
func _init() -> void:
@@ -48,6 +49,8 @@ func _init() -> void:
_progress_text("res://data/scenarios/045_fancheng_relief.json", false),
"Reach (10, 5): not reached"
)
_check_objective_update(failures)
_check_objective_notice(failures)
if failures.is_empty():
print("objective progress smoke ok")
@@ -73,6 +76,74 @@ func _defeat_text(path: String) -> String:
return state.get_defeat_progress_text()
func _check_objective_update(failures: Array[String]) -> void:
var state = BattleStateScript.new()
if not state.load_battle("res://data/scenarios/001_yellow_turbans.json"):
failures.append("objective update smoke could not load scenario")
return
var signal_values := []
var logs := []
state.objective_updated.connect(func(victory: String, defeat: String) -> void:
signal_values.append({"victory": victory, "defeat": defeat})
)
state.log_added.connect(func(message: String) -> void:
logs.append(message)
)
state._apply_objective_event({
"victory": "Defeat the new vanguard.",
"defeat": "Cao Cao is defeated."
})
if signal_values.size() != 1:
failures.append("objective update signal expected 1 emission, got %d" % signal_values.size())
else:
var signal_value: Dictionary = signal_values[0]
if str(signal_value.get("victory", "")) != "Defeat the new vanguard.":
failures.append("objective update signal victory mismatch: %s" % str(signal_value.get("victory", "")))
if str(signal_value.get("defeat", "")) != "Cao Cao is defeated.":
failures.append("objective update signal defeat mismatch: %s" % str(signal_value.get("defeat", "")))
_check_log_contains(failures, logs, "Objective updated: Defeat the new vanguard.")
_check_log_contains(failures, logs, "Defeat condition updated: Cao Cao is defeated.")
signal_values.clear()
logs.clear()
state._apply_objective_event({"defeat": "Supply train is lost."})
if signal_values.size() != 1:
failures.append("defeat-only objective signal expected 1 emission, got %d" % signal_values.size())
else:
var defeat_signal_value: Dictionary = signal_values[0]
if not str(defeat_signal_value.get("victory", "")).is_empty():
failures.append("defeat-only objective signal should not include victory: %s" % str(defeat_signal_value.get("victory", "")))
if str(defeat_signal_value.get("defeat", "")) != "Supply train is lost.":
failures.append("defeat-only objective signal mismatch: %s" % str(defeat_signal_value.get("defeat", "")))
_check_log_contains(failures, logs, "Defeat condition updated: Supply train is lost.")
func _check_log_contains(failures: Array[String], logs: Array, expected: String) -> void:
for log_entry in logs:
if str(log_entry) == expected:
return
failures.append("expected log `%s` in `%s`" % [expected, logs])
func _check_objective_notice(failures: Array[String]) -> void:
var scene = BattleSceneScript.new()
scene._create_hud()
scene._on_objective_updated("Defeat the new vanguard.", "")
if scene.objective_notice_panel == null or not scene.objective_notice_panel.visible:
failures.append("objective notice panel should be visible after objective update")
elif not scene.objective_notice_label.text.contains("Defeat the new vanguard."):
failures.append("objective notice label missing updated objective: %s" % scene.objective_notice_label.text)
scene._on_objective_updated("", "Supply train is lost.")
if scene.objective_notice_panel == null or not scene.objective_notice_panel.visible:
failures.append("objective notice panel should be visible after defeat update")
elif not scene.objective_notice_label.text.contains("Supply train is lost."):
failures.append("objective notice label missing updated defeat condition: %s" % scene.objective_notice_label.text)
if scene.objective_notice_timer <= 0.0:
failures.append("objective notice timer should be active")
scene.free()
func _check_contains(failures: Array[String], label: String, text: String, expected: String) -> void:
if text.contains(expected):
return