Wickedness/heros
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve camp talk and merchant previews

Browse Source
This commit is contained in:
Wickedness
2026-06-18 22:51:06 +09:00
parent 3cdadf8599
commit 65d6dff0f0
2 changed files with 185 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tools/smoke_visual_assets.gd
View File

@@ -179,11 +179,22 @@ func _check_scene_texture_loading(failures: Array[String]) -> void:
failures.append("battle scene should find Cao Cao camp conversation by id")
elif not scene._format_camp_conversation_button_text(strategy).contains("Cao Cao"):
failures.append("camp conversation button text should include label/speaker")
elif scene._camp_conversation_preview_portrait_path(strategy).is_empty():
failures.append("camp conversation preview should resolve Cao Cao portrait")
elif scene._load_art_texture(scene._camp_conversation_preview_portrait_path(strategy)) == null:
failures.append("camp conversation preview portrait should load")
elif not scene._format_camp_conversation_row_title(strategy).contains("Officer"):
failures.append("camp conversation row title should include group")
elif not scene._format_camp_conversation_preview_text(strategy).contains("Yingchuan"):
failures.append("camp conversation preview should include first dialogue text")
var cache := scene._camp_conversation_by_id("northern_woods_cache")
if cache.is_empty():
failures.append("battle scene should find cache camp conversation by id")
elif not scene._format_camp_conversation_button_text(cache).contains("Supply Bean"):
failures.append("camp conversation button text should preview supply effect")
var merchant_notice := scene._format_shop_merchant_notice_text(scene.state.get_shop_merchant())
if not merchant_notice.contains("Camp Merchant") or not merchant_notice.contains("Roadside stores"):
failures.append("shop merchant notice should include name and flavor lines")
scene.free()
_check_scenario_background_texture_loading(failures)