Make opening prologue more image led
This commit is contained in:
@@ -96,12 +96,12 @@ func _check_title_menu_start_load_and_settings(failures: Array[String]) -> void:
|
||||
var feature_body := title_story_feature.find_child("TitleStoryFeatureBody", true, false) as Label
|
||||
if feature_image == null or feature_image.texture == null:
|
||||
failures.append("title story feature should load generated opening artwork")
|
||||
elif feature_image.custom_minimum_size.x < 380.0 or feature_image.custom_minimum_size.y < 140.0:
|
||||
failures.append("title story feature should lead with a wide generated artwork frame: %s" % str(feature_image.custom_minimum_size))
|
||||
elif feature_image.custom_minimum_size.x < 430.0 or feature_image.custom_minimum_size.y < 160.0:
|
||||
failures.append("title story feature should lead with a larger generated artwork frame: %s" % str(feature_image.custom_minimum_size))
|
||||
if feature_title == null or feature_title.text != "황건의 난":
|
||||
failures.append("title story feature should name the first opening beat")
|
||||
if feature_body == null or not feature_body.text.contains("조조") or not feature_body.text.contains("황건의 난"):
|
||||
failures.append("title story feature should summarize the first opening beat in Korean")
|
||||
failures.append("title story feature should summarize the first opening beat with a short Korean teaser")
|
||||
var feature_frame := title_story_feature.find_child("TitleStoryFeatureImageFrame", true, false) as PanelContainer
|
||||
if feature_frame == null or not bool(feature_frame.get_meta("generated_panel_texture", false)):
|
||||
failures.append("title story feature artwork should sit inside a generated frame")
|
||||
@@ -126,7 +126,7 @@ func _check_title_menu_start_load_and_settings(failures: Array[String]) -> void:
|
||||
failures.append("title story preview image should sit inside a generated frame")
|
||||
if story_image == null or story_image.texture == null:
|
||||
failures.append("title story preview card should load generated artwork")
|
||||
elif story_image.custom_minimum_size.y < 54.0:
|
||||
elif story_image.custom_minimum_size.y < 64.0:
|
||||
failures.append("title story preview image should stay large enough to read as artwork: %s" % str(story_image.custom_minimum_size))
|
||||
if story_label == null or story_label.text.strip_edges().is_empty():
|
||||
failures.append("title story preview card should name its story beat")
|
||||
@@ -252,8 +252,15 @@ func _check_title_menu_start_load_and_settings(failures: Array[String]) -> void:
|
||||
failures.append("opening prologue story artwork should use a wide cinematic frame")
|
||||
elif scene.opening_prologue_scene_texture_rect.custom_minimum_size.x < 1200 or scene.opening_prologue_scene_texture_rect.custom_minimum_size.y < 700:
|
||||
failures.append("opening prologue story artwork should fill the first screen instead of sitting in a small frame")
|
||||
if scene.opening_prologue_body_label != null and scene.opening_prologue_body_label.custom_minimum_size.x < 500:
|
||||
if scene.opening_prologue_body_label != null and scene.opening_prologue_body_label.custom_minimum_size.x < 680:
|
||||
failures.append("opening prologue body text should have enough caption width for Korean copy")
|
||||
var opening_caption: PanelContainer = null
|
||||
if scene.opening_prologue_root != null:
|
||||
opening_caption = scene.opening_prologue_root.find_child("OpeningCaptionScroll", true, false) as PanelContainer
|
||||
if opening_caption == null:
|
||||
failures.append("opening prologue should keep a bottom scroll caption over the artwork")
|
||||
elif opening_caption.custom_minimum_size.y > 124.0 or opening_caption.position.y < 540.0:
|
||||
failures.append("opening prologue caption should stay low and compact so the image leads: %s at %s" % [str(opening_caption.custom_minimum_size), str(opening_caption.position)])
|
||||
var first_story_texture: Texture2D = null
|
||||
if scene.opening_prologue_scene_texture_rect != null:
|
||||
first_story_texture = scene.opening_prologue_scene_texture_rect.texture
|
||||
@@ -285,6 +292,16 @@ func _check_title_menu_start_load_and_settings(failures: Array[String]) -> void:
|
||||
failures.append("opening prologue should close after advancing through its pages")
|
||||
if scene.briefing_panel == null or not scene.briefing_panel.visible:
|
||||
failures.append("finishing the opening prologue should enter the first briefing")
|
||||
var audio_scene = BattleSceneScript.new()
|
||||
audio_scene._ready()
|
||||
audio_scene._enter_campaign_from_title()
|
||||
audio_scene._start_battle_from_briefing()
|
||||
if audio_scene.current_bgm_key != "battle" or audio_scene.bgm_player == null or audio_scene.bgm_player.stream == null:
|
||||
failures.append("battle start should switch from menu music to an audible battle BGM stream")
|
||||
audio_scene._show_title_menu()
|
||||
if audio_scene.current_bgm_key != "menu" or audio_scene.bgm_player == null or audio_scene.bgm_player.stream == null:
|
||||
failures.append("returning to title should restore the menu BGM stream")
|
||||
audio_scene.free()
|
||||
if not scene.campaign_state.has_save():
|
||||
failures.append("starting a new game should create the main campaign save")
|
||||
if not scene.campaign_state.save_manual_game():
|
||||
|
||||
Reference in New Issue
Block a user