Wickedness/heros
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve narration dialogue record card

Browse Source
This commit is contained in:
Wickedness
2026-06-20 22:55:31 +09:00
parent 164fbbb9bf
commit 4d89c03948
3 changed files with 40 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tools/smoke_visual_assets.gd
View File

@@ -3999,8 +3999,10 @@ func _check_ancient_ui_theme(failures: Array[String]) -> void:
scene._render_dialogue_line()
if scene.dialogue_portrait_panel == null or not scene.dialogue_portrait_panel.visible:
failures.append("speakerless narration should keep the dialogue portrait slot visible")
if scene.dialogue_portrait_label == null or scene.dialogue_portrait_label.text != "기록":
failures.append("speakerless narration should show a stable record placeholder")
if scene.dialogue_portrait_texture == null or not scene.dialogue_portrait_texture.visible or scene.dialogue_portrait_texture.texture == null:
failures.append("speakerless narration should use a battlefield record image instead of an empty portrait slot")
if scene.dialogue_portrait_label == null or not scene.dialogue_portrait_label.text.contains("전황"):
failures.append("speakerless narration should show a stable battle-record placeholder")
var portrait_index_after_narration: int = scene.dialogue_row.get_children().find(scene.dialogue_portrait_panel)
if portrait_index_after_narration != portrait_index_before_narration:
failures.append("speakerless narration should not move the portrait slot")
@@ -4014,8 +4016,10 @@ func _check_ancient_ui_theme(failures: Array[String]) -> void:
scene._render_dialogue_line()
if scene.dialogue_speaker_label == null or scene.dialogue_speaker_label.text != "이야기":
failures.append("explicit narrator should keep the story speaker label: %s" % ("" if scene.dialogue_speaker_label == null else scene.dialogue_speaker_label.text))
if scene.dialogue_portrait_label == null or scene.dialogue_portrait_label.text != "기록":
failures.append("explicit narrator should use the record placeholder instead of a single initial: %s" % ("" if scene.dialogue_portrait_label == null else scene.dialogue_portrait_label.text))
if scene.dialogue_portrait_label == null or not scene.dialogue_portrait_label.text.contains("전황"):
failures.append("explicit narrator should use the battle-record placeholder instead of a single initial: %s" % ("" if scene.dialogue_portrait_label == null else scene.dialogue_portrait_label.text))
if scene.dialogue_portrait_texture == null or not scene.dialogue_portrait_texture.visible or scene.dialogue_portrait_texture.texture == null:
failures.append("explicit narrator should keep a readable record image in the portrait slot")
scene._hide_dialogue_panel()
var enemy_lines := scene._normalized_dialogue_lines([{"speaker": "Wen Chou", "text": "전진!"}])
if enemy_lines.is_empty() or str((enemy_lines[0] as Dictionary).get("speaker", "")) != "문추":