Wickedness/heros
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve post-move picker readability

Browse Source
This commit is contained in:
Wickedness
2026-06-20 23:46:52 +09:00
parent 7b9671c901
commit 38161e3819
2 changed files with 84 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tools/smoke_visual_assets.gd
View File

@@ -4142,12 +4142,16 @@ func _check_ancient_ui_theme(failures: Array[String]) -> void:
failures.append("post-move picker back button should use immediately readable wording")
if scene.post_move_picker_cancel_move_button == null or scene.post_move_picker_cancel_move_button.text != "이동 취소":
failures.append("post-move picker cancel-move button should use immediately readable wording")
_check_picker_utility_button(failures, scene.post_move_picker_back_button, "목록 닫기", "cancel", BattleSceneScript.POST_MOVE_PICKER_UTILITY_BUTTON_SIZE)
_check_picker_utility_button(failures, scene.post_move_picker_cancel_move_button, "이동 취소", "move", BattleSceneScript.POST_MOVE_PICKER_UTILITY_BUTTON_SIZE)
if scene.targeting_hint_title_label == null or scene.targeting_hint_title_label.text != "적장 지목":
failures.append("targeting hint title should use mark foe wording")
if scene.targeting_hint_back_button == null or scene.targeting_hint_back_button.text != "선택 취소":
failures.append("targeting hint back button should use immediately readable wording")
if scene.targeting_hint_cancel_move_button == null or scene.targeting_hint_cancel_move_button.text != "이동 취소":
failures.append("targeting hint cancel-move button should use immediately readable wording")
_check_picker_utility_button(failures, scene.targeting_hint_back_button, "선택 취소", "cancel", BattleSceneScript.TARGETING_HINT_UTILITY_BUTTON_SIZE)
_check_picker_utility_button(failures, scene.targeting_hint_cancel_move_button, "이동 취소", "move", BattleSceneScript.TARGETING_HINT_UTILITY_BUTTON_SIZE)
scene._on_objective_updated("동문에 깃발을 세워라.", "조조가 퇴각하면 패전이다.")
if scene.objective_notice_label == null or not scene.objective_notice_label.text.contains("목표:") or not scene.objective_notice_label.text.contains("주의:"):
failures.append("objective update notice should use Korean annotation wording")
@@ -4885,6 +4889,22 @@ func _check_local_command_icon_button(failures: Array[String], button: Button, e
failures.append("local command should reserve stable icon space: %s" % expected_label)
func _check_picker_utility_button(failures: Array[String], button: Button, expected_label: String, expected_icon: String, minimum_size: Vector2) -> void:
if button == null:
failures.append("picker utility button missing: %s" % expected_label)
return
if button.text != expected_label:
failures.append("picker utility should keep readable Korean text: %s text=%s" % [expected_label, button.text])
if button.icon == null or str(button.get_meta("command_icon", "")) != expected_icon:
failures.append("picker utility should carry a generated icon: %s icon=%s meta=%s" % [expected_label, str(button.icon), str(button.get_meta("command_icon", ""))])
_check_button_uses_generated_toolbar_icon(failures, button, expected_label)
_check_button_uses_generated_surface(failures, button, expected_label)
if button.custom_minimum_size.x < minimum_size.x or button.custom_minimum_size.y < minimum_size.y:
failures.append("picker utility should reserve readable button space: %s size=%s" % [expected_label, str(button.custom_minimum_size)])
if str(button.tooltip_text).strip_edges().is_empty() or not str(button.tooltip_text).contains(expected_label):
failures.append("picker utility should explain itself on hover: %s tooltip=%s" % [expected_label, str(button.tooltip_text)])
func _check_hud_command_grid_layout(failures: Array[String]) -> void:
var scene = BattleSceneScript.new()
scene._create_hud()