Wickedness/heros
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve briefing and story readability

Browse Source
This commit is contained in:
Wickedness
2026-06-20 16:33:22 +09:00
parent 4c793194a9
commit 2d15108edb
4 changed files with 138 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
tools/smoke_title_menu.gd
View File

@@ -284,19 +284,8 @@ func _check_title_menu_start_load_and_settings(failures: Array[String]) -> void:
if not opening_story_cards.is_empty():
failures.append("opening story ledger should not expose old numbered-card style nodes")
var opening_story_ticks: Array = opening_story_strip.find_children("OpeningStoryLedgerTick*", "", true, false)
if opening_story_ticks.size() != 4:
failures.append("opening story ledger should expose four quiet progress ticks: %d" % opening_story_ticks.size())
var current_count := 0
var current_index := 0
for opening_story_tick in opening_story_ticks:
var tick_node := opening_story_tick as Node
if not bool(tick_node.get_meta("story_progress_tick", false)):
failures.append("opening story tick should be marked as a quiet progress tick")
if bool(tick_node.get_meta("current_story_beat", false)):
current_count += 1
current_index = opening_story_ticks.find(opening_story_tick) + 1
if current_count != 1 or current_index != 1:
failures.append("opening story ledger should highlight the first story tick on entry")
if not opening_story_ticks.is_empty():
failures.append("opening story ledger should avoid unreadable numeric/tick progress marks: %d" % opening_story_ticks.size())
var numeric_labels := opening_story_strip.find_children("*", "Label", true, false)
for numeric_label in numeric_labels:
if str((numeric_label as Label).text).strip_edges() in ["1", "2", "3", "4", "1/4", "2/4", "3/4", "4/4"]:
@@ -307,11 +296,11 @@ func _check_title_menu_start_load_and_settings(failures: Array[String]) -> void:
if opening_story_strip.custom_minimum_size.x > 340.0 or opening_story_strip.custom_minimum_size.y > 54.0:
failures.append("opening story ledger should stay compact beside the chapter seal: %s" % str(opening_story_strip.custom_minimum_size))
_check_control_inside_design_view(failures, opening_story_strip as Control, "opening story ledger")
if scene.opening_prologue_next_button == null or scene.opening_prologue_next_button.text != "기록 넘기기":
if scene.opening_prologue_next_button == null or scene.opening_prologue_next_button.text != "다음 기록":
failures.append("opening prologue next button should read as a story action")
else:
_check_opening_story_button_art(failures, scene.opening_prologue_next_button, "opening next")
if scene.opening_prologue_skip_button == null or scene.opening_prologue_skip_button.text != "군막으로 바로":
if scene.opening_prologue_skip_button == null or scene.opening_prologue_skip_button.text != "군막으로":
failures.append("opening prologue skip button should read as a contextual camp shortcut")
else:
_check_opening_story_button_art(failures, scene.opening_prologue_skip_button, "opening skip")
@@ -383,8 +372,13 @@ func _check_title_menu_start_load_and_settings(failures: Array[String]) -> void:
var second_story_card: Node = null
if scene.opening_prologue_root != null:
second_story_card = scene.opening_prologue_root.find_child("OpeningStoryLedgerTick2", true, false)
if second_story_card == null or not bool(second_story_card.get_meta("current_story_beat", false)):
failures.append("opening story ledger should highlight the second tick after advancing")
if second_story_card != null:
failures.append("opening story ledger should not show a second tick after advancing")
var second_progress: Label = null
if scene.opening_prologue_root != null:
second_progress = scene.opening_prologue_root.find_child("OpeningStoryProgressScene", true, false) as Label
if second_progress == null or not second_progress.text.contains("둘째 기록") or not second_progress.text.contains("맹덕의 군령"):
failures.append("opening story ledger should update the text record after advancing")
if scene.opening_prologue_title_label == null or scene.opening_prologue_title_label.text != "맹덕의 군령":
failures.append("opening prologue should move from Cao Cao background to his decision")
elif not scene.opening_prologue_body_label.text.contains("황건") or not scene.opening_prologue_body_label.text.contains("작은 군세"):
@@ -550,24 +544,23 @@ func _check_opening_story_button_art(failures: Array[String], button: Button, co
return
if not bool(button.get_meta("opening_story_button", false)):
failures.append("%s should use the compact opening-story button profile" % context)
if not bool(button.get_meta("flat_readable_button", false)):
failures.append("%s should use the flat readable story button style" % context)
if button.texture_filter != CanvasItem.TEXTURE_FILTER_LINEAR:
failures.append("%s should use linear filtering so generated button art stays smooth at QHD" % context)
failures.append("%s should use linear filtering at QHD" % context)
if button.expand_icon:
failures.append("%s icon should not stretch in QHD fullscreen" % context)
if button.get_theme_constant("icon_max_width") > 22:
failures.append("%s icon should stay small beside Korean text" % context)
var stylebox := button.get_theme_stylebox("normal")
if not (stylebox is StyleBoxTexture):
failures.append("%s should keep a generated button texture" % context)
if not (stylebox is StyleBoxFlat):
failures.append("%s should use a crisp flat style instead of a smeared generated texture" % context)
return
var style := stylebox as StyleBoxTexture
if style.texture_margin_left < 24 or style.texture_margin_top < 10:
failures.append("%s generated button slices should preserve the ornamental frame at QHD: %d/%d" % [context, style.texture_margin_left, style.texture_margin_top])
if style.axis_stretch_horizontal != StyleBoxTexture.AXIS_STRETCH_MODE_TILE_FIT or style.axis_stretch_vertical != StyleBoxTexture.AXIS_STRETCH_MODE_TILE_FIT:
failures.append("%s generated button surface should tile-fit its 9-slice center at QHD" % context)
_check_button_texture_slice_fit(failures, button, context)
if button.get_theme_font_size("font_size") > 17:
failures.append("%s should stay visually quiet in the story caption" % context)
var style := stylebox as StyleBoxFlat
if style.bg_color.a < 0.92:
failures.append("%s flat button should have a solid readable surface: %s" % [context, str(style.bg_color)])
if button.get_theme_font_size("font_size") < 14:
failures.append("%s should keep readable Korean text in the story caption" % context)
func _check_button_texture_slice_fit(failures: Array[String], button: Button, context: String) -> void: