Wickedness/heros
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify post-move command panels

Browse Source
This commit is contained in:
Wickedness
2026-06-21 02:06:53 +09:00
parent ddec5b5e94
commit 1d9b00c1bf
2 changed files with 40 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
tools/smoke_visual_assets.gd
View File

@@ -4182,20 +4182,15 @@ func _check_ancient_ui_theme(failures: Array[String]) -> void:
failures.append("briefing shop sell button should avoid modern sale wording")
if scene.post_move_title_label == null or scene.post_move_title_label.text != "행동 선택":
failures.append("post-move command title should use immediately readable action wording")
_check_panel_uses_generated_texture(failures, scene.post_move_menu, "post-move command generated frame")
var post_move_header: PanelContainer = null
var post_move_header_seal: PanelContainer = null
var post_move_header_icon: TextureRect = null
_check_panel_uses_flat_readable_backing(failures, scene.post_move_menu, "post-move command flat panel")
_check_panel_uses_flat_readable_backing(failures, scene.post_move_picker_panel, "post-move picker flat panel")
if scene.post_move_menu != null:
post_move_header = scene.post_move_menu.find_child("LocalCommandHeader", true, false) as PanelContainer
post_move_header_seal = scene.post_move_menu.find_child("LocalCommandHeaderSeal", true, false) as PanelContainer
post_move_header_icon = scene.post_move_menu.find_child("LocalCommandHeaderIcon", true, false) as TextureRect
_check_panel_uses_generated_texture(failures, post_move_header, "post-move command generated header")
_check_panel_uses_generated_texture(failures, post_move_header_seal, "post-move command generated header seal")
if post_move_header_icon == null or post_move_header_icon.texture == null:
failures.append("post-move command header should show a generated move icon")
elif post_move_header_icon.texture.get_width() < 128 or post_move_header_icon.texture.get_height() < 128:
failures.append("post-move command header should use high-resolution generated move icon art")
if bool(scene.post_move_menu.get_meta("generated_panel_texture", false)):
failures.append("post-move command panel should not use a busy generated image")
if scene.post_move_menu.find_child("LocalCommandHeaderSeal", true, false) != null:
failures.append("post-move command panel should not show decorative seal imagery")
if scene.post_move_menu.find_child("GeneratedSealRibbon", true, false) != null:
failures.append("post-move command panel should not show decorative ribbon imagery")
_check_local_command_labeled_button(failures, scene.post_move_attack_button, "공격", "attack")
_check_local_command_labeled_button(failures, scene.post_move_tactic_button, "책략", "tactic")
_check_local_command_labeled_button(failures, scene.post_move_item_button, "도구", "item")
@@ -4943,7 +4938,7 @@ func _check_local_command_icon_button(failures: Array[String], button: Button, e
if button.icon == null or str(button.get_meta("command_icon", "")) != expected_icon:
failures.append("local command should carry an immediate visual icon: %s icon=%s meta=%s" % [expected_label, str(button.icon), str(button.get_meta("command_icon", ""))])
_check_button_uses_generated_toolbar_icon(failures, button, expected_label)
_check_button_uses_generated_surface(failures, button, expected_label)
_check_button_uses_flat_readable_surface(failures, button, expected_label)
if str(button.get_meta("command_label", "")) != expected_label:
failures.append("local command should keep old wording in hover metadata: %s meta=%s" % [expected_label, str(button.get_meta("command_label", ""))])
if str(button.tooltip_text).strip_edges().is_empty() or not str(button.tooltip_text).contains(expected_label):
@@ -4961,7 +4956,7 @@ func _check_local_command_labeled_button(failures: Array[String], button: Button
if button.icon == null or str(button.get_meta("command_icon", "")) != expected_icon:
failures.append("local command should carry an immediate visual icon: %s icon=%s meta=%s" % [expected_label, str(button.icon), str(button.get_meta("command_icon", ""))])
_check_button_uses_generated_toolbar_icon(failures, button, expected_label)
_check_button_uses_generated_surface(failures, button, expected_label)
_check_button_uses_flat_readable_surface(failures, button, expected_label)
if str(button.get_meta("command_label", "")) != expected_label:
failures.append("local command should keep old wording in hover metadata: %s meta=%s" % [expected_label, str(button.get_meta("command_label", ""))])
if str(button.tooltip_text).strip_edges().is_empty() or not str(button.tooltip_text).contains(expected_label):
@@ -4979,7 +4974,7 @@ func _check_picker_utility_button(failures: Array[String], button: Button, expec
if button.icon == null or str(button.get_meta("command_icon", "")) != expected_icon:
failures.append("picker utility should carry a generated icon: %s icon=%s meta=%s" % [expected_label, str(button.icon), str(button.get_meta("command_icon", ""))])
_check_button_uses_generated_toolbar_icon(failures, button, expected_label)
_check_button_uses_generated_surface(failures, button, expected_label)
_check_button_uses_flat_readable_surface(failures, button, expected_label)
if button.custom_minimum_size.x < minimum_size.x or button.custom_minimum_size.y < minimum_size.y:
failures.append("picker utility should reserve readable button space: %s size=%s" % [expected_label, str(button.custom_minimum_size)])
if str(button.tooltip_text).strip_edges().is_empty() or not str(button.tooltip_text).contains(expected_label):